René's URL Explorer Experiment


Title: stream: read refactor by ronag · Pull Request #29155 · nodejs/node · GitHub

Open Graph Title: stream: read refactor by ronag · Pull Request #29155 · nodejs/node

X Title: stream: read refactor by ronag · Pull Request #29155 · nodejs/node

Description: Node.js JavaScript runtime ✨🐢🚀✨. Contribute to nodejs/node development by creating an account on GitHub.

Open Graph Description: This slightly refactors read by moving side effects out of howMuchToRead. We don't actually have to set state.needReadable = true; in howMuchToRead since read handles 0 return as needReadable. ...

X Description: This slightly refactors read by moving side effects out of howMuchToRead. We don't actually have to set state.needReadable = true; in howMuchToRead since read handles 0 return as needReadab...

Opengraph URL: https://github.com/nodejs/node/pull/29155

X: @github

direct link

Domain: github.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:3bb93ed8-0003-72d5-746a-5eb650f5c31b
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-id9C96:1960:4C715F9:6C0372D:6A503E7B
html-safe-noncea8018e42b158323b6da369e5f5fb7bf05b36d2e2aeb174fd58ed8c8539ff6c1f
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI5Qzk2OjE5NjA6NEM3MTVGOTo2QzAzNzJEOjZBNTAzRTdCIiwidmlzaXRvcl9pZCI6IjQwOTU0OTcwOTM3MjgxOTAwNzYiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmaca37b5a0b6dec77c4ce30233408ee69964a7d0a5a382ec20db4ffa58cf4dc509c
hovercard-subject-tagpull_request:307985409
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/29155/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/5e4c7f332a28f9bd11ca4d503174e646b2adf50879fbb306947506818a0b6153/nodejs/node/pull/29155
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/5e4c7f332a28f9bd11ca4d503174e646b2adf50879fbb306947506818a0b6153/nodejs/node/pull/29155
og:image:altThis slightly refactors read by moving side effects out of howMuchToRead. We don't actually have to set state.needReadable = true; in howMuchToRead since read handles 0 return as needReadable. ...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernameronag
hostnamegithub.com
expected-hostnamegithub.com
Noned6dc8294eb500fa36bbc57472d61fe87c522f9c3c1d64f70f4926f66a66a7efb
turbo-cache-controlno-cache
go-importgithub.com/nodejs/node git https://github.com/nodejs/node.git
octolytics-dimension-user_id9950313
octolytics-dimension-user_loginnodejs
octolytics-dimension-repository_id27193779
octolytics-dimension-repository_nwonodejs/node
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id27193779
octolytics-dimension-repository_network_root_nwonodejs/node
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
released90666eaf032b7eb8975a378efe38e37f4ebb96c
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/nodejs/node/pull/29155#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F29155
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub Copilot appDirect agents from issue to mergehttps://github.com/features/ai/github-app
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
View all resourceshttps://github.com/resources
GitHub SponsorsFund open source developershttps://github.com/open-source/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/open-source/accelerator
GitHub Starshttps://stars.github.com
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F29155
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode
Reloadhttps://github.com/nodejs/node/pull/29155
Reloadhttps://github.com/nodejs/node/pull/29155
Reloadhttps://github.com/nodejs/node/pull/29155
Please reload this pagehttps://github.com/nodejs/node/pull/29155
nodejs https://github.com/nodejs
nodehttps://github.com/nodejs/node
Please reload this pagehttps://github.com/nodejs/node/pull/29155
Notifications https://github.com/login?return_to=%2Fnodejs%2Fnode
Fork 36k https://github.com/login?return_to=%2Fnodejs%2Fnode
Star 118k https://github.com/login?return_to=%2Fnodejs%2Fnode
Code https://github.com/nodejs/node
Issues 1.3k https://github.com/nodejs/node/issues
Pull requests 978 https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects https://github.com/nodejs/node/projects
Security and quality 0 https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
Code https://github.com/nodejs/node
Issues https://github.com/nodejs/node/issues
Pull requests https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects https://github.com/nodejs/node/projects
Security and quality https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
ronaghttps://github.com/ronag
nodejs:masterhttps://github.com/nodejs/node/tree/master
nxtedition:stream-read-refactorhttps://github.com/nxtedition/node/tree/stream-read-refactor
Conversationhttps://github.com/nodejs/node/pull/29155
Commits1 (1)https://github.com/nodejs/node/pull/29155/commits
Checkshttps://github.com/nodejs/node/pull/29155/checks
Files changedhttps://github.com/nodejs/node/pull/29155/files
stream: read refactorhttps://github.com/nodejs/node/pull/29155#top
ronaghttps://github.com/ronag
nodejs:masterhttps://github.com/nodejs/node/tree/master
nxtedition:stream-read-refactorhttps://github.com/nxtedition/node/tree/stream-read-refactor
https://github.com/ronag
ronaghttps://github.com/ronag
Aug 16, 2019https://github.com/nodejs/node/pull/29155#issue-481498339
Please reload this pagehttps://github.com/nodejs/node/pull/29155
commit guidelineshttps://github.com/nodejs/node/blob/master/doc/guides/contributing/pull-requests.md#commit-message-guidelines
Please reload this pagehttps://github.com/nodejs/node/pull/29155
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
stream https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Astream
Aug 16, 2019https://github.com/nodejs/node/pull/29155#event-2561641615
https://github.com/ronag
ronaghttps://github.com/ronag
Aug 16, 2019 https://github.com/nodejs/node/pull/29155#pullrequestreview-275828600
View reviewed changes https://github.com/nodejs/node/pull/29155/files
lib/_stream_readable.jshttps://github.com/nodejs/node/pull/29155/files#diff-1fd696295b3ae3f444c5c6839a11f89a91e2a42edeb5827e54e86b8acc3e6fe7
Please reload this pagehttps://github.com/nodejs/node/pull/29155
https://github.com/ronag
ronaghttps://github.com/ronag
force-pushedhttps://github.com/nodejs/node/compare/f0a46f362a18b37b1b040ec00b5418cef5b3e03b..463d3fe96368316d4ab32ee76d13c872581702c0
f0a46f3https://github.com/nodejs/node/commit/f0a46f362a18b37b1b040ec00b5418cef5b3e03b
463d3fehttps://github.com/nodejs/node/commit/463d3fe96368316d4ab32ee76d13c872581702c0
Compare https://github.com/nodejs/node/compare/f0a46f362a18b37b1b040ec00b5418cef5b3e03b..463d3fe96368316d4ab32ee76d13c872581702c0
August 16, 2019 08:36https://github.com/nodejs/node/pull/29155#event-2561678699
https://github.com/ronag
stream: simplify howMuchToReadhttps://github.com/nodejs/node/pull/29155/commits/df1756e803861626f15d1e97c3de3b4b14e620e8
df1756ehttps://github.com/nodejs/node/pull/29155/commits/df1756e803861626f15d1e97c3de3b4b14e620e8
https://github.com/ronag
ronaghttps://github.com/ronag
force-pushedhttps://github.com/nodejs/node/compare/463d3fe96368316d4ab32ee76d13c872581702c0..df1756e803861626f15d1e97c3de3b4b14e620e8
463d3fehttps://github.com/nodejs/node/commit/463d3fe96368316d4ab32ee76d13c872581702c0
df1756ehttps://github.com/nodejs/node/commit/df1756e803861626f15d1e97c3de3b4b14e620e8
Compare https://github.com/nodejs/node/compare/463d3fe96368316d4ab32ee76d13c872581702c0..df1756e803861626f15d1e97c3de3b4b14e620e8
August 16, 2019 08:40https://github.com/nodejs/node/pull/29155#event-2561688507
https://github.com/Trott
Trotthttps://github.com/Trott
Aug 18, 2019https://github.com/nodejs/node/pull/29155#issuecomment-522365855
Please reload this pagehttps://github.com/nodejs/node/pull/29155
https://github.com/mcollina
mcollinahttps://github.com/mcollina
Aug 19, 2019 https://github.com/nodejs/node/pull/29155#pullrequestreview-276342909
View reviewed changes https://github.com/nodejs/node/pull/29155/files/df1756e803861626f15d1e97c3de3b4b14e620e8
mcollinahttps://github.com/mcollina
https://github.com/nodejs/node/pull/29155#pullrequestreview-276342909
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/29155
https://github.com/Trott
Trotthttps://github.com/Trott
Aug 19, 2019https://github.com/nodejs/node/pull/29155#issuecomment-522578667
https://ci.nodejs.org/view/Node.js-citgm/job/citgm-smoker/1965/https://ci.nodejs.org/view/Node.js-citgm/job/citgm-smoker/1965/
Please reload this pagehttps://github.com/nodejs/node/pull/29155
https://github.com/Trott
Trotthttps://github.com/Trott
Aug 19, 2019 https://github.com/nodejs/node/pull/29155#pullrequestreview-276562786
View reviewed changes https://github.com/nodejs/node/pull/29155/files/df1756e803861626f15d1e97c3de3b4b14e620e8
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
Aug 19, 2019https://github.com/nodejs/node/pull/29155#issuecomment-522578862
https://ci.nodejs.org/job/node-test-pull-request/25084/https://ci.nodejs.org/job/node-test-pull-request/25084/
Please reload this pagehttps://github.com/nodejs/node/pull/29155
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
Aug 19, 2019https://github.com/nodejs/node/pull/29155#issuecomment-522664840
https://ci.nodejs.org/job/node-test-pull-request/25102/https://ci.nodejs.org/job/node-test-pull-request/25102/
Please reload this pagehttps://github.com/nodejs/node/pull/29155
https://github.com/Trott
Trotthttps://github.com/Trott
Aug 19, 2019https://github.com/nodejs/node/pull/29155#issuecomment-522666584
https://ci.nodejs.org/view/Node.js-citgm/job/citgm-smoker/1967/https://ci.nodejs.org/view/Node.js-citgm/job/citgm-smoker/1967/
Please reload this pagehttps://github.com/nodejs/node/pull/29155
https://github.com/ronag
ronaghttps://github.com/ronag
Aug 19, 2019https://github.com/nodejs/node/pull/29155#issuecomment-522712345
@Trotthttps://github.com/Trott
Please reload this pagehttps://github.com/nodejs/node/pull/29155
Trotthttps://github.com/Trott
Aug 20, 2019 https://github.com/nodejs/node/pull/29155#ref-commit-ea765eb
https://github.com/ronag
https://github.com/Trott
stream: simplify howMuchToRead()https://github.com/nodejs/node/commit/ea765eba2055132bfe42bd27caf970f4c169eca5
ea765ebhttps://github.com/nodejs/node/commit/ea765eba2055132bfe42bd27caf970f4c169eca5
#29155https://github.com/nodejs/node/pull/29155
https://github.com/Trott
Trotthttps://github.com/Trott
Aug 20, 2019https://github.com/nodejs/node/pull/29155#issuecomment-522835782
ea765ebhttps://github.com/nodejs/node/commit/ea765eba2055132bfe42bd27caf970f4c169eca5
Please reload this pagehttps://github.com/nodejs/node/pull/29155
https://github.com/Trott
Trotthttps://github.com/Trott
Aug 20, 2019https://github.com/nodejs/node/pull/29155#event-2568244298
targoshttps://github.com/targos
Aug 20, 2019 https://github.com/nodejs/node/pull/29155#ref-commit-1e3e6da
https://github.com/ronag
https://github.com/targos
stream: simplify howMuchToRead()https://github.com/nodejs/node/commit/1e3e6da9b9bdab5ab3a5678ce9d3d178e62444b3
1e3e6dahttps://github.com/nodejs/node/commit/1e3e6da9b9bdab5ab3a5678ce9d3d178e62444b3
#29155https://github.com/nodejs/node/pull/29155
https://github.com/targos
targoshttps://github.com/targos
Aug 20, 2019 https://github.com/nodejs/node/pull/29155#ref-pullrequest-482485175
v12.9.0 release proposal #29210 https://github.com/nodejs/node/pull/29210
2019-08-20 Version 12.9.0 (Current) @targos beevelop/docker-android-nodejs#328 https://github.com/beevelop/docker-android-nodejs/issues/328
2019-08-20 Version 12.9.0 (Current) @targos beevelop/docker-android-nodejs#329 https://github.com/beevelop/docker-android-nodejs/issues/329
2019-08-20 Version 12.9.0 (Current) @targos beevelop/docker-android-nodejs#330 https://github.com/beevelop/docker-android-nodejs/issues/330
2019-08-20 Version 12.9.0 (Current) @targos beevelop/docker-nodejs#295 https://github.com/beevelop/docker-nodejs/issues/295
2019-08-20 Version 12.9.0 (Current) @targos beevelop/docker-nodejs#296 https://github.com/beevelop/docker-nodejs/issues/296
2019-08-20 Version 12.9.0 (Current) @targos beevelop/docker-nodejs#297 https://github.com/beevelop/docker-nodejs/issues/297
https://github.com/ad-m
ad-mhttps://github.com/ad-m
Jan 29, 2020 https://github.com/nodejs/node/pull/29155#ref-issue-556557373
Pipe to Channel hangs on "Parser: IN_PACKETBEFORE (expecting 16)" mscdex/ssh2#870 https://github.com/mscdex/ssh2/issues/870
https://github.co/hiddenchars
https://github.com/nodejs/node/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F29155
https://github.com/mcollina
mcollina https://github.com/mcollina
https://github.com/nodejs/node/pull/29155/files/df1756e803861626f15d1e97c3de3b4b14e620e8
https://github.com/Trott
Trott https://github.com/Trott
https://github.com/nodejs/node/pull/29155/files/df1756e803861626f15d1e97c3de3b4b14e620e8
stream https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Astream
Please reload this pagehttps://github.com/nodejs/node/pull/29155
https://github.com/ronag
https://github.com/Trott
https://github.com/nodejs-github-bot
https://github.com/mcollina
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.