| route-pattern | /_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format) |
| route-controller | voltron_pull_requests_fragments |
| route-action | pull_request_layout |
| fetch-nonce | v2:a5b1c7af-ed70-e7db-b47d-9f334960318b |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | 932C:397AD8:4255591:5D8B9DB:6A4FAB78 |
| html-safe-nonce | 3ff54244aa2c61f1a8586b7b65f523f2f2ad01a75e0ca479c894b7281eaac85c |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI5MzJDOjM5N0FEODo0MjU1NTkxOjVEOEI5REI6NkE0RkFCNzgiLCJ2aXNpdG9yX2lkIjoiMTMyNTIyMTMwMDY1NDgxMjAyNCIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9 |
| visitor-hmac | 15ff10a05c207d054d12841125582452cdaccabae36f25e3a41296ab5cf78708 |
| hovercard-subject-tag | pull_request:307691011 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///voltron/pull_requests_fragments/pull_request_layout |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/29140/pull_request_layout |
| twitter:image | https://opengraph.githubassets.com/bd1e12b592283aba9aa6ba8db410521db484117bd391eafadf6490e98cba8817/nodejs/node/pull/29140 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/bd1e12b592283aba9aa6ba8db410521db484117bd391eafadf6490e98cba8817/nodejs/node/pull/29140 |
| og:image:alt | Built on the lessons learned in #29130 if we bring all changes done to this file in node-gyp, that breaks our Travis CI tests so this PR cherrypicks only the Python 3 compatibility changes. These ... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | cclauss |
| hostname | github.com |
| expected-hostname | github.com |
| None | b92d11c0aa4a77d54ef4af1078b6a15fb5a70a215b30c4ecf28889d5a8e656d9 |
| turbo-cache-control | no-cache |
| go-import | github.com/nodejs/node git https://github.com/nodejs/node.git |
| octolytics-dimension-user_id | 9950313 |
| octolytics-dimension-user_login | nodejs |
| octolytics-dimension-repository_id | 27193779 |
| octolytics-dimension-repository_nwo | nodejs/node |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 27193779 |
| octolytics-dimension-repository_network_root_nwo | nodejs/node |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 4b249b445842943ed31549e027f57a8ade9881ed |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| Skip to content | https://github.com/nodejs/node/pull/29140#start-of-content |
|
| https://github.com/ |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F29140 |
| GitHub CopilotWrite better code with AI | https://github.com/features/copilot |
| GitHub Copilot appDirect agents from issue to merge | https://github.com/features/ai/github-app |
| MCP RegistryNewIntegrate external tools | https://github.com/mcp |
| ActionsAutomate any workflow | https://github.com/features/actions |
| CodespacesInstant dev environments | https://github.com/features/codespaces |
| IssuesPlan and track work | https://github.com/features/issues |
| Code ReviewManage code changes | https://github.com/features/code-review |
| GitHub Advanced SecurityFind and fix vulnerabilities | https://github.com/security/advanced-security |
| Code securitySecure your code as you build | https://github.com/security/advanced-security/code-security |
| Secret protectionStop leaks before they start | https://github.com/security/advanced-security/secret-protection |
| Why GitHub | https://github.com/why-github |
| Documentation | https://docs.github.com |
| Blog | https://github.blog |
| Changelog | https://github.blog/changelog |
| Marketplace | https://github.com/marketplace |
| View all features | https://github.com/features |
| Enterprises | https://github.com/enterprise |
| Small and medium teams | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| App Modernization | https://github.com/solutions/use-case/app-modernization |
| DevSecOps | https://github.com/solutions/use-case/devsecops |
| DevOps | https://github.com/solutions/use-case/devops |
| CI/CD | https://github.com/solutions/use-case/ci-cd |
| View all use cases | https://github.com/solutions/use-case |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| View all industries | https://github.com/solutions/industry |
| View all solutions | https://github.com/solutions |
| AI | https://github.com/resources/articles?topic=ai |
| Software Development | https://github.com/resources/articles?topic=software-development |
| DevOps | https://github.com/resources/articles?topic=devops |
| Security | https://github.com/resources/articles?topic=security |
| View all topics | https://github.com/resources/articles |
| Customer stories | https://github.com/customer-stories |
| Events & webinars | https://github.com/resources/events |
| Ebooks & reports | https://github.com/resources/whitepapers |
| Business insights | https://github.com/solutions/executive-insights |
| GitHub Skills | https://skills.github.com |
| Documentation | https://docs.github.com |
| Customer support | https://support.github.com |
| Community forum | https://github.com/orgs/community/discussions |
| Trust center | https://github.com/trust-center |
| Partners | https://github.com/partners |
| View all resources | https://github.com/resources |
| GitHub SponsorsFund open source developers | https://github.com/open-source/sponsors |
| Security Lab | https://securitylab.github.com |
| Maintainer Community | https://maintainers.github.com |
| Accelerator | https://github.com/open-source/accelerator |
| GitHub Stars | https://stars.github.com |
| Archive Program | https://archiveprogram.github.com |
| Topics | https://github.com/topics |
| Trending | https://github.com/trending |
| Collections | https://github.com/collections |
| Enterprise platformAI-powered developer platform | https://github.com/enterprise |
| GitHub Advanced SecurityEnterprise-grade security features | https://github.com/security/advanced-security |
| Copilot for BusinessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/enterprise/premium-support |
| Pricing | https://github.com/pricing |
| Search syntax tips | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
| documentation | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F29140 |
|
Sign up
| https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode |
| Reload | https://github.com/nodejs/node/pull/29140 |
| Reload | https://github.com/nodejs/node/pull/29140 |
| Reload | https://github.com/nodejs/node/pull/29140 |
| Please reload this page | https://github.com/nodejs/node/pull/29140 |
|
nodejs
| https://github.com/nodejs |
| node | https://github.com/nodejs/node |
| Please reload this page | https://github.com/nodejs/node/pull/29140 |
|
Notifications
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Fork
36k
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Star
118k
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Code
| https://github.com/nodejs/node |
|
Issues
1.3k
| https://github.com/nodejs/node/issues |
|
Pull requests
972
| https://github.com/nodejs/node/pulls |
|
Actions
| https://github.com/nodejs/node/actions |
|
Projects
| https://github.com/nodejs/node/projects |
|
Security and quality
0
| https://github.com/nodejs/node/security |
|
Insights
| https://github.com/nodejs/node/pulse |
|
Code
| https://github.com/nodejs/node |
|
Issues
| https://github.com/nodejs/node/issues |
|
Pull requests
| https://github.com/nodejs/node/pulls |
|
Actions
| https://github.com/nodejs/node/actions |
|
Projects
| https://github.com/nodejs/node/projects |
|
Security and quality
| https://github.com/nodejs/node/security |
|
Insights
| https://github.com/nodejs/node/pulse |
| cclauss | https://github.com/cclauss |
| nodejs:master | https://github.com/nodejs/node/tree/master |
| cclauss:py3_input.py-futurize-ast | https://github.com/cclauss/node/tree/py3_input.py-futurize-ast |
| Conversation | https://github.com/nodejs/node/pull/29140 |
| Commits1 (1) | https://github.com/nodejs/node/pull/29140/commits |
| Checks | https://github.com/nodejs/node/pull/29140/checks |
| Files changed | https://github.com/nodejs/node/pull/29140/files |
| gyp: cherrypick python3 changes to input.py from node-gyp | https://github.com/nodejs/node/pull/29140#top |
| cclauss | https://github.com/cclauss |
| nodejs:master | https://github.com/nodejs/node/tree/master |
| cclauss:py3_input.py-futurize-ast | https://github.com/cclauss/node/tree/py3_input.py-futurize-ast |
|
| https://github.com/cclauss |
| cclauss | https://github.com/cclauss |
| Aug 15, 2019 | https://github.com/nodejs/node/pull/29140#issue-481132246 |
| #29130 | https://github.com/nodejs/node/pull/29130 |
| this file in node-gyp | https://github.com/nodejs/node-gyp/blob/master/gyp/pylib/gyp/input.py |
| ast | https://docs.python.org/3/library/ast.html |
| commit guidelines | https://github.com/nodejs/node/blob/master/doc/guides/contributing/pull-requests.md#commit-message-guidelines |
| Please reload this page | https://github.com/nodejs/node/pull/29140 |
| https://github.com/cclauss |
| cclauss | https://github.com/cclauss |
|
python
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Apython |
| Aug 15, 2019 | https://github.com/nodejs/node/pull/29140#event-2559383592 |
| https://github.com/cclauss |
| cclauss | https://github.com/cclauss |
| sam-github | https://github.com/sam-github |
| August 15, 2019 12:39 | https://github.com/nodejs/node/pull/29140#event-2559383601 |
| https://github.com/nodejs-github-bot |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
|
build
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Abuild |
|
tools
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Atools |
| Aug 15, 2019 | https://github.com/nodejs/node/pull/29140#event-2559383740 |
| https://github.com/targos |
| targos | https://github.com/targos |
|
Aug 15, 2019
| https://github.com/nodejs/node/pull/29140#pullrequestreview-275436030 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/29140/files |
| targos | https://github.com/targos |
| https://github.com/nodejs/node/pull/29140#pullrequestreview-275436030 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/29140 |
|
build: find Python 3 or Python 2 in configure
#25878
| https://github.com/nodejs/node/pull/25878 |
|
build: ongoing list of actions for Python 3 compatibility
#25789
| https://github.com/nodejs/node/issues/25789 |
| https://github.com/cclauss |
| cclauss | https://github.com/cclauss |
| force-pushed | https://github.com/nodejs/node/compare/b3e2b29bedb3430b18d79d525daf7f379d3b5afb..b601fe00560c913c6be2c5d68b57e3858d5aa0aa |
| b3e2b29 | https://github.com/nodejs/node/commit/b3e2b29bedb3430b18d79d525daf7f379d3b5afb |
| b601fe0 | https://github.com/nodejs/node/commit/b601fe00560c913c6be2c5d68b57e3858d5aa0aa |
|
Compare
| https://github.com/nodejs/node/compare/b3e2b29bedb3430b18d79d525daf7f379d3b5afb..b601fe00560c913c6be2c5d68b57e3858d5aa0aa |
| August 15, 2019 15:00 | https://github.com/nodejs/node/pull/29140#event-2559763980 |
| https://github.com/sam-github |
| sam-github | https://github.com/sam-github |
|
Aug 15, 2019
| https://github.com/nodejs/node/pull/29140#pullrequestreview-275686124 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/29140/files |
| https://github.com/nodejs-github-bot |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
| Aug 15, 2019 | https://github.com/nodejs/node/pull/29140#issuecomment-521808871 |
| https://ci.nodejs.org/job/node-test-pull-request/25010/ | https://ci.nodejs.org/job/node-test-pull-request/25010/ |
| Please reload this page | https://github.com/nodejs/node/pull/29140 |
| https://github.com/sam-github |
| sam-github | https://github.com/sam-github |
| Aug 15, 2019 | https://github.com/nodejs/node/pull/29140#issuecomment-521809389 |
| @cclauss | https://github.com/cclauss |
| Please reload this page | https://github.com/nodejs/node/pull/29140 |
| https://github.com/sam-github |
| sam-github | https://github.com/sam-github |
| force-pushed | https://github.com/nodejs/node/compare/b601fe00560c913c6be2c5d68b57e3858d5aa0aa..83df0d2f9f6936f7a00d2ff30e1ec2e80883ed98 |
| b601fe0 | https://github.com/nodejs/node/commit/b601fe00560c913c6be2c5d68b57e3858d5aa0aa |
| 83df0d2 | https://github.com/nodejs/node/commit/83df0d2f9f6936f7a00d2ff30e1ec2e80883ed98 |
|
Compare
| https://github.com/nodejs/node/compare/b601fe00560c913c6be2c5d68b57e3858d5aa0aa..83df0d2f9f6936f7a00d2ff30e1ec2e80883ed98 |
| August 15, 2019 22:26 | https://github.com/nodejs/node/pull/29140#event-2560855398 |
| https://github.com/nodejs-github-bot |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
| Aug 15, 2019 | https://github.com/nodejs/node/pull/29140#issuecomment-521819558 |
| https://ci.nodejs.org/job/node-test-pull-request/25012/ | https://ci.nodejs.org/job/node-test-pull-request/25012/ |
| Please reload this page | https://github.com/nodejs/node/pull/29140 |
| https://github.com/sam-github |
| sam-github | https://github.com/sam-github |
| force-pushed | https://github.com/nodejs/node/compare/83df0d2f9f6936f7a00d2ff30e1ec2e80883ed98..227fbeebaee52608de31506bdd144051da2807b0 |
| 83df0d2 | https://github.com/nodejs/node/commit/83df0d2f9f6936f7a00d2ff30e1ec2e80883ed98 |
| 227fbee | https://github.com/nodejs/node/commit/227fbeebaee52608de31506bdd144051da2807b0 |
|
Compare
| https://github.com/nodejs/node/compare/83df0d2f9f6936f7a00d2ff30e1ec2e80883ed98..227fbeebaee52608de31506bdd144051da2807b0 |
| August 15, 2019 22:28 | https://github.com/nodejs/node/pull/29140#event-2560859659 |
| https://github.com/nodejs-github-bot |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
| Aug 15, 2019 | https://github.com/nodejs/node/pull/29140#issuecomment-521819982 |
| https://ci.nodejs.org/job/node-test-pull-request/25013/ | https://ci.nodejs.org/job/node-test-pull-request/25013/ |
| Please reload this page | https://github.com/nodejs/node/pull/29140 |
| https://github.com/cclauss |
| cclauss | https://github.com/cclauss |
| force-pushed | https://github.com/nodejs/node/compare/227fbeebaee52608de31506bdd144051da2807b0..4c7eae187183ff55b01df934ebb53ecdd4e7fafc |
| 227fbee | https://github.com/nodejs/node/commit/227fbeebaee52608de31506bdd144051da2807b0 |
| 4c7eae1 | https://github.com/nodejs/node/commit/4c7eae187183ff55b01df934ebb53ecdd4e7fafc |
|
Compare
| https://github.com/nodejs/node/compare/227fbeebaee52608de31506bdd144051da2807b0..4c7eae187183ff55b01df934ebb53ecdd4e7fafc |
| August 16, 2019 14:04 | https://github.com/nodejs/node/pull/29140#event-2562406278 |
| https://github.com/sam-github |
| sam-github | https://github.com/sam-github |
| force-pushed | https://github.com/nodejs/node/compare/4c7eae187183ff55b01df934ebb53ecdd4e7fafc..f6885f48ddd61bcb089a87d48f76bd946ab11eee |
| 4c7eae1 | https://github.com/nodejs/node/commit/4c7eae187183ff55b01df934ebb53ecdd4e7fafc |
| f6885f4 | https://github.com/nodejs/node/commit/f6885f48ddd61bcb089a87d48f76bd946ab11eee |
|
Compare
| https://github.com/nodejs/node/compare/4c7eae187183ff55b01df934ebb53ecdd4e7fafc..f6885f48ddd61bcb089a87d48f76bd946ab11eee |
| August 16, 2019 17:57 | https://github.com/nodejs/node/pull/29140#event-2563004674 |
| https://github.com/Trott |
| Trott | https://github.com/Trott |
|
Aug 18, 2019
| https://github.com/nodejs/node/pull/29140#pullrequestreview-276259336 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/29140/files |
| Trott | https://github.com/Trott |
| https://github.com/nodejs/node/pull/29140#pullrequestreview-276259336 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/29140 |
| https://github.com/nodejs-github-bot |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
| Aug 18, 2019 | https://github.com/nodejs/node/pull/29140#issuecomment-522287669 |
| https://ci.nodejs.org/job/node-test-pull-request/25064/ | https://ci.nodejs.org/job/node-test-pull-request/25064/ |
| Please reload this page | https://github.com/nodejs/node/pull/29140 |
| https://github.com/nodejs-github-bot |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
| Aug 18, 2019 | https://github.com/nodejs/node/pull/29140#issuecomment-522302816 |
| https://ci.nodejs.org/job/node-test-pull-request/25066/ | https://ci.nodejs.org/job/node-test-pull-request/25066/ |
| Please reload this page | https://github.com/nodejs/node/pull/29140 |
| https://github.com/cclauss |
| cclauss | https://github.com/cclauss |
| bnoordhuis | https://github.com/bnoordhuis |
| richardlau | https://github.com/richardlau |
| August 19, 2019 06:09 | https://github.com/nodejs/node/pull/29140#event-2565150886 |
| cclauss | https://github.com/cclauss |
|
Aug 19, 2019
| https://github.com/nodejs/node/pull/29140#ref-commit-2a7ab08 |
|
| https://github.com/cclauss |
| gyp: try | https://github.com/cclauss/node/commit/2a7ab08c376870245105fb2adcd4c5c3072bed85 |
| nodejs#29140 | https://github.com/nodejs/node/pull/29140 |
| && | https://github.com/cclauss/node/commit/2a7ab08c376870245105fb2adcd4c5c3072bed85 |
| nodejs#29196 | https://github.com/nodejs/node/pull/29196 |
| 2a7ab08 | https://github.com/cclauss/node/commit/2a7ab08c376870245105fb2adcd4c5c3072bed85 |
| https://github.com/Trott |
| Trott | https://github.com/Trott |
|
author ready
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22author%20ready%22 |
| Aug 19, 2019 | https://github.com/nodejs/node/pull/29140#event-2567034057 |
| https://github.com/richardlau |
| richardlau | https://github.com/richardlau |
|
Aug 19, 2019
| https://github.com/nodejs/node/pull/29140#pullrequestreview-276699245 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/29140/files |
| https://github.com/Trott |
| Trott | https://github.com/Trott |
| Aug 20, 2019 | https://github.com/nodejs/node/pull/29140#issuecomment-522836196 |
| Please reload this page | https://github.com/nodejs/node/pull/29140 |
| https://github.com/cclauss |
| cclauss | https://github.com/cclauss |
|
Aug 20, 2019
| https://github.com/nodejs/node/pull/29140#ref-pullrequest-482039168 |
|
build: add Python 3 tests to Travis CI
#29196
| https://github.com/nodejs/node/pull/29196 |
| https://github.com/gengjiawen |
| gengjiawen | https://github.com/gengjiawen |
|
Aug 20, 2019
| https://github.com/nodejs/node/pull/29140#pullrequestreview-277066263 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/29140/files |
| https://github.com/gengjiawen |
| gengjiawen | https://github.com/gengjiawen |
| Aug 20, 2019 | https://github.com/nodejs/node/pull/29140#issuecomment-522950440 |
| Please reload this page | https://github.com/nodejs/node/pull/29140 |
| https://github.com/cclauss |
| cclauss | https://github.com/cclauss |
| Aug 20, 2019 | https://github.com/nodejs/node/pull/29140#issuecomment-522953344 |
| Please reload this page | https://github.com/nodejs/node/pull/29140 |
| squash like this | https://devguide.python.org/gitbootcamp/?highlight=upstream#syncing-with-upstream |
| @cclauss | https://github.com/cclauss |
| Please reload this page | https://github.com/nodejs/node/pull/29140 |
| https://github.com/bnoordhuis |
| bnoordhuis | https://github.com/bnoordhuis |
| Aug 20, 2019 | https://github.com/nodejs/node/pull/29140#issuecomment-522968365 |
| @cclauss | https://github.com/cclauss |
| Please reload this page | https://github.com/nodejs/node/pull/29140 |
| https://github.com/bnoordhuis |
| bnoordhuis | https://github.com/bnoordhuis |
|
Aug 20, 2019
| https://github.com/nodejs/node/pull/29140#pullrequestreview-277095579 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/29140/files |
| tools/gyp/pylib/gyp/input.py | https://github.com/nodejs/node/pull/29140/files#diff-15af5a6f295dc79388ca35e8d7e352a19203d9eb56180c0174d8f6d602a1aa57 |
| bnoordhuis | https://github.com/bnoordhuis |
| Aug 20, 2019 | https://github.com/nodejs/node/pull/29140#discussion_r315634714 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/29140 |
| cclauss | https://github.com/cclauss |
| Aug 20, 2019 | https://github.com/nodejs/node/pull/29140#discussion_r315658901 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| going in the opposite direction | https://github.com/psf/black#strings |
| Please reload this page | https://github.com/nodejs/node/pull/29140 |
| tools/gyp/pylib/gyp/input.py | https://github.com/nodejs/node/pull/29140/files#diff-15af5a6f295dc79388ca35e8d7e352a19203d9eb56180c0174d8f6d602a1aa57 |
| bnoordhuis | https://github.com/bnoordhuis |
| Aug 20, 2019 | https://github.com/nodejs/node/pull/29140#discussion_r315635565 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/29140 |
| cclauss | https://github.com/cclauss |
| Aug 20, 2019 | https://github.com/nodejs/node/pull/29140#discussion_r315746794 |
| Please reload this page | https://github.com/nodejs/node/pull/29140 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/29140 |
| bnoordhuis | https://github.com/bnoordhuis |
| Aug 20, 2019 | https://github.com/nodejs/node/pull/29140#discussion_r315798453 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/29140 |
|
| https://github.com/cclauss |
| gyp: futurize imput.py to prepare for Python 3 | https://github.com/nodejs/node/pull/29140/commits/bbde6998ac29b208909794ed3c09e478cab72e82 |
| bbde699 | https://github.com/nodejs/node/pull/29140/commits/bbde6998ac29b208909794ed3c09e478cab72e82 |
| https://github.com/cclauss |
| cclauss | https://github.com/cclauss |
| force-pushed | https://github.com/nodejs/node/compare/f6885f48ddd61bcb089a87d48f76bd946ab11eee..bbde6998ac29b208909794ed3c09e478cab72e82 |
| f6885f4 | https://github.com/nodejs/node/commit/f6885f48ddd61bcb089a87d48f76bd946ab11eee |
| bbde699 | https://github.com/nodejs/node/commit/bbde6998ac29b208909794ed3c09e478cab72e82 |
|
Compare
| https://github.com/nodejs/node/compare/f6885f48ddd61bcb089a87d48f76bd946ab11eee..bbde6998ac29b208909794ed3c09e478cab72e82 |
| August 20, 2019 12:30 | https://github.com/nodejs/node/pull/29140#event-2569500903 |
| https://github.com/bnoordhuis |
| bnoordhuis | https://github.com/bnoordhuis |
|
Aug 20, 2019
| https://github.com/nodejs/node/pull/29140#pullrequestreview-277140399 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/29140/files/bbde6998ac29b208909794ed3c09e478cab72e82 |
| https://github.com/nodejs-github-bot |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
| Aug 20, 2019 | https://github.com/nodejs/node/pull/29140#issuecomment-523071754 |
| https://ci.nodejs.org/job/node-test-pull-request/25125/ | https://ci.nodejs.org/job/node-test-pull-request/25125/ |
| Please reload this page | https://github.com/nodejs/node/pull/29140 |
| https://github.com/Trott |
| Trott | https://github.com/Trott |
| Aug 20, 2019 | https://github.com/nodejs/node/pull/29140#issuecomment-523113789 |
| 3b92998 | https://github.com/nodejs/node/commit/3b929989185fc9e1d89ef07c612ee02b84800378 |
| Please reload this page | https://github.com/nodejs/node/pull/29140 |
| https://github.com/Trott |
| Trott | https://github.com/Trott |
| Aug 20, 2019 | https://github.com/nodejs/node/pull/29140#event-2570477940 |
| Trott | https://github.com/Trott |
|
Aug 20, 2019
| https://github.com/nodejs/node/pull/29140#ref-commit-3b92998 |
|
| https://github.com/cclauss |
|
| https://github.com/Trott |
| gyp: futurize imput.py to prepare for Python 3 | https://github.com/nodejs/node/commit/3b929989185fc9e1d89ef07c612ee02b84800378 |
| 3b92998 | https://github.com/nodejs/node/commit/3b929989185fc9e1d89ef07c612ee02b84800378 |
| #29140 | https://github.com/nodejs/node/pull/29140 |
| BridgeAR | https://github.com/BridgeAR |
|
Sep 3, 2019
| https://github.com/nodejs/node/pull/29140#ref-commit-10bae2e |
|
| https://github.com/cclauss |
|
| https://github.com/BridgeAR |
| gyp: futurize imput.py to prepare for Python 3 | https://github.com/nodejs/node/commit/10bae2ec919b26f2f8be5182f3e751d8e2726ec2 |
| 10bae2e | https://github.com/nodejs/node/commit/10bae2ec919b26f2f8be5182f3e751d8e2726ec2 |
| #29140 | https://github.com/nodejs/node/pull/29140 |
| https://github.com/BridgeAR |
| BridgeAR | https://github.com/BridgeAR |
|
Sep 3, 2019
| https://github.com/nodejs/node/pull/29140#ref-pullrequest-488849745 |
|
v12.10.0 proposal
#29429
| https://github.com/nodejs/node/pull/29429 |
| BaochengSu | https://github.com/BaochengSu |
|
Oct 20, 2020
| https://github.com/nodejs/node/pull/29140#ref-commit-6d81e4d |
|
| https://github.com/cclauss |
|
| https://github.com/BaochengSu |
| gyp: futurize imput.py to prepare for Python 3 | https://github.com/BaochengSu/node/commit/6d81e4dff0402e6ca32687ad5133e630d5cbbf68 |
| 6d81e4d | https://github.com/BaochengSu/node/commit/6d81e4dff0402e6ca32687ad5133e630d5cbbf68 |
| nodejs#29140 | https://github.com/nodejs/node/pull/29140 |
| 3b92998 | https://github.com/BaochengSu/node/commit/3b929989185fc9e1d89ef07c612ee02b84800378 |
| https://github.com/DeeDeeG |
| DeeDeeG | https://github.com/DeeDeeG |
|
Sep 4, 2022
| https://github.com/nodejs/node/pull/29140#ref-issue-890270678 |
|
Upstream gyp has actually been updated somewhat recently. Review those changes and sync (some of) them?
nodejs/gyp-next#108
| https://github.com/nodejs/gyp-next/issues/108 |
| https://github.co/hiddenchars |
| https://github.com/nodejs/node/pull/{{ revealButtonHref }} |
| Sign up for free | https://github.com/join?source=comment-repo |
| Sign in to comment | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F29140 |
|
| https://github.com/bnoordhuis |
|
bnoordhuis
| https://github.com/bnoordhuis |
|
| https://github.com/nodejs/node/pull/29140/files/bbde6998ac29b208909794ed3c09e478cab72e82 |
|
| https://github.com/Trott |
|
Trott
| https://github.com/Trott |
|
| https://github.com/nodejs/node/pull/29140/files/f6885f48ddd61bcb089a87d48f76bd946ab11eee |
|
| https://github.com/targos |
|
targos
| https://github.com/targos |
|
| https://github.com/nodejs/node/pull/29140/files/b3e2b29bedb3430b18d79d525daf7f379d3b5afb |
|
| https://github.com/gengjiawen |
|
gengjiawen
| https://github.com/gengjiawen |
|
| https://github.com/nodejs/node/pull/29140/files/f6885f48ddd61bcb089a87d48f76bd946ab11eee |
|
| https://github.com/richardlau |
|
richardlau
| https://github.com/richardlau |
|
| https://github.com/nodejs/node/pull/29140/files/f6885f48ddd61bcb089a87d48f76bd946ab11eee |
|
| https://github.com/sam-github |
|
sam-github
| https://github.com/sam-github |
|
| https://github.com/nodejs/node/pull/29140/files/b601fe00560c913c6be2c5d68b57e3858d5aa0aa |
|
author ready
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22author%20ready%22 |
|
build
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Abuild |
|
python
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Apython |
|
tools
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Atools |
| Please reload this page | https://github.com/nodejs/node/pull/29140 |
|
| https://github.com/cclauss |
|
| https://github.com/nodejs-github-bot |
|
| https://github.com/sam-github |
|
| https://github.com/Trott |
|
| https://github.com/gengjiawen |
|
| https://github.com/bnoordhuis |
|
| https://github.com/targos |
|
| https://github.com/richardlau |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |