| route-pattern | /_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format) |
| route-controller | voltron_pull_requests_fragments |
| route-action | pull_request_layout |
| fetch-nonce | v2:40ea5e7e-0b24-78ac-809a-96a993073c65 |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | B7C2:3F60C6:317035B:459D960:6A4F7BE7 |
| html-safe-nonce | af911d17c6c522e78b34fb64e79b455f249a9a8e49c9f1879164e836f6bfe7d3 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJCN0MyOjNGNjBDNjozMTcwMzVCOjQ1OUQ5NjA6NkE0RjdCRTciLCJ2aXNpdG9yX2lkIjoiNzA2MjU0NDg5MzYxNzMzOTM2NyIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9 |
| visitor-hmac | eea845ceeeab22504df0d2136a5129d2e059884bccec0c3d62ebf9ff2d8d2a95 |
| hovercard-subject-tag | pull_request:307652866 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///voltron/pull_requests_fragments/pull_request_layout |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/29134/pull_request_layout |
| twitter:image | https://opengraph.githubassets.com/a1d4479f11419a54b07042f1749ee847db631a99e8bfd49dfe3a7faa20e122ef/nodejs/node/pull/29134 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/a1d4479f11419a54b07042f1749ee847db631a99e8bfd49dfe3a7faa20e122ef/nodejs/node/pull/29134 |
| og:image:alt | Move socket.end() to client.
Fixes: #28111
Refs: #27569
Checklist
make -j4 test (UNIX), or vcbuild test (Windows) passes
commit message follows commit guidelines |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | lpinca |
| hostname | github.com |
| expected-hostname | github.com |
| None | b92d11c0aa4a77d54ef4af1078b6a15fb5a70a215b30c4ecf28889d5a8e656d9 |
| turbo-cache-control | no-cache |
| go-import | github.com/nodejs/node git https://github.com/nodejs/node.git |
| octolytics-dimension-user_id | 9950313 |
| octolytics-dimension-user_login | nodejs |
| octolytics-dimension-repository_id | 27193779 |
| octolytics-dimension-repository_nwo | nodejs/node |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 27193779 |
| octolytics-dimension-repository_network_root_nwo | nodejs/node |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 4b249b445842943ed31549e027f57a8ade9881ed |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| Skip to content | https://github.com/nodejs/node/pull/29134#start-of-content |
|
| https://github.com/ |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F29134 |
| GitHub CopilotWrite better code with AI | https://github.com/features/copilot |
| GitHub Copilot appDirect agents from issue to merge | https://github.com/features/ai/github-app |
| MCP RegistryNewIntegrate external tools | https://github.com/mcp |
| ActionsAutomate any workflow | https://github.com/features/actions |
| CodespacesInstant dev environments | https://github.com/features/codespaces |
| IssuesPlan and track work | https://github.com/features/issues |
| Code ReviewManage code changes | https://github.com/features/code-review |
| GitHub Advanced SecurityFind and fix vulnerabilities | https://github.com/security/advanced-security |
| Code securitySecure your code as you build | https://github.com/security/advanced-security/code-security |
| Secret protectionStop leaks before they start | https://github.com/security/advanced-security/secret-protection |
| Why GitHub | https://github.com/why-github |
| Documentation | https://docs.github.com |
| Blog | https://github.blog |
| Changelog | https://github.blog/changelog |
| Marketplace | https://github.com/marketplace |
| View all features | https://github.com/features |
| Enterprises | https://github.com/enterprise |
| Small and medium teams | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| App Modernization | https://github.com/solutions/use-case/app-modernization |
| DevSecOps | https://github.com/solutions/use-case/devsecops |
| DevOps | https://github.com/solutions/use-case/devops |
| CI/CD | https://github.com/solutions/use-case/ci-cd |
| View all use cases | https://github.com/solutions/use-case |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| View all industries | https://github.com/solutions/industry |
| View all solutions | https://github.com/solutions |
| AI | https://github.com/resources/articles?topic=ai |
| Software Development | https://github.com/resources/articles?topic=software-development |
| DevOps | https://github.com/resources/articles?topic=devops |
| Security | https://github.com/resources/articles?topic=security |
| View all topics | https://github.com/resources/articles |
| Customer stories | https://github.com/customer-stories |
| Events & webinars | https://github.com/resources/events |
| Ebooks & reports | https://github.com/resources/whitepapers |
| Business insights | https://github.com/solutions/executive-insights |
| GitHub Skills | https://skills.github.com |
| Documentation | https://docs.github.com |
| Customer support | https://support.github.com |
| Community forum | https://github.com/orgs/community/discussions |
| Trust center | https://github.com/trust-center |
| Partners | https://github.com/partners |
| View all resources | https://github.com/resources |
| GitHub SponsorsFund open source developers | https://github.com/open-source/sponsors |
| Security Lab | https://securitylab.github.com |
| Maintainer Community | https://maintainers.github.com |
| Accelerator | https://github.com/open-source/accelerator |
| GitHub Stars | https://stars.github.com |
| Archive Program | https://archiveprogram.github.com |
| Topics | https://github.com/topics |
| Trending | https://github.com/trending |
| Collections | https://github.com/collections |
| Enterprise platformAI-powered developer platform | https://github.com/enterprise |
| GitHub Advanced SecurityEnterprise-grade security features | https://github.com/security/advanced-security |
| Copilot for BusinessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/enterprise/premium-support |
| Pricing | https://github.com/pricing |
| Search syntax tips | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
| documentation | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F29134 |
|
Sign up
| https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode |
| Reload | https://github.com/nodejs/node/pull/29134 |
| Reload | https://github.com/nodejs/node/pull/29134 |
| Reload | https://github.com/nodejs/node/pull/29134 |
| Please reload this page | https://github.com/nodejs/node/pull/29134 |
|
nodejs
| https://github.com/nodejs |
| node | https://github.com/nodejs/node |
| Please reload this page | https://github.com/nodejs/node/pull/29134 |
|
Notifications
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Fork
36k
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Star
118k
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Code
| https://github.com/nodejs/node |
|
Issues
1.3k
| https://github.com/nodejs/node/issues |
|
Pull requests
973
| https://github.com/nodejs/node/pulls |
|
Actions
| https://github.com/nodejs/node/actions |
|
Projects
| https://github.com/nodejs/node/projects |
|
Security and quality
0
| https://github.com/nodejs/node/security |
|
Insights
| https://github.com/nodejs/node/pulse |
|
Code
| https://github.com/nodejs/node |
|
Issues
| https://github.com/nodejs/node/issues |
|
Pull requests
| https://github.com/nodejs/node/pulls |
|
Actions
| https://github.com/nodejs/node/actions |
|
Projects
| https://github.com/nodejs/node/projects |
|
Security and quality
| https://github.com/nodejs/node/security |
|
Insights
| https://github.com/nodejs/node/pulse |
| lpinca | https://github.com/lpinca |
| nodejs:master | https://github.com/nodejs/node/tree/master |
| lpinca:deflake/test-tls-passphrase | https://github.com/lpinca/node/tree/deflake/test-tls-passphrase |
| Conversation | https://github.com/nodejs/node/pull/29134 |
| Commits1 (1) | https://github.com/nodejs/node/pull/29134/commits |
| Checks | https://github.com/nodejs/node/pull/29134/checks |
| Files changed | https://github.com/nodejs/node/pull/29134/files |
| test: deflake test-tls-passphrase | https://github.com/nodejs/node/pull/29134#top |
| lpinca | https://github.com/lpinca |
| nodejs:master | https://github.com/nodejs/node/tree/master |
| lpinca:deflake/test-tls-passphrase | https://github.com/lpinca/node/tree/deflake/test-tls-passphrase |
|
| https://github.com/lpinca |
| lpinca | https://github.com/lpinca |
| Aug 15, 2019 | https://github.com/nodejs/node/pull/29134#issue-481084552 |
| Please reload this page | https://github.com/nodejs/node/pull/29134 |
| #28111 | https://github.com/nodejs/node/issues/28111 |
| #27569 | https://github.com/nodejs/node/pull/27569 |
| commit guidelines | https://github.com/nodejs/node/blob/master/doc/guides/contributing/pull-requests.md#commit-message-guidelines |
| Please reload this page | https://github.com/nodejs/node/pull/29134 |
| https://github.com/nodejs-github-bot |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
|
test
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Atest |
| Aug 15, 2019 | https://github.com/nodejs/node/pull/29134#event-2559102890 |
| https://github.com/lpinca |
| lpinca | https://github.com/lpinca |
| Aug 15, 2019 | https://github.com/nodejs/node/pull/29134#issuecomment-521591511 |
| Please reload this page | https://github.com/nodejs/node/pull/29134 |
| https://github.com/lpinca |
| lpinca | https://github.com/lpinca |
|
macos
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Amacos |
|
flaky-test
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aflaky-test |
| Aug 15, 2019 | https://github.com/nodejs/node/pull/29134#event-2559107156 |
| https://github.com/lpinca |
| lpinca | https://github.com/lpinca |
| Aug 15, 2019 | https://github.com/nodejs/node/pull/29134#issuecomment-521591691 |
| @sam-github | https://github.com/sam-github |
| Please reload this page | https://github.com/nodejs/node/pull/29134 |
| https://github.com/bnoordhuis |
| bnoordhuis | https://github.com/bnoordhuis |
|
Aug 15, 2019
| https://github.com/nodejs/node/pull/29134#pullrequestreview-275355766 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/29134/files |
| bnoordhuis | https://github.com/bnoordhuis |
| https://github.com/nodejs/node/pull/29134#pullrequestreview-275355766 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/29134 |
| test/parallel/test-tls-passphrase.js | https://github.com/nodejs/node/pull/29134/files#diff-eae655ec3c70ad79bdac99a750dd77177a75eae65b2b376236beec03b98cd86a |
| Please reload this page | https://github.com/nodejs/node/pull/29134 |
| https://github.com/lpinca |
| lpinca | https://github.com/lpinca |
| force-pushed | https://github.com/nodejs/node/compare/20c24fd59201403ab1e466b2deac12fc17e49489..6db2364a1460167bdc636ad1e239fe645dde33a1 |
| 20c24fd | https://github.com/nodejs/node/commit/20c24fd59201403ab1e466b2deac12fc17e49489 |
| 6db2364 | https://github.com/nodejs/node/commit/6db2364a1460167bdc636ad1e239fe645dde33a1 |
|
Compare
| https://github.com/nodejs/node/compare/20c24fd59201403ab1e466b2deac12fc17e49489..6db2364a1460167bdc636ad1e239fe645dde33a1 |
| August 15, 2019 10:19 | https://github.com/nodejs/node/pull/29134#event-2559121016 |
| https://github.com/cjihrig |
| cjihrig | https://github.com/cjihrig |
|
Aug 15, 2019
| https://github.com/nodejs/node/pull/29134#pullrequestreview-275433245 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/29134/files |
| https://github.com/sam-github |
| sam-github | https://github.com/sam-github |
|
Aug 15, 2019
| https://github.com/nodejs/node/pull/29134#pullrequestreview-275517833 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/29134/files |
| sam-github | https://github.com/sam-github |
| https://github.com/nodejs/node/pull/29134#pullrequestreview-275517833 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| @lpinca | https://github.com/lpinca |
| Please reload this page | https://github.com/nodejs/node/pull/29134 |
| https://github.com/lpinca |
| lpinca | https://github.com/lpinca |
| Aug 15, 2019 | https://github.com/nodejs/node/pull/29134#issuecomment-521697860 |
| #28337 (comment) | https://github.com/nodejs/node/issues/28337#issuecomment-515762218 |
| #28111 | https://github.com/nodejs/node/issues/28111 |
| Please reload this page | https://github.com/nodejs/node/pull/29134 |
|
| https://github.com/lpinca |
| test: deflake test-tls-passphrase | https://github.com/nodejs/node/pull/29134/commits/6d6de17e2da18b5c9e792570ec55601ee6bdd606 |
| 6d6de17 | https://github.com/nodejs/node/pull/29134/commits/6d6de17e2da18b5c9e792570ec55601ee6bdd606 |
| nodejs#28111 | https://github.com/nodejs/node/issues/28111 |
| nodejs#27569 | https://github.com/nodejs/node/pull/27569 |
| https://github.com/lpinca |
| lpinca | https://github.com/lpinca |
| force-pushed | https://github.com/nodejs/node/compare/6db2364a1460167bdc636ad1e239fe645dde33a1..6d6de17e2da18b5c9e792570ec55601ee6bdd606 |
| 6db2364 | https://github.com/nodejs/node/commit/6db2364a1460167bdc636ad1e239fe645dde33a1 |
| 6d6de17 | https://github.com/nodejs/node/commit/6d6de17e2da18b5c9e792570ec55601ee6bdd606 |
|
Compare
| https://github.com/nodejs/node/compare/6db2364a1460167bdc636ad1e239fe645dde33a1..6d6de17e2da18b5c9e792570ec55601ee6bdd606 |
| August 15, 2019 16:11 | https://github.com/nodejs/node/pull/29134#event-2559968679 |
| https://github.com/Trott |
| Trott | https://github.com/Trott |
|
Aug 16, 2019
| https://github.com/nodejs/node/pull/29134#pullrequestreview-275749540 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/29134/files/6d6de17e2da18b5c9e792570ec55601ee6bdd606 |
| https://github.com/jasnell |
| jasnell | https://github.com/jasnell |
|
Aug 16, 2019
| https://github.com/nodejs/node/pull/29134#pullrequestreview-275895893 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/29134/files/6d6de17e2da18b5c9e792570ec55601ee6bdd606 |
| https://github.com/nodejs-github-bot |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
| Aug 19, 2019 | https://github.com/nodejs/node/pull/29134#issuecomment-522680108 |
| https://ci.nodejs.org/job/node-test-pull-request/25105/ | https://ci.nodejs.org/job/node-test-pull-request/25105/ |
| Please reload this page | https://github.com/nodejs/node/pull/29134 |
| https://github.com/Trott |
| Trott | https://github.com/Trott |
| Aug 19, 2019 | https://github.com/nodejs/node/pull/29134#issuecomment-522729233 |
| Please reload this page | https://github.com/nodejs/node/pull/29134 |
| https://github.com/Trott |
| Trott | https://github.com/Trott |
| Aug 19, 2019 | https://github.com/nodejs/node/pull/29134#event-2567485683 |
| Trott | https://github.com/Trott |
|
Aug 19, 2019
| https://github.com/nodejs/node/pull/29134#ref-commit-a0cc62f |
|
| https://github.com/lpinca |
|
| https://github.com/Trott |
| test: deflake test-tls-passphrase | https://github.com/nodejs/node/commit/a0cc62f34549302d7a85588776c23faffda1f8b7 |
| a0cc62f | https://github.com/nodejs/node/commit/a0cc62f34549302d7a85588776c23faffda1f8b7 |
| #28111 | https://github.com/nodejs/node/issues/28111 |
| #27569 | https://github.com/nodejs/node/pull/27569 |
| #29134 | https://github.com/nodejs/node/pull/29134 |
| https://github.com/lpinca |
| lpinca | https://github.com/lpinca |
| August 19, 2019 20:00 | https://github.com/nodejs/node/pull/29134#event-2567499233 |
| targos | https://github.com/targos |
|
Aug 20, 2019
| https://github.com/nodejs/node/pull/29134#ref-commit-6bafd35 |
|
| https://github.com/lpinca |
|
| https://github.com/targos |
| test: deflake test-tls-passphrase | https://github.com/nodejs/node/commit/6bafd353697a282aa88b8774967277c56bdc0150 |
| 6bafd35 | https://github.com/nodejs/node/commit/6bafd353697a282aa88b8774967277c56bdc0150 |
| #28111 | https://github.com/nodejs/node/issues/28111 |
| #27569 | https://github.com/nodejs/node/pull/27569 |
| #29134 | https://github.com/nodejs/node/pull/29134 |
| https://github.com/targos |
| targos | https://github.com/targos |
|
Aug 20, 2019
| https://github.com/nodejs/node/pull/29134#ref-pullrequest-482485175 |
|
v12.9.0 release proposal
#29210
| https://github.com/nodejs/node/pull/29210 |
|
2019-08-20 Version 12.9.0 (Current) @targos
beevelop/docker-android-nodejs#328
| https://github.com/beevelop/docker-android-nodejs/issues/328 |
|
2019-08-20 Version 12.9.0 (Current) @targos
beevelop/docker-android-nodejs#329
| https://github.com/beevelop/docker-android-nodejs/issues/329 |
|
2019-08-20 Version 12.9.0 (Current) @targos
beevelop/docker-android-nodejs#330
| https://github.com/beevelop/docker-android-nodejs/issues/330 |
|
2019-08-20 Version 12.9.0 (Current) @targos
beevelop/docker-nodejs#295
| https://github.com/beevelop/docker-nodejs/issues/295 |
|
2019-08-20 Version 12.9.0 (Current) @targos
beevelop/docker-nodejs#296
| https://github.com/beevelop/docker-nodejs/issues/296 |
|
2019-08-20 Version 12.9.0 (Current) @targos
beevelop/docker-nodejs#297
| https://github.com/beevelop/docker-nodejs/issues/297 |
| https://github.co/hiddenchars |
| https://github.com/nodejs/node/pull/{{ revealButtonHref }} |
| Sign up for free | https://github.com/join?source=comment-repo |
| Sign in to comment | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F29134 |
|
| https://github.com/bnoordhuis |
|
bnoordhuis
| https://github.com/bnoordhuis |
|
| https://github.com/nodejs/node/pull/29134/files/20c24fd59201403ab1e466b2deac12fc17e49489 |
|
| https://github.com/jasnell |
|
jasnell
| https://github.com/jasnell |
|
| https://github.com/nodejs/node/pull/29134/files/6d6de17e2da18b5c9e792570ec55601ee6bdd606 |
|
| https://github.com/Trott |
|
Trott
| https://github.com/Trott |
|
| https://github.com/nodejs/node/pull/29134/files/6d6de17e2da18b5c9e792570ec55601ee6bdd606 |
|
| https://github.com/cjihrig |
|
cjihrig
| https://github.com/cjihrig |
|
| https://github.com/nodejs/node/pull/29134/files/6db2364a1460167bdc636ad1e239fe645dde33a1 |
|
| https://github.com/sam-github |
|
sam-github
| https://github.com/sam-github |
|
| https://github.com/nodejs/node/pull/29134/files/6db2364a1460167bdc636ad1e239fe645dde33a1 |
|
flaky-test
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aflaky-test |
|
macos
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Amacos |
|
test
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Atest |
|
Investigate flaky parallel/test-tls-passphrase on OS X
| https://github.com/nodejs/node/issues/28111 |
| Please reload this page | https://github.com/nodejs/node/pull/29134 |
|
| https://github.com/lpinca |
|
| https://github.com/nodejs-github-bot |
|
| https://github.com/Trott |
|
| https://github.com/sam-github |
|
| https://github.com/bnoordhuis |
|
| https://github.com/jasnell |
|
| https://github.com/cjihrig |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |