René's URL Explorer Experiment


Title: [v10.x] http2: mitigate reported DoS attacks by addaleax · Pull Request #29123 · nodejs/node · GitHub

Open Graph Title: [v10.x] http2: mitigate reported DoS attacks by addaleax · Pull Request #29123 · nodejs/node

X Title: [v10.x] http2: mitigate reported DoS attacks by addaleax · Pull Request #29123 · nodejs/node

Description: See #29122 for the PR against master.

Open Graph Description: See #29122 for the PR against master.

X Description: See #29122 for the PR against master.

Opengraph URL: https://github.com/nodejs/node/pull/29123

X: @github

direct link

Domain: github.com

route-pattern/:user_id/:repository/pull/:id/commits/:range(.:format)
route-controllerpull_requests
route-actioncommits
fetch-noncev2:01d7ef61-4c22-e471-04c2-b09bd85ada68
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idEBD0:20176B:1FACCC0:2AEF278:6A6556D1
html-safe-nonceba904b3ada6136e7c8fe93f2a016424779f2f9c7507eff802a3d1f9d36128e19
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJFQkQwOjIwMTc2QjoxRkFDQ0MwOjJBRUYyNzg6NkE2NTU2RDEiLCJ2aXNpdG9yX2lkIjoiNTYzNjA2MjgzODczMTkyMTEwNSIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmac3247eb2d53547ab4b36f0dc4f36eef4e191e23036fc4dcfe2191d7b23b0fce33
hovercard-subject-tagpull_request:307395712
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/commits
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/nodejs/node/pull/29123/commits/0c905656fa960082f5c08c915f2e87849c4e9ba9
twitter:imagehttps://avatars.githubusercontent.com/u/899444?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/899444?s=400&v=4
og:image:altSee #29122 for the PR against master.
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
None52c76df668885aaff23b50bdca1fa1ea44ac9c1553e888ebc70ff1e4daa4625b
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/nodejs/node git https://github.com/nodejs/node.git
octolytics-dimension-user_id9950313
octolytics-dimension-user_loginnodejs
octolytics-dimension-repository_id27193779
octolytics-dimension-repository_nwonodejs/node
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id27193779
octolytics-dimension-repository_network_root_nwonodejs/node
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release309153364422b3c499922d1a2a6404910a58ed8e
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/nodejs/node/pull/29123/commits/0c905656fa960082f5c08c915f2e87849c4e9ba9#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F29123%2Fcommits%2F0c905656fa960082f5c08c915f2e87849c4e9ba9
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub Copilot appDirect agents from issue to mergehttps://github.com/features/ai/github-app
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
Code QualityEnforce quality at mergehttps://github.com/features/code-quality
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
View all resourceshttps://github.com/resources
GitHub SponsorsFund open source developershttps://github.com/open-source/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/open-source/accelerator
GitHub Starshttps://stars.github.com
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F29123%2Fcommits%2F0c905656fa960082f5c08c915f2e87849c4e9ba9
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Fcommits&source=header-repo&source_repo=nodejs%2Fnode
Reloadhttps://github.com/nodejs/node/pull/29123/commits/0c905656fa960082f5c08c915f2e87849c4e9ba9
Reloadhttps://github.com/nodejs/node/pull/29123/commits/0c905656fa960082f5c08c915f2e87849c4e9ba9
Reloadhttps://github.com/nodejs/node/pull/29123/commits/0c905656fa960082f5c08c915f2e87849c4e9ba9
Please reload this pagehttps://github.com/nodejs/node/pull/29123/commits/0c905656fa960082f5c08c915f2e87849c4e9ba9
nodejs https://github.com/nodejs
nodehttps://github.com/nodejs/node
Please reload this pagehttps://github.com/nodejs/node/pull/29123/commits/0c905656fa960082f5c08c915f2e87849c4e9ba9
Notifications https://github.com/login?return_to=%2Fnodejs%2Fnode
Fork 36.1k https://github.com/login?return_to=%2Fnodejs%2Fnode
Star 118k https://github.com/login?return_to=%2Fnodejs%2Fnode
Code https://github.com/nodejs/node
Issues 1.3k https://github.com/nodejs/node/issues
Pull requests 1.1k https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects https://github.com/nodejs/node/projects
Security and quality 0 https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
Code https://github.com/nodejs/node
Issues https://github.com/nodejs/node/issues
Pull requests https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects https://github.com/nodejs/node/projects
Security and quality https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fnodejs%2Fnode%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fnodejs%2Fnode%2Fissues%2Fnew%2Fchoose
addaleaxhttps://github.com/addaleax
nodejs:v10.xhttps://github.com/nodejs/node/tree/v10.x
addaleax:http2-fixes-v10.xhttps://github.com/addaleax/node/tree/http2-fixes-v10.x
Conversation 3 https://github.com/nodejs/node/pull/29123
Commits 19 https://github.com/nodejs/node/pull/29123/commits
Checks 0 https://github.com/nodejs/node/pull/29123/checks
Files changed https://github.com/nodejs/node/pull/29123/files
Please reload this pagehttps://github.com/nodejs/node/pull/29123/commits/0c905656fa960082f5c08c915f2e87849c4e9ba9
[v10.x] http2: mitigate reported DoS attacks https://github.com/nodejs/node/pull/29123/commits/0c905656fa960082f5c08c915f2e87849c4e9ba9#top
Show all changes 19 commits https://github.com/nodejs/node/pull/29123/files
ff15024 http2: improve http2 code a bit jasnell Oct 30, 2018 https://github.com/nodejs/node/pull/29123/commits/ff15024b479a38c1f6c5db8df1ffdb1c0a26d18c
5caf137 src: pass along errors from http2 object creation addaleax Jan 30, 2019 https://github.com/nodejs/node/pull/29123/commits/5caf137af84e0179aaacea84d3e2d859954bd394
bdd3b09 deps: update nghttp2 to 1.37.0 gengjiawen Mar 29, 2019 https://github.com/nodejs/node/pull/29123/commits/bdd3b092532564ae563e58febe5efcdd55697985
bd05d74 deps: update nghttp2 to 1.38.0 gengjiawen Apr 18, 2019 https://github.com/nodejs/node/pull/29123/commits/bd05d749d25dd834357e4a2bb61bfc7b49da4911
ee711ce deps: update nghttp2 to 1.39.1 gengjiawen Jun 27, 2019 https://github.com/nodejs/node/pull/29123/commits/ee711ce988ffb8a808fc5d4d3e67e9f70009e1fe
eecba7b deps: update nghttp2 to 1.39.2 addaleax Aug 14, 2019 https://github.com/nodejs/node/pull/29123/commits/eecba7be0b9edfe22cb6f570a263b0052d6ff6f5
c625114 http2: improve JS-side debug logging addaleax Aug 5, 2019 https://github.com/nodejs/node/pull/29123/commits/c625114ec8dbef08b552a9769ce6d8d4bdc3e778
3b76bb6 http2: only call into JS when necessary for session events addaleax Aug 9, 2019 https://github.com/nodejs/node/pull/29123/commits/3b76bb61aab35ddc2fcef73f02b552758d34e445
0f0bf81 http2: do not create ArrayBuffers when no DATA received addaleax Aug 9, 2019 https://github.com/nodejs/node/pull/29123/commits/0f0bf8197dc52afaf051146f158c2896a827d54a
e350322 http2: limit number of rejected stream openings addaleax Aug 10, 2019 https://github.com/nodejs/node/pull/29123/commits/e3503225d7de50693518a4c983357916d84bd6f1
0c90565 http2: limit number of invalid incoming frames addaleax Aug 12, 2019 https://github.com/nodejs/node/pull/29123/commits/0c905656fa960082f5c08c915f2e87849c4e9ba9
8c741e6 http2: handle 0-length headers better addaleax Aug 10, 2019 https://github.com/nodejs/node/pull/29123/commits/8c741e60022c322e51410f98267b01dc728beefc
1c03103 http2: shrink default `vector::reserve()` allocations addaleax Aug 10, 2019 https://github.com/nodejs/node/pull/29123/commits/1c0310374c3e7ef99a6a5092e0f52faaa3084de3
f1ec93f http2: consider 0-length non-end DATA frames an error addaleax Aug 10, 2019 https://github.com/nodejs/node/pull/29123/commits/f1ec93fe3f091ed9e0cbf087e92aacd50c2b32dd
3343c3e http2: stop reading from socket if writes are in progress addaleax Aug 10, 2019 https://github.com/nodejs/node/pull/29123/commits/3343c3ee5cf65f50b64624e1e39d75f2b54e4128
981fd55 http2: pause input processing if sending output addaleax Aug 11, 2019 https://github.com/nodejs/node/pull/29123/commits/981fd55d6b7a9acfaa64b6dd22734bc62aebdb4a
e4e47e2 http2: allow security revert for Ping/Settings Flood addaleax Aug 12, 2019 https://github.com/nodejs/node/pull/29123/commits/e4e47e2cf848844740a02fa980baeecdfc061356
b0d0bdd test: apply test-http2-max-session-memory-leak from v12.x addaleax Aug 13, 2019 https://github.com/nodejs/node/pull/29123/commits/b0d0bdd4c72d2f68448b92c505f681c01d63d090
2aa90c2 fixup! deps: update nghttp2 to 1.39.2 addaleax Aug 14, 2019 https://github.com/nodejs/node/pull/29123/commits/2aa90c2342a0abbd17afe1cc1fcba9203d89ae93
Clear filters https://github.com/nodejs/node/pull/29123/commits/0c905656fa960082f5c08c915f2e87849c4e9ba9
Please reload this pagehttps://github.com/nodejs/node/pull/29123/commits/0c905656fa960082f5c08c915f2e87849c4e9ba9
Please reload this pagehttps://github.com/nodejs/node/pull/29123/commits/0c905656fa960082f5c08c915f2e87849c4e9ba9
node_http2.cc https://github.com/nodejs/node/pull/29123/commits/0c905656fa960082f5c08c915f2e87849c4e9ba9#diff-33f026e43570112875cf4c8eab6743496f3aa014329611128e348ec23d6f771c
node_http2.h https://github.com/nodejs/node/pull/29123/commits/0c905656fa960082f5c08c915f2e87849c4e9ba9#diff-430b8a0d2f4cc14e0eac16d13f3879eed2697ebe3749acbb48a11db567a7e936
test-http2-reset-flood.js https://github.com/nodejs/node/pull/29123/commits/0c905656fa960082f5c08c915f2e87849c4e9ba9#diff-95937af78c5d734ef9bbdddc818d42adb8f170ceb243d4fad5a9052ecc674b9a
Prev https://github.com/nodejs/node/pull/29123/commits/e3503225d7de50693518a4c983357916d84bd6f1
Next https://github.com/nodejs/node/pull/29123/commits/8c741e60022c322e51410f98267b01dc728beefc
CVE-2019-9514https://github.com/advisories/GHSA-39qc-96h7-956f
libuv/libuv@ee24ce900e5714c950b248da2bhttps://github.com/libuv/libuv/commit/ee24ce900e5714c950b248da2b
Please reload this pagehttps://github.com/nodejs/node/pull/29123/commits/0c905656fa960082f5c08c915f2e87849c4e9ba9
https://github.com/addaleax
addaleaxhttps://github.com/nodejs/node/commits?author=addaleax
src/node_http2.cchttps://github.com/nodejs/node/pull/29123/commits/0c905656fa960082f5c08c915f2e87849c4e9ba9#diff-33f026e43570112875cf4c8eab6743496f3aa014329611128e348ec23d6f771c
View file https://github.com/addaleax/node/blob/0c905656fa960082f5c08c915f2e87849c4e9ba9/src/node_http2.cc
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/nodejs/node/pull/29123/commits/{{ revealButtonHref }}
https://github.com/nodejs/node/pull/29123/commits/0c905656fa960082f5c08c915f2e87849c4e9ba9#diff-33f026e43570112875cf4c8eab6743496f3aa014329611128e348ec23d6f771c
https://github.com/nodejs/node/pull/29123/commits/0c905656fa960082f5c08c915f2e87849c4e9ba9#diff-33f026e43570112875cf4c8eab6743496f3aa014329611128e348ec23d6f771c
src/node_http2.hhttps://github.com/nodejs/node/pull/29123/commits/0c905656fa960082f5c08c915f2e87849c4e9ba9#diff-430b8a0d2f4cc14e0eac16d13f3879eed2697ebe3749acbb48a11db567a7e936
View file https://github.com/addaleax/node/blob/0c905656fa960082f5c08c915f2e87849c4e9ba9/src/node_http2.h
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/nodejs/node/pull/29123/commits/{{ revealButtonHref }}
https://github.com/nodejs/node/pull/29123/commits/0c905656fa960082f5c08c915f2e87849c4e9ba9#diff-430b8a0d2f4cc14e0eac16d13f3879eed2697ebe3749acbb48a11db567a7e936
https://github.com/nodejs/node/pull/29123/commits/0c905656fa960082f5c08c915f2e87849c4e9ba9#diff-430b8a0d2f4cc14e0eac16d13f3879eed2697ebe3749acbb48a11db567a7e936
test/parallel/test-http2-reset-flood.jshttps://github.com/nodejs/node/pull/29123/commits/0c905656fa960082f5c08c915f2e87849c4e9ba9#diff-95937af78c5d734ef9bbdddc818d42adb8f170ceb243d4fad5a9052ecc674b9a
View file https://github.com/addaleax/node/blob/0c905656fa960082f5c08c915f2e87849c4e9ba9/test/parallel/test-http2-reset-flood.js
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/nodejs/node/pull/29123/commits/{{ revealButtonHref }}
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.