| route-pattern | /:user_id/:repository/pull/:id/commits/:range(.:format) |
| route-controller | pull_requests |
| route-action | commits |
| fetch-nonce | v2:01d7ef61-4c22-e471-04c2-b09bd85ada68 |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | EBD0:20176B:1FACCC0:2AEF278:6A6556D1 |
| html-safe-nonce | ba904b3ada6136e7c8fe93f2a016424779f2f9c7507eff802a3d1f9d36128e19 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJFQkQwOjIwMTc2QjoxRkFDQ0MwOjJBRUYyNzg6NkE2NTU2RDEiLCJ2aXNpdG9yX2lkIjoiNTYzNjA2MjgzODczMTkyMTEwNSIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9 |
| visitor-hmac | 3247eb2d53547ab4b36f0dc4f36eef4e191e23036fc4dcfe2191d7b23b0fce33 |
| hovercard-subject-tag | pull_request:307395712 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///pull_requests/show/commits |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/nodejs/node/pull/29123/commits/0c905656fa960082f5c08c915f2e87849c4e9ba9 |
| twitter:image | https://avatars.githubusercontent.com/u/899444?s=400&v=4 |
| twitter:card | summary_large_image |
| og:image | https://avatars.githubusercontent.com/u/899444?s=400&v=4 |
| og:image:alt | See #29122 for the PR against master. |
| og:site_name | GitHub |
| og:type | object |
| hostname | github.com |
| expected-hostname | github.com |
| None | 52c76df668885aaff23b50bdca1fa1ea44ac9c1553e888ebc70ff1e4daa4625b |
| turbo-cache-control | no-preview |
| diff-view | unified |
| go-import | github.com/nodejs/node git https://github.com/nodejs/node.git |
| octolytics-dimension-user_id | 9950313 |
| octolytics-dimension-user_login | nodejs |
| octolytics-dimension-repository_id | 27193779 |
| octolytics-dimension-repository_nwo | nodejs/node |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 27193779 |
| octolytics-dimension-repository_network_root_nwo | nodejs/node |
| turbo-body-classes | logged-out env-production page-responsive full-width |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 309153364422b3c499922d1a2a6404910a58ed8e |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| Skip to content | https://github.com/nodejs/node/pull/29123/commits/0c905656fa960082f5c08c915f2e87849c4e9ba9#start-of-content |
|
| https://github.com/ |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F29123%2Fcommits%2F0c905656fa960082f5c08c915f2e87849c4e9ba9 |
| GitHub CopilotWrite better code with AI | https://github.com/features/copilot |
| GitHub Copilot appDirect agents from issue to merge | https://github.com/features/ai/github-app |
| MCP RegistryNewIntegrate external tools | https://github.com/mcp |
| ActionsAutomate any workflow | https://github.com/features/actions |
| CodespacesInstant dev environments | https://github.com/features/codespaces |
| IssuesPlan and track work | https://github.com/features/issues |
| Code ReviewManage code changes | https://github.com/features/code-review |
| Code QualityEnforce quality at merge | https://github.com/features/code-quality |
| GitHub Advanced SecurityFind and fix vulnerabilities | https://github.com/security/advanced-security |
| Code securitySecure your code as you build | https://github.com/security/advanced-security/code-security |
| Secret protectionStop leaks before they start | https://github.com/security/advanced-security/secret-protection |
| Why GitHub | https://github.com/why-github |
| Documentation | https://docs.github.com |
| Blog | https://github.blog |
| Changelog | https://github.blog/changelog |
| Marketplace | https://github.com/marketplace |
| View all features | https://github.com/features |
| Enterprises | https://github.com/enterprise |
| Small and medium teams | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| App Modernization | https://github.com/solutions/use-case/app-modernization |
| DevSecOps | https://github.com/solutions/use-case/devsecops |
| DevOps | https://github.com/solutions/use-case/devops |
| CI/CD | https://github.com/solutions/use-case/ci-cd |
| View all use cases | https://github.com/solutions/use-case |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| View all industries | https://github.com/solutions/industry |
| View all solutions | https://github.com/solutions |
| AI | https://github.com/resources/articles?topic=ai |
| Software Development | https://github.com/resources/articles?topic=software-development |
| DevOps | https://github.com/resources/articles?topic=devops |
| Security | https://github.com/resources/articles?topic=security |
| View all topics | https://github.com/resources/articles |
| Customer stories | https://github.com/customer-stories |
| Events & webinars | https://github.com/resources/events |
| Ebooks & reports | https://github.com/resources/whitepapers |
| Business insights | https://github.com/solutions/executive-insights |
| GitHub Skills | https://skills.github.com |
| Documentation | https://docs.github.com |
| Customer support | https://support.github.com |
| Community forum | https://github.com/orgs/community/discussions |
| Trust center | https://github.com/trust-center |
| Partners | https://github.com/partners |
| View all resources | https://github.com/resources |
| GitHub SponsorsFund open source developers | https://github.com/open-source/sponsors |
| Security Lab | https://securitylab.github.com |
| Maintainer Community | https://maintainers.github.com |
| Accelerator | https://github.com/open-source/accelerator |
| GitHub Stars | https://stars.github.com |
| Archive Program | https://archiveprogram.github.com |
| Topics | https://github.com/topics |
| Trending | https://github.com/trending |
| Collections | https://github.com/collections |
| Enterprise platformAI-powered developer platform | https://github.com/enterprise |
| GitHub Advanced SecurityEnterprise-grade security features | https://github.com/security/advanced-security |
| Copilot for BusinessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/enterprise/premium-support |
| Pricing | https://github.com/pricing |
| Search syntax tips | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
| documentation | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F29123%2Fcommits%2F0c905656fa960082f5c08c915f2e87849c4e9ba9 |
|
Sign up
| https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Fcommits&source=header-repo&source_repo=nodejs%2Fnode |
| Reload | https://github.com/nodejs/node/pull/29123/commits/0c905656fa960082f5c08c915f2e87849c4e9ba9 |
| Reload | https://github.com/nodejs/node/pull/29123/commits/0c905656fa960082f5c08c915f2e87849c4e9ba9 |
| Reload | https://github.com/nodejs/node/pull/29123/commits/0c905656fa960082f5c08c915f2e87849c4e9ba9 |
| Please reload this page | https://github.com/nodejs/node/pull/29123/commits/0c905656fa960082f5c08c915f2e87849c4e9ba9 |
|
nodejs
| https://github.com/nodejs |
| node | https://github.com/nodejs/node |
| Please reload this page | https://github.com/nodejs/node/pull/29123/commits/0c905656fa960082f5c08c915f2e87849c4e9ba9 |
|
Notifications
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Fork
36.1k
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Star
118k
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Code
| https://github.com/nodejs/node |
|
Issues
1.3k
| https://github.com/nodejs/node/issues |
|
Pull requests
1.1k
| https://github.com/nodejs/node/pulls |
|
Actions
| https://github.com/nodejs/node/actions |
|
Projects
| https://github.com/nodejs/node/projects |
|
Security and quality
0
| https://github.com/nodejs/node/security |
|
Insights
| https://github.com/nodejs/node/pulse |
|
Code
| https://github.com/nodejs/node |
|
Issues
| https://github.com/nodejs/node/issues |
|
Pull requests
| https://github.com/nodejs/node/pulls |
|
Actions
| https://github.com/nodejs/node/actions |
|
Projects
| https://github.com/nodejs/node/projects |
|
Security and quality
| https://github.com/nodejs/node/security |
|
Insights
| https://github.com/nodejs/node/pulse |
| Sign up for GitHub
| https://github.com/signup?return_to=%2Fnodejs%2Fnode%2Fissues%2Fnew%2Fchoose |
| terms of service | https://docs.github.com/terms |
| privacy statement | https://docs.github.com/privacy |
| Sign in | https://github.com/login?return_to=%2Fnodejs%2Fnode%2Fissues%2Fnew%2Fchoose |
| addaleax | https://github.com/addaleax |
| nodejs:v10.x | https://github.com/nodejs/node/tree/v10.x |
| addaleax:http2-fixes-v10.x | https://github.com/addaleax/node/tree/http2-fixes-v10.x |
|
Conversation
3
| https://github.com/nodejs/node/pull/29123 |
|
Commits
19
| https://github.com/nodejs/node/pull/29123/commits |
|
Checks
0
| https://github.com/nodejs/node/pull/29123/checks |
|
Files changed
| https://github.com/nodejs/node/pull/29123/files |
| Please reload this page | https://github.com/nodejs/node/pull/29123/commits/0c905656fa960082f5c08c915f2e87849c4e9ba9 |
|
[v10.x] http2: mitigate reported DoS attacks
| https://github.com/nodejs/node/pull/29123/commits/0c905656fa960082f5c08c915f2e87849c4e9ba9#top |
|
Show all changes
19 commits
| https://github.com/nodejs/node/pull/29123/files |
|
ff15024
http2: improve http2 code a bit
jasnell Oct 30, 2018
| https://github.com/nodejs/node/pull/29123/commits/ff15024b479a38c1f6c5db8df1ffdb1c0a26d18c |
|
5caf137
src: pass along errors from http2 object creation
addaleax Jan 30, 2019
| https://github.com/nodejs/node/pull/29123/commits/5caf137af84e0179aaacea84d3e2d859954bd394 |
|
bdd3b09
deps: update nghttp2 to 1.37.0
gengjiawen Mar 29, 2019
| https://github.com/nodejs/node/pull/29123/commits/bdd3b092532564ae563e58febe5efcdd55697985 |
|
bd05d74
deps: update nghttp2 to 1.38.0
gengjiawen Apr 18, 2019
| https://github.com/nodejs/node/pull/29123/commits/bd05d749d25dd834357e4a2bb61bfc7b49da4911 |
|
ee711ce
deps: update nghttp2 to 1.39.1
gengjiawen Jun 27, 2019
| https://github.com/nodejs/node/pull/29123/commits/ee711ce988ffb8a808fc5d4d3e67e9f70009e1fe |
|
eecba7b
deps: update nghttp2 to 1.39.2
addaleax Aug 14, 2019
| https://github.com/nodejs/node/pull/29123/commits/eecba7be0b9edfe22cb6f570a263b0052d6ff6f5 |
|
c625114
http2: improve JS-side debug logging
addaleax Aug 5, 2019
| https://github.com/nodejs/node/pull/29123/commits/c625114ec8dbef08b552a9769ce6d8d4bdc3e778 |
|
3b76bb6
http2: only call into JS when necessary for session events
addaleax Aug 9, 2019
| https://github.com/nodejs/node/pull/29123/commits/3b76bb61aab35ddc2fcef73f02b552758d34e445 |
|
0f0bf81
http2: do not create ArrayBuffers when no DATA received
addaleax Aug 9, 2019
| https://github.com/nodejs/node/pull/29123/commits/0f0bf8197dc52afaf051146f158c2896a827d54a |
|
e350322
http2: limit number of rejected stream openings
addaleax Aug 10, 2019
| https://github.com/nodejs/node/pull/29123/commits/e3503225d7de50693518a4c983357916d84bd6f1 |
|
0c90565
http2: limit number of invalid incoming frames
addaleax Aug 12, 2019
| https://github.com/nodejs/node/pull/29123/commits/0c905656fa960082f5c08c915f2e87849c4e9ba9 |
|
8c741e6
http2: handle 0-length headers better
addaleax Aug 10, 2019
| https://github.com/nodejs/node/pull/29123/commits/8c741e60022c322e51410f98267b01dc728beefc |
|
1c03103
http2: shrink default `vector::reserve()` allocations
addaleax Aug 10, 2019
| https://github.com/nodejs/node/pull/29123/commits/1c0310374c3e7ef99a6a5092e0f52faaa3084de3 |
|
f1ec93f
http2: consider 0-length non-end DATA frames an error
addaleax Aug 10, 2019
| https://github.com/nodejs/node/pull/29123/commits/f1ec93fe3f091ed9e0cbf087e92aacd50c2b32dd |
|
3343c3e
http2: stop reading from socket if writes are in progress
addaleax Aug 10, 2019
| https://github.com/nodejs/node/pull/29123/commits/3343c3ee5cf65f50b64624e1e39d75f2b54e4128 |
|
981fd55
http2: pause input processing if sending output
addaleax Aug 11, 2019
| https://github.com/nodejs/node/pull/29123/commits/981fd55d6b7a9acfaa64b6dd22734bc62aebdb4a |
|
e4e47e2
http2: allow security revert for Ping/Settings Flood
addaleax Aug 12, 2019
| https://github.com/nodejs/node/pull/29123/commits/e4e47e2cf848844740a02fa980baeecdfc061356 |
|
b0d0bdd
test: apply test-http2-max-session-memory-leak from v12.x
addaleax Aug 13, 2019
| https://github.com/nodejs/node/pull/29123/commits/b0d0bdd4c72d2f68448b92c505f681c01d63d090 |
|
2aa90c2
fixup! deps: update nghttp2 to 1.39.2
addaleax Aug 14, 2019
| https://github.com/nodejs/node/pull/29123/commits/2aa90c2342a0abbd17afe1cc1fcba9203d89ae93 |
|
Clear filters
| https://github.com/nodejs/node/pull/29123/commits/0c905656fa960082f5c08c915f2e87849c4e9ba9 |
| Please reload this page | https://github.com/nodejs/node/pull/29123/commits/0c905656fa960082f5c08c915f2e87849c4e9ba9 |
| Please reload this page | https://github.com/nodejs/node/pull/29123/commits/0c905656fa960082f5c08c915f2e87849c4e9ba9 |
|
node_http2.cc
| https://github.com/nodejs/node/pull/29123/commits/0c905656fa960082f5c08c915f2e87849c4e9ba9#diff-33f026e43570112875cf4c8eab6743496f3aa014329611128e348ec23d6f771c |
|
node_http2.h
| https://github.com/nodejs/node/pull/29123/commits/0c905656fa960082f5c08c915f2e87849c4e9ba9#diff-430b8a0d2f4cc14e0eac16d13f3879eed2697ebe3749acbb48a11db567a7e936 |
|
test-http2-reset-flood.js
| https://github.com/nodejs/node/pull/29123/commits/0c905656fa960082f5c08c915f2e87849c4e9ba9#diff-95937af78c5d734ef9bbdddc818d42adb8f170ceb243d4fad5a9052ecc674b9a |
|
Prev
| https://github.com/nodejs/node/pull/29123/commits/e3503225d7de50693518a4c983357916d84bd6f1 |
|
Next
| https://github.com/nodejs/node/pull/29123/commits/8c741e60022c322e51410f98267b01dc728beefc |
| CVE-2019-9514 | https://github.com/advisories/GHSA-39qc-96h7-956f |
| libuv/libuv@ee24ce900e5714c950b248da2b | https://github.com/libuv/libuv/commit/ee24ce900e5714c950b248da2b |
| Please reload this page | https://github.com/nodejs/node/pull/29123/commits/0c905656fa960082f5c08c915f2e87849c4e9ba9 |
|
| https://github.com/addaleax |
| addaleax | https://github.com/nodejs/node/commits?author=addaleax |
| src/node_http2.cc | https://github.com/nodejs/node/pull/29123/commits/0c905656fa960082f5c08c915f2e87849c4e9ba9#diff-33f026e43570112875cf4c8eab6743496f3aa014329611128e348ec23d6f771c |
|
View file
| https://github.com/addaleax/node/blob/0c905656fa960082f5c08c915f2e87849c4e9ba9/src/node_http2.cc |
|
Open in desktop
| https://desktop.github.com |
| https://github.co/hiddenchars |
| https://github.com/nodejs/node/pull/29123/commits/{{ revealButtonHref }} |
|
| https://github.com/nodejs/node/pull/29123/commits/0c905656fa960082f5c08c915f2e87849c4e9ba9#diff-33f026e43570112875cf4c8eab6743496f3aa014329611128e348ec23d6f771c |
|
| https://github.com/nodejs/node/pull/29123/commits/0c905656fa960082f5c08c915f2e87849c4e9ba9#diff-33f026e43570112875cf4c8eab6743496f3aa014329611128e348ec23d6f771c |
| src/node_http2.h | https://github.com/nodejs/node/pull/29123/commits/0c905656fa960082f5c08c915f2e87849c4e9ba9#diff-430b8a0d2f4cc14e0eac16d13f3879eed2697ebe3749acbb48a11db567a7e936 |
|
View file
| https://github.com/addaleax/node/blob/0c905656fa960082f5c08c915f2e87849c4e9ba9/src/node_http2.h |
|
Open in desktop
| https://desktop.github.com |
| https://github.co/hiddenchars |
| https://github.com/nodejs/node/pull/29123/commits/{{ revealButtonHref }} |
|
| https://github.com/nodejs/node/pull/29123/commits/0c905656fa960082f5c08c915f2e87849c4e9ba9#diff-430b8a0d2f4cc14e0eac16d13f3879eed2697ebe3749acbb48a11db567a7e936 |
|
| https://github.com/nodejs/node/pull/29123/commits/0c905656fa960082f5c08c915f2e87849c4e9ba9#diff-430b8a0d2f4cc14e0eac16d13f3879eed2697ebe3749acbb48a11db567a7e936 |
| test/parallel/test-http2-reset-flood.js | https://github.com/nodejs/node/pull/29123/commits/0c905656fa960082f5c08c915f2e87849c4e9ba9#diff-95937af78c5d734ef9bbdddc818d42adb8f170ceb243d4fad5a9052ecc674b9a |
|
View file
| https://github.com/addaleax/node/blob/0c905656fa960082f5c08c915f2e87849c4e9ba9/test/parallel/test-http2-reset-flood.js |
|
Open in desktop
| https://desktop.github.com |
| https://github.co/hiddenchars |
| https://github.com/nodejs/node/pull/29123/commits/{{ revealButtonHref }} |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |