René's URL Explorer Experiment


Title: stream: sync writes don't need drain by ronag · Pull Request #29087 · nodejs/node · GitHub

Open Graph Title: stream: sync writes don't need drain by ronag · Pull Request #29087 · nodejs/node

X Title: stream: sync writes don't need drain by ronag · Pull Request #29087 · nodejs/node

Description: Node.js JavaScript runtime ✨🐢🚀✨. Contribute to nodejs/node development by creating an account on GitHub.

Open Graph Description: Minor fix and performance improvement. Synchronous writes do not require drain. This can be a significant improvement especially for transform streams that do not perform any async work. Checklist ...

X Description: Minor fix and performance improvement. Synchronous writes do not require drain. This can be a significant improvement especially for transform streams that do not perform any async work. Checklist ...

Opengraph URL: https://github.com/nodejs/node/pull/29087

X: @github

direct link

Domain: github.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:a14d0afb-1624-2a1b-9aa4-920cd8ad64fd
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-id8C30:1ED8:20AF40A:2E245AD:6A4F6A37
html-safe-nonce27be4cb96188fd5df5383a6539f8fd4615d2c98e9b3f8618206910dbe88f339c
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI4QzMwOjFFRDg6MjBBRjQwQToyRTI0NUFEOjZBNEY2QTM3IiwidmlzaXRvcl9pZCI6IjE4OTA0MzY5NzgxNzM3NjYxOTkiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmacf22d066dae21f724e5e35b87a430df4fec6b9fab1c394a3838c22be1edbf6bca
hovercard-subject-tagpull_request:306290899
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/29087/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/3e2b020dc15381c2a6a7f4d3f1e946c9079aafc0d1756cd3cd122af0431389a4/nodejs/node/pull/29087
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/3e2b020dc15381c2a6a7f4d3f1e946c9079aafc0d1756cd3cd122af0431389a4/nodejs/node/pull/29087
og:image:altMinor fix and performance improvement. Synchronous writes do not require drain. This can be a significant improvement especially for transform streams that do not perform any async work. Checklist ...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernameronag
hostnamegithub.com
expected-hostnamegithub.com
Noneb92d11c0aa4a77d54ef4af1078b6a15fb5a70a215b30c4ecf28889d5a8e656d9
turbo-cache-controlno-cache
go-importgithub.com/nodejs/node git https://github.com/nodejs/node.git
octolytics-dimension-user_id9950313
octolytics-dimension-user_loginnodejs
octolytics-dimension-repository_id27193779
octolytics-dimension-repository_nwonodejs/node
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id27193779
octolytics-dimension-repository_network_root_nwonodejs/node
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release4b249b445842943ed31549e027f57a8ade9881ed
ui-targetcanary-1
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/nodejs/node/pull/29087#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F29087
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub Copilot appDirect agents from issue to mergehttps://github.com/features/ai/github-app
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
View all resourceshttps://github.com/resources
GitHub SponsorsFund open source developershttps://github.com/open-source/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/open-source/accelerator
GitHub Starshttps://stars.github.com
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F29087
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode
Reloadhttps://github.com/nodejs/node/pull/29087
Reloadhttps://github.com/nodejs/node/pull/29087
Reloadhttps://github.com/nodejs/node/pull/29087
Please reload this pagehttps://github.com/nodejs/node/pull/29087
nodejs https://github.com/nodejs
nodehttps://github.com/nodejs/node
Please reload this pagehttps://github.com/nodejs/node/pull/29087
Notifications https://github.com/login?return_to=%2Fnodejs%2Fnode
Fork 36k https://github.com/login?return_to=%2Fnodejs%2Fnode
Star 118k https://github.com/login?return_to=%2Fnodejs%2Fnode
Code https://github.com/nodejs/node
Issues 1.3k https://github.com/nodejs/node/issues
Pull requests 971 https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects https://github.com/nodejs/node/projects
Security and quality 0 https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
Code https://github.com/nodejs/node
Issues https://github.com/nodejs/node/issues
Pull requests https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects https://github.com/nodejs/node/projects
Security and quality https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
ronaghttps://github.com/ronag
nodejs:masterhttps://github.com/nodejs/node/tree/master
nxtedition:stream-sync-write-drainhttps://github.com/nxtedition/node/tree/stream-sync-write-drain
Conversationhttps://github.com/nodejs/node/pull/29087
Commits1 (1)https://github.com/nodejs/node/pull/29087/commits
Checkshttps://github.com/nodejs/node/pull/29087/checks
Files changedhttps://github.com/nodejs/node/pull/29087/files
stream: sync writes don't need drainhttps://github.com/nodejs/node/pull/29087#top
ronaghttps://github.com/ronag
nodejs:masterhttps://github.com/nodejs/node/tree/master
nxtedition:stream-sync-write-drainhttps://github.com/nxtedition/node/tree/stream-sync-write-drain
https://github.com/ronag
ronaghttps://github.com/ronag
Aug 11, 2019https://github.com/nodejs/node/pull/29087#issue-479385138
commit guidelineshttps://github.com/nodejs/node/blob/master/doc/guides/contributing/pull-requests.md#commit-message-guidelines
Please reload this pagehttps://github.com/nodejs/node/pull/29087
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
stream https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Astream
Aug 11, 2019https://github.com/nodejs/node/pull/29087#event-2548705076
https://github.com/ronag
ronaghttps://github.com/ronag
force-pushedhttps://github.com/nodejs/node/compare/ea33898556af3bd552b30f2495eb3e48aa211624..34127640f85ad01cbe9a46def0089b15673a8b70
ea33898https://github.com/nodejs/node/commit/ea33898556af3bd552b30f2495eb3e48aa211624
3412764https://github.com/nodejs/node/commit/34127640f85ad01cbe9a46def0089b15673a8b70
Compare https://github.com/nodejs/node/compare/ea33898556af3bd552b30f2495eb3e48aa211624..34127640f85ad01cbe9a46def0089b15673a8b70
August 11, 2019 17:25https://github.com/nodejs/node/pull/29087#event-2548736574
https://github.com/ronag
stream: sync writes don't need drainhttps://github.com/nodejs/node/pull/29087/commits/49102ae6c3ebf19095127c22aacae08f02ea31cd
49102aehttps://github.com/nodejs/node/pull/29087/commits/49102ae6c3ebf19095127c22aacae08f02ea31cd
https://github.com/ronag
ronaghttps://github.com/ronag
force-pushedhttps://github.com/nodejs/node/compare/34127640f85ad01cbe9a46def0089b15673a8b70..49102ae6c3ebf19095127c22aacae08f02ea31cd
3412764https://github.com/nodejs/node/commit/34127640f85ad01cbe9a46def0089b15673a8b70
49102aehttps://github.com/nodejs/node/commit/49102ae6c3ebf19095127c22aacae08f02ea31cd
Compare https://github.com/nodejs/node/compare/34127640f85ad01cbe9a46def0089b15673a8b70..49102ae6c3ebf19095127c22aacae08f02ea31cd
August 11, 2019 17:59https://github.com/nodejs/node/pull/29087#event-2548749359
stream: pipe lazy drain #29095 https://github.com/nodejs/node/pull/29095
stream: reduce pipe overhead #29096 https://github.com/nodejs/node/issues/29096
https://github.com/Trott
Trotthttps://github.com/Trott
Aug 13, 2019https://github.com/nodejs/node/pull/29087#issuecomment-520953513
Please reload this pagehttps://github.com/nodejs/node/pull/29087
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
Aug 13, 2019https://github.com/nodejs/node/pull/29087#issuecomment-520953759
https://ci.nodejs.org/job/node-test-pull-request/24969/https://ci.nodejs.org/job/node-test-pull-request/24969/
Please reload this pagehttps://github.com/nodejs/node/pull/29087
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
Aug 14, 2019https://github.com/nodejs/node/pull/29087#issuecomment-521109469
https://ci.nodejs.org/job/node-test-pull-request/24973/https://ci.nodejs.org/job/node-test-pull-request/24973/
Please reload this pagehttps://github.com/nodejs/node/pull/29087
https://github.com/mcollina
mcollinahttps://github.com/mcollina
Aug 14, 2019 https://github.com/nodejs/node/pull/29087#pullrequestreview-274748247
View reviewed changes https://github.com/nodejs/node/pull/29087/files/49102ae6c3ebf19095127c22aacae08f02ea31cd
mcollinahttps://github.com/mcollina
https://github.com/nodejs/node/pull/29087#pullrequestreview-274748247
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/29087
https://github.com/mcollina
mcollinahttps://github.com/mcollina
semver-major https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Asemver-major
Aug 14, 2019https://github.com/nodejs/node/pull/29087#event-2555859672
https://github.com/ronag
ronaghttps://github.com/ronag
Aug 14, 2019https://github.com/nodejs/node/pull/29087#issuecomment-521258925
Please reload this pagehttps://github.com/nodejs/node/pull/29087
@mcollinahttps://github.com/mcollina
Please reload this pagehttps://github.com/nodejs/node/pull/29087
https://github.com/mcollina
mcollinahttps://github.com/mcollina
Aug 15, 2019https://github.com/nodejs/node/pull/29087#issuecomment-521572676
https://www.npmjs.com/package/syncthroughhttps://www.npmjs.com/package/syncthrough
Please reload this pagehttps://github.com/nodejs/node/pull/29087
https://github.com/ronag
ronaghttps://github.com/ronag
Aug 15, 2019https://github.com/nodejs/node/pull/29087#issuecomment-521576391
@mcollinahttps://github.com/mcollina
Please reload this pagehttps://github.com/nodejs/node/pull/29087
https://github.com/mcollina
mcollinahttps://github.com/mcollina
Aug 15, 2019https://github.com/nodejs/node/pull/29087#event-2559012362
https://github.co/hiddenchars
https://github.com/nodejs/node/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F29087
https://github.com/mcollina
mcollina https://github.com/mcollina
https://github.com/nodejs/node/pull/29087/files/49102ae6c3ebf19095127c22aacae08f02ea31cd
semver-major https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Asemver-major
stream https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Astream
Please reload this pagehttps://github.com/nodejs/node/pull/29087
https://github.com/ronag
https://github.com/Trott
https://github.com/nodejs-github-bot
https://github.com/mcollina
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.