René's URL Explorer Experiment


Title: http: simplify drain by ronag · Pull Request #29081 · nodejs/node · GitHub

Open Graph Title: http: simplify drain by ronag · Pull Request #29081 · nodejs/node

X Title: http: simplify drain by ronag · Pull Request #29081 · nodejs/node

Description: Node.js JavaScript runtime ✨🐢🚀✨. Contribute to nodejs/node development by creating an account on GitHub.

Open Graph Description: Simplify and slightly optimize draining outgoing http streams. Avoid extra event listener and inline with rest of the drain logic. Checklist make -j4 test (UNIX), or vcbuild test (Windows) passe...

X Description: Simplify and slightly optimize draining outgoing http streams. Avoid extra event listener and inline with rest of the drain logic. Checklist make -j4 test (UNIX), or vcbuild test (Windows) passe...

Opengraph URL: https://github.com/nodejs/node/pull/29081

X: @github

direct link

Domain: github.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:6edcceea-3462-fead-64af-7dd32c4e3709
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idAAAA:221685:857FF0:B1E7E8:6A5180D0
html-safe-nonce36d4437da153a56716fb378002e79d7f9fd371995cded142b514179453605f3c
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJBQUFBOjIyMTY4NTo4NTdGRjA6QjFFN0U4OjZBNTE4MEQwIiwidmlzaXRvcl9pZCI6IjM2MTQxMTQxMTQwNjA3Nzk3MjgiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmacb509c79270ea49a57e99a23a5f60ff9eb81b2b72e2066b33c069f3d40c524d47
hovercard-subject-tagpull_request:306267571
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/29081/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/94093b22862b93e14614dede8d3ba32f2c7b3eb4e0052f3a31c2d31560777746/nodejs/node/pull/29081
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/94093b22862b93e14614dede8d3ba32f2c7b3eb4e0052f3a31c2d31560777746/nodejs/node/pull/29081
og:image:altSimplify and slightly optimize draining outgoing http streams. Avoid extra event listener and inline with rest of the drain logic. Checklist make -j4 test (UNIX), or vcbuild test (Windows) passe...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernameronag
hostnamegithub.com
expected-hostnamegithub.com
Noneb9a586c06a05a7a86fc7e3f4dbd03e42f6869085879aa184aa6369456dbd50fb
turbo-cache-controlno-cache
go-importgithub.com/nodejs/node git https://github.com/nodejs/node.git
octolytics-dimension-user_id9950313
octolytics-dimension-user_loginnodejs
octolytics-dimension-repository_id27193779
octolytics-dimension-repository_nwonodejs/node
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id27193779
octolytics-dimension-repository_network_root_nwonodejs/node
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
released01c62704ef24df49056c63892a149b775e1353d
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/nodejs/node/pull/29081#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F29081
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub Copilot appDirect agents from issue to mergehttps://github.com/features/ai/github-app
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
View all resourceshttps://github.com/resources
GitHub SponsorsFund open source developershttps://github.com/open-source/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/open-source/accelerator
GitHub Starshttps://stars.github.com
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F29081
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode
Reloadhttps://github.com/nodejs/node/pull/29081
Reloadhttps://github.com/nodejs/node/pull/29081
Reloadhttps://github.com/nodejs/node/pull/29081
Please reload this pagehttps://github.com/nodejs/node/pull/29081
nodejs https://github.com/nodejs
nodehttps://github.com/nodejs/node
Please reload this pagehttps://github.com/nodejs/node/pull/29081
Notifications https://github.com/login?return_to=%2Fnodejs%2Fnode
Fork 36.1k https://github.com/login?return_to=%2Fnodejs%2Fnode
Star 118k https://github.com/login?return_to=%2Fnodejs%2Fnode
Code https://github.com/nodejs/node
Issues 1.4k https://github.com/nodejs/node/issues
Pull requests 981 https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects https://github.com/nodejs/node/projects
Security and quality 0 https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
Code https://github.com/nodejs/node
Issues https://github.com/nodejs/node/issues
Pull requests https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects https://github.com/nodejs/node/projects
Security and quality https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
ronaghttps://github.com/ronag
nodejs:masterhttps://github.com/nodejs/node/tree/master
nxtedition:http-simplify-drainhttps://github.com/nxtedition/node/tree/http-simplify-drain
Conversationhttps://github.com/nodejs/node/pull/29081
Commits1 (1)https://github.com/nodejs/node/pull/29081/commits
Checkshttps://github.com/nodejs/node/pull/29081/checks
Files changedhttps://github.com/nodejs/node/pull/29081/files
http: simplify drainhttps://github.com/nodejs/node/pull/29081#top
ronaghttps://github.com/ronag
nodejs:masterhttps://github.com/nodejs/node/tree/master
nxtedition:http-simplify-drainhttps://github.com/nxtedition/node/tree/http-simplify-drain
https://github.com/ronag
ronaghttps://github.com/ronag
Aug 11, 2019https://github.com/nodejs/node/pull/29081#issue-479349503
Please reload this pagehttps://github.com/nodejs/node/pull/29081
commit guidelineshttps://github.com/nodejs/node/blob/master/doc/guides/contributing/pull-requests.md#commit-message-guidelines
Please reload this pagehttps://github.com/nodejs/node/pull/29081
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
lib / src https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22lib%20%2F%20src%22
Aug 11, 2019https://github.com/nodejs/node/pull/29081#event-2548544501
https://github.com/mscdex
mscdexhttps://github.com/mscdex
Aug 11, 2019https://github.com/nodejs/node/pull/29081#issuecomment-520232890
Please reload this pagehttps://github.com/nodejs/node/pull/29081
https://github.com/ronag
ronaghttps://github.com/ronag
force-pushedhttps://github.com/nodejs/node/compare/078268ce1c2c7a525a4f85ce746235728d371f57..054d050f56a3fe4a9b7872ac5e317b58a558b6cd
078268chttps://github.com/nodejs/node/commit/078268ce1c2c7a525a4f85ce746235728d371f57
054d050https://github.com/nodejs/node/commit/054d050f56a3fe4a9b7872ac5e317b58a558b6cd
Compare https://github.com/nodejs/node/compare/078268ce1c2c7a525a4f85ce746235728d371f57..054d050f56a3fe4a9b7872ac5e317b58a558b6cd
August 11, 2019 15:11https://github.com/nodejs/node/pull/29081#event-2548679685
https://github.com/ronag
ronaghttps://github.com/ronag
Aug 11, 2019https://github.com/nodejs/node/pull/29081#issuecomment-520235744
@mscdexhttps://github.com/mscdex
Please reload this pagehttps://github.com/nodejs/node/pull/29081
https://github.com/ronag
ronaghttps://github.com/ronag
force-pushedhttps://github.com/nodejs/node/compare/e82d80e479626c6cccec10a97b52299218723cc4..a6486deb514e89b0d9783281fa2a107e91a49f5a
e82d80ehttps://github.com/nodejs/node/commit/e82d80e479626c6cccec10a97b52299218723cc4
a6486dehttps://github.com/nodejs/node/commit/a6486deb514e89b0d9783281fa2a107e91a49f5a
Compare https://github.com/nodejs/node/compare/e82d80e479626c6cccec10a97b52299218723cc4..a6486deb514e89b0d9783281fa2a107e91a49f5a
August 11, 2019 15:57https://github.com/nodejs/node/pull/29081#event-2548700349
https://github.com/mscdex
mscdexhttps://github.com/mscdex
Aug 11, 2019 https://github.com/nodejs/node/pull/29081#pullrequestreview-273472708
View reviewed changes https://github.com/nodejs/node/pull/29081/files
lib/_http_outgoing.jshttps://github.com/nodejs/node/pull/29081/files#diff-48d21edbddb6e855d1ee5716c49bcdc0d913c11ee8a24a98ea7dbc60cd253556
Please reload this pagehttps://github.com/nodejs/node/pull/29081
https://github.com/ronag
ronaghttps://github.com/ronag
force-pushedhttps://github.com/nodejs/node/compare/e9184d595a766e1bc01f7b08736ca06156afd581..35ba9c3ca53dd9a0285492d2259a9d5d78fa2654
e9184d5https://github.com/nodejs/node/commit/e9184d595a766e1bc01f7b08736ca06156afd581
35ba9c3https://github.com/nodejs/node/commit/35ba9c3ca53dd9a0285492d2259a9d5d78fa2654
Compare https://github.com/nodejs/node/compare/e9184d595a766e1bc01f7b08736ca06156afd581..35ba9c3ca53dd9a0285492d2259a9d5d78fa2654
August 11, 2019 19:35https://github.com/nodejs/node/pull/29081#event-2548788990
https://github.com/mscdex
mscdexhttps://github.com/mscdex
Aug 11, 2019 https://github.com/nodejs/node/pull/29081#pullrequestreview-273478671
View reviewed changes https://github.com/nodejs/node/pull/29081/files
lib/_http_client.jshttps://github.com/nodejs/node/pull/29081/files#diff-cf533721360d04a028e31659e9b6cde7e4bd871200d13ce37d4a358be65bfd43
Please reload this pagehttps://github.com/nodejs/node/pull/29081
https://github.com/ronag
ronaghttps://github.com/ronag
force-pushedhttps://github.com/nodejs/node/compare/2a6fb634e67a51e06c09d60b57d11e0e719e5b97..41a045844b67b2e149ce640f938c550e92a791d7
2a6fb63https://github.com/nodejs/node/commit/2a6fb634e67a51e06c09d60b57d11e0e719e5b97
41a0458https://github.com/nodejs/node/commit/41a045844b67b2e149ce640f938c550e92a791d7
Compare https://github.com/nodejs/node/compare/2a6fb634e67a51e06c09d60b57d11e0e719e5b97..41a045844b67b2e149ce640f938c550e92a791d7
August 13, 2019 13:47https://github.com/nodejs/node/pull/29081#event-2553437159
https://github.com/Trott
Trotthttps://github.com/Trott
Aug 13, 2019https://github.com/nodejs/node/pull/29081#issuecomment-520961871
Please reload this pagehttps://github.com/nodejs/node/pull/29081
https://github.com/Trott
Trotthttps://github.com/Trott
Aug 16, 2019https://github.com/nodejs/node/pull/29081#issuecomment-522181549
@ronaghttps://github.com/ronag
Please reload this pagehttps://github.com/nodejs/node/pull/29081
https://github.com/ronag
ronaghttps://github.com/ronag
force-pushedhttps://github.com/nodejs/node/compare/41a045844b67b2e149ce640f938c550e92a791d7..dcca00fbefc7790855de76a92d6dbdc212c0171f
41a0458https://github.com/nodejs/node/commit/41a045844b67b2e149ce640f938c550e92a791d7
dcca00fhttps://github.com/nodejs/node/commit/dcca00fbefc7790855de76a92d6dbdc212c0171f
Compare https://github.com/nodejs/node/compare/41a045844b67b2e149ce640f938c550e92a791d7..dcca00fbefc7790855de76a92d6dbdc212c0171f
August 17, 2019 04:44https://github.com/nodejs/node/pull/29081#event-2563779539
https://github.com/ronag
ronaghttps://github.com/ronag
Aug 17, 2019https://github.com/nodejs/node/pull/29081#issuecomment-522204222
@Trotthttps://github.com/Trott
Please reload this pagehttps://github.com/nodejs/node/pull/29081
https://github.com/ronag
http: simplify drainhttps://github.com/nodejs/node/pull/29081/commits/73e760f4b7729d2f9ed7e6d5e12c8c54394d7bcc
73e760fhttps://github.com/nodejs/node/pull/29081/commits/73e760f4b7729d2f9ed7e6d5e12c8c54394d7bcc
https://github.com/ronag
ronaghttps://github.com/ronag
force-pushedhttps://github.com/nodejs/node/compare/dcca00fbefc7790855de76a92d6dbdc212c0171f..73e760f4b7729d2f9ed7e6d5e12c8c54394d7bcc
dcca00fhttps://github.com/nodejs/node/commit/dcca00fbefc7790855de76a92d6dbdc212c0171f
73e760fhttps://github.com/nodejs/node/commit/73e760f4b7729d2f9ed7e6d5e12c8c54394d7bcc
Compare https://github.com/nodejs/node/compare/dcca00fbefc7790855de76a92d6dbdc212c0171f..73e760f4b7729d2f9ed7e6d5e12c8c54394d7bcc
August 17, 2019 05:11https://github.com/nodejs/node/pull/29081#event-2563788219
https://github.com/mcollina
mcollinahttps://github.com/mcollina
Aug 19, 2019 https://github.com/nodejs/node/pull/29081#pullrequestreview-276389246
View reviewed changes https://github.com/nodejs/node/pull/29081/files/73e760f4b7729d2f9ed7e6d5e12c8c54394d7bcc
mcollinahttps://github.com/mcollina
https://github.com/nodejs/node/pull/29081#pullrequestreview-276389246
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/29081
lib/_http_outgoing.jshttps://github.com/nodejs/node/pull/29081/files/73e760f4b7729d2f9ed7e6d5e12c8c54394d7bcc#diff-48d21edbddb6e855d1ee5716c49bcdc0d913c11ee8a24a98ea7dbc60cd253556
Please reload this pagehttps://github.com/nodejs/node/pull/29081
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
Aug 19, 2019https://github.com/nodejs/node/pull/29081#issuecomment-522584106
https://ci.nodejs.org/job/node-test-pull-request/25085/https://ci.nodejs.org/job/node-test-pull-request/25085/
Please reload this pagehttps://github.com/nodejs/node/pull/29081
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
Aug 19, 2019https://github.com/nodejs/node/pull/29081#issuecomment-522682200
https://ci.nodejs.org/job/node-test-pull-request/25106/https://ci.nodejs.org/job/node-test-pull-request/25106/
Please reload this pagehttps://github.com/nodejs/node/pull/29081
https://github.com/Trott
Trotthttps://github.com/Trott
Aug 19, 2019https://github.com/nodejs/node/pull/29081#issuecomment-522729853
bdf07f4https://github.com/nodejs/node/commit/bdf07f4317ce738bbe56c5b91aaebf35d15052a8
Please reload this pagehttps://github.com/nodejs/node/pull/29081
https://github.com/Trott
Trotthttps://github.com/Trott
Aug 19, 2019https://github.com/nodejs/node/pull/29081#event-2567490222
Trotthttps://github.com/Trott
Aug 19, 2019 https://github.com/nodejs/node/pull/29081#ref-commit-bdf07f4
https://github.com/ronag
https://github.com/Trott
http: simplify drain()https://github.com/nodejs/node/commit/bdf07f4317ce738bbe56c5b91aaebf35d15052a8
bdf07f4https://github.com/nodejs/node/commit/bdf07f4317ce738bbe56c5b91aaebf35d15052a8
#29081https://github.com/nodejs/node/pull/29081
targoshttps://github.com/targos
Aug 20, 2019 https://github.com/nodejs/node/pull/29081#ref-commit-c5edeb9
https://github.com/ronag
https://github.com/targos
http: simplify drain()https://github.com/nodejs/node/commit/c5edeb9776099040c379d1619649b4ffc6cf3e2d
c5edeb9https://github.com/nodejs/node/commit/c5edeb9776099040c379d1619649b4ffc6cf3e2d
#29081https://github.com/nodejs/node/pull/29081
https://github.com/targos
targoshttps://github.com/targos
Aug 20, 2019 https://github.com/nodejs/node/pull/29081#ref-pullrequest-482485175
v12.9.0 release proposal #29210 https://github.com/nodejs/node/pull/29210
2019-08-20 Version 12.9.0 (Current) @targos beevelop/docker-android-nodejs#328 https://github.com/beevelop/docker-android-nodejs/issues/328
2019-08-20 Version 12.9.0 (Current) @targos beevelop/docker-android-nodejs#329 https://github.com/beevelop/docker-android-nodejs/issues/329
2019-08-20 Version 12.9.0 (Current) @targos beevelop/docker-android-nodejs#330 https://github.com/beevelop/docker-android-nodejs/issues/330
2019-08-20 Version 12.9.0 (Current) @targos beevelop/docker-nodejs#295 https://github.com/beevelop/docker-nodejs/issues/295
2019-08-20 Version 12.9.0 (Current) @targos beevelop/docker-nodejs#296 https://github.com/beevelop/docker-nodejs/issues/296
2019-08-20 Version 12.9.0 (Current) @targos beevelop/docker-nodejs#297 https://github.com/beevelop/docker-nodejs/issues/297
https://github.com/targos
targoshttps://github.com/targos
Aug 21, 2019 https://github.com/nodejs/node/pull/29081#ref-issue-483230853
12.9.0 MaxListenersExceededWarning #29239 https://github.com/nodejs/node/issues/29239
https://github.com/Trott
Trotthttps://github.com/Trott
dont-land-on-v10.x https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Adont-land-on-v10.x
Aug 21, 2019https://github.com/nodejs/node/pull/29081#event-2572986105
https://github.co/hiddenchars
https://github.com/nodejs/node/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F29081
https://github.com/mcollina
mcollina https://github.com/mcollina
https://github.com/nodejs/node/pull/29081/files/73e760f4b7729d2f9ed7e6d5e12c8c54394d7bcc
https://github.com/mscdex
mscdex https://github.com/mscdex
https://github.com/nodejs/node/pull/29081/files/35ba9c3ca53dd9a0285492d2259a9d5d78fa2654
lib / src https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22lib%20%2F%20src%22
Please reload this pagehttps://github.com/nodejs/node/pull/29081
https://github.com/ronag
https://github.com/mscdex
https://github.com/Trott
https://github.com/nodejs-github-bot
https://github.com/mcollina
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.