René's URL Explorer Experiment


Title: dns: update lookupService() first arg name by cjihrig · Pull Request #29040 · nodejs/node · GitHub

Open Graph Title: dns: update lookupService() first arg name by cjihrig · Pull Request #29040 · nodejs/node

X Title: dns: update lookupService() first arg name by cjihrig · Pull Request #29040 · nodejs/node

Description: Node.js JavaScript runtime ✨🐢🚀✨. Contribute to nodejs/node development by creating an account on GitHub.

Open Graph Description: The first argument to lookupService() should be an IP address, and is named "address" in the documentation. This commit updates the code to match the documentation and provide less confus...

X Description: The first argument to lookupService() should be an IP address, and is named "address" in the documentation. This commit updates the code to match the documentation and provide les...

Opengraph URL: https://github.com/nodejs/node/pull/29040

X: @github

direct link

Domain: github.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:9f7d45ce-94fb-9b1d-16da-43d0ad285dcd
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idE230:108F59:EA87EC:14B59AD:6A4F55C5
html-safe-nonce8373511742666f9b0bef21d567bf1922796dd82a85de6099e83858e71a7cd265
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJFMjMwOjEwOEY1OTpFQTg3RUM6MTRCNTlBRDo2QTRGNTVDNSIsInZpc2l0b3JfaWQiOiI3ODU5NTIyMzc1MTM3NTgwNDg1IiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmaca82f9649047e6457802f70cc7bbae99a68ea345cb0a382c58c6945ccd3149d59
hovercard-subject-tagpull_request:305379932
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/29040/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/afdb7b2010f411a05cf8eec14ffd1a0a528bbab629c259e54f73dc7b2114d4d4/nodejs/node/pull/29040
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/afdb7b2010f411a05cf8eec14ffd1a0a528bbab629c259e54f73dc7b2114d4d4/nodejs/node/pull/29040
og:image:altThe first argument to lookupService() should be an IP address, and is named "address" in the documentation. This commit updates the code to match the documentation and provide less confus...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamecjihrig
hostnamegithub.com
expected-hostnamegithub.com
Noneb92d11c0aa4a77d54ef4af1078b6a15fb5a70a215b30c4ecf28889d5a8e656d9
turbo-cache-controlno-cache
go-importgithub.com/nodejs/node git https://github.com/nodejs/node.git
octolytics-dimension-user_id9950313
octolytics-dimension-user_loginnodejs
octolytics-dimension-repository_id27193779
octolytics-dimension-repository_nwonodejs/node
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id27193779
octolytics-dimension-repository_network_root_nwonodejs/node
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release4b249b445842943ed31549e027f57a8ade9881ed
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/nodejs/node/pull/29040#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F29040
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub Copilot appDirect agents from issue to mergehttps://github.com/features/ai/github-app
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
View all resourceshttps://github.com/resources
GitHub SponsorsFund open source developershttps://github.com/open-source/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/open-source/accelerator
GitHub Starshttps://stars.github.com
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F29040
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode
Reloadhttps://github.com/nodejs/node/pull/29040
Reloadhttps://github.com/nodejs/node/pull/29040
Reloadhttps://github.com/nodejs/node/pull/29040
Please reload this pagehttps://github.com/nodejs/node/pull/29040
nodejs https://github.com/nodejs
nodehttps://github.com/nodejs/node
Please reload this pagehttps://github.com/nodejs/node/pull/29040
Notifications https://github.com/login?return_to=%2Fnodejs%2Fnode
Fork 36k https://github.com/login?return_to=%2Fnodejs%2Fnode
Star 118k https://github.com/login?return_to=%2Fnodejs%2Fnode
Code https://github.com/nodejs/node
Issues 1.3k https://github.com/nodejs/node/issues
Pull requests 970 https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects https://github.com/nodejs/node/projects
Security and quality 0 https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
Code https://github.com/nodejs/node
Issues https://github.com/nodejs/node/issues
Pull requests https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects https://github.com/nodejs/node/projects
Security and quality https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
cjihrighttps://github.com/cjihrig
nodejs:masterhttps://github.com/nodejs/node/tree/master
cjihrig:dns-errhttps://github.com/cjihrig/node/tree/dns-err
Conversationhttps://github.com/nodejs/node/pull/29040
Commits1 (1)https://github.com/nodejs/node/pull/29040/commits
Checkshttps://github.com/nodejs/node/pull/29040/checks
Files changedhttps://github.com/nodejs/node/pull/29040/files
dns: update lookupService() first arg namehttps://github.com/nodejs/node/pull/29040#top
cjihrighttps://github.com/cjihrig
nodejs:masterhttps://github.com/nodejs/node/tree/master
cjihrig:dns-errhttps://github.com/cjihrig/node/tree/dns-err
https://github.com/cjihrig
cjihrighttps://github.com/cjihrig
Aug 8, 2019https://github.com/nodejs/node/pull/29040#issue-478214027
#29039https://github.com/nodejs/node/issues/29039
commit guidelineshttps://github.com/nodejs/node/blob/master/doc/guides/contributing/pull-requests.md#commit-message-guidelines
Please reload this pagehttps://github.com/nodejs/node/pull/29040
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
dns https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Adns
Aug 8, 2019https://github.com/nodejs/node/pull/29040#event-2541860310
https://github.com/Trott
Trotthttps://github.com/Trott
Aug 8, 2019 https://github.com/nodejs/node/pull/29040#pullrequestreview-272313554
View reviewed changes https://github.com/nodejs/node/pull/29040/files
Trotthttps://github.com/Trott
https://github.com/nodejs/node/pull/29040#pullrequestreview-272313554
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/29040
https://github.com/sam-github
sam-githubhttps://github.com/sam-github
Aug 8, 2019 https://github.com/nodejs/node/pull/29040#pullrequestreview-272315902
View reviewed changes https://github.com/nodejs/node/pull/29040/files
test/parallel/test-dns.jshttps://github.com/nodejs/node/pull/29040/files#diff-a589bc69dba5bba9e7ba489b212b3e296217fc2094b915efa5da2a8488dd8770
Please reload this pagehttps://github.com/nodejs/node/pull/29040
https://github.com/cjihrig
dns: update lookupService() first arg namehttps://github.com/nodejs/node/pull/29040/commits/9a41646c36b9beeec8f50b3f092506650cdc2772
9a41646https://github.com/nodejs/node/pull/29040/commits/9a41646c36b9beeec8f50b3f092506650cdc2772
https://github.com/cjihrig
cjihrighttps://github.com/cjihrig
force-pushedhttps://github.com/nodejs/node/compare/134f97b4c6780616aa6b13745d9259db0844a647..9a41646c36b9beeec8f50b3f092506650cdc2772
134f97bhttps://github.com/nodejs/node/commit/134f97b4c6780616aa6b13745d9259db0844a647
9a41646https://github.com/nodejs/node/commit/9a41646c36b9beeec8f50b3f092506650cdc2772
Compare https://github.com/nodejs/node/compare/134f97b4c6780616aa6b13745d9259db0844a647..9a41646c36b9beeec8f50b3f092506650cdc2772
August 8, 2019 02:35https://github.com/nodejs/node/pull/29040#event-2541898481
https://github.com/trivikr
trivikrhttps://github.com/trivikr
Aug 8, 2019 https://github.com/nodejs/node/pull/29040#pullrequestreview-272318434
View reviewed changes https://github.com/nodejs/node/pull/29040/files/9a41646c36b9beeec8f50b3f092506650cdc2772
https://github.com/targos
targoshttps://github.com/targos
Aug 8, 2019 https://github.com/nodejs/node/pull/29040#pullrequestreview-272345575
View reviewed changes https://github.com/nodejs/node/pull/29040/files/9a41646c36b9beeec8f50b3f092506650cdc2772
https://github.com/jasnell
jasnellhttps://github.com/jasnell
Aug 8, 2019 https://github.com/nodejs/node/pull/29040#pullrequestreview-272708135
View reviewed changes https://github.com/nodejs/node/pull/29040/files/9a41646c36b9beeec8f50b3f092506650cdc2772
https://github.com/lpinca
lpincahttps://github.com/lpinca
Aug 8, 2019 https://github.com/nodejs/node/pull/29040#pullrequestreview-272803459
View reviewed changes https://github.com/nodejs/node/pull/29040/files/9a41646c36b9beeec8f50b3f092506650cdc2772
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
Aug 10, 2019https://github.com/nodejs/node/pull/29040#issuecomment-520177988
https://ci.nodejs.org/job/node-test-pull-request/24928/https://ci.nodejs.org/job/node-test-pull-request/24928/
Please reload this pagehttps://github.com/nodejs/node/pull/29040
Trotthttps://github.com/Trott
Aug 11, 2019 https://github.com/nodejs/node/pull/29040#ref-commit-df936c5
https://github.com/cjihrig
https://github.com/Trott
dns: update lookupService() first arg namehttps://github.com/Trott/io.js/commit/df936c592596855ec9ad1141692faf0dc74f46f3
df936c5https://github.com/Trott/io.js/commit/df936c592596855ec9ad1141692faf0dc74f46f3
nodejs#29040https://github.com/nodejs/node/pull/29040
nodejs#29039https://github.com/nodejs/node/issues/29039
https://github.com/Trott
Trotthttps://github.com/Trott
Aug 11, 2019https://github.com/nodejs/node/pull/29040#issuecomment-520194212
df936c5https://github.com/nodejs/node/commit/df936c592596855ec9ad1141692faf0dc74f46f3
Please reload this pagehttps://github.com/nodejs/node/pull/29040
https://github.com/Trott
Trotthttps://github.com/Trott
Aug 11, 2019https://github.com/nodejs/node/pull/29040#event-2548429527
https://github.com/cjihrig
cjihrighttps://github.com/cjihrig
August 11, 2019 12:56https://github.com/nodejs/node/pull/29040#event-2548623746
targoshttps://github.com/targos
Aug 19, 2019 https://github.com/nodejs/node/pull/29040#ref-commit-6f7b561
https://github.com/cjihrig
https://github.com/targos
dns: update lookupService() first arg namehttps://github.com/nodejs/node/commit/6f7b561295e3ab46d37e196496208d429251fdde
6f7b561https://github.com/nodejs/node/commit/6f7b561295e3ab46d37e196496208d429251fdde
#29040https://github.com/nodejs/node/pull/29040
#29039https://github.com/nodejs/node/issues/29039
https://github.com/targos
targoshttps://github.com/targos
Aug 19, 2019 https://github.com/nodejs/node/pull/29040#ref-pullrequest-482485175
v12.9.0 release proposal #29210 https://github.com/nodejs/node/pull/29210
2019-08-20 Version 12.9.0 (Current) @targos beevelop/docker-android-nodejs#328 https://github.com/beevelop/docker-android-nodejs/issues/328
2019-08-20 Version 12.9.0 (Current) @targos beevelop/docker-android-nodejs#329 https://github.com/beevelop/docker-android-nodejs/issues/329
2019-08-20 Version 12.9.0 (Current) @targos beevelop/docker-android-nodejs#330 https://github.com/beevelop/docker-android-nodejs/issues/330
2019-08-20 Version 12.9.0 (Current) @targos beevelop/docker-nodejs#295 https://github.com/beevelop/docker-nodejs/issues/295
2019-08-20 Version 12.9.0 (Current) @targos beevelop/docker-nodejs#296 https://github.com/beevelop/docker-nodejs/issues/296
2019-08-20 Version 12.9.0 (Current) @targos beevelop/docker-nodejs#297 https://github.com/beevelop/docker-nodejs/issues/297
https://github.co/hiddenchars
https://github.com/nodejs/node/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F29040
https://github.com/jasnell
jasnell https://github.com/jasnell
https://github.com/nodejs/node/pull/29040/files/9a41646c36b9beeec8f50b3f092506650cdc2772
https://github.com/Trott
Trott https://github.com/Trott
https://github.com/nodejs/node/pull/29040/files/134f97b4c6780616aa6b13745d9259db0844a647
https://github.com/lpinca
lpinca https://github.com/lpinca
https://github.com/nodejs/node/pull/29040/files/9a41646c36b9beeec8f50b3f092506650cdc2772
https://github.com/targos
targos https://github.com/targos
https://github.com/nodejs/node/pull/29040/files/9a41646c36b9beeec8f50b3f092506650cdc2772
https://github.com/trivikr
trivikr https://github.com/trivikr
https://github.com/nodejs/node/pull/29040/files/9a41646c36b9beeec8f50b3f092506650cdc2772
https://github.com/sam-github
sam-github https://github.com/sam-github
https://github.com/nodejs/node/pull/29040/files/134f97b4c6780616aa6b13745d9259db0844a647
dns https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Adns
Error message could be improved for dns.lookupService https://github.com/nodejs/node/issues/29039
Please reload this pagehttps://github.com/nodejs/node/pull/29040
https://github.com/cjihrig
https://github.com/nodejs-github-bot
https://github.com/Trott
https://github.com/sam-github
https://github.com/jasnell
https://github.com/lpinca
https://github.com/targos
https://github.com/trivikr
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.