René's URL Explorer Experiment


Title: stream: inline onwritedrain by ronag · Pull Request #29037 · nodejs/node · GitHub

Open Graph Title: stream: inline onwritedrain by ronag · Pull Request #29037 · nodejs/node

X Title: stream: inline onwritedrain by ronag · Pull Request #29037 · nodejs/node

Description: Node.js JavaScript runtime ✨🐢🚀✨. Contribute to nodejs/node development by creating an account on GitHub.

Open Graph Description: Just a minor cleanup. Inline and simplify onwritedrain. Also remove comment that seems to be outdated/invalid. Checklist make -j4 test (UNIX), or vcbuild test (Windows) passes commit message fo...

X Description: Just a minor cleanup. Inline and simplify onwritedrain. Also remove comment that seems to be outdated/invalid. Checklist make -j4 test (UNIX), or vcbuild test (Windows) passes commit message fo...

Opengraph URL: https://github.com/nodejs/node/pull/29037

X: @github

direct link

Domain: github.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:724293a3-4eff-2ad5-ae82-82b19c089e67
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idB53E:163D9C:13D7F15:1A2DC1E:6A51B52E
html-safe-nonce26919e64f0a6cf780741413b1b21170137fce38fa081558aefa7a73ba7825d72
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJCNTNFOjE2M0Q5QzoxM0Q3RjE1OjFBMkRDMUU6NkE1MUI1MkUiLCJ2aXNpdG9yX2lkIjoiNzI0MjY0NzUzOTY1MjA4MDk0MiIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmac1ec30fa299ff9e80b95c9a8fe6cb4e0deb58c6ef78fd36031542291d3c9db791
hovercard-subject-tagpull_request:305287647
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/29037/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/b5aac0131b819acad9c91a166fa2c16e4c5ab88a0aeda42e11633c79e6489dca/nodejs/node/pull/29037
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/b5aac0131b819acad9c91a166fa2c16e4c5ab88a0aeda42e11633c79e6489dca/nodejs/node/pull/29037
og:image:altJust a minor cleanup. Inline and simplify onwritedrain. Also remove comment that seems to be outdated/invalid. Checklist make -j4 test (UNIX), or vcbuild test (Windows) passes commit message fo...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernameronag
hostnamegithub.com
expected-hostnamegithub.com
Noneb9a586c06a05a7a86fc7e3f4dbd03e42f6869085879aa184aa6369456dbd50fb
turbo-cache-controlno-cache
go-importgithub.com/nodejs/node git https://github.com/nodejs/node.git
octolytics-dimension-user_id9950313
octolytics-dimension-user_loginnodejs
octolytics-dimension-repository_id27193779
octolytics-dimension-repository_nwonodejs/node
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id27193779
octolytics-dimension-repository_network_root_nwonodejs/node
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release7aed05249554b889eb33d002851a973eebcc7e91
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/nodejs/node/pull/29037#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F29037
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub Copilot appDirect agents from issue to mergehttps://github.com/features/ai/github-app
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
View all resourceshttps://github.com/resources
GitHub SponsorsFund open source developershttps://github.com/open-source/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/open-source/accelerator
GitHub Starshttps://stars.github.com
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F29037
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode
Reloadhttps://github.com/nodejs/node/pull/29037
Reloadhttps://github.com/nodejs/node/pull/29037
Reloadhttps://github.com/nodejs/node/pull/29037
Please reload this pagehttps://github.com/nodejs/node/pull/29037
nodejs https://github.com/nodejs
nodehttps://github.com/nodejs/node
Please reload this pagehttps://github.com/nodejs/node/pull/29037
Notifications https://github.com/login?return_to=%2Fnodejs%2Fnode
Fork 36.1k https://github.com/login?return_to=%2Fnodejs%2Fnode
Star 118k https://github.com/login?return_to=%2Fnodejs%2Fnode
Code https://github.com/nodejs/node
Issues 1.4k https://github.com/nodejs/node/issues
Pull requests 983 https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects https://github.com/nodejs/node/projects
Security and quality 0 https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
Code https://github.com/nodejs/node
Issues https://github.com/nodejs/node/issues
Pull requests https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects https://github.com/nodejs/node/projects
Security and quality https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
ronaghttps://github.com/ronag
nodejs:masterhttps://github.com/nodejs/node/tree/master
nxtedition:stream-inline-on-write-drainhttps://github.com/nxtedition/node/tree/stream-inline-on-write-drain
Conversationhttps://github.com/nodejs/node/pull/29037
Commits1 (1)https://github.com/nodejs/node/pull/29037/commits
Checkshttps://github.com/nodejs/node/pull/29037/checks
Files changedhttps://github.com/nodejs/node/pull/29037/files
stream: inline onwritedrainhttps://github.com/nodejs/node/pull/29037#top
ronaghttps://github.com/ronag
nodejs:masterhttps://github.com/nodejs/node/tree/master
nxtedition:stream-inline-on-write-drainhttps://github.com/nxtedition/node/tree/stream-inline-on-write-drain
https://github.com/ronag
ronaghttps://github.com/ronag
Aug 7, 2019https://github.com/nodejs/node/pull/29037#issue-478099782
Please reload this pagehttps://github.com/nodejs/node/pull/29037
commit guidelineshttps://github.com/nodejs/node/blob/master/doc/guides/contributing/pull-requests.md#commit-message-guidelines
Please reload this pagehttps://github.com/nodejs/node/pull/29037
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
stream https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Astream
Aug 7, 2019https://github.com/nodejs/node/pull/29037#event-2541158031
https://github.com/lpinca
lpincahttps://github.com/lpinca
Aug 8, 2019 https://github.com/nodejs/node/pull/29037#pullrequestreview-272804903
View reviewed changes https://github.com/nodejs/node/pull/29037/files
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
Aug 8, 2019https://github.com/nodejs/node/pull/29037#issuecomment-519666236
https://ci.nodejs.org/job/node-test-pull-request/24895/https://ci.nodejs.org/job/node-test-pull-request/24895/
Please reload this pagehttps://github.com/nodejs/node/pull/29037
https://github.com/ronag
stream: inline onwritedrainhttps://github.com/nodejs/node/pull/29037/commits/180245f18d5351edebaf45c5dde3ca8e3e408bb1
180245fhttps://github.com/nodejs/node/pull/29037/commits/180245f18d5351edebaf45c5dde3ca8e3e408bb1
https://github.com/ronag
ronaghttps://github.com/ronag
force-pushedhttps://github.com/nodejs/node/compare/08bb994dc6b6b217162e49598d8c3ba710202749..180245f18d5351edebaf45c5dde3ca8e3e408bb1
08bb994https://github.com/nodejs/node/commit/08bb994dc6b6b217162e49598d8c3ba710202749
180245fhttps://github.com/nodejs/node/commit/180245f18d5351edebaf45c5dde3ca8e3e408bb1
Compare https://github.com/nodejs/node/compare/08bb994dc6b6b217162e49598d8c3ba710202749..180245f18d5351edebaf45c5dde3ca8e3e408bb1
August 9, 2019 16:01https://github.com/nodejs/node/pull/29037#event-2546935708
https://github.com/Trott
Trotthttps://github.com/Trott
Aug 9, 2019https://github.com/nodejs/node/pull/29037#issuecomment-520058436
Please reload this pagehttps://github.com/nodejs/node/pull/29037
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
Aug 9, 2019https://github.com/nodejs/node/pull/29037#issuecomment-520058597
https://ci.nodejs.org/job/node-test-pull-request/24918/https://ci.nodejs.org/job/node-test-pull-request/24918/
Please reload this pagehttps://github.com/nodejs/node/pull/29037
https://github.com/mcollina
mcollinahttps://github.com/mcollina
Aug 9, 2019 https://github.com/nodejs/node/pull/29037#pullrequestreview-273374024
View reviewed changes https://github.com/nodejs/node/pull/29037/files/180245f18d5351edebaf45c5dde3ca8e3e408bb1
mcollinahttps://github.com/mcollina
https://github.com/nodejs/node/pull/29037#pullrequestreview-273374024
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/29037
https://github.com/trivikr
trivikrhttps://github.com/trivikr
Aug 9, 2019 https://github.com/nodejs/node/pull/29037#pullrequestreview-273390834
View reviewed changes https://github.com/nodejs/node/pull/29037/files/180245f18d5351edebaf45c5dde3ca8e3e408bb1
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
Aug 9, 2019https://github.com/nodejs/node/pull/29037#issuecomment-520090514
https://ci.nodejs.org/job/node-test-pull-request/24919/https://ci.nodejs.org/job/node-test-pull-request/24919/
Please reload this pagehttps://github.com/nodejs/node/pull/29037
https://github.com/trivikr
trivikrhttps://github.com/trivikr
author ready https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22author%20ready%22
Aug 9, 2019https://github.com/nodejs/node/pull/29037#event-2547800672
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
Aug 9, 2019https://github.com/nodejs/node/pull/29037#issuecomment-520093908
https://ci.nodejs.org/job/node-test-pull-request/24921/https://ci.nodejs.org/job/node-test-pull-request/24921/
Please reload this pagehttps://github.com/nodejs/node/pull/29037
https://github.com/Trott
Trotthttps://github.com/Trott
Aug 9, 2019 https://github.com/nodejs/node/pull/29037#pullrequestreview-273396732
View reviewed changes https://github.com/nodejs/node/pull/29037/files/180245f18d5351edebaf45c5dde3ca8e3e408bb1
https://github.com/Trott
Trotthttps://github.com/Trott
Aug 9, 2019https://github.com/nodejs/node/pull/29037#issuecomment-520096595
83495e7https://github.com/nodejs/node/commit/83495e778319603c3ed61e31d37dc9715df14329
Please reload this pagehttps://github.com/nodejs/node/pull/29037
https://github.com/Trott
Trotthttps://github.com/Trott
Aug 9, 2019https://github.com/nodejs/node/pull/29037#event-2547841741
Trotthttps://github.com/Trott
Aug 9, 2019 https://github.com/nodejs/node/pull/29037#ref-commit-83495e7
https://github.com/ronag
https://github.com/Trott
stream: inline and simplify onwritedrainhttps://github.com/Trott/io.js/commit/83495e778319603c3ed61e31d37dc9715df14329
83495e7https://github.com/Trott/io.js/commit/83495e778319603c3ed61e31d37dc9715df14329
nodejs#29037https://github.com/nodejs/node/pull/29037
targoshttps://github.com/targos
Aug 19, 2019 https://github.com/nodejs/node/pull/29037#ref-commit-e543d35
https://github.com/ronag
https://github.com/targos
stream: inline and simplify onwritedrainhttps://github.com/nodejs/node/commit/e543d35f3541baeb19b7f23fcbd0051d1be48448
e543d35https://github.com/nodejs/node/commit/e543d35f3541baeb19b7f23fcbd0051d1be48448
#29037https://github.com/nodejs/node/pull/29037
https://github.com/targos
targoshttps://github.com/targos
Aug 19, 2019 https://github.com/nodejs/node/pull/29037#ref-pullrequest-482485175
v12.9.0 release proposal #29210 https://github.com/nodejs/node/pull/29210
2019-08-20 Version 12.9.0 (Current) @targos beevelop/docker-android-nodejs#328 https://github.com/beevelop/docker-android-nodejs/issues/328
2019-08-20 Version 12.9.0 (Current) @targos beevelop/docker-android-nodejs#329 https://github.com/beevelop/docker-android-nodejs/issues/329
2019-08-20 Version 12.9.0 (Current) @targos beevelop/docker-android-nodejs#330 https://github.com/beevelop/docker-android-nodejs/issues/330
2019-08-20 Version 12.9.0 (Current) @targos beevelop/docker-nodejs#295 https://github.com/beevelop/docker-nodejs/issues/295
2019-08-20 Version 12.9.0 (Current) @targos beevelop/docker-nodejs#296 https://github.com/beevelop/docker-nodejs/issues/296
2019-08-20 Version 12.9.0 (Current) @targos beevelop/docker-nodejs#297 https://github.com/beevelop/docker-nodejs/issues/297
https://github.com/ad-m
ad-mhttps://github.com/ad-m
Jan 29, 2020 https://github.com/nodejs/node/pull/29037#ref-issue-556557373
Pipe to Channel hangs on "Parser: IN_PACKETBEFORE (expecting 16)" mscdex/ssh2#870 https://github.com/mscdex/ssh2/issues/870
https://github.co/hiddenchars
https://github.com/nodejs/node/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F29037
https://github.com/mcollina
mcollina https://github.com/mcollina
https://github.com/nodejs/node/pull/29037/files/180245f18d5351edebaf45c5dde3ca8e3e408bb1
https://github.com/Trott
Trott https://github.com/Trott
https://github.com/nodejs/node/pull/29037/files/180245f18d5351edebaf45c5dde3ca8e3e408bb1
https://github.com/lpinca
lpinca https://github.com/lpinca
https://github.com/nodejs/node/pull/29037/files/08bb994dc6b6b217162e49598d8c3ba710202749
https://github.com/trivikr
trivikr https://github.com/trivikr
https://github.com/nodejs/node/pull/29037/files/180245f18d5351edebaf45c5dde3ca8e3e408bb1
author ready https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22author%20ready%22
stream https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Astream
Please reload this pagehttps://github.com/nodejs/node/pull/29037
https://github.com/ronag
https://github.com/nodejs-github-bot
https://github.com/Trott
https://github.com/mcollina
https://github.com/lpinca
https://github.com/trivikr
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.