| route-pattern | /_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format) |
| route-controller | voltron_pull_requests_fragments |
| route-action | pull_request_layout |
| fetch-nonce | v2:713ee990-20c8-019a-c839-c82da7f7e0eb |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | E674:D9FFD:BAA1E8:1054132:6A4F4BCE |
| html-safe-nonce | 0b3767140bf08e39fa70acbf302ea1e0c0824e548623f5ab7091ccbaa6ac6856 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJFNjc0OkQ5RkZEOkJBQTFFODoxMDU0MTMyOjZBNEY0QkNFIiwidmlzaXRvcl9pZCI6IjM1ODU2MTU2MDU4OTIzMzY1OTAiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ== |
| visitor-hmac | d7d3094d8d862cac3516d4dcb3a0ea28244307d97fcd6dce146a09a607185104 |
| hovercard-subject-tag | pull_request:305271745 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///voltron/pull_requests_fragments/pull_request_layout |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/29036/pull_request_layout |
| twitter:image | https://opengraph.githubassets.com/e036fc127effdc2f0b11fe91c7351d7b233c74a43aab9ca93fdf852575432642/nodejs/node/pull/29036 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/e036fc127effdc2f0b11fe91c7351d7b233c74a43aab9ca93fdf852575432642/nodejs/node/pull/29036 |
| og:image:alt | Backporting #26599 was not completely trivial, since there where so many changes that required a work around. Functionality wise it should now be identical.
Checklist
make -j4 test (UNIX), or v... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | BridgeAR |
| hostname | github.com |
| expected-hostname | github.com |
| None | b92d11c0aa4a77d54ef4af1078b6a15fb5a70a215b30c4ecf28889d5a8e656d9 |
| turbo-cache-control | no-cache |
| go-import | github.com/nodejs/node git https://github.com/nodejs/node.git |
| octolytics-dimension-user_id | 9950313 |
| octolytics-dimension-user_login | nodejs |
| octolytics-dimension-repository_id | 27193779 |
| octolytics-dimension-repository_nwo | nodejs/node |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 27193779 |
| octolytics-dimension-repository_network_root_nwo | nodejs/node |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 4b249b445842943ed31549e027f57a8ade9881ed |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| Skip to content | https://github.com/nodejs/node/pull/29036#start-of-content |
|
| https://github.com/ |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F29036 |
| GitHub CopilotWrite better code with AI | https://github.com/features/copilot |
| GitHub Copilot appDirect agents from issue to merge | https://github.com/features/ai/github-app |
| MCP RegistryNewIntegrate external tools | https://github.com/mcp |
| ActionsAutomate any workflow | https://github.com/features/actions |
| CodespacesInstant dev environments | https://github.com/features/codespaces |
| IssuesPlan and track work | https://github.com/features/issues |
| Code ReviewManage code changes | https://github.com/features/code-review |
| GitHub Advanced SecurityFind and fix vulnerabilities | https://github.com/security/advanced-security |
| Code securitySecure your code as you build | https://github.com/security/advanced-security/code-security |
| Secret protectionStop leaks before they start | https://github.com/security/advanced-security/secret-protection |
| Why GitHub | https://github.com/why-github |
| Documentation | https://docs.github.com |
| Blog | https://github.blog |
| Changelog | https://github.blog/changelog |
| Marketplace | https://github.com/marketplace |
| View all features | https://github.com/features |
| Enterprises | https://github.com/enterprise |
| Small and medium teams | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| App Modernization | https://github.com/solutions/use-case/app-modernization |
| DevSecOps | https://github.com/solutions/use-case/devsecops |
| DevOps | https://github.com/solutions/use-case/devops |
| CI/CD | https://github.com/solutions/use-case/ci-cd |
| View all use cases | https://github.com/solutions/use-case |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| View all industries | https://github.com/solutions/industry |
| View all solutions | https://github.com/solutions |
| AI | https://github.com/resources/articles?topic=ai |
| Software Development | https://github.com/resources/articles?topic=software-development |
| DevOps | https://github.com/resources/articles?topic=devops |
| Security | https://github.com/resources/articles?topic=security |
| View all topics | https://github.com/resources/articles |
| Customer stories | https://github.com/customer-stories |
| Events & webinars | https://github.com/resources/events |
| Ebooks & reports | https://github.com/resources/whitepapers |
| Business insights | https://github.com/solutions/executive-insights |
| GitHub Skills | https://skills.github.com |
| Documentation | https://docs.github.com |
| Customer support | https://support.github.com |
| Community forum | https://github.com/orgs/community/discussions |
| Trust center | https://github.com/trust-center |
| Partners | https://github.com/partners |
| View all resources | https://github.com/resources |
| GitHub SponsorsFund open source developers | https://github.com/open-source/sponsors |
| Security Lab | https://securitylab.github.com |
| Maintainer Community | https://maintainers.github.com |
| Accelerator | https://github.com/open-source/accelerator |
| GitHub Stars | https://stars.github.com |
| Archive Program | https://archiveprogram.github.com |
| Topics | https://github.com/topics |
| Trending | https://github.com/trending |
| Collections | https://github.com/collections |
| Enterprise platformAI-powered developer platform | https://github.com/enterprise |
| GitHub Advanced SecurityEnterprise-grade security features | https://github.com/security/advanced-security |
| Copilot for BusinessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/enterprise/premium-support |
| Pricing | https://github.com/pricing |
| Search syntax tips | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
| documentation | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F29036 |
|
Sign up
| https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode |
| Reload | https://github.com/nodejs/node/pull/29036 |
| Reload | https://github.com/nodejs/node/pull/29036 |
| Reload | https://github.com/nodejs/node/pull/29036 |
| Please reload this page | https://github.com/nodejs/node/pull/29036 |
|
nodejs
| https://github.com/nodejs |
| node | https://github.com/nodejs/node |
| Please reload this page | https://github.com/nodejs/node/pull/29036 |
|
Notifications
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Fork
36k
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Star
118k
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Code
| https://github.com/nodejs/node |
|
Issues
1.3k
| https://github.com/nodejs/node/issues |
|
Pull requests
969
| https://github.com/nodejs/node/pulls |
|
Actions
| https://github.com/nodejs/node/actions |
|
Projects
| https://github.com/nodejs/node/projects |
|
Security and quality
0
| https://github.com/nodejs/node/security |
|
Insights
| https://github.com/nodejs/node/pulse |
|
Code
| https://github.com/nodejs/node |
|
Issues
| https://github.com/nodejs/node/issues |
|
Pull requests
| https://github.com/nodejs/node/pulls |
|
Actions
| https://github.com/nodejs/node/actions |
|
Projects
| https://github.com/nodejs/node/projects |
|
Security and quality
| https://github.com/nodejs/node/security |
|
Insights
| https://github.com/nodejs/node/pulse |
| BridgeAR | https://github.com/BridgeAR |
| nodejs:v10.x-staging | https://github.com/nodejs/node/tree/v10.x-staging |
| BridgeAR:v10.x-backport-26599 | https://github.com/BridgeAR/node/tree/v10.x-backport-26599 |
| Conversation | https://github.com/nodejs/node/pull/29036 |
| Commits2 (2) | https://github.com/nodejs/node/pull/29036/commits |
| Checks | https://github.com/nodejs/node/pull/29036/checks |
| Files changed | https://github.com/nodejs/node/pull/29036/files |
| [v10.x] backport #26599 (process: add --unhandled-rejections flag) | https://github.com/nodejs/node/pull/29036#top |
| BridgeAR | https://github.com/BridgeAR |
| nodejs:v10.x-staging | https://github.com/nodejs/node/tree/v10.x-staging |
| BridgeAR:v10.x-backport-26599 | https://github.com/BridgeAR/node/tree/v10.x-backport-26599 |
|
| https://github.com/BridgeAR |
| BridgeAR | https://github.com/BridgeAR |
| Aug 7, 2019 | https://github.com/nodejs/node/pull/29036#issue-478080359 |
| #26599 | https://github.com/nodejs/node/pull/26599 |
| commit guidelines | https://github.com/nodejs/node/blob/master/doc/guides/contributing/pull-requests.md#commit-message-guidelines |
| Please reload this page | https://github.com/nodejs/node/pull/29036 |
|
| https://github.com/BridgeAR |
| process: add --unhandled-rejections flag | https://github.com/nodejs/node/pull/29036/commits/e7ff5ea6d9a0a8f9649ff2347bd16616dc8bad55 |
| e7ff5ea | https://github.com/nodejs/node/pull/29036/commits/e7ff5ea6d9a0a8f9649ff2347bd16616dc8bad55 |
| nodejs#26599 | https://github.com/nodejs/node/pull/26599 |
| https://github.com/nodejs-github-bot |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
|
c++
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Ac%2B%2B |
|
lib / src
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22lib%20%2F%20src%22 |
|
v10.x
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Av10.x |
| Aug 7, 2019 | https://github.com/nodejs/node/pull/29036#event-2541035992 |
| https://github.com/nodejs-github-bot |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
| Sep 20, 2019 | https://github.com/nodejs/node/pull/29036#issuecomment-533509354 |
| https://ci.nodejs.org/job/node-test-pull-request/25597/ | https://ci.nodejs.org/job/node-test-pull-request/25597/ |
| Please reload this page | https://github.com/nodejs/node/pull/29036 |
| https://github.com/nodejs-github-bot |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
| Sep 24, 2019 | https://github.com/nodejs/node/pull/29036#issuecomment-534353418 |
| https://ci.nodejs.org/job/node-test-pull-request/25660/ | https://ci.nodejs.org/job/node-test-pull-request/25660/ |
| Please reload this page | https://github.com/nodejs/node/pull/29036 |
| https://github.com/BridgeAR |
| BridgeAR | https://github.com/BridgeAR |
| Sep 24, 2019 | https://github.com/nodejs/node/pull/29036#issuecomment-534535208 |
| @addaleax | https://github.com/addaleax |
| fails | https://ci.nodejs.org/job/node-test-commit-custom-suites-freestyle/9168/testReport/junit/(root)/test/parallel_test_promise_unhandled_error/ |
| Please reload this page | https://github.com/nodejs/node/pull/29036 |
| https://github.com/addaleax |
| addaleax | https://github.com/addaleax |
|
semver-minor
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Asemver-minor |
| Sep 24, 2019 | https://github.com/nodejs/node/pull/29036#event-2659501456 |
| https://github.com/addaleax |
| addaleax | https://github.com/addaleax |
| Sep 24, 2019 | https://github.com/nodejs/node/pull/29036#issuecomment-534746392 |
| @BridgeAR | https://github.com/BridgeAR |
| Please reload this page | https://github.com/nodejs/node/pull/29036 |
| https://github.com/BridgeAR |
| BridgeAR | https://github.com/BridgeAR |
| Sep 24, 2019 | https://github.com/nodejs/node/pull/29036#issuecomment-534764635 |
| @addaleax | https://github.com/addaleax |
| Please reload this page | https://github.com/nodejs/node/pull/29036 |
| https://github.com/addaleax |
| addaleax | https://github.com/addaleax |
|
Sep 24, 2019
| https://github.com/nodejs/node/pull/29036#pullrequestreview-292737161 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/29036/files/e7ff5ea6d9a0a8f9649ff2347bd16616dc8bad55 |
| lib/internal/process/promises.js | https://github.com/nodejs/node/pull/29036/files/e7ff5ea6d9a0a8f9649ff2347bd16616dc8bad55#diff-04f0a68c4bc76396de863bbe0982c85d70a5b71432bdc26bc503e3ac317c6f82 |
| Please reload this page | https://github.com/nodejs/node/pull/29036 |
|
| https://github.com/BridgeAR |
| worker: add missing return value in case of fatal exceptions | https://github.com/nodejs/node/pull/29036/commits/26d3b0a757c91614f2a42dba3da9f67a99689044 |
| 26d3b0a | https://github.com/nodejs/node/pull/29036/commits/26d3b0a757c91614f2a42dba3da9f67a99689044 |
| https://github.com/nodejs-github-bot |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
| Sep 24, 2019 | https://github.com/nodejs/node/pull/29036#issuecomment-534782825 |
| https://ci.nodejs.org/job/node-test-pull-request/25688/ | https://ci.nodejs.org/job/node-test-pull-request/25688/ |
| Please reload this page | https://github.com/nodejs/node/pull/29036 |
| https://github.com/nodejs-github-bot |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
| Sep 25, 2019 | https://github.com/nodejs/node/pull/29036#issuecomment-534855179 |
| https://ci.nodejs.org/job/node-test-pull-request/25694/ | https://ci.nodejs.org/job/node-test-pull-request/25694/ |
| Please reload this page | https://github.com/nodejs/node/pull/29036 |
| https://github.com/nodejs-github-bot |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
| Sep 25, 2019 | https://github.com/nodejs/node/pull/29036#issuecomment-534867808 |
| https://ci.nodejs.org/job/node-test-pull-request/25698/ | https://ci.nodejs.org/job/node-test-pull-request/25698/ |
| Please reload this page | https://github.com/nodejs/node/pull/29036 |
| https://github.com/nodejs-github-bot |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
| Sep 25, 2019 | https://github.com/nodejs/node/pull/29036#issuecomment-535223663 |
| https://ci.nodejs.org/job/node-test-pull-request/25709/ | https://ci.nodejs.org/job/node-test-pull-request/25709/ |
| Please reload this page | https://github.com/nodejs/node/pull/29036 |
| https://github.com/BethGriggs |
| BethGriggs | https://github.com/BethGriggs |
|
Oct 1, 2019
| https://github.com/nodejs/node/pull/29036#pullrequestreview-295781197 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/29036/files/26d3b0a757c91614f2a42dba3da9f67a99689044 |
| https://github.com/BridgeAR |
| BridgeAR | https://github.com/BridgeAR |
|
lts-watch-v10.x
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Alts-watch-v10.x |
| Oct 8, 2019 | https://github.com/nodejs/node/pull/29036#event-2694755094 |
| BethGriggs | https://github.com/BethGriggs |
|
Oct 15, 2019
| https://github.com/nodejs/node/pull/29036#ref-commit-2eae030 |
|
| https://github.com/BridgeAR |
|
| https://github.com/BethGriggs |
| worker: add missing return value in case of fatal exceptions | https://github.com/nodejs/node/commit/2eae030a4bef670852625d5742b2ea963e39e1a4 |
| 2eae030 | https://github.com/nodejs/node/commit/2eae030a4bef670852625d5742b2ea963e39e1a4 |
| #29036 | https://github.com/nodejs/node/pull/29036 |
| https://github.com/BethGriggs |
| BethGriggs | https://github.com/BethGriggs |
| Oct 15, 2019 | https://github.com/nodejs/node/pull/29036#issuecomment-542360710 |
| Please reload this page | https://github.com/nodejs/node/pull/29036 |
| https://github.com/BethGriggs |
| BethGriggs | https://github.com/BethGriggs |
| Oct 15, 2019 | https://github.com/nodejs/node/pull/29036#event-2715123967 |
| https://github.com/BethGriggs |
| BethGriggs | https://github.com/BethGriggs |
|
lts-watch-v10.x
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Alts-watch-v10.x |
| Oct 17, 2019 | https://github.com/nodejs/node/pull/29036#event-2722770118 |
| https://github.com/BethGriggs |
| BethGriggs | https://github.com/BethGriggs |
|
Oct 18, 2019
| https://github.com/nodejs/node/pull/29036#ref-pullrequest-503572635 |
|
v10.17.0 proposal
#29875
| https://github.com/nodejs/node/pull/29875 |
| https://github.com/BridgeAR |
| BridgeAR | https://github.com/BridgeAR |
| January 20, 2020 12:05 | https://github.com/nodejs/node/pull/29036#event-2962704703 |
| https://github.co/hiddenchars |
| https://github.com/nodejs/node/pull/{{ revealButtonHref }} |
| Sign up for free | https://github.com/join?source=comment-repo |
| Sign in to comment | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F29036 |
|
| https://github.com/addaleax |
|
addaleax
| https://github.com/addaleax |
|
| https://github.com/nodejs/node/pull/29036/files/e7ff5ea6d9a0a8f9649ff2347bd16616dc8bad55 |
|
| https://github.com/BethGriggs |
|
BethGriggs
| https://github.com/BethGriggs |
|
| https://github.com/nodejs/node/pull/29036/files/26d3b0a757c91614f2a42dba3da9f67a99689044 |
|
c++
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Ac%2B%2B |
|
lib / src
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22lib%20%2F%20src%22 |
|
semver-minor
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Asemver-minor |
| Please reload this page | https://github.com/nodejs/node/pull/29036 |
|
| https://github.com/BridgeAR |
|
| https://github.com/nodejs-github-bot |
|
| https://github.com/addaleax |
|
| https://github.com/BethGriggs |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |