René's URL Explorer Experiment


Title: http: remove duplicate check by ronag · Pull Request #29022 · nodejs/node · GitHub

Open Graph Title: http: remove duplicate check by ronag · Pull Request #29022 · nodejs/node

X Title: http: remove duplicate check by ronag · Pull Request #29022 · nodejs/node

Description: Node.js JavaScript runtime ✨🐢🚀✨. Contribute to nodejs/node development by creating an account on GitHub.

Open Graph Description: socketOnDrain performs the exact same check and doesn't return anything. Checklist make -j4 test (UNIX), or vcbuild test (Windows) passes tests and/or benchmarks are included documentation...

X Description: socketOnDrain performs the exact same check and doesn't return anything. Checklist make -j4 test (UNIX), or vcbuild test (Windows) passes tests and/or benchmarks are included documenta...

Opengraph URL: https://github.com/nodejs/node/pull/29022

X: @github

direct link

Domain: github.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:8bf5ce6d-bd55-5cbe-eb14-b0ca3c198b63
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-id8E66:8F52B:457EDBD:6135ECB:6A4F78CF
html-safe-nonce074618fec7fea37fc92440b023a5041be8eb8a36f13aa6fa6af36475b7c7eba0
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI4RTY2OjhGNTJCOjQ1N0VEQkQ6NjEzNUVDQjo2QTRGNzhDRiIsInZpc2l0b3JfaWQiOiIzMjQxNDM3NjAyNzYzNDcxMDU1IiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmac56e163237821daeab706c04b124a117f0371508004ac3f6619cfb340c11e708b
hovercard-subject-tagpull_request:304794154
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/29022/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/d071c5680182cb10794b5723b7dfded4682aa28d7d7cb42145419e74f706d522/nodejs/node/pull/29022
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/d071c5680182cb10794b5723b7dfded4682aa28d7d7cb42145419e74f706d522/nodejs/node/pull/29022
og:image:altsocketOnDrain performs the exact same check and doesn't return anything. Checklist make -j4 test (UNIX), or vcbuild test (Windows) passes tests and/or benchmarks are included documentation...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernameronag
hostnamegithub.com
expected-hostnamegithub.com
Noneb92d11c0aa4a77d54ef4af1078b6a15fb5a70a215b30c4ecf28889d5a8e656d9
turbo-cache-controlno-cache
go-importgithub.com/nodejs/node git https://github.com/nodejs/node.git
octolytics-dimension-user_id9950313
octolytics-dimension-user_loginnodejs
octolytics-dimension-repository_id27193779
octolytics-dimension-repository_nwonodejs/node
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id27193779
octolytics-dimension-repository_network_root_nwonodejs/node
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release4b249b445842943ed31549e027f57a8ade9881ed
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/nodejs/node/pull/29022#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F29022
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub Copilot appDirect agents from issue to mergehttps://github.com/features/ai/github-app
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
View all resourceshttps://github.com/resources
GitHub SponsorsFund open source developershttps://github.com/open-source/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/open-source/accelerator
GitHub Starshttps://stars.github.com
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F29022
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode
Reloadhttps://github.com/nodejs/node/pull/29022
Reloadhttps://github.com/nodejs/node/pull/29022
Reloadhttps://github.com/nodejs/node/pull/29022
Please reload this pagehttps://github.com/nodejs/node/pull/29022
nodejs https://github.com/nodejs
nodehttps://github.com/nodejs/node
Please reload this pagehttps://github.com/nodejs/node/pull/29022
Notifications https://github.com/login?return_to=%2Fnodejs%2Fnode
Fork 36k https://github.com/login?return_to=%2Fnodejs%2Fnode
Star 118k https://github.com/login?return_to=%2Fnodejs%2Fnode
Code https://github.com/nodejs/node
Issues 1.3k https://github.com/nodejs/node/issues
Pull requests 973 https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects https://github.com/nodejs/node/projects
Security and quality 0 https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
Code https://github.com/nodejs/node
Issues https://github.com/nodejs/node/issues
Pull requests https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects https://github.com/nodejs/node/projects
Security and quality https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
ronaghttps://github.com/ronag
nodejs:masterhttps://github.com/nodejs/node/tree/master
nxtedition:http-remove-noophttps://github.com/nxtedition/node/tree/http-remove-noop
Conversationhttps://github.com/nodejs/node/pull/29022
Commits1 (1)https://github.com/nodejs/node/pull/29022/commits
Checkshttps://github.com/nodejs/node/pull/29022/checks
Files changedhttps://github.com/nodejs/node/pull/29022/files
http: remove duplicate checkhttps://github.com/nodejs/node/pull/29022#top
ronaghttps://github.com/ronag
nodejs:masterhttps://github.com/nodejs/node/tree/master
nxtedition:http-remove-noophttps://github.com/nxtedition/node/tree/http-remove-noop
https://github.com/ronag
ronaghttps://github.com/ronag
Aug 6, 2019https://github.com/nodejs/node/pull/29022#issue-477476095
Please reload this pagehttps://github.com/nodejs/node/pull/29022
commit guidelineshttps://github.com/nodejs/node/blob/master/doc/guides/contributing/pull-requests.md#commit-message-guidelines
Please reload this pagehttps://github.com/nodejs/node/pull/29022
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
http https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Ahttp
Aug 6, 2019https://github.com/nodejs/node/pull/29022#event-2537366198
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
Aug 6, 2019 https://github.com/nodejs/node/pull/29022#pullrequestreview-271481052
View reviewed changes https://github.com/nodejs/node/pull/29022/files
addaleaxhttps://github.com/addaleax
https://github.com/nodejs/node/pull/29022#pullrequestreview-271481052
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/29022
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
Aug 8, 2019https://github.com/nodejs/node/pull/29022#issuecomment-519595533
https://ci.nodejs.org/job/node-test-pull-request/24891/https://ci.nodejs.org/job/node-test-pull-request/24891/
Please reload this pagehttps://github.com/nodejs/node/pull/29022
https://github.com/ronag
http: remove duplicate checkhttps://github.com/nodejs/node/pull/29022/commits/9300b4b6ec374966ed973c34b1dc624e72a629c5
9300b4bhttps://github.com/nodejs/node/pull/29022/commits/9300b4b6ec374966ed973c34b1dc624e72a629c5
https://github.com/ronag
ronaghttps://github.com/ronag
force-pushedhttps://github.com/nodejs/node/compare/e8900ecc6f9d67f3a3b05b905ac636c6f0f23b96..9300b4b6ec374966ed973c34b1dc624e72a629c5
e8900echttps://github.com/nodejs/node/commit/e8900ecc6f9d67f3a3b05b905ac636c6f0f23b96
9300b4bhttps://github.com/nodejs/node/commit/9300b4b6ec374966ed973c34b1dc624e72a629c5
Compare https://github.com/nodejs/node/compare/e8900ecc6f9d67f3a3b05b905ac636c6f0f23b96..9300b4b6ec374966ed973c34b1dc624e72a629c5
August 9, 2019 16:02https://github.com/nodejs/node/pull/29022#event-2546938296
https://github.com/Trott
Trotthttps://github.com/Trott
Aug 9, 2019https://github.com/nodejs/node/pull/29022#issuecomment-520021738
Please reload this pagehttps://github.com/nodejs/node/pull/29022
https://github.com/Trott
Trotthttps://github.com/Trott
review wanted https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22review%20wanted%22
Aug 9, 2019https://github.com/nodejs/node/pull/29022#event-2547305523
https://github.com/mcollina
mcollinahttps://github.com/mcollina
Aug 9, 2019 https://github.com/nodejs/node/pull/29022#pullrequestreview-273320544
View reviewed changes https://github.com/nodejs/node/pull/29022/files/9300b4b6ec374966ed973c34b1dc624e72a629c5
mcollinahttps://github.com/mcollina
https://github.com/nodejs/node/pull/29022#pullrequestreview-273320544
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/29022
https://github.com/trivikr
trivikrhttps://github.com/trivikr
Aug 9, 2019 https://github.com/nodejs/node/pull/29022#pullrequestreview-273395591
View reviewed changes https://github.com/nodejs/node/pull/29022/files/9300b4b6ec374966ed973c34b1dc624e72a629c5
https://github.com/Trott
Trotthttps://github.com/Trott
Aug 11, 2019 https://github.com/nodejs/node/pull/29022#pullrequestreview-273445262
View reviewed changes https://github.com/nodejs/node/pull/29022/files/9300b4b6ec374966ed973c34b1dc624e72a629c5
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
Aug 11, 2019https://github.com/nodejs/node/pull/29022#issuecomment-520194321
https://ci.nodejs.org/job/node-test-pull-request/24933/https://ci.nodejs.org/job/node-test-pull-request/24933/
Please reload this pagehttps://github.com/nodejs/node/pull/29022
https://github.com/Trott
Trotthttps://github.com/Trott
Aug 11, 2019https://github.com/nodejs/node/pull/29022#issuecomment-520263796
7635b7chttps://github.com/nodejs/node/commit/7635b7cc27305dbe11112771d6f7c52b3c401db8
Please reload this pagehttps://github.com/nodejs/node/pull/29022
https://github.com/Trott
Trotthttps://github.com/Trott
Aug 11, 2019https://github.com/nodejs/node/pull/29022#event-2548853400
Trotthttps://github.com/Trott
Aug 11, 2019 https://github.com/nodejs/node/pull/29022#ref-commit-7635b7c
https://github.com/ronag
https://github.com/Trott
http: remove duplicate checkhttps://github.com/Trott/io.js/commit/7635b7cc27305dbe11112771d6f7c52b3c401db8
7635b7chttps://github.com/Trott/io.js/commit/7635b7cc27305dbe11112771d6f7c52b3c401db8
nodejs#29022https://github.com/nodejs/node/pull/29022
targoshttps://github.com/targos
Aug 19, 2019 https://github.com/nodejs/node/pull/29022#ref-commit-13a4979
https://github.com/ronag
https://github.com/targos
http: remove duplicate checkhttps://github.com/nodejs/node/commit/13a497912d71b516352599e36f7172e654c3aec4
13a4979https://github.com/nodejs/node/commit/13a497912d71b516352599e36f7172e654c3aec4
#29022https://github.com/nodejs/node/pull/29022
https://github.com/targos
targoshttps://github.com/targos
Aug 19, 2019 https://github.com/nodejs/node/pull/29022#ref-pullrequest-482485175
v12.9.0 release proposal #29210 https://github.com/nodejs/node/pull/29210
2019-08-20 Version 12.9.0 (Current) @targos beevelop/docker-android-nodejs#328 https://github.com/beevelop/docker-android-nodejs/issues/328
2019-08-20 Version 12.9.0 (Current) @targos beevelop/docker-android-nodejs#329 https://github.com/beevelop/docker-android-nodejs/issues/329
2019-08-20 Version 12.9.0 (Current) @targos beevelop/docker-android-nodejs#330 https://github.com/beevelop/docker-android-nodejs/issues/330
2019-08-20 Version 12.9.0 (Current) @targos beevelop/docker-nodejs#295 https://github.com/beevelop/docker-nodejs/issues/295
2019-08-20 Version 12.9.0 (Current) @targos beevelop/docker-nodejs#296 https://github.com/beevelop/docker-nodejs/issues/296
2019-08-20 Version 12.9.0 (Current) @targos beevelop/docker-nodejs#297 https://github.com/beevelop/docker-nodejs/issues/297
https://github.co/hiddenchars
https://github.com/nodejs/node/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F29022
https://github.com/mcollina
mcollina https://github.com/mcollina
https://github.com/nodejs/node/pull/29022/files/9300b4b6ec374966ed973c34b1dc624e72a629c5
https://github.com/Trott
Trott https://github.com/Trott
https://github.com/nodejs/node/pull/29022/files/9300b4b6ec374966ed973c34b1dc624e72a629c5
https://github.com/addaleax
addaleax https://github.com/addaleax
https://github.com/nodejs/node/pull/29022/files/e8900ecc6f9d67f3a3b05b905ac636c6f0f23b96
https://github.com/trivikr
trivikr https://github.com/trivikr
https://github.com/nodejs/node/pull/29022/files/9300b4b6ec374966ed973c34b1dc624e72a629c5
http https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Ahttp
review wanted https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22review%20wanted%22
Please reload this pagehttps://github.com/nodejs/node/pull/29022
https://github.com/ronag
https://github.com/nodejs-github-bot
https://github.com/Trott
https://github.com/mcollina
https://github.com/addaleax
https://github.com/trivikr
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.