René's URL Explorer Experiment


Title: test: refactor test-sync-io-option by addaleax · Pull Request #29020 · nodejs/node · GitHub

Open Graph Title: test: refactor test-sync-io-option by addaleax · Pull Request #29020 · nodejs/node

X Title: test: refactor test-sync-io-option by addaleax · Pull Request #29020 · nodejs/node

Description: Node.js JavaScript runtime ✨🐢🚀✨. Contribute to nodejs/node development by creating an account on GitHub.

Open Graph Description: Refactor test/parallel/test-sync-io-option.js to be simpler and cover more cases (in particular, this adds a regression test for #28913). Refs: #28913 Checklist make -j4 test (UNIX), or vcbuild...

X Description: Refactor test/parallel/test-sync-io-option.js to be simpler and cover more cases (in particular, this adds a regression test for #28913). Refs: #28913 Checklist make -j4 test (UNIX), or vcbuild...

Opengraph URL: https://github.com/nodejs/node/pull/29020

X: @github

direct link

Domain: github.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:5cad0e24-294e-1612-245b-87ce2f682f9e
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-id8F0A:3463DE:31DB6A4:45F7299:6A4F7BC9
html-safe-nonce94197bd2e6769d4e09bfc37f8f50fe53bc0553482dc727316c4755fc012de1e8
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI4RjBBOjM0NjNERTozMURCNkE0OjQ1RjcyOTk6NkE0RjdCQzkiLCJ2aXNpdG9yX2lkIjoiODMwNTEyMTY1NDM4OTgzMjY0OSIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmac67f0657025da3da892e3e023d2406107d7711aac947e85fc351a390c7fbb9ec0
hovercard-subject-tagpull_request:304732285
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/29020/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/7bea16b6494c5d7bb6a9ccd5cdd8050dcd28d3ab162036e98914a9817c63c40a/nodejs/node/pull/29020
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/7bea16b6494c5d7bb6a9ccd5cdd8050dcd28d3ab162036e98914a9817c63c40a/nodejs/node/pull/29020
og:image:altRefactor test/parallel/test-sync-io-option.js to be simpler and cover more cases (in particular, this adds a regression test for #28913). Refs: #28913 Checklist make -j4 test (UNIX), or vcbuild...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernameaddaleax
hostnamegithub.com
expected-hostnamegithub.com
Noneb92d11c0aa4a77d54ef4af1078b6a15fb5a70a215b30c4ecf28889d5a8e656d9
turbo-cache-controlno-cache
go-importgithub.com/nodejs/node git https://github.com/nodejs/node.git
octolytics-dimension-user_id9950313
octolytics-dimension-user_loginnodejs
octolytics-dimension-repository_id27193779
octolytics-dimension-repository_nwonodejs/node
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id27193779
octolytics-dimension-repository_network_root_nwonodejs/node
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release4b249b445842943ed31549e027f57a8ade9881ed
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/nodejs/node/pull/29020#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F29020
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub Copilot appDirect agents from issue to mergehttps://github.com/features/ai/github-app
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
View all resourceshttps://github.com/resources
GitHub SponsorsFund open source developershttps://github.com/open-source/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/open-source/accelerator
GitHub Starshttps://stars.github.com
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F29020
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode
Reloadhttps://github.com/nodejs/node/pull/29020
Reloadhttps://github.com/nodejs/node/pull/29020
Reloadhttps://github.com/nodejs/node/pull/29020
Please reload this pagehttps://github.com/nodejs/node/pull/29020
nodejs https://github.com/nodejs
nodehttps://github.com/nodejs/node
Please reload this pagehttps://github.com/nodejs/node/pull/29020
Notifications https://github.com/login?return_to=%2Fnodejs%2Fnode
Fork 36k https://github.com/login?return_to=%2Fnodejs%2Fnode
Star 118k https://github.com/login?return_to=%2Fnodejs%2Fnode
Code https://github.com/nodejs/node
Issues 1.3k https://github.com/nodejs/node/issues
Pull requests 973 https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects https://github.com/nodejs/node/projects
Security and quality 0 https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
Code https://github.com/nodejs/node
Issues https://github.com/nodejs/node/issues
Pull requests https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects https://github.com/nodejs/node/projects
Security and quality https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
addaleaxhttps://github.com/addaleax
nodejs:masterhttps://github.com/nodejs/node/tree/master
addaleax:test-sync-io-fixhttps://github.com/addaleax/node/tree/test-sync-io-fix
Conversationhttps://github.com/nodejs/node/pull/29020
Commits1 (1)https://github.com/nodejs/node/pull/29020/commits
Checkshttps://github.com/nodejs/node/pull/29020/checks
Files changedhttps://github.com/nodejs/node/pull/29020/files
test: refactor test-sync-io-optionhttps://github.com/nodejs/node/pull/29020#top
addaleaxhttps://github.com/addaleax
nodejs:masterhttps://github.com/nodejs/node/tree/master
addaleax:test-sync-io-fixhttps://github.com/addaleax/node/tree/test-sync-io-fix
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
Aug 6, 2019https://github.com/nodejs/node/pull/29020#issue-477399985
#28913https://github.com/nodejs/node/issues/28913
#28913https://github.com/nodejs/node/issues/28913
commit guidelineshttps://github.com/nodejs/node/blob/master/doc/guides/contributing/pull-requests.md#commit-message-guidelines
Please reload this pagehttps://github.com/nodejs/node/pull/29020
https://github.com/addaleax
test: refactor test-sync-io-optionhttps://github.com/nodejs/node/pull/29020/commits/77694f3ec44de81e37d2fc7c73ae806d5044c43d
77694f3https://github.com/nodejs/node/pull/29020/commits/77694f3ec44de81e37d2fc7c73ae806d5044c43d
nodejs#28913https://github.com/nodejs/node/issues/28913
nodejs#28913https://github.com/nodejs/node/issues/28913
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
test https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Atest
Aug 6, 2019https://github.com/nodejs/node/pull/29020#event-2536884078
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
cli https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Acli
Aug 6, 2019https://github.com/nodejs/node/pull/29020#event-2536885574
https://github.com/cjihrig
cjihrighttps://github.com/cjihrig
Aug 6, 2019 https://github.com/nodejs/node/pull/29020#pullrequestreview-271386338
View reviewed changes https://github.com/nodejs/node/pull/29020/files/77694f3ec44de81e37d2fc7c73ae806d5044c43d
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
Aug 6, 2019https://github.com/nodejs/node/pull/29020#issuecomment-518694510
https://ci.nodejs.org/job/node-test-pull-request/24861/https://ci.nodejs.org/job/node-test-pull-request/24861/
Please reload this pagehttps://github.com/nodejs/node/pull/29020
https://github.com/targos
targoshttps://github.com/targos
Aug 6, 2019 https://github.com/nodejs/node/pull/29020#pullrequestreview-271464925
View reviewed changes https://github.com/nodejs/node/pull/29020/files/77694f3ec44de81e37d2fc7c73ae806d5044c43d
https://github.com/lpinca
lpincahttps://github.com/lpinca
Aug 6, 2019 https://github.com/nodejs/node/pull/29020#pullrequestreview-271543852
View reviewed changes https://github.com/nodejs/node/pull/29020/files/77694f3ec44de81e37d2fc7c73ae806d5044c43d
https://github.com/jasnell
jasnellhttps://github.com/jasnell
Aug 7, 2019 https://github.com/nodejs/node/pull/29020#pullrequestreview-271681442
View reviewed changes https://github.com/nodejs/node/pull/29020/files/77694f3ec44de81e37d2fc7c73ae806d5044c43d
https://github.com/gengjiawen
gengjiawenhttps://github.com/gengjiawen
Aug 8, 2019 https://github.com/nodejs/node/pull/29020#pullrequestreview-272394456
View reviewed changes https://github.com/nodejs/node/pull/29020/files/77694f3ec44de81e37d2fc7c73ae806d5044c43d
https://github.com/Trott
Trotthttps://github.com/Trott
Aug 8, 2019 https://github.com/nodejs/node/pull/29020#pullrequestreview-272686636
View reviewed changes https://github.com/nodejs/node/pull/29020/files/77694f3ec44de81e37d2fc7c73ae806d5044c43d
https://github.com/Trott
Trotthttps://github.com/Trott
Aug 8, 2019https://github.com/nodejs/node/pull/29020#issuecomment-519588353
44f228chttps://github.com/nodejs/node/commit/44f228c2ccd16a6b70ea0c5e12acd141f5d8549c
Please reload this pagehttps://github.com/nodejs/node/pull/29020
https://github.com/Trott
Trotthttps://github.com/Trott
Aug 8, 2019https://github.com/nodejs/node/pull/29020#event-2543937307
Trotthttps://github.com/Trott
Aug 8, 2019 https://github.com/nodejs/node/pull/29020#ref-commit-44f228c
https://github.com/addaleax
https://github.com/Trott
test: refactor test-sync-io-optionhttps://github.com/Trott/io.js/commit/44f228c2ccd16a6b70ea0c5e12acd141f5d8549c
44f228chttps://github.com/Trott/io.js/commit/44f228c2ccd16a6b70ea0c5e12acd141f5d8549c
nodejs#28913https://github.com/nodejs/node/issues/28913
nodejs#28913https://github.com/nodejs/node/issues/28913
nodejs#29020https://github.com/nodejs/node/pull/29020
targoshttps://github.com/targos
Aug 19, 2019 https://github.com/nodejs/node/pull/29020#ref-commit-43e444b
https://github.com/addaleax
https://github.com/targos
test: refactor test-sync-io-optionhttps://github.com/nodejs/node/commit/43e444b07afa128c740638af817886f3425f5db4
43e444bhttps://github.com/nodejs/node/commit/43e444b07afa128c740638af817886f3425f5db4
#28913https://github.com/nodejs/node/issues/28913
#28913https://github.com/nodejs/node/issues/28913
#29020https://github.com/nodejs/node/pull/29020
https://github.com/targos
targoshttps://github.com/targos
Aug 19, 2019 https://github.com/nodejs/node/pull/29020#ref-pullrequest-482485175
v12.9.0 release proposal #29210 https://github.com/nodejs/node/pull/29210
2019-08-20 Version 12.9.0 (Current) @targos beevelop/docker-android-nodejs#328 https://github.com/beevelop/docker-android-nodejs/issues/328
2019-08-20 Version 12.9.0 (Current) @targos beevelop/docker-android-nodejs#329 https://github.com/beevelop/docker-android-nodejs/issues/329
2019-08-20 Version 12.9.0 (Current) @targos beevelop/docker-android-nodejs#330 https://github.com/beevelop/docker-android-nodejs/issues/330
2019-08-20 Version 12.9.0 (Current) @targos beevelop/docker-nodejs#295 https://github.com/beevelop/docker-nodejs/issues/295
2019-08-20 Version 12.9.0 (Current) @targos beevelop/docker-nodejs#296 https://github.com/beevelop/docker-nodejs/issues/296
2019-08-20 Version 12.9.0 (Current) @targos beevelop/docker-nodejs#297 https://github.com/beevelop/docker-nodejs/issues/297
https://github.co/hiddenchars
https://github.com/nodejs/node/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F29020
https://github.com/jasnell
jasnell https://github.com/jasnell
https://github.com/nodejs/node/pull/29020/files/77694f3ec44de81e37d2fc7c73ae806d5044c43d
https://github.com/Trott
Trott https://github.com/Trott
https://github.com/nodejs/node/pull/29020/files/77694f3ec44de81e37d2fc7c73ae806d5044c43d
https://github.com/lpinca
lpinca https://github.com/lpinca
https://github.com/nodejs/node/pull/29020/files/77694f3ec44de81e37d2fc7c73ae806d5044c43d
https://github.com/targos
targos https://github.com/targos
https://github.com/nodejs/node/pull/29020/files/77694f3ec44de81e37d2fc7c73ae806d5044c43d
https://github.com/cjihrig
cjihrig https://github.com/cjihrig
https://github.com/nodejs/node/pull/29020/files/77694f3ec44de81e37d2fc7c73ae806d5044c43d
https://github.com/gengjiawen
gengjiawen https://github.com/gengjiawen
https://github.com/nodejs/node/pull/29020/files/77694f3ec44de81e37d2fc7c73ae806d5044c43d
cli https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Acli
test https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Atest
Please reload this pagehttps://github.com/nodejs/node/pull/29020
https://github.com/addaleax
https://github.com/nodejs-github-bot
https://github.com/Trott
https://github.com/jasnell
https://github.com/lpinca
https://github.com/targos
https://github.com/cjihrig
https://github.com/gengjiawen
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.