René's URL Explorer Experiment


Title: http: buffer writes while no socket by ronag · Pull Request #29019 · nodejs/node · GitHub

Open Graph Title: http: buffer writes while no socket by ronag · Pull Request #29019 · nodejs/node

X Title: http: buffer writes while no socket by ronag · Pull Request #29019 · nodejs/node

Description: Node.js JavaScript runtime ✨🐢🚀✨. Contribute to nodejs/node development by creating an account on GitHub.

Open Graph Description: We should be buffering writes even while no socket is assigned. Checklist make -j4 test (UNIX), or vcbuild test (Windows) passes tests and/or benchmarks are included documentation is changed o...

X Description: We should be buffering writes even while no socket is assigned. Checklist make -j4 test (UNIX), or vcbuild test (Windows) passes tests and/or benchmarks are included documentation is changed o...

Opengraph URL: https://github.com/nodejs/node/pull/29019

X: @github

direct link

Domain: github.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:104d2201-39f1-7664-ae4a-cf399d44e0cf
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idC9C6:3730CE:475718C:63C0864:6A4F75D4
html-safe-nonce4f33d1d32304d3fdfac6919c4e42a9d1caa472a2c350cc611a8ca2e8ac328010
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJDOUM2OjM3MzBDRTo0NzU3MThDOjYzQzA4NjQ6NkE0Rjc1RDQiLCJ2aXNpdG9yX2lkIjoiMzI4MjQ0MTk1OTM1MzUyMjc2IiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmaccb192cb18fcbe6df06da1e9468c63c6c930b41382bc169829c5b40528a1735be
hovercard-subject-tagpull_request:304726066
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/29019/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/d0e4d149d7ec986ee1fef725591071606bafefc472eecc686bf8ce452bdc252e/nodejs/node/pull/29019
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/d0e4d149d7ec986ee1fef725591071606bafefc472eecc686bf8ce452bdc252e/nodejs/node/pull/29019
og:image:altWe should be buffering writes even while no socket is assigned. Checklist make -j4 test (UNIX), or vcbuild test (Windows) passes tests and/or benchmarks are included documentation is changed o...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernameronag
hostnamegithub.com
expected-hostnamegithub.com
Noneb92d11c0aa4a77d54ef4af1078b6a15fb5a70a215b30c4ecf28889d5a8e656d9
turbo-cache-controlno-cache
go-importgithub.com/nodejs/node git https://github.com/nodejs/node.git
octolytics-dimension-user_id9950313
octolytics-dimension-user_loginnodejs
octolytics-dimension-repository_id27193779
octolytics-dimension-repository_nwonodejs/node
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id27193779
octolytics-dimension-repository_network_root_nwonodejs/node
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release4b249b445842943ed31549e027f57a8ade9881ed
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/nodejs/node/pull/29019#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F29019
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub Copilot appDirect agents from issue to mergehttps://github.com/features/ai/github-app
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
View all resourceshttps://github.com/resources
GitHub SponsorsFund open source developershttps://github.com/open-source/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/open-source/accelerator
GitHub Starshttps://stars.github.com
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F29019
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode
Reloadhttps://github.com/nodejs/node/pull/29019
Reloadhttps://github.com/nodejs/node/pull/29019
Reloadhttps://github.com/nodejs/node/pull/29019
Please reload this pagehttps://github.com/nodejs/node/pull/29019
nodejs https://github.com/nodejs
nodehttps://github.com/nodejs/node
Please reload this pagehttps://github.com/nodejs/node/pull/29019
Notifications https://github.com/login?return_to=%2Fnodejs%2Fnode
Fork 36k https://github.com/login?return_to=%2Fnodejs%2Fnode
Star 118k https://github.com/login?return_to=%2Fnodejs%2Fnode
Code https://github.com/nodejs/node
Issues 1.3k https://github.com/nodejs/node/issues
Pull requests 973 https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects https://github.com/nodejs/node/projects
Security and quality 0 https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
Code https://github.com/nodejs/node
Issues https://github.com/nodejs/node/issues
Pull requests https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects https://github.com/nodejs/node/projects
Security and quality https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
ronaghttps://github.com/ronag
nodejs:masterhttps://github.com/nodejs/node/tree/master
nxtedition:http-buffer-even-while-no-sockethttps://github.com/nxtedition/node/tree/http-buffer-even-while-no-socket
Conversationhttps://github.com/nodejs/node/pull/29019
Commits1 (1)https://github.com/nodejs/node/pull/29019/commits
Checkshttps://github.com/nodejs/node/pull/29019/checks
Files changedhttps://github.com/nodejs/node/pull/29019/files
http: buffer writes while no sockethttps://github.com/nodejs/node/pull/29019#top
ronaghttps://github.com/ronag
nodejs:masterhttps://github.com/nodejs/node/tree/master
nxtedition:http-buffer-even-while-no-sockethttps://github.com/nxtedition/node/tree/http-buffer-even-while-no-socket
https://github.com/ronag
ronaghttps://github.com/ronag
Aug 6, 2019https://github.com/nodejs/node/pull/29019#issue-477392359
Please reload this pagehttps://github.com/nodejs/node/pull/29019
commit guidelineshttps://github.com/nodejs/node/blob/master/doc/guides/contributing/pull-requests.md#commit-message-guidelines
Please reload this pagehttps://github.com/nodejs/node/pull/29019
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
http https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Ahttp
Aug 6, 2019https://github.com/nodejs/node/pull/29019#event-2536835958
https://github.com/ronag
ronaghttps://github.com/ronag
force-pushedhttps://github.com/nodejs/node/compare/7e038a5ebf1f23e2d181063387e00ff79c7ed4e8..6cc9e2ff83fcdbe8739d97efcbf531101be0e0c1
7e038a5https://github.com/nodejs/node/commit/7e038a5ebf1f23e2d181063387e00ff79c7ed4e8
6cc9e2fhttps://github.com/nodejs/node/commit/6cc9e2ff83fcdbe8739d97efcbf531101be0e0c1
Compare https://github.com/nodejs/node/compare/7e038a5ebf1f23e2d181063387e00ff79c7ed4e8..6cc9e2ff83fcdbe8739d97efcbf531101be0e0c1
August 6, 2019 13:50https://github.com/nodejs/node/pull/29019#event-2536845601
https://github.com/ronag
ronaghttps://github.com/ronag
Aug 6, 2019https://github.com/nodejs/node/pull/29019#event-2536856675
https://github.com/ronag
ronaghttps://github.com/ronag
force-pushedhttps://github.com/nodejs/node/compare/6cc9e2ff83fcdbe8739d97efcbf531101be0e0c1..292dac1cb94e541a8fce7ba30932a4b9f0e9289f
6cc9e2fhttps://github.com/nodejs/node/commit/6cc9e2ff83fcdbe8739d97efcbf531101be0e0c1
292dac1https://github.com/nodejs/node/commit/292dac1cb94e541a8fce7ba30932a4b9f0e9289f
Compare https://github.com/nodejs/node/compare/6cc9e2ff83fcdbe8739d97efcbf531101be0e0c1..292dac1cb94e541a8fce7ba30932a4b9f0e9289f
August 6, 2019 13:54https://github.com/nodejs/node/pull/29019#event-2536858833
https://github.com/ronag
ronaghttps://github.com/ronag
Aug 6, 2019 https://github.com/nodejs/node/pull/29019#ref-pullrequest-477382954
http: OutgoingMessage stream properties #29018 https://github.com/nodejs/node/pull/29018
https://github.com/lpinca
lpincahttps://github.com/lpinca
Aug 6, 2019 https://github.com/nodejs/node/pull/29019#pullrequestreview-271551091
View reviewed changes https://github.com/nodejs/node/pull/29019/files
lib/_http_outgoing.jshttps://github.com/nodejs/node/pull/29019/files#diff-48d21edbddb6e855d1ee5716c49bcdc0d913c11ee8a24a98ea7dbc60cd253556
Please reload this pagehttps://github.com/nodejs/node/pull/29019
test/parallel/test-http-outgoing-buffer.jshttps://github.com/nodejs/node/pull/29019/files#diff-9905da9f740336134339001e75495848dcfbcdabf46bab6fa882a99318d1c6d3
Please reload this pagehttps://github.com/nodejs/node/pull/29019
https://github.com/lpinca
lpincahttps://github.com/lpinca
Aug 6, 2019https://github.com/nodejs/node/pull/29019#issuecomment-518802865
Please reload this pagehttps://github.com/nodejs/node/pull/29019
https://github.com/ronag
ronaghttps://github.com/ronag
force-pushedhttps://github.com/nodejs/node/compare/6de19938686bae32f227c50af7f104caeb7febb4..355f5b7e98cc39d48070e60c7b8034b25c5873de
6de1993https://github.com/nodejs/node/commit/6de19938686bae32f227c50af7f104caeb7febb4
355f5b7https://github.com/nodejs/node/commit/355f5b7e98cc39d48070e60c7b8034b25c5873de
Compare https://github.com/nodejs/node/compare/6de19938686bae32f227c50af7f104caeb7febb4..355f5b7e98cc39d48070e60c7b8034b25c5873de
August 6, 2019 23:24https://github.com/nodejs/node/pull/29019#event-2538375763
https://github.com/lpinca
lpincahttps://github.com/lpinca
Aug 7, 2019 https://github.com/nodejs/node/pull/29019#pullrequestreview-271749167
View reviewed changes https://github.com/nodejs/node/pull/29019/files
lib/_http_outgoing.jshttps://github.com/nodejs/node/pull/29019/files#diff-48d21edbddb6e855d1ee5716c49bcdc0d913c11ee8a24a98ea7dbc60cd253556
Please reload this pagehttps://github.com/nodejs/node/pull/29019
https://github.com/lpinca
lpincahttps://github.com/lpinca
Aug 7, 2019 https://github.com/nodejs/node/pull/29019#pullrequestreview-271749692
View reviewed changes https://github.com/nodejs/node/pull/29019/files
test/parallel/test-http-outgoing-buffer.jshttps://github.com/nodejs/node/pull/29019/files#diff-9905da9f740336134339001e75495848dcfbcdabf46bab6fa882a99318d1c6d3
Please reload this pagehttps://github.com/nodejs/node/pull/29019
https://github.com/ronag
ronaghttps://github.com/ronag
force-pushedhttps://github.com/nodejs/node/compare/53d503ba6385b44dee71e793252b59c4f93be0ad..0f8400b9bbaddb396f044fb4303b38c1ab17edaa
53d503bhttps://github.com/nodejs/node/commit/53d503ba6385b44dee71e793252b59c4f93be0ad
0f8400bhttps://github.com/nodejs/node/commit/0f8400b9bbaddb396f044fb4303b38c1ab17edaa
Compare https://github.com/nodejs/node/compare/53d503ba6385b44dee71e793252b59c4f93be0ad..0f8400b9bbaddb396f044fb4303b38c1ab17edaa
August 8, 2019 11:11https://github.com/nodejs/node/pull/29019#event-2542960679
https://github.com/lpinca
lpincahttps://github.com/lpinca
Aug 8, 2019 https://github.com/nodejs/node/pull/29019#pullrequestreview-272799400
View reviewed changes https://github.com/nodejs/node/pull/29019/files
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
Aug 8, 2019https://github.com/nodejs/node/pull/29019#issuecomment-519666695
https://ci.nodejs.org/job/node-test-pull-request/24897/https://ci.nodejs.org/job/node-test-pull-request/24897/
Please reload this pagehttps://github.com/nodejs/node/pull/29019
https://github.com/ronag
http: buffer while no sockethttps://github.com/nodejs/node/pull/29019/commits/d37b21361e7d6076e778186ffe9caf552ac504f6
d37b213https://github.com/nodejs/node/pull/29019/commits/d37b21361e7d6076e778186ffe9caf552ac504f6
https://github.com/ronag
ronaghttps://github.com/ronag
force-pushedhttps://github.com/nodejs/node/compare/0f8400b9bbaddb396f044fb4303b38c1ab17edaa..d37b21361e7d6076e778186ffe9caf552ac504f6
0f8400bhttps://github.com/nodejs/node/commit/0f8400b9bbaddb396f044fb4303b38c1ab17edaa
d37b213https://github.com/nodejs/node/commit/d37b21361e7d6076e778186ffe9caf552ac504f6
Compare https://github.com/nodejs/node/compare/0f8400b9bbaddb396f044fb4303b38c1ab17edaa..d37b21361e7d6076e778186ffe9caf552ac504f6
August 9, 2019 16:02https://github.com/nodejs/node/pull/29019#event-2546939232
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
Aug 9, 2019https://github.com/nodejs/node/pull/29019#issuecomment-520022268
https://ci.nodejs.org/job/node-test-pull-request/24912/https://ci.nodejs.org/job/node-test-pull-request/24912/
Please reload this pagehttps://github.com/nodejs/node/pull/29019
https://github.com/Trott
Trotthttps://github.com/Trott
Aug 9, 2019https://github.com/nodejs/node/pull/29019#issuecomment-520059555
Please reload this pagehttps://github.com/nodejs/node/pull/29019
https://github.com/mcollina
mcollinahttps://github.com/mcollina
Aug 9, 2019 https://github.com/nodejs/node/pull/29019#pullrequestreview-273374295
View reviewed changes https://github.com/nodejs/node/pull/29019/files/d37b21361e7d6076e778186ffe9caf552ac504f6
mcollinahttps://github.com/mcollina
https://github.com/nodejs/node/pull/29019#pullrequestreview-273374295
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/29019
https://github.com/Trott
Trotthttps://github.com/Trott
Aug 9, 2019https://github.com/nodejs/node/pull/29019#issuecomment-520089278
c065773https://github.com/nodejs/node/commit/c065773cc56080b48ff4e29822152679f7db5573
Please reload this pagehttps://github.com/nodejs/node/pull/29019
https://github.com/Trott
Trotthttps://github.com/Trott
Aug 9, 2019https://github.com/nodejs/node/pull/29019#event-2547791719
Trotthttps://github.com/Trott
Aug 9, 2019 https://github.com/nodejs/node/pull/29019#ref-commit-c065773
https://github.com/ronag
https://github.com/Trott
http: buffer writes even while no socket assignedhttps://github.com/Trott/io.js/commit/c065773cc56080b48ff4e29822152679f7db5573
c065773https://github.com/Trott/io.js/commit/c065773cc56080b48ff4e29822152679f7db5573
nodejs#29019https://github.com/nodejs/node/pull/29019
targoshttps://github.com/targos
Aug 19, 2019 https://github.com/nodejs/node/pull/29019#ref-commit-c396b2a
https://github.com/ronag
https://github.com/targos
http: buffer writes even while no socket assignedhttps://github.com/nodejs/node/commit/c396b2a5b25cae7881946df7f756b38580b33003
c396b2ahttps://github.com/nodejs/node/commit/c396b2a5b25cae7881946df7f756b38580b33003
#29019https://github.com/nodejs/node/pull/29019
https://github.com/targos
targoshttps://github.com/targos
Aug 19, 2019 https://github.com/nodejs/node/pull/29019#ref-pullrequest-482485175
v12.9.0 release proposal #29210 https://github.com/nodejs/node/pull/29210
2019-08-20 Version 12.9.0 (Current) @targos beevelop/docker-android-nodejs#328 https://github.com/beevelop/docker-android-nodejs/issues/328
2019-08-20 Version 12.9.0 (Current) @targos beevelop/docker-android-nodejs#329 https://github.com/beevelop/docker-android-nodejs/issues/329
2019-08-20 Version 12.9.0 (Current) @targos beevelop/docker-android-nodejs#330 https://github.com/beevelop/docker-android-nodejs/issues/330
2019-08-20 Version 12.9.0 (Current) @targos beevelop/docker-nodejs#295 https://github.com/beevelop/docker-nodejs/issues/295
2019-08-20 Version 12.9.0 (Current) @targos beevelop/docker-nodejs#296 https://github.com/beevelop/docker-nodejs/issues/296
2019-08-20 Version 12.9.0 (Current) @targos beevelop/docker-nodejs#297 https://github.com/beevelop/docker-nodejs/issues/297
https://github.co/hiddenchars
https://github.com/nodejs/node/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F29019
https://github.com/mcollina
mcollina https://github.com/mcollina
https://github.com/nodejs/node/pull/29019/files/d37b21361e7d6076e778186ffe9caf552ac504f6
https://github.com/lpinca
lpinca https://github.com/lpinca
https://github.com/nodejs/node/pull/29019/files/0f8400b9bbaddb396f044fb4303b38c1ab17edaa
http https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Ahttp
Please reload this pagehttps://github.com/nodejs/node/pull/29019
https://github.com/ronag
https://github.com/lpinca
https://github.com/nodejs-github-bot
https://github.com/Trott
https://github.com/mcollina
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.