René's URL Explorer Experiment


Title: fs: validate fds as int32s by cjihrig · Pull Request #28984 · nodejs/node · GitHub

Open Graph Title: fs: validate fds as int32s by cjihrig · Pull Request #28984 · nodejs/node

X Title: fs: validate fds as int32s by cjihrig · Pull Request #28984 · nodejs/node

Description: Node.js JavaScript runtime ✨🐢🚀✨. Contribute to nodejs/node development by creating an account on GitHub.

Open Graph Description: This commit updates the JS layer's validation of file descriptors to check for int32s >= 0 instead of uint32s. Fixes: #28980 Checklist make -j4 test (UNIX), or vcbuild test (Windows) passe...

X Description: This commit updates the JS layer's validation of file descriptors to check for int32s >= 0 instead of uint32s. Fixes: #28980 Checklist make -j4 test (UNIX), or vcbuild test (Window...

Opengraph URL: https://github.com/nodejs/node/pull/28984

X: @github

direct link

Domain: github.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:af0d98ff-2862-387f-5cd8-12ae39574bad
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-id9BBC:6435C:54F3CF9:77149BE:6A4FA345
html-safe-nonce7186dcd776b0162458769695503f95871bb2fc02808b132f54b41e91ed25ba24
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI5QkJDOjY0MzVDOjU0RjNDRjk6NzcxNDlCRTo2QTRGQTM0NSIsInZpc2l0b3JfaWQiOiI3MTM1NTQ2MDI3NTQ1Njk5MTQxIiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmac88ce523e9e0aa836950b2b82b72bb55ade907027e2d7aac6006e8cc9cd881610
hovercard-subject-tagpull_request:304391192
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/28984/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/d8b20af04b9f2b2302c713f0ca904f08102ba2637544d35eaeeb282aba788fa7/nodejs/node/pull/28984
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/d8b20af04b9f2b2302c713f0ca904f08102ba2637544d35eaeeb282aba788fa7/nodejs/node/pull/28984
og:image:altThis commit updates the JS layer's validation of file descriptors to check for int32s >= 0 instead of uint32s. Fixes: #28980 Checklist make -j4 test (UNIX), or vcbuild test (Windows) passe...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamecjihrig
hostnamegithub.com
expected-hostnamegithub.com
Noneb92d11c0aa4a77d54ef4af1078b6a15fb5a70a215b30c4ecf28889d5a8e656d9
turbo-cache-controlno-cache
go-importgithub.com/nodejs/node git https://github.com/nodejs/node.git
octolytics-dimension-user_id9950313
octolytics-dimension-user_loginnodejs
octolytics-dimension-repository_id27193779
octolytics-dimension-repository_nwonodejs/node
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id27193779
octolytics-dimension-repository_network_root_nwonodejs/node
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release4b249b445842943ed31549e027f57a8ade9881ed
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/nodejs/node/pull/28984#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F28984
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub Copilot appDirect agents from issue to mergehttps://github.com/features/ai/github-app
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
View all resourceshttps://github.com/resources
GitHub SponsorsFund open source developershttps://github.com/open-source/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/open-source/accelerator
GitHub Starshttps://stars.github.com
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F28984
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode
Reloadhttps://github.com/nodejs/node/pull/28984
Reloadhttps://github.com/nodejs/node/pull/28984
Reloadhttps://github.com/nodejs/node/pull/28984
Please reload this pagehttps://github.com/nodejs/node/pull/28984
nodejs https://github.com/nodejs
nodehttps://github.com/nodejs/node
Please reload this pagehttps://github.com/nodejs/node/pull/28984
Notifications https://github.com/login?return_to=%2Fnodejs%2Fnode
Fork 36k https://github.com/login?return_to=%2Fnodejs%2Fnode
Star 118k https://github.com/login?return_to=%2Fnodejs%2Fnode
Code https://github.com/nodejs/node
Issues 1.3k https://github.com/nodejs/node/issues
Pull requests 972 https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects https://github.com/nodejs/node/projects
Security and quality 0 https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
Code https://github.com/nodejs/node
Issues https://github.com/nodejs/node/issues
Pull requests https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects https://github.com/nodejs/node/projects
Security and quality https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
cjihrighttps://github.com/cjihrig
nodejs:masterhttps://github.com/nodejs/node/tree/master
cjihrig:fdshttps://github.com/cjihrig/node/tree/fds
Conversationhttps://github.com/nodejs/node/pull/28984
Commits1 (1)https://github.com/nodejs/node/pull/28984/commits
Checkshttps://github.com/nodejs/node/pull/28984/checks
Files changedhttps://github.com/nodejs/node/pull/28984/files
fs: validate fds as int32shttps://github.com/nodejs/node/pull/28984#top
cjihrighttps://github.com/cjihrig
nodejs:masterhttps://github.com/nodejs/node/tree/master
cjihrig:fdshttps://github.com/cjihrig/node/tree/fds
https://github.com/cjihrig
cjihrighttps://github.com/cjihrig
Aug 5, 2019https://github.com/nodejs/node/pull/28984#issue-476971267
#28980https://github.com/nodejs/node/issues/28980
commit guidelineshttps://github.com/nodejs/node/blob/master/doc/guides/contributing/pull-requests.md#commit-message-guidelines
Please reload this pagehttps://github.com/nodejs/node/pull/28984
https://github.com/cjihrig
fs: validate fds as int32shttps://github.com/nodejs/node/pull/28984/commits/25dd0219495bbe051db6eed699e06f435d4841dd
25dd021https://github.com/nodejs/node/pull/28984/commits/25dd0219495bbe051db6eed699e06f435d4841dd
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
fs https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Afs
Aug 5, 2019https://github.com/nodejs/node/pull/28984#event-2534228182
https://github.com/targos
targoshttps://github.com/targos
Aug 5, 2019 https://github.com/nodejs/node/pull/28984#pullrequestreview-270909117
View reviewed changes https://github.com/nodejs/node/pull/28984/files/25dd0219495bbe051db6eed699e06f435d4841dd
https://github.com/devsnek
devsnekhttps://github.com/devsnek
Aug 5, 2019 https://github.com/nodejs/node/pull/28984#pullrequestreview-270917257
View reviewed changes https://github.com/nodejs/node/pull/28984/files/25dd0219495bbe051db6eed699e06f435d4841dd
https://github.com/bnoordhuis
bnoordhuishttps://github.com/bnoordhuis
Aug 6, 2019 https://github.com/nodejs/node/pull/28984#pullrequestreview-271291758
View reviewed changes https://github.com/nodejs/node/pull/28984/files/25dd0219495bbe051db6eed699e06f435d4841dd
https://github.com/jasnell
jasnellhttps://github.com/jasnell
Aug 7, 2019 https://github.com/nodejs/node/pull/28984#pullrequestreview-271684240
View reviewed changes https://github.com/nodejs/node/pull/28984/files/25dd0219495bbe051db6eed699e06f435d4841dd
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
Aug 7, 2019https://github.com/nodejs/node/pull/28984#issuecomment-519225174
https://ci.nodejs.org/job/node-test-pull-request/24884/https://ci.nodejs.org/job/node-test-pull-request/24884/
Please reload this pagehttps://github.com/nodejs/node/pull/28984
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
Aug 7, 2019https://github.com/nodejs/node/pull/28984#issuecomment-519238355
https://ci.nodejs.org/job/node-test-pull-request/24885/https://ci.nodejs.org/job/node-test-pull-request/24885/
Please reload this pagehttps://github.com/nodejs/node/pull/28984
https://github.com/Trott
Trotthttps://github.com/Trott
Aug 7, 2019 https://github.com/nodejs/node/pull/28984#pullrequestreview-272210425
View reviewed changes https://github.com/nodejs/node/pull/28984/files/25dd0219495bbe051db6eed699e06f435d4841dd
https://github.com/Trott
Trotthttps://github.com/Trott
Aug 7, 2019https://github.com/nodejs/node/pull/28984#issuecomment-519256427
Please reload this pagehttps://github.com/nodejs/node/pull/28984
https://github.com/Trott
Trotthttps://github.com/Trott
Aug 7, 2019https://github.com/nodejs/node/pull/28984#event-2541312217
Trotthttps://github.com/Trott
Aug 7, 2019 https://github.com/nodejs/node/pull/28984#ref-commit-c072a80
https://github.com/cjihrig
https://github.com/Trott
fs: validate fds as int32shttps://github.com/Trott/io.js/commit/c072a807178230948ed40dea0708593663efa0cd
c072a80https://github.com/Trott/io.js/commit/c072a807178230948ed40dea0708593663efa0cd
nodejs#28984https://github.com/nodejs/node/pull/28984
nodejs#28980https://github.com/nodejs/node/issues/28980
https://github.com/cjihrig
cjihrighttps://github.com/cjihrig
August 8, 2019 13:50https://github.com/nodejs/node/pull/28984#event-2543424068
targoshttps://github.com/targos
Aug 19, 2019 https://github.com/nodejs/node/pull/28984#ref-commit-f194626
https://github.com/cjihrig
https://github.com/targos
fs: validate fds as int32shttps://github.com/nodejs/node/commit/f194626ffb9794c9339518c59c789e4c4fd7dc2a
f194626https://github.com/nodejs/node/commit/f194626ffb9794c9339518c59c789e4c4fd7dc2a
#28984https://github.com/nodejs/node/pull/28984
#28980https://github.com/nodejs/node/issues/28980
https://github.com/targos
targoshttps://github.com/targos
Aug 19, 2019 https://github.com/nodejs/node/pull/28984#ref-pullrequest-482485175
v12.9.0 release proposal #29210 https://github.com/nodejs/node/pull/29210
2019-08-20 Version 12.9.0 (Current) @targos beevelop/docker-android-nodejs#328 https://github.com/beevelop/docker-android-nodejs/issues/328
2019-08-20 Version 12.9.0 (Current) @targos beevelop/docker-android-nodejs#329 https://github.com/beevelop/docker-android-nodejs/issues/329
2019-08-20 Version 12.9.0 (Current) @targos beevelop/docker-android-nodejs#330 https://github.com/beevelop/docker-android-nodejs/issues/330
2019-08-20 Version 12.9.0 (Current) @targos beevelop/docker-nodejs#295 https://github.com/beevelop/docker-nodejs/issues/295
2019-08-20 Version 12.9.0 (Current) @targos beevelop/docker-nodejs#296 https://github.com/beevelop/docker-nodejs/issues/296
2019-08-20 Version 12.9.0 (Current) @targos beevelop/docker-nodejs#297 https://github.com/beevelop/docker-nodejs/issues/297
https://github.com/Linkgoron
Linkgoronhttps://github.com/Linkgoron
Mar 25, 2021 https://github.com/nodejs/node/pull/28984#ref-issue-841040833
"fs.fdatasyncSync" results in an abort #37912 https://github.com/nodejs/node/issues/37912
fs.write results in an abort on v10.x #38092 https://github.com/nodejs/node/issues/38092
fs.closeSync results in an abort in v10.x #38193 https://github.com/nodejs/node/issues/38193
Ayase-252https://github.com/Ayase-252
Apr 11, 2021 https://github.com/nodejs/node/pull/28984#ref-commit-1539bc2
https://github.com/cjihrig
https://github.com/Ayase-252
fs: validate fds as int32shttps://github.com/Ayase-252/node/commit/1539bc2de1ab3bb4a00d31cc44f7fbc8c15398e6
1539bc2https://github.com/Ayase-252/node/commit/1539bc2de1ab3bb4a00d31cc44f7fbc8c15398e6
nodejs#28984https://github.com/nodejs/node/pull/28984
nodejs#28980https://github.com/nodejs/node/issues/28980
https://github.co/hiddenchars
https://github.com/nodejs/node/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F28984
https://github.com/bnoordhuis
bnoordhuis https://github.com/bnoordhuis
https://github.com/nodejs/node/pull/28984/files/25dd0219495bbe051db6eed699e06f435d4841dd
https://github.com/jasnell
jasnell https://github.com/jasnell
https://github.com/nodejs/node/pull/28984/files/25dd0219495bbe051db6eed699e06f435d4841dd
https://github.com/Trott
Trott https://github.com/Trott
https://github.com/nodejs/node/pull/28984/files/25dd0219495bbe051db6eed699e06f435d4841dd
https://github.com/targos
targos https://github.com/targos
https://github.com/nodejs/node/pull/28984/files/25dd0219495bbe051db6eed699e06f435d4841dd
https://github.com/devsnek
devsnek https://github.com/devsnek
https://github.com/nodejs/node/pull/28984/files/25dd0219495bbe051db6eed699e06f435d4841dd
fs https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Afs
Abort/core dump in fs.closeSync upon fd of greater than 32 bit https://github.com/nodejs/node/issues/28980
Please reload this pagehttps://github.com/nodejs/node/pull/28984
https://github.com/cjihrig
https://github.com/nodejs-github-bot
https://github.com/Trott
https://github.com/bnoordhuis
https://github.com/jasnell
https://github.com/targos
https://github.com/devsnek
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.