| route-pattern | /_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format) |
| route-controller | voltron_pull_requests_fragments |
| route-action | pull_request_layout |
| fetch-nonce | v2:bf792b2e-0d38-6263-2c5e-c9cc6cc79065 |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | 82FE:7A391:5AD9FD:820970:6A59E4BC |
| html-safe-nonce | 852c2e6ccbd202ac79b5b2aad09cb07228fcfb7ce3c565bd5be11b771ed806ab |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI4MkZFOjdBMzkxOjVBRDlGRDo4MjA5NzA6NkE1OUU0QkMiLCJ2aXNpdG9yX2lkIjoiMjk4NzQzNjI3NzcxNTU1OTYxMiIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9 |
| visitor-hmac | 86fc99ea9e65635d727a73442b9ebfc69ecf57607db353267e3a02d870fd18fe |
| hovercard-subject-tag | pull_request:304230201 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///voltron/pull_requests_fragments/pull_request_layout |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/28970/pull_request_layout |
| twitter:image | https://opengraph.githubassets.com/86b2181dcf2791b03be339688191fed1c54ce25ba6488a02cbb964ee9940437b/nodejs/node/pull/28970 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/86b2181dcf2791b03be339688191fed1c54ce25ba6488a02cbb964ee9940437b/nodejs/node/pull/28970 |
| og:image:alt | Surprisingly this can be quite relevant when working with destroy.
Grammar fix.
Checklist
documentation is changed or added |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | ronag |
| hostname | github.com |
| expected-hostname | github.com |
| None | ba3976babb66479b1c943a8edc0777d96157da48fadc0161f9ddb219deee8353 |
| turbo-cache-control | no-cache |
| go-import | github.com/nodejs/node git https://github.com/nodejs/node.git |
| octolytics-dimension-user_id | 9950313 |
| octolytics-dimension-user_login | nodejs |
| octolytics-dimension-repository_id | 27193779 |
| octolytics-dimension-repository_nwo | nodejs/node |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 27193779 |
| octolytics-dimension-repository_network_root_nwo | nodejs/node |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 26f17126414f953984d8ae42f57c0db48e7dbde3 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| Skip to content | https://github.com/nodejs/node/pull/28970#start-of-content |
|
| https://github.com/ |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F28970 |
| GitHub CopilotWrite better code with AI | https://github.com/features/copilot |
| GitHub Copilot appDirect agents from issue to merge | https://github.com/features/ai/github-app |
| MCP RegistryNewIntegrate external tools | https://github.com/mcp |
| ActionsAutomate any workflow | https://github.com/features/actions |
| CodespacesInstant dev environments | https://github.com/features/codespaces |
| IssuesPlan and track work | https://github.com/features/issues |
| Code ReviewManage code changes | https://github.com/features/code-review |
| GitHub Advanced SecurityFind and fix vulnerabilities | https://github.com/security/advanced-security |
| Code securitySecure your code as you build | https://github.com/security/advanced-security/code-security |
| Secret protectionStop leaks before they start | https://github.com/security/advanced-security/secret-protection |
| Why GitHub | https://github.com/why-github |
| Documentation | https://docs.github.com |
| Blog | https://github.blog |
| Changelog | https://github.blog/changelog |
| Marketplace | https://github.com/marketplace |
| View all features | https://github.com/features |
| Enterprises | https://github.com/enterprise |
| Small and medium teams | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| App Modernization | https://github.com/solutions/use-case/app-modernization |
| DevSecOps | https://github.com/solutions/use-case/devsecops |
| DevOps | https://github.com/solutions/use-case/devops |
| CI/CD | https://github.com/solutions/use-case/ci-cd |
| View all use cases | https://github.com/solutions/use-case |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| View all industries | https://github.com/solutions/industry |
| View all solutions | https://github.com/solutions |
| AI | https://github.com/resources/articles?topic=ai |
| Software Development | https://github.com/resources/articles?topic=software-development |
| DevOps | https://github.com/resources/articles?topic=devops |
| Security | https://github.com/resources/articles?topic=security |
| View all topics | https://github.com/resources/articles |
| Customer stories | https://github.com/customer-stories |
| Events & webinars | https://github.com/resources/events |
| Ebooks & reports | https://github.com/resources/whitepapers |
| Business insights | https://github.com/solutions/executive-insights |
| GitHub Skills | https://skills.github.com |
| Documentation | https://docs.github.com |
| Customer support | https://support.github.com |
| Community forum | https://github.com/orgs/community/discussions |
| Trust center | https://github.com/trust-center |
| Partners | https://github.com/partners |
| View all resources | https://github.com/resources |
| GitHub SponsorsFund open source developers | https://github.com/open-source/sponsors |
| Security Lab | https://securitylab.github.com |
| Maintainer Community | https://maintainers.github.com |
| Accelerator | https://github.com/open-source/accelerator |
| GitHub Stars | https://stars.github.com |
| Archive Program | https://archiveprogram.github.com |
| Topics | https://github.com/topics |
| Trending | https://github.com/trending |
| Collections | https://github.com/collections |
| Enterprise platformAI-powered developer platform | https://github.com/enterprise |
| GitHub Advanced SecurityEnterprise-grade security features | https://github.com/security/advanced-security |
| Copilot for BusinessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/enterprise/premium-support |
| Pricing | https://github.com/pricing |
| Search syntax tips | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
| documentation | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F28970 |
|
Sign up
| https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode |
| Reload | https://github.com/nodejs/node/pull/28970 |
| Reload | https://github.com/nodejs/node/pull/28970 |
| Reload | https://github.com/nodejs/node/pull/28970 |
| Please reload this page | https://github.com/nodejs/node/pull/28970 |
|
nodejs
| https://github.com/nodejs |
| node | https://github.com/nodejs/node |
| Please reload this page | https://github.com/nodejs/node/pull/28970 |
|
Notifications
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Fork
36.1k
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Star
118k
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Code
| https://github.com/nodejs/node |
|
Issues
1.4k
| https://github.com/nodejs/node/issues |
|
Pull requests
1k
| https://github.com/nodejs/node/pulls |
|
Actions
| https://github.com/nodejs/node/actions |
|
Projects
| https://github.com/nodejs/node/projects |
|
Security and quality
0
| https://github.com/nodejs/node/security |
|
Insights
| https://github.com/nodejs/node/pulse |
|
Code
| https://github.com/nodejs/node |
|
Issues
| https://github.com/nodejs/node/issues |
|
Pull requests
| https://github.com/nodejs/node/pulls |
|
Actions
| https://github.com/nodejs/node/actions |
|
Projects
| https://github.com/nodejs/node/projects |
|
Security and quality
| https://github.com/nodejs/node/security |
|
Insights
| https://github.com/nodejs/node/pulse |
| ronag | https://github.com/ronag |
| nodejs:master | https://github.com/nodejs/node/tree/master |
| nxtedition:doc-clarify-destroy-events | https://github.com/nxtedition/node/tree/doc-clarify-destroy-events |
| Conversation | https://github.com/nodejs/node/pull/28970 |
| Commits1 (1) | https://github.com/nodejs/node/pull/28970/commits |
| Checks | https://github.com/nodejs/node/pull/28970/checks |
| Files changed | https://github.com/nodejs/node/pull/28970/files |
| doc: clarify when destroy emits events | https://github.com/nodejs/node/pull/28970#top |
| ronag | https://github.com/ronag |
| nodejs:master | https://github.com/nodejs/node/tree/master |
| nxtedition:doc-clarify-destroy-events | https://github.com/nxtedition/node/tree/doc-clarify-destroy-events |
|
| https://github.com/ronag |
| ronag | https://github.com/ronag |
| Aug 5, 2019 | https://github.com/nodejs/node/pull/28970#issue-476770159 |
| Please reload this page | https://github.com/nodejs/node/pull/28970 |
| Please reload this page | https://github.com/nodejs/node/pull/28970 |
| https://github.com/nodejs-github-bot |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
|
doc
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Adoc |
|
stream
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Astream |
| Aug 5, 2019 | https://github.com/nodejs/node/pull/28970#event-2532982410 |
| https://github.com/ronag |
| ronag | https://github.com/ronag |
| Aug 5, 2019 | https://github.com/nodejs/node/pull/28970#event-2532982582 |
| https://github.com/ronag |
| ronag | https://github.com/ronag |
| force-pushed | https://github.com/nodejs/node/compare/dfe2006b4c13186b5653b9af2b12b112b13b529f..ec68dd8cef25349afc02e8b93984e26d2e437a84 |
| dfe2006 | https://github.com/nodejs/node/commit/dfe2006b4c13186b5653b9af2b12b112b13b529f |
| ec68dd8 | https://github.com/nodejs/node/commit/ec68dd8cef25349afc02e8b93984e26d2e437a84 |
|
Compare
| https://github.com/nodejs/node/compare/dfe2006b4c13186b5653b9af2b12b112b13b529f..ec68dd8cef25349afc02e8b93984e26d2e437a84 |
| August 5, 2019 10:02 | https://github.com/nodejs/node/pull/28970#event-2532983204 |
|
stream: cleanup
#29000
| https://github.com/nodejs/node/issues/29000 |
|
stream: event contract
#29005
| https://github.com/nodejs/node/issues/29005 |
| https://github.com/Trott |
| Trott | https://github.com/Trott |
|
Aug 8, 2019
| https://github.com/nodejs/node/pull/28970#pullrequestreview-272319731 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/28970/files |
| doc/api/stream.md | https://github.com/nodejs/node/pull/28970/files#diff-00d8d040a3fe90e3052af39cb55dc9bcac70539d5d17791449cbfe7e3b55fb90 |
| Please reload this page | https://github.com/nodejs/node/pull/28970 |
| https://github.com/Trott |
| Trott | https://github.com/Trott |
|
Aug 8, 2019
| https://github.com/nodejs/node/pull/28970#pullrequestreview-272319770 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/28970/files |
| doc/api/stream.md | https://github.com/nodejs/node/pull/28970/files#diff-00d8d040a3fe90e3052af39cb55dc9bcac70539d5d17791449cbfe7e3b55fb90 |
| Please reload this page | https://github.com/nodejs/node/pull/28970 |
| https://github.com/ronag |
| ronag | https://github.com/ronag |
| force-pushed | https://github.com/nodejs/node/compare/2b38e1b570e334d0f64e64a5bd7dc6223c2a3d8a..02fe331ada5c30eb58b82993a998e0d0587c5c3b |
| 2b38e1b | https://github.com/nodejs/node/commit/2b38e1b570e334d0f64e64a5bd7dc6223c2a3d8a |
| 02fe331 | https://github.com/nodejs/node/commit/02fe331ada5c30eb58b82993a998e0d0587c5c3b |
|
Compare
| https://github.com/nodejs/node/compare/2b38e1b570e334d0f64e64a5bd7dc6223c2a3d8a..02fe331ada5c30eb58b82993a998e0d0587c5c3b |
| August 8, 2019 11:10 | https://github.com/nodejs/node/pull/28970#event-2542958474 |
| https://github.com/lpinca |
| lpinca | https://github.com/lpinca |
|
Aug 11, 2019
| https://github.com/nodejs/node/pull/28970#pullrequestreview-273477388 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/28970/files |
| doc/api/stream.md | https://github.com/nodejs/node/pull/28970/files#diff-00d8d040a3fe90e3052af39cb55dc9bcac70539d5d17791449cbfe7e3b55fb90 |
| Please reload this page | https://github.com/nodejs/node/pull/28970 |
| doc/api/stream.md | https://github.com/nodejs/node/pull/28970/files#diff-00d8d040a3fe90e3052af39cb55dc9bcac70539d5d17791449cbfe7e3b55fb90 |
| Please reload this page | https://github.com/nodejs/node/pull/28970 |
| https://github.com/ronag |
| ronag | https://github.com/ronag |
| force-pushed | https://github.com/nodejs/node/compare/02fe331ada5c30eb58b82993a998e0d0587c5c3b..cb3db82eefabc9a61fc99e2dd2fae0d3c3284b26 |
| 02fe331 | https://github.com/nodejs/node/commit/02fe331ada5c30eb58b82993a998e0d0587c5c3b |
| cb3db82 | https://github.com/nodejs/node/commit/cb3db82eefabc9a61fc99e2dd2fae0d3c3284b26 |
|
Compare
| https://github.com/nodejs/node/compare/02fe331ada5c30eb58b82993a998e0d0587c5c3b..cb3db82eefabc9a61fc99e2dd2fae0d3c3284b26 |
| August 11, 2019 20:19 | https://github.com/nodejs/node/pull/28970#event-2548807163 |
|
| https://github.com/ronag |
| doc: clarify when destroy emits events | https://github.com/nodejs/node/pull/28970/commits/032753b11d25df75b8f3c775e03c9f7b4cfa4bae |
| 032753b | https://github.com/nodejs/node/pull/28970/commits/032753b11d25df75b8f3c775e03c9f7b4cfa4bae |
| https://github.com/ronag |
| ronag | https://github.com/ronag |
| force-pushed | https://github.com/nodejs/node/compare/cb3db82eefabc9a61fc99e2dd2fae0d3c3284b26..032753b11d25df75b8f3c775e03c9f7b4cfa4bae |
| cb3db82 | https://github.com/nodejs/node/commit/cb3db82eefabc9a61fc99e2dd2fae0d3c3284b26 |
| 032753b | https://github.com/nodejs/node/commit/032753b11d25df75b8f3c775e03c9f7b4cfa4bae |
|
Compare
| https://github.com/nodejs/node/compare/cb3db82eefabc9a61fc99e2dd2fae0d3c3284b26..032753b11d25df75b8f3c775e03c9f7b4cfa4bae |
| August 11, 2019 20:21 | https://github.com/nodejs/node/pull/28970#event-2548808067 |
| https://github.com/Trott |
| Trott | https://github.com/Trott |
| force-pushed | https://github.com/nodejs/node/compare/1ecc406b77ba7573ed0b982a7e6654514c71a7a2..49cf67efd66a94a93f4c91be6c39125e7f896ee7 |
| 1ecc406 | https://github.com/nodejs/node/commit/1ecc406b77ba7573ed0b982a7e6654514c71a7a2 |
| 49cf67e | https://github.com/nodejs/node/commit/49cf67efd66a94a93f4c91be6c39125e7f896ee7 |
|
Compare
| https://github.com/nodejs/node/compare/1ecc406b77ba7573ed0b982a7e6654514c71a7a2..49cf67efd66a94a93f4c91be6c39125e7f896ee7 |
| September 17, 2019 16:51 | https://github.com/nodejs/node/pull/28970#event-2640605051 |
| https://github.com/ronag |
| ronag | https://github.com/ronag |
| Sep 18, 2019 | https://github.com/nodejs/node/pull/28970#issuecomment-532899619 |
| @Trott | https://github.com/Trott |
| Please reload this page | https://github.com/nodejs/node/pull/28970 |
| https://github.com/Trott |
| Trott | https://github.com/Trott |
|
Sep 21, 2019
| https://github.com/nodejs/node/pull/28970#pullrequestreview-291451959 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/28970/files/032753b11d25df75b8f3c775e03c9f7b4cfa4bae |
| https://github.com/Trott |
| Trott | https://github.com/Trott |
| Sep 21, 2019 | https://github.com/nodejs/node/pull/28970#issuecomment-533769949 |
| https://ci.nodejs.org/job/node-test-pull-request-lite-pipeline/3917/ | https://ci.nodejs.org/job/node-test-pull-request-lite-pipeline/3917/ |
| Please reload this page | https://github.com/nodejs/node/pull/28970 |
| https://github.com/Trott |
| Trott | https://github.com/Trott |
|
author ready
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22author%20ready%22 |
| Sep 21, 2019 | https://github.com/nodejs/node/pull/28970#event-2651939466 |
| https://github.com/Trott |
| Trott | https://github.com/Trott |
| Sep 22, 2019 | https://github.com/nodejs/node/pull/28970#issuecomment-533892576 |
| 1fceccb | https://github.com/nodejs/node/commit/1fceccb4cfe250dffe9455fd2158db452376c8cc |
| Please reload this page | https://github.com/nodejs/node/pull/28970 |
| https://github.com/Trott |
| Trott | https://github.com/Trott |
| Sep 22, 2019 | https://github.com/nodejs/node/pull/28970#event-2652738215 |
| Trott | https://github.com/Trott |
|
Sep 22, 2019
| https://github.com/nodejs/node/pull/28970#ref-commit-1fceccb |
|
| https://github.com/ronag |
|
| https://github.com/Trott |
| doc: make minor improvements to stream.md | https://github.com/nodejs/node/commit/1fceccb4cfe250dffe9455fd2158db452376c8cc |
| 1fceccb | https://github.com/nodejs/node/commit/1fceccb4cfe250dffe9455fd2158db452376c8cc |
| #28970 | https://github.com/nodejs/node/pull/28970 |
| targos | https://github.com/targos |
|
Sep 23, 2019
| https://github.com/nodejs/node/pull/28970#ref-commit-15191a6 |
|
| https://github.com/ronag |
|
| https://github.com/targos |
| doc: make minor improvements to stream.md | https://github.com/nodejs/node/commit/15191a61d6a5526e8fc110e26555b8654bbdbb66 |
| 15191a6 | https://github.com/nodejs/node/commit/15191a61d6a5526e8fc110e26555b8654bbdbb66 |
| #28970 | https://github.com/nodejs/node/pull/28970 |
| https://github.com/BridgeAR |
| BridgeAR | https://github.com/BridgeAR |
|
Sep 24, 2019
| https://github.com/nodejs/node/pull/28970#ref-pullrequest-497808887 |
|
v12.11.0 proposal
#29695
| https://github.com/nodejs/node/pull/29695 |
| BridgeAR | https://github.com/BridgeAR |
|
Sep 25, 2019
| https://github.com/nodejs/node/pull/28970#ref-commit-39b1770 |
|
| https://github.com/ronag |
|
| https://github.com/BridgeAR |
| doc: make minor improvements to stream.md | https://github.com/nodejs/node/commit/39b17706eab319e60d368bf573bcca990a50f2b7 |
| 39b1770 | https://github.com/nodejs/node/commit/39b17706eab319e60d368bf573bcca990a50f2b7 |
| #28970 | https://github.com/nodejs/node/pull/28970 |
|
2019-09-25 Version 12.11.0 (Current) @BridgeAR
beevelop/docker-nodejs#301
| https://github.com/beevelop/docker-nodejs/issues/301 |
|
2019-09-25 Version 12.11.0 (Current) @BridgeAR
beevelop/docker-android-nodejs#333
| https://github.com/beevelop/docker-android-nodejs/issues/333 |
|
2019-09-25 Version 12.11.0 (Current) @BridgeAR
beevelop/docker-nodejs#302
| https://github.com/beevelop/docker-nodejs/issues/302 |
|
2019-09-25 Version 12.11.0 (Current) @BridgeAR
beevelop/docker-android-nodejs#334
| https://github.com/beevelop/docker-android-nodejs/issues/334 |
|
2019-09-25 Version 12.11.0 (Current) @BridgeAR
beevelop/docker-nodejs#303
| https://github.com/beevelop/docker-nodejs/issues/303 |
| https://github.com/beevelop |
| beevelop | https://github.com/beevelop |
|
Sep 26, 2019
| https://github.com/nodejs/node/pull/28970#ref-issue-498640068 |
|
2019-09-25 Version 12.11.0 (Current) @BridgeAR
beevelop/docker-android-nodejs#335
| https://github.com/beevelop/docker-android-nodejs/issues/335 |
| https://github.co/hiddenchars |
| https://github.com/nodejs/node/pull/{{ revealButtonHref }} |
| Sign up for free | https://github.com/join?source=comment-repo |
| Sign in to comment | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F28970 |
|
| https://github.com/lpinca |
|
lpinca
| https://github.com/lpinca |
|
| https://github.com/nodejs/node/pull/28970/files/02fe331ada5c30eb58b82993a998e0d0587c5c3b |
|
| https://github.com/Trott |
|
Trott
| https://github.com/Trott |
|
| https://github.com/nodejs/node/pull/28970/files/032753b11d25df75b8f3c775e03c9f7b4cfa4bae |
|
author ready
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22author%20ready%22 |
|
doc
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Adoc |
|
stream
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Astream |
| Please reload this page | https://github.com/nodejs/node/pull/28970 |
|
| https://github.com/ronag |
|
| https://github.com/Trott |
|
| https://github.com/lpinca |
|
| https://github.com/nodejs-github-bot |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |