| route-pattern | /_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format) |
| route-controller | voltron_pull_requests_fragments |
| route-action | pull_request_layout |
| fetch-nonce | v2:bad43d34-d93c-3496-9f9b-5b760cbe7d31 |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | E086:3D00EE:1060D59:1644CD3:6A50782A |
| html-safe-nonce | ed0ae76acc37ce676efd9046b2562bf7f0d67392f305f911e2083a939a50052d |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJFMDg2OjNEMDBFRToxMDYwRDU5OjE2NDRDRDM6NkE1MDc4MkEiLCJ2aXNpdG9yX2lkIjoiMTU3NjQ2Nzc3Nzg0NTIyOTYxMCIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9 |
| visitor-hmac | cf52eb98516f7d1f32e37014c383526b45e60f782c515901c80eaa92ba82c249 |
| hovercard-subject-tag | pull_request:304222782 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///voltron/pull_requests_fragments/pull_request_layout |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/28968/pull_request_layout |
| twitter:image | https://opengraph.githubassets.com/1c297785d17c349c6967838d221f834a4d3f7411d30d8cee1c967888ef12e9fe/nodejs/node/pull/28968 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/1c297785d17c349c6967838d221f834a4d3f7411d30d8cee1c967888ef12e9fe/nodejs/node/pull/28968 |
| og:image:alt | This is just a suggestion. Would like to see if there is any traction behind it.
It is quite common (at least in http and middleware) to check whether any further useful work can be performed on a ... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | ronag |
| hostname | github.com |
| expected-hostname | github.com |
| None | d6dc8294eb500fa36bbc57472d61fe87c522f9c3c1d64f70f4926f66a66a7efb |
| turbo-cache-control | no-cache |
| go-import | github.com/nodejs/node git https://github.com/nodejs/node.git |
| octolytics-dimension-user_id | 9950313 |
| octolytics-dimension-user_login | nodejs |
| octolytics-dimension-repository_id | 27193779 |
| octolytics-dimension-repository_nwo | nodejs/node |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 27193779 |
| octolytics-dimension-repository_network_root_nwo | nodejs/node |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 7ac0ad2f2c7e4b9056617355fd9e33e22b0c8df9 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| Skip to content | https://github.com/nodejs/node/pull/28968#start-of-content |
|
| https://github.com/ |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F28968 |
| GitHub CopilotWrite better code with AI | https://github.com/features/copilot |
| GitHub Copilot appDirect agents from issue to merge | https://github.com/features/ai/github-app |
| MCP RegistryNewIntegrate external tools | https://github.com/mcp |
| ActionsAutomate any workflow | https://github.com/features/actions |
| CodespacesInstant dev environments | https://github.com/features/codespaces |
| IssuesPlan and track work | https://github.com/features/issues |
| Code ReviewManage code changes | https://github.com/features/code-review |
| GitHub Advanced SecurityFind and fix vulnerabilities | https://github.com/security/advanced-security |
| Code securitySecure your code as you build | https://github.com/security/advanced-security/code-security |
| Secret protectionStop leaks before they start | https://github.com/security/advanced-security/secret-protection |
| Why GitHub | https://github.com/why-github |
| Documentation | https://docs.github.com |
| Blog | https://github.blog |
| Changelog | https://github.blog/changelog |
| Marketplace | https://github.com/marketplace |
| View all features | https://github.com/features |
| Enterprises | https://github.com/enterprise |
| Small and medium teams | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| App Modernization | https://github.com/solutions/use-case/app-modernization |
| DevSecOps | https://github.com/solutions/use-case/devsecops |
| DevOps | https://github.com/solutions/use-case/devops |
| CI/CD | https://github.com/solutions/use-case/ci-cd |
| View all use cases | https://github.com/solutions/use-case |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| View all industries | https://github.com/solutions/industry |
| View all solutions | https://github.com/solutions |
| AI | https://github.com/resources/articles?topic=ai |
| Software Development | https://github.com/resources/articles?topic=software-development |
| DevOps | https://github.com/resources/articles?topic=devops |
| Security | https://github.com/resources/articles?topic=security |
| View all topics | https://github.com/resources/articles |
| Customer stories | https://github.com/customer-stories |
| Events & webinars | https://github.com/resources/events |
| Ebooks & reports | https://github.com/resources/whitepapers |
| Business insights | https://github.com/solutions/executive-insights |
| GitHub Skills | https://skills.github.com |
| Documentation | https://docs.github.com |
| Customer support | https://support.github.com |
| Community forum | https://github.com/orgs/community/discussions |
| Trust center | https://github.com/trust-center |
| Partners | https://github.com/partners |
| View all resources | https://github.com/resources |
| GitHub SponsorsFund open source developers | https://github.com/open-source/sponsors |
| Security Lab | https://securitylab.github.com |
| Maintainer Community | https://maintainers.github.com |
| Accelerator | https://github.com/open-source/accelerator |
| GitHub Stars | https://stars.github.com |
| Archive Program | https://archiveprogram.github.com |
| Topics | https://github.com/topics |
| Trending | https://github.com/trending |
| Collections | https://github.com/collections |
| Enterprise platformAI-powered developer platform | https://github.com/enterprise |
| GitHub Advanced SecurityEnterprise-grade security features | https://github.com/security/advanced-security |
| Copilot for BusinessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/enterprise/premium-support |
| Pricing | https://github.com/pricing |
| Search syntax tips | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
| documentation | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F28968 |
|
Sign up
| https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode |
| Reload | https://github.com/nodejs/node/pull/28968 |
| Reload | https://github.com/nodejs/node/pull/28968 |
| Reload | https://github.com/nodejs/node/pull/28968 |
| Please reload this page | https://github.com/nodejs/node/pull/28968 |
|
nodejs
| https://github.com/nodejs |
| node | https://github.com/nodejs/node |
| Please reload this page | https://github.com/nodejs/node/pull/28968 |
|
Notifications
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Fork
36k
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Star
118k
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Code
| https://github.com/nodejs/node |
|
Issues
1.3k
| https://github.com/nodejs/node/issues |
|
Pull requests
979
| https://github.com/nodejs/node/pulls |
|
Actions
| https://github.com/nodejs/node/actions |
|
Projects
| https://github.com/nodejs/node/projects |
|
Security and quality
0
| https://github.com/nodejs/node/security |
|
Insights
| https://github.com/nodejs/node/pulse |
|
Code
| https://github.com/nodejs/node |
|
Issues
| https://github.com/nodejs/node/issues |
|
Pull requests
| https://github.com/nodejs/node/pulls |
|
Actions
| https://github.com/nodejs/node/actions |
|
Projects
| https://github.com/nodejs/node/projects |
|
Security and quality
| https://github.com/nodejs/node/security |
|
Insights
| https://github.com/nodejs/node/pulse |
| ronag | https://github.com/ronag |
| nodejs:master | https://github.com/nodejs/node/tree/master |
| nxtedition:stream-writablecomplete | https://github.com/nxtedition/node/tree/stream-writablecomplete |
| Conversation | https://github.com/nodejs/node/pull/28968 |
| Commits1 (1) | https://github.com/nodejs/node/pull/28968/commits |
| Checks | https://github.com/nodejs/node/pull/28968/checks |
| Files changed | https://github.com/nodejs/node/pull/28968/files |
| stream: writableComplete | https://github.com/nodejs/node/pull/28968#top |
| ronag | https://github.com/ronag |
| nodejs:master | https://github.com/nodejs/node/tree/master |
| nxtedition:stream-writablecomplete | https://github.com/nxtedition/node/tree/stream-writablecomplete |
|
| https://github.com/ronag |
| ronag | https://github.com/ronag |
| Aug 5, 2019 | https://github.com/nodejs/node/pull/28968#issue-476759744 |
| Please reload this page | https://github.com/nodejs/node/pull/28968 |
| https://github.com/nodejs/node/blob/master/lib/internal/http2/compat.js#L304 | https://github.com/nodejs/node/blob/master/lib/internal/http2/compat.js#L304 |
| #28628 | https://github.com/nodejs/node/pull/28628 |
| commit guidelines | https://github.com/nodejs/node/blob/master/doc/guides/contributing/pull-requests.md#commit-message-guidelines |
| Please reload this page | https://github.com/nodejs/node/pull/28968 |
| https://github.com/nodejs-github-bot |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
|
stream
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Astream |
| Aug 5, 2019 | https://github.com/nodejs/node/pull/28968#event-2532926828 |
| https://github.com/ronag |
| ronag | https://github.com/ronag |
| Aug 5, 2019 | https://github.com/nodejs/node/pull/28968#issuecomment-518164316 |
| @mcollina | https://github.com/mcollina |
| Please reload this page | https://github.com/nodejs/node/pull/28968 |
| https://github.com/ronag |
| ronag | https://github.com/ronag |
| force-pushed | https://github.com/nodejs/node/compare/bd7ad6f9b9217244bcae7a1df0f793921700e7ee..3999edb03ad71b517ea265329f755341356198e4 |
| bd7ad6f | https://github.com/nodejs/node/commit/bd7ad6f9b9217244bcae7a1df0f793921700e7ee |
| 3999edb | https://github.com/nodejs/node/commit/3999edb03ad71b517ea265329f755341356198e4 |
|
Compare
| https://github.com/nodejs/node/compare/bd7ad6f9b9217244bcae7a1df0f793921700e7ee..3999edb03ad71b517ea265329f755341356198e4 |
| August 5, 2019 09:44 | https://github.com/nodejs/node/pull/28968#event-2532928769 |
| https://github.com/ronag |
| ronag | https://github.com/ronag |
|
Aug 5, 2019
| https://github.com/nodejs/node/pull/28968#ref-pullrequest-466495161 |
|
http: add complete property
#28628
| https://github.com/nodejs/node/pull/28628 |
|
| https://github.com/ronag |
| stream: writableComplete | https://github.com/nodejs/node/pull/28968/commits/54b2d81b0fa737a7df36874c6b99aedbc70da080 |
| 54b2d81 | https://github.com/nodejs/node/pull/28968/commits/54b2d81b0fa737a7df36874c6b99aedbc70da080 |
| https://github.com/ronag |
| ronag | https://github.com/ronag |
| force-pushed | https://github.com/nodejs/node/compare/3999edb03ad71b517ea265329f755341356198e4..54b2d81b0fa737a7df36874c6b99aedbc70da080 |
| 3999edb | https://github.com/nodejs/node/commit/3999edb03ad71b517ea265329f755341356198e4 |
| 54b2d81 | https://github.com/nodejs/node/commit/54b2d81b0fa737a7df36874c6b99aedbc70da080 |
|
Compare
| https://github.com/nodejs/node/compare/3999edb03ad71b517ea265329f755341356198e4..54b2d81b0fa737a7df36874c6b99aedbc70da080 |
| August 5, 2019 09:53 | https://github.com/nodejs/node/pull/28968#event-2532956238 |
| https://github.com/mcollina |
| mcollina | https://github.com/mcollina |
| Aug 5, 2019 | https://github.com/nodejs/node/pull/28968#issuecomment-518233076 |
| Please reload this page | https://github.com/nodejs/node/pull/28968 |
| https://github.com/ronag |
| ronag | https://github.com/ronag |
| Aug 5, 2019 | https://github.com/nodejs/node/pull/28968#issuecomment-518240996 |
| @mcollina | https://github.com/mcollina |
| Please reload this page | https://github.com/nodejs/node/pull/28968 |
| https://github.com/Trott |
| Trott | https://github.com/Trott |
| Aug 8, 2019 | https://github.com/nodejs/node/pull/28968#issuecomment-519342409 |
| Please reload this page | https://github.com/nodejs/node/pull/28968 |
| https://github.com/mcollina |
| mcollina | https://github.com/mcollina |
|
Aug 9, 2019
| https://github.com/nodejs/node/pull/28968#pullrequestreview-273037974 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/28968/files/54b2d81b0fa737a7df36874c6b99aedbc70da080 |
| mcollina | https://github.com/mcollina |
| https://github.com/nodejs/node/pull/28968#pullrequestreview-273037974 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/28968 |
| https://github.com/ronag |
| ronag | https://github.com/ronag |
| Aug 24, 2019 | https://github.com/nodejs/node/pull/28968#issuecomment-524549683 |
| Please reload this page | https://github.com/nodejs/node/pull/28968 |
| https://github.com/ronag |
| ronag | https://github.com/ronag |
| Aug 24, 2019 | https://github.com/nodejs/node/pull/28968#event-2581407980 |
| https://github.co/hiddenchars |
| https://github.com/nodejs/node/pull/{{ revealButtonHref }} |
| Sign up for free | https://github.com/join?source=comment-repo |
| Sign in to comment | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F28968 |
|
| https://github.com/mcollina |
|
mcollina
| https://github.com/mcollina |
|
| https://github.com/nodejs/node/pull/28968/files/54b2d81b0fa737a7df36874c6b99aedbc70da080 |
|
stream
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Astream |
| Please reload this page | https://github.com/nodejs/node/pull/28968 |
|
| https://github.com/ronag |
|
| https://github.com/mcollina |
|
| https://github.com/Trott |
|
| https://github.com/nodejs-github-bot |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |