René's URL Explorer Experiment


Title: Refine package name validations in esm resolver by guybedford · Pull Request #28965 · nodejs/node · GitHub

Open Graph Title: Refine package name validations in esm resolver by guybedford · Pull Request #28965 · nodejs/node

X Title: Refine package name validations in esm resolver by guybedford · Pull Request #28965 · nodejs/node

Description: Node.js JavaScript runtime ✨🐢🚀✨. Contribute to nodejs/node development by creating an account on GitHub.

Open Graph Description: This ensures that the way package name parsing is done in the ESM resolver is consistent and well-defined based on the rules: Package name must start with @ and contain a separator, or not start w...

X Description: This ensures that the way package name parsing is done in the ESM resolver is consistent and well-defined based on the rules: Package name must start with @ and contain a separator, or not start w...

Opengraph URL: https://github.com/nodejs/node/pull/28965

X: @github

direct link

Domain: github.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:f0feb10d-3948-5853-c59b-d1b952f67ee3
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idB66C:12F35E:F4F0FA:15A3D24:6A4F567D
html-safe-nonce7504cfa5c17737a72292a74cb224dd0d9368f50200c70d0895b1ac3afbae8d50
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJCNjZDOjEyRjM1RTpGNEYwRkE6MTVBM0QyNDo2QTRGNTY3RCIsInZpc2l0b3JfaWQiOiIyOTkxNjQwNjc3MDM1NDk3MDg1IiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmac47cb1ed2dbac322fb8219ff6288949bdff7251b2c36b0062993ec747d3ebc9a5
hovercard-subject-tagpull_request:304160162
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/28965/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/aaea3779a0f6fed3c1eca80f8963087caed6fddc27ae6ebafcea1b072af22b5f/nodejs/node/pull/28965
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/aaea3779a0f6fed3c1eca80f8963087caed6fddc27ae6ebafcea1b072af22b5f/nodejs/node/pull/28965
og:image:altThis ensures that the way package name parsing is done in the ESM resolver is consistent and well-defined based on the rules: Package name must start with @ and contain a separator, or not start w...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernameguybedford
hostnamegithub.com
expected-hostnamegithub.com
Noneb92d11c0aa4a77d54ef4af1078b6a15fb5a70a215b30c4ecf28889d5a8e656d9
turbo-cache-controlno-cache
go-importgithub.com/nodejs/node git https://github.com/nodejs/node.git
octolytics-dimension-user_id9950313
octolytics-dimension-user_loginnodejs
octolytics-dimension-repository_id27193779
octolytics-dimension-repository_nwonodejs/node
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id27193779
octolytics-dimension-repository_network_root_nwonodejs/node
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release4b249b445842943ed31549e027f57a8ade9881ed
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/nodejs/node/pull/28965#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F28965
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub Copilot appDirect agents from issue to mergehttps://github.com/features/ai/github-app
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
View all resourceshttps://github.com/resources
GitHub SponsorsFund open source developershttps://github.com/open-source/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/open-source/accelerator
GitHub Starshttps://stars.github.com
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F28965
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode
Reloadhttps://github.com/nodejs/node/pull/28965
Reloadhttps://github.com/nodejs/node/pull/28965
Reloadhttps://github.com/nodejs/node/pull/28965
Please reload this pagehttps://github.com/nodejs/node/pull/28965
nodejs https://github.com/nodejs
nodehttps://github.com/nodejs/node
Please reload this pagehttps://github.com/nodejs/node/pull/28965
Notifications https://github.com/login?return_to=%2Fnodejs%2Fnode
Fork 36k https://github.com/login?return_to=%2Fnodejs%2Fnode
Star 118k https://github.com/login?return_to=%2Fnodejs%2Fnode
Code https://github.com/nodejs/node
Issues 1.3k https://github.com/nodejs/node/issues
Pull requests 970 https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects https://github.com/nodejs/node/projects
Security and quality 0 https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
Code https://github.com/nodejs/node
Issues https://github.com/nodejs/node/issues
Pull requests https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects https://github.com/nodejs/node/projects
Security and quality https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
guybedfordhttps://github.com/guybedford
nodejs:masterhttps://github.com/nodejs/node/tree/master
guybedford:pkgnamehttps://github.com/guybedford/node/tree/pkgname
Conversationhttps://github.com/nodejs/node/pull/28965
Commits3 (3)https://github.com/nodejs/node/pull/28965/commits
Checkshttps://github.com/nodejs/node/pull/28965/checks
Files changedhttps://github.com/nodejs/node/pull/28965/files
Refine package name validations in esm resolverhttps://github.com/nodejs/node/pull/28965#top
guybedfordhttps://github.com/guybedford
nodejs:masterhttps://github.com/nodejs/node/tree/master
guybedford:pkgnamehttps://github.com/guybedford/node/tree/pkgname
https://github.com/guybedford
guybedfordhttps://github.com/guybedford
Aug 5, 2019https://github.com/nodejs/node/pull/28965#issue-476680741
Please reload this pagehttps://github.com/nodejs/node/pull/28965
commit guidelineshttps://github.com/nodejs/node/blob/master/doc/guides/contributing/pull-requests.md#commit-message-guidelines
Please reload this pagehttps://github.com/nodejs/node/pull/28965
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
c++ https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Ac%2B%2B
Aug 5, 2019https://github.com/nodejs/node/pull/28965#event-2532443214
https://github.com/guybedford
guybedfordhttps://github.com/guybedford
hybristhttps://github.com/hybrist
August 5, 2019 06:34https://github.com/nodejs/node/pull/28965#event-2532443216
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
esm https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aesm
Aug 5, 2019https://github.com/nodejs/node/pull/28965#event-2533152053
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
Aug 5, 2019 https://github.com/nodejs/node/pull/28965#pullrequestreview-270700814
View reviewed changes https://github.com/nodejs/node/pull/28965/files
https://github.com/hybrist
hybristhttps://github.com/hybrist
Aug 5, 2019 https://github.com/nodejs/node/pull/28965#pullrequestreview-270836161
View reviewed changes https://github.com/nodejs/node/pull/28965/files
lib/internal/modules/cjs/loader.jshttps://github.com/nodejs/node/pull/28965/files#diff-5b5902273122e094ff474fda358605ffa45a4a58b51cd0bf4c1acb93779df142
Please reload this pagehttps://github.com/nodejs/node/pull/28965
test/es-module/test-esm-pkgname.mjshttps://github.com/nodejs/node/pull/28965/files#diff-b24dafb047426b4d7dbbb4a865c1f9353bcbd629ec2ea60819011e82778d598b
hybristhttps://github.com/hybrist
Aug 5, 2019https://github.com/nodejs/node/pull/28965#discussion_r310660079
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/28965
guybedfordhttps://github.com/guybedford
Aug 6, 2019https://github.com/nodejs/node/pull/28965#discussion_r310845213
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/28965
hybristhttps://github.com/hybrist
Aug 6, 2019https://github.com/nodejs/node/pull/28965#discussion_r310859787
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/28965
guybedfordhttps://github.com/guybedford
Aug 6, 2019https://github.com/nodejs/node/pull/28965#discussion_r310860658
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/28965
hybristhttps://github.com/hybrist
Aug 6, 2019https://github.com/nodejs/node/pull/28965#discussion_r310861939
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/28965
guybedfordhttps://github.com/guybedford
Aug 6, 2019https://github.com/nodejs/node/pull/28965#discussion_r310862647
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/28965
hybristhttps://github.com/hybrist
Aug 6, 2019https://github.com/nodejs/node/pull/28965#discussion_r310863503
Please reload this pagehttps://github.com/nodejs/node/pull/28965
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/28965
https://github.com/guybedford
module: refine package name validationhttps://github.com/nodejs/node/pull/28965/commits/4aaf0858b377fca0e17e662fcfcb89742614e2cf
4aaf085https://github.com/nodejs/node/pull/28965/commits/4aaf0858b377fca0e17e662fcfcb89742614e2cf
https://github.com/guybedford
guybedfordhttps://github.com/guybedford
force-pushedhttps://github.com/nodejs/node/compare/38fe5cc0af02985ed6a5c985c5b7e1a22dac4248..acfad9dfea54bae012dc84897fb605a064f52a76
38fe5cchttps://github.com/nodejs/node/commit/38fe5cc0af02985ed6a5c985c5b7e1a22dac4248
acfad9dhttps://github.com/nodejs/node/commit/acfad9dfea54bae012dc84897fb605a064f52a76
Compare https://github.com/nodejs/node/compare/38fe5cc0af02985ed6a5c985c5b7e1a22dac4248..acfad9dfea54bae012dc84897fb605a064f52a76
August 6, 2019 01:01https://github.com/nodejs/node/pull/28965#event-2535143085
https://github.com/guybedford
guybedfordhttps://github.com/guybedford
hybristhttps://github.com/hybrist
August 6, 2019 01:03https://github.com/nodejs/node/pull/28965#event-2535145464
https://github.com/guybedford
pr feedbackhttps://github.com/nodejs/node/pull/28965/commits/7bbe46635357567ee282dc0dd3d4e31207f80579
7bbe466https://github.com/nodejs/node/pull/28965/commits/7bbe46635357567ee282dc0dd3d4e31207f80579
https://github.com/guybedford
guybedfordhttps://github.com/guybedford
force-pushedhttps://github.com/nodejs/node/compare/acfad9dfea54bae012dc84897fb605a064f52a76..7bbe46635357567ee282dc0dd3d4e31207f80579
acfad9dhttps://github.com/nodejs/node/commit/acfad9dfea54bae012dc84897fb605a064f52a76
7bbe466https://github.com/nodejs/node/commit/7bbe46635357567ee282dc0dd3d4e31207f80579
Compare https://github.com/nodejs/node/compare/acfad9dfea54bae012dc84897fb605a064f52a76..7bbe46635357567ee282dc0dd3d4e31207f80579
August 6, 2019 01:07https://github.com/nodejs/node/pull/28965#event-2535150247
https://github.com/hybrist
hybristhttps://github.com/hybrist
Aug 6, 2019 https://github.com/nodejs/node/pull/28965#pullrequestreview-271088425
View reviewed changes https://github.com/nodejs/node/pull/28965/files/7bbe46635357567ee282dc0dd3d4e31207f80579
hybristhttps://github.com/hybrist
https://github.com/nodejs/node/pull/28965#pullrequestreview-271088425
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/28965
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
Aug 6, 2019https://github.com/nodejs/node/pull/28965#issuecomment-518472385
https://ci.nodejs.org/job/node-test-pull-request/24851/https://ci.nodejs.org/job/node-test-pull-request/24851/
Please reload this pagehttps://github.com/nodejs/node/pull/28965
https://github.com/hybrist
hybristhttps://github.com/hybrist
author ready https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22author%20ready%22
Aug 6, 2019https://github.com/nodejs/node/pull/28965#event-2535258704
https://github.com/guybedford
fixup packageSubpath validationshttps://github.com/nodejs/node/pull/28965/commits/b5aaeaf1fb0530acf7f47ffa416c4b15c9548750
b5aaeafhttps://github.com/nodejs/node/pull/28965/commits/b5aaeaf1fb0530acf7f47ffa416c4b15c9548750
https://github.com/guybedford
guybedfordhttps://github.com/guybedford
force-pushedhttps://github.com/nodejs/node/compare/2193e39f66399fa7d07edced86ae06faa9f60482..b5aaeaf1fb0530acf7f47ffa416c4b15c9548750
2193e39https://github.com/nodejs/node/commit/2193e39f66399fa7d07edced86ae06faa9f60482
b5aaeafhttps://github.com/nodejs/node/commit/b5aaeaf1fb0530acf7f47ffa416c4b15c9548750
Compare https://github.com/nodejs/node/compare/2193e39f66399fa7d07edced86ae06faa9f60482..b5aaeaf1fb0530acf7f47ffa416c4b15c9548750
August 6, 2019 10:05https://github.com/nodejs/node/pull/28965#event-2536207413
https://github.com/Trott
Trotthttps://github.com/Trott
Aug 6, 2019 https://github.com/nodejs/node/pull/28965#pullrequestreview-271583574
View reviewed changes https://github.com/nodejs/node/pull/28965/files/b5aaeaf1fb0530acf7f47ffa416c4b15c9548750
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
Aug 6, 2019https://github.com/nodejs/node/pull/28965#issuecomment-518823342
https://ci.nodejs.org/job/node-test-pull-request/24866/https://ci.nodejs.org/job/node-test-pull-request/24866/
Please reload this pagehttps://github.com/nodejs/node/pull/28965
https://github.com/Trott
Trotthttps://github.com/Trott
Aug 8, 2019https://github.com/nodejs/node/pull/28965#issuecomment-519343232
Please reload this pagehttps://github.com/nodejs/node/pull/28965
https://github.com/Trott
Trotthttps://github.com/Trott
Aug 8, 2019https://github.com/nodejs/node/pull/28965#event-2541925100
Trotthttps://github.com/Trott
Aug 8, 2019 https://github.com/nodejs/node/pull/28965#ref-commit-0e03c44
https://github.com/guybedford
https://github.com/Trott
module: refine package name validationhttps://github.com/Trott/io.js/commit/0e03c449e35e4951e9e9c962ff279ec271e62010
0e03c44https://github.com/Trott/io.js/commit/0e03c449e35e4951e9e9c962ff279ec271e62010
nodejs#28965https://github.com/nodejs/node/pull/28965
https://github.com/guybedford
guybedfordhttps://github.com/guybedford
August 8, 2019 02:58https://github.com/nodejs/node/pull/28965#event-2541926957
targoshttps://github.com/targos
Aug 19, 2019 https://github.com/nodejs/node/pull/28965#ref-commit-491b46d
https://github.com/guybedford
https://github.com/targos
module: refine package name validationhttps://github.com/nodejs/node/commit/491b46d605c0bc127fc98104b15b926dcffc92b5
491b46dhttps://github.com/nodejs/node/commit/491b46d605c0bc127fc98104b15b926dcffc92b5
#28965https://github.com/nodejs/node/pull/28965
https://github.com/targos
targoshttps://github.com/targos
Aug 19, 2019 https://github.com/nodejs/node/pull/28965#ref-pullrequest-482485175
v12.9.0 release proposal #29210 https://github.com/nodejs/node/pull/29210
2019-08-20 Version 12.9.0 (Current) @targos beevelop/docker-android-nodejs#328 https://github.com/beevelop/docker-android-nodejs/issues/328
2019-08-20 Version 12.9.0 (Current) @targos beevelop/docker-android-nodejs#329 https://github.com/beevelop/docker-android-nodejs/issues/329
2019-08-20 Version 12.9.0 (Current) @targos beevelop/docker-android-nodejs#330 https://github.com/beevelop/docker-android-nodejs/issues/330
2019-08-20 Version 12.9.0 (Current) @targos beevelop/docker-nodejs#295 https://github.com/beevelop/docker-nodejs/issues/295
2019-08-20 Version 12.9.0 (Current) @targos beevelop/docker-nodejs#296 https://github.com/beevelop/docker-nodejs/issues/296
https://github.com/beevelop
beevelophttps://github.com/beevelop
Aug 20, 2019 https://github.com/nodejs/node/pull/28965#ref-issue-483088900
2019-08-20 Version 12.9.0 (Current) @targos beevelop/docker-nodejs#297 https://github.com/beevelop/docker-nodejs/issues/297
https://github.co/hiddenchars
https://github.com/nodejs/node/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F28965
https://github.com/hybrist
hybrist https://github.com/hybrist
https://github.com/nodejs/node/pull/28965/files/7bbe46635357567ee282dc0dd3d4e31207f80579
https://github.com/Trott
Trott https://github.com/Trott
https://github.com/nodejs/node/pull/28965/files/b5aaeaf1fb0530acf7f47ffa416c4b15c9548750
https://github.com/addaleax
addaleax https://github.com/addaleax
https://github.com/nodejs/node/pull/28965/files/2fb663935fac3707e3005d57a54921801950ab69
author ready https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22author%20ready%22
c++ https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Ac%2B%2B
esm https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aesm
Please reload this pagehttps://github.com/nodejs/node/pull/28965
https://github.com/guybedford
https://github.com/nodejs-github-bot
https://github.com/Trott
https://github.com/hybrist
https://github.com/addaleax
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.