| route-pattern | /_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format) |
| route-controller | voltron_pull_requests_fragments |
| route-action | pull_request_layout |
| fetch-nonce | v2:51fa91db-8cac-ffd4-5f39-eff3843c58ac |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | B11A:8A2B5:3573720:4B0D997:6A4F8D9E |
| html-safe-nonce | 824e4f5eb91f4a2339ede852951612e64a02886c052b78cdc30f6c837f1c178f |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJCMTFBOjhBMkI1OjM1NzM3MjA6NEIwRDk5Nzo2QTRGOEQ5RSIsInZpc2l0b3JfaWQiOiIzODczNzIwNzc1MTU3NDUyMTkwIiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0= |
| visitor-hmac | 36996137b8b61828ee1443f3afc14cd7444bf545bc0155ef94a0f0f6ff21a503 |
| hovercard-subject-tag | pull_request:304027297 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///voltron/pull_requests_fragments/pull_request_layout |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/28953/pull_request_layout |
| twitter:image | https://opengraph.githubassets.com/1c7a0dafeab57924a580278a039cca3da7cf2495eeafb8ca5fa3acac5c63f8b9/nodejs/node/pull/28953 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/1c7a0dafeab57924a580278a039cca3da7cf2495eeafb8ca5fa3acac5c63f8b9/nodejs/node/pull/28953 |
| og:image:alt | As readable.unshift() share implementation with readable.push() it makes sense to make the doc similar.
Checklist
documentation is changed or added
commit message follows [commit guidelines](htt... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | EduardoRFS |
| hostname | github.com |
| expected-hostname | github.com |
| None | b92d11c0aa4a77d54ef4af1078b6a15fb5a70a215b30c4ecf28889d5a8e656d9 |
| turbo-cache-control | no-cache |
| go-import | github.com/nodejs/node git https://github.com/nodejs/node.git |
| octolytics-dimension-user_id | 9950313 |
| octolytics-dimension-user_login | nodejs |
| octolytics-dimension-repository_id | 27193779 |
| octolytics-dimension-repository_nwo | nodejs/node |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 27193779 |
| octolytics-dimension-repository_network_root_nwo | nodejs/node |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 4b249b445842943ed31549e027f57a8ade9881ed |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| Skip to content | https://github.com/nodejs/node/pull/28953#start-of-content |
|
| https://github.com/ |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F28953 |
| GitHub CopilotWrite better code with AI | https://github.com/features/copilot |
| GitHub Copilot appDirect agents from issue to merge | https://github.com/features/ai/github-app |
| MCP RegistryNewIntegrate external tools | https://github.com/mcp |
| ActionsAutomate any workflow | https://github.com/features/actions |
| CodespacesInstant dev environments | https://github.com/features/codespaces |
| IssuesPlan and track work | https://github.com/features/issues |
| Code ReviewManage code changes | https://github.com/features/code-review |
| GitHub Advanced SecurityFind and fix vulnerabilities | https://github.com/security/advanced-security |
| Code securitySecure your code as you build | https://github.com/security/advanced-security/code-security |
| Secret protectionStop leaks before they start | https://github.com/security/advanced-security/secret-protection |
| Why GitHub | https://github.com/why-github |
| Documentation | https://docs.github.com |
| Blog | https://github.blog |
| Changelog | https://github.blog/changelog |
| Marketplace | https://github.com/marketplace |
| View all features | https://github.com/features |
| Enterprises | https://github.com/enterprise |
| Small and medium teams | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| App Modernization | https://github.com/solutions/use-case/app-modernization |
| DevSecOps | https://github.com/solutions/use-case/devsecops |
| DevOps | https://github.com/solutions/use-case/devops |
| CI/CD | https://github.com/solutions/use-case/ci-cd |
| View all use cases | https://github.com/solutions/use-case |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| View all industries | https://github.com/solutions/industry |
| View all solutions | https://github.com/solutions |
| AI | https://github.com/resources/articles?topic=ai |
| Software Development | https://github.com/resources/articles?topic=software-development |
| DevOps | https://github.com/resources/articles?topic=devops |
| Security | https://github.com/resources/articles?topic=security |
| View all topics | https://github.com/resources/articles |
| Customer stories | https://github.com/customer-stories |
| Events & webinars | https://github.com/resources/events |
| Ebooks & reports | https://github.com/resources/whitepapers |
| Business insights | https://github.com/solutions/executive-insights |
| GitHub Skills | https://skills.github.com |
| Documentation | https://docs.github.com |
| Customer support | https://support.github.com |
| Community forum | https://github.com/orgs/community/discussions |
| Trust center | https://github.com/trust-center |
| Partners | https://github.com/partners |
| View all resources | https://github.com/resources |
| GitHub SponsorsFund open source developers | https://github.com/open-source/sponsors |
| Security Lab | https://securitylab.github.com |
| Maintainer Community | https://maintainers.github.com |
| Accelerator | https://github.com/open-source/accelerator |
| GitHub Stars | https://stars.github.com |
| Archive Program | https://archiveprogram.github.com |
| Topics | https://github.com/topics |
| Trending | https://github.com/trending |
| Collections | https://github.com/collections |
| Enterprise platformAI-powered developer platform | https://github.com/enterprise |
| GitHub Advanced SecurityEnterprise-grade security features | https://github.com/security/advanced-security |
| Copilot for BusinessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/enterprise/premium-support |
| Pricing | https://github.com/pricing |
| Search syntax tips | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
| documentation | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F28953 |
|
Sign up
| https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode |
| Reload | https://github.com/nodejs/node/pull/28953 |
| Reload | https://github.com/nodejs/node/pull/28953 |
| Reload | https://github.com/nodejs/node/pull/28953 |
| Please reload this page | https://github.com/nodejs/node/pull/28953 |
|
nodejs
| https://github.com/nodejs |
| node | https://github.com/nodejs/node |
| Please reload this page | https://github.com/nodejs/node/pull/28953 |
|
Notifications
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Fork
36k
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Star
118k
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Code
| https://github.com/nodejs/node |
|
Issues
1.3k
| https://github.com/nodejs/node/issues |
|
Pull requests
971
| https://github.com/nodejs/node/pulls |
|
Actions
| https://github.com/nodejs/node/actions |
|
Projects
| https://github.com/nodejs/node/projects |
|
Security and quality
0
| https://github.com/nodejs/node/security |
|
Insights
| https://github.com/nodejs/node/pulse |
|
Code
| https://github.com/nodejs/node |
|
Issues
| https://github.com/nodejs/node/issues |
|
Pull requests
| https://github.com/nodejs/node/pulls |
|
Actions
| https://github.com/nodejs/node/actions |
|
Projects
| https://github.com/nodejs/node/projects |
|
Security and quality
| https://github.com/nodejs/node/security |
|
Insights
| https://github.com/nodejs/node/pulse |
| EduardoRFS | https://github.com/EduardoRFS |
| nodejs:master | https://github.com/nodejs/node/tree/master |
| EduardoRFS:patch-1 | https://github.com/EduardoRFS/node/tree/patch-1 |
| Conversation | https://github.com/nodejs/node/pull/28953 |
| Commits3 (3) | https://github.com/nodejs/node/pull/28953/commits |
| Checks | https://github.com/nodejs/node/pull/28953/checks |
| Files changed | https://github.com/nodejs/node/pull/28953/files |
| doc: make unshift doc compliant with push doc | https://github.com/nodejs/node/pull/28953#top |
| EduardoRFS | https://github.com/EduardoRFS |
| nodejs:master | https://github.com/nodejs/node/tree/master |
| EduardoRFS:patch-1 | https://github.com/EduardoRFS/node/tree/patch-1 |
|
| https://github.com/EduardoRFS |
| EduardoRFS | https://github.com/EduardoRFS |
| Aug 3, 2019 | https://github.com/nodejs/node/pull/28953#issue-476492059 |
| Please reload this page | https://github.com/nodejs/node/pull/28953 |
| https://github.com/nodejs/node/blob/master/doc/ | https://github.com/nodejs/node/blob/master/doc/ |
| Please reload this page | https://github.com/nodejs/node/pull/28953 |
| https://github.com/nodejs-github-bot |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
|
doc
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Adoc |
|
stream
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Astream |
| Aug 3, 2019 | https://github.com/nodejs/node/pull/28953#event-2531495365 |
| https://github.com/mscdex |
| mscdex | https://github.com/mscdex |
|
Aug 3, 2019
| https://github.com/nodejs/node/pull/28953#pullrequestreview-270474093 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/28953/files |
| doc/api/stream.md | https://github.com/nodejs/node/pull/28953/files#diff-00d8d040a3fe90e3052af39cb55dc9bcac70539d5d17791449cbfe7e3b55fb90 |
| Please reload this page | https://github.com/nodejs/node/pull/28953 |
| https://github.com/EduardoRFS |
| EduardoRFS | https://github.com/EduardoRFS |
| force-pushed | https://github.com/nodejs/node/compare/2c854b33481d492fa7cdeb866f9f9e3ddd6c28f9..c580523d7c957431ef10875ab762497e06caf263 |
| 2c854b3 | https://github.com/nodejs/node/commit/2c854b33481d492fa7cdeb866f9f9e3ddd6c28f9 |
| c580523 | https://github.com/nodejs/node/commit/c580523d7c957431ef10875ab762497e06caf263 |
|
Compare
| https://github.com/nodejs/node/compare/2c854b33481d492fa7cdeb866f9f9e3ddd6c28f9..c580523d7c957431ef10875ab762497e06caf263 |
| August 4, 2019 15:51 | https://github.com/nodejs/node/pull/28953#event-2531834396 |
|
| https://github.com/EduardoRFS |
| doc: make unshift doc compliant with push doc | https://github.com/nodejs/node/pull/28953/commits/6bb3112968c3a8eaef36897bdf156972477493aa |
| 6bb3112 | https://github.com/nodejs/node/pull/28953/commits/6bb3112968c3a8eaef36897bdf156972477493aa |
| https://github.com/EduardoRFS |
| EduardoRFS | https://github.com/EduardoRFS |
| force-pushed | https://github.com/nodejs/node/compare/c580523d7c957431ef10875ab762497e06caf263..6bb3112968c3a8eaef36897bdf156972477493aa |
| c580523 | https://github.com/nodejs/node/commit/c580523d7c957431ef10875ab762497e06caf263 |
| 6bb3112 | https://github.com/nodejs/node/commit/6bb3112968c3a8eaef36897bdf156972477493aa |
|
Compare
| https://github.com/nodejs/node/compare/c580523d7c957431ef10875ab762497e06caf263..6bb3112968c3a8eaef36897bdf156972477493aa |
| August 4, 2019 15:54 | https://github.com/nodejs/node/pull/28953#event-2531835720 |
| https://github.com/EduardoRFS |
| EduardoRFS | https://github.com/EduardoRFS |
| Aug 4, 2019 | https://github.com/nodejs/node/pull/28953#event-2531835851 |
| https://github.com/EduardoRFS |
| EduardoRFS | https://github.com/EduardoRFS |
| Aug 4, 2019 | https://github.com/nodejs/node/pull/28953#issuecomment-518014902 |
| Please reload this page | https://github.com/nodejs/node/pull/28953 |
| https://github.com/mscdex |
| mscdex | https://github.com/mscdex |
|
Aug 4, 2019
| https://github.com/nodejs/node/pull/28953#pullrequestreview-270504587 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/28953/files/6bb3112968c3a8eaef36897bdf156972477493aa |
| doc/api/stream.md | https://github.com/nodejs/node/pull/28953/files/6bb3112968c3a8eaef36897bdf156972477493aa#diff-00d8d040a3fe90e3052af39cb55dc9bcac70539d5d17791449cbfe7e3b55fb90 |
| Please reload this page | https://github.com/nodejs/node/pull/28953 |
|
| https://github.com/EduardoRFS |
|
| https://github.com/mscdex |
| Update doc/api/stream.md | https://github.com/nodejs/node/pull/28953/commits/69798b282d84a344fbae8bfeb25ff1230320786c |
| 69798b2 | https://github.com/nodejs/node/pull/28953/commits/69798b282d84a344fbae8bfeb25ff1230320786c |
| https://github.com/Trott |
| Trott | https://github.com/Trott |
|
Aug 6, 2019
| https://github.com/nodejs/node/pull/28953#pullrequestreview-271105360 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/28953/files/69798b282d84a344fbae8bfeb25ff1230320786c |
| doc/api/stream.md | https://github.com/nodejs/node/pull/28953/files/69798b282d84a344fbae8bfeb25ff1230320786c#diff-00d8d040a3fe90e3052af39cb55dc9bcac70539d5d17791449cbfe7e3b55fb90 |
| Trott | https://github.com/Trott |
| Aug 6, 2019 | https://github.com/nodejs/node/pull/28953#discussion_r310873149 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/28953 |
| https://github.com/Trott |
| Trott | https://github.com/Trott |
|
Aug 6, 2019
| https://github.com/nodejs/node/pull/28953#pullrequestreview-271105649 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/28953/files/69798b282d84a344fbae8bfeb25ff1230320786c |
| doc/api/stream.md | https://github.com/nodejs/node/pull/28953/files/69798b282d84a344fbae8bfeb25ff1230320786c#diff-00d8d040a3fe90e3052af39cb55dc9bcac70539d5d17791449cbfe7e3b55fb90 |
| Please reload this page | https://github.com/nodejs/node/pull/28953 |
| https://github.com/Trott |
| Trott | https://github.com/Trott |
| Aug 6, 2019 | https://github.com/nodejs/node/pull/28953#issuecomment-518489767 |
| Please reload this page | https://github.com/nodejs/node/pull/28953 |
|
| https://github.com/Trott |
| fixup! Update doc/api/stream.md | https://github.com/nodejs/node/pull/28953/commits/6234ca39823ae336b8f3b3570c43eb0cc1bd9948 |
| 6234ca3 | https://github.com/nodejs/node/pull/28953/commits/6234ca39823ae336b8f3b3570c43eb0cc1bd9948 |
| https://github.com/Trott |
| Trott | https://github.com/Trott |
| Aug 6, 2019 | https://github.com/nodejs/node/pull/28953#issuecomment-518772440 |
| @mscdex | https://github.com/mscdex |
| Please reload this page | https://github.com/nodejs/node/pull/28953 |
| https://github.com/Trott |
| Trott | https://github.com/Trott |
| Aug 6, 2019 | https://github.com/nodejs/node/pull/28953#issuecomment-518773031 |
| https://ci.nodejs.org/job/node-test-pull-request-lite-pipeline/3823/ | https://ci.nodejs.org/job/node-test-pull-request-lite-pipeline/3823/ |
| Please reload this page | https://github.com/nodejs/node/pull/28953 |
| https://github.com/jasnell |
| jasnell | https://github.com/jasnell |
|
Aug 7, 2019
| https://github.com/nodejs/node/pull/28953#pullrequestreview-271682047 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/28953/files/6234ca39823ae336b8f3b3570c43eb0cc1bd9948 |
| https://github.com/Trott |
| Trott | https://github.com/Trott |
|
Aug 7, 2019
| https://github.com/nodejs/node/pull/28953#pullrequestreview-271707402 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/28953/files/6234ca39823ae336b8f3b3570c43eb0cc1bd9948 |
| https://github.com/mcollina |
| mcollina | https://github.com/mcollina |
|
Aug 7, 2019
| https://github.com/nodejs/node/pull/28953#pullrequestreview-271779513 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/28953/files/6234ca39823ae336b8f3b3570c43eb0cc1bd9948 |
| mcollina | https://github.com/mcollina |
| https://github.com/nodejs/node/pull/28953#pullrequestreview-271779513 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/28953 |
| https://github.com/Trott |
| Trott | https://github.com/Trott |
| Aug 7, 2019 | https://github.com/nodejs/node/pull/28953#issuecomment-519252233 |
| Please reload this page | https://github.com/nodejs/node/pull/28953 |
| https://github.com/Trott |
| Trott | https://github.com/Trott |
| Aug 7, 2019 | https://github.com/nodejs/node/pull/28953#event-2541279326 |
| Trott | https://github.com/Trott |
|
Aug 7, 2019
| https://github.com/nodejs/node/pull/28953#ref-commit-84a6384 |
|
| https://github.com/EduardoRFS |
|
| https://github.com/Trott |
| doc: make unshift doc compliant with push doc | https://github.com/Trott/io.js/commit/84a638484ead2074625ab5198338bcaf784625c6 |
| 84a6384 | https://github.com/Trott/io.js/commit/84a638484ead2074625ab5198338bcaf784625c6 |
| nodejs#28953 | https://github.com/nodejs/node/pull/28953 |
| targos | https://github.com/targos |
|
Aug 19, 2019
| https://github.com/nodejs/node/pull/28953#ref-commit-17d9495 |
|
| https://github.com/EduardoRFS |
|
| https://github.com/targos |
| doc: make unshift doc compliant with push doc | https://github.com/nodejs/node/commit/17d9495afa0606debf1c07b07c2dfe685811eeb5 |
| 17d9495 | https://github.com/nodejs/node/commit/17d9495afa0606debf1c07b07c2dfe685811eeb5 |
| #28953 | https://github.com/nodejs/node/pull/28953 |
| https://github.com/targos |
| targos | https://github.com/targos |
|
Aug 19, 2019
| https://github.com/nodejs/node/pull/28953#ref-pullrequest-482485175 |
|
v12.9.0 release proposal
#29210
| https://github.com/nodejs/node/pull/29210 |
|
2019-08-20 Version 12.9.0 (Current) @targos
beevelop/docker-android-nodejs#328
| https://github.com/beevelop/docker-android-nodejs/issues/328 |
|
2019-08-20 Version 12.9.0 (Current) @targos
beevelop/docker-android-nodejs#329
| https://github.com/beevelop/docker-android-nodejs/issues/329 |
|
2019-08-20 Version 12.9.0 (Current) @targos
beevelop/docker-android-nodejs#330
| https://github.com/beevelop/docker-android-nodejs/issues/330 |
|
2019-08-20 Version 12.9.0 (Current) @targos
beevelop/docker-nodejs#295
| https://github.com/beevelop/docker-nodejs/issues/295 |
|
2019-08-20 Version 12.9.0 (Current) @targos
beevelop/docker-nodejs#296
| https://github.com/beevelop/docker-nodejs/issues/296 |
| https://github.com/beevelop |
| beevelop | https://github.com/beevelop |
|
Aug 20, 2019
| https://github.com/nodejs/node/pull/28953#ref-issue-483088900 |
|
2019-08-20 Version 12.9.0 (Current) @targos
beevelop/docker-nodejs#297
| https://github.com/beevelop/docker-nodejs/issues/297 |
| https://github.co/hiddenchars |
| https://github.com/nodejs/node/pull/{{ revealButtonHref }} |
| Sign up for free | https://github.com/join?source=comment-repo |
| Sign in to comment | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F28953 |
|
| https://github.com/mcollina |
|
mcollina
| https://github.com/mcollina |
|
| https://github.com/nodejs/node/pull/28953/files/6234ca39823ae336b8f3b3570c43eb0cc1bd9948 |
|
| https://github.com/jasnell |
|
jasnell
| https://github.com/jasnell |
|
| https://github.com/nodejs/node/pull/28953/files/6234ca39823ae336b8f3b3570c43eb0cc1bd9948 |
|
| https://github.com/Trott |
|
Trott
| https://github.com/Trott |
|
| https://github.com/nodejs/node/pull/28953/files/6234ca39823ae336b8f3b3570c43eb0cc1bd9948 |
|
| https://github.com/mscdex |
|
mscdex
| https://github.com/mscdex |
|
| https://github.com/nodejs/node/pull/28953/files/6bb3112968c3a8eaef36897bdf156972477493aa |
|
doc
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Adoc |
|
stream
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Astream |
| Please reload this page | https://github.com/nodejs/node/pull/28953 |
|
| https://github.com/EduardoRFS |
|
| https://github.com/Trott |
|
| https://github.com/mcollina |
|
| https://github.com/mscdex |
|
| https://github.com/jasnell |
|
| https://github.com/nodejs-github-bot |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |