René's URL Explorer Experiment


Title: module: add note when cjs loader throws error by gntem · Pull Request #28950 · nodejs/node · GitHub

Open Graph Title: module: add note when cjs loader throws error by gntem · Pull Request #28950 · nodejs/node

X Title: module: add note when cjs loader throws error by gntem · Pull Request #28950 · nodejs/node

Description: Node.js JavaScript runtime ✨🐢🚀✨. Contribute to nodejs/node development by creating an account on GitHub.

Open Graph Description: subsystem: module: add note to error when import,export is detected. These will allow users to know how to change their project to support es modules when the message is displayed. Checklist ma...

X Description: subsystem: module: add note to error when import,export is detected. These will allow users to know how to change their project to support es modules when the message is displayed. Checklist ma...

Opengraph URL: https://github.com/nodejs/node/pull/28950

X: @github

direct link

Domain: github.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:d039af02-6723-1cd2-7c12-eeceda1c699b
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idC974:108F59:14E903F:1DDCD4A:6A4F69E2
html-safe-noncebb12ff5551875ab077ac5cd2a12d572692d0c505442744f4ea7e33f852e52bd7
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJDOTc0OjEwOEY1OToxNEU5MDNGOjFERENENEE6NkE0RjY5RTIiLCJ2aXNpdG9yX2lkIjoiNjkyNzE2NTE2MjIxNTQwMTk1NCIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmacb98ec16633f5adc3eb9b2ac2ce19d28927597b0dc6ee6cbc9113ca17a2b748e6
hovercard-subject-tagpull_request:304001415
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/28950/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/a381123f8bb3a89901f37c5a222c9f49077e3ef4919ffba54d9edf4b214c95f4/nodejs/node/pull/28950
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/a381123f8bb3a89901f37c5a222c9f49077e3ef4919ffba54d9edf4b214c95f4/nodejs/node/pull/28950
og:image:altsubsystem: module: add note to error when import,export is detected. These will allow users to know how to change their project to support es modules when the message is displayed. Checklist ma...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamegntem
hostnamegithub.com
expected-hostnamegithub.com
Noneb92d11c0aa4a77d54ef4af1078b6a15fb5a70a215b30c4ecf28889d5a8e656d9
turbo-cache-controlno-cache
go-importgithub.com/nodejs/node git https://github.com/nodejs/node.git
octolytics-dimension-user_id9950313
octolytics-dimension-user_loginnodejs
octolytics-dimension-repository_id27193779
octolytics-dimension-repository_nwonodejs/node
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id27193779
octolytics-dimension-repository_network_root_nwonodejs/node
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release4b249b445842943ed31549e027f57a8ade9881ed
ui-targetcanary-2
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/nodejs/node/pull/28950#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F28950
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub Copilot appDirect agents from issue to mergehttps://github.com/features/ai/github-app
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
View all resourceshttps://github.com/resources
GitHub SponsorsFund open source developershttps://github.com/open-source/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/open-source/accelerator
GitHub Starshttps://stars.github.com
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F28950
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode
Reloadhttps://github.com/nodejs/node/pull/28950
Reloadhttps://github.com/nodejs/node/pull/28950
Reloadhttps://github.com/nodejs/node/pull/28950
Please reload this pagehttps://github.com/nodejs/node/pull/28950
nodejs https://github.com/nodejs
nodehttps://github.com/nodejs/node
Please reload this pagehttps://github.com/nodejs/node/pull/28950
Notifications https://github.com/login?return_to=%2Fnodejs%2Fnode
Fork 36k https://github.com/login?return_to=%2Fnodejs%2Fnode
Star 118k https://github.com/login?return_to=%2Fnodejs%2Fnode
Code https://github.com/nodejs/node
Issues 1.3k https://github.com/nodejs/node/issues
Pull requests 971 https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects https://github.com/nodejs/node/projects
Security and quality 0 https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
Code https://github.com/nodejs/node
Issues https://github.com/nodejs/node/issues
Pull requests https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects https://github.com/nodejs/node/projects
Security and quality https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
gntemhttps://github.com/gntem
nodejs:masterhttps://github.com/nodejs/node/tree/master
gntem:esm-modules-note-for-invalid-importshttps://github.com/gntem/node/tree/esm-modules-note-for-invalid-imports
Conversationhttps://github.com/nodejs/node/pull/28950
Commits1 (1)https://github.com/nodejs/node/pull/28950/commits
Checkshttps://github.com/nodejs/node/pull/28950/checks
Files changedhttps://github.com/nodejs/node/pull/28950/files
module: add note when cjs loader throws errorhttps://github.com/nodejs/node/pull/28950#top
gntemhttps://github.com/gntem
nodejs:masterhttps://github.com/nodejs/node/tree/master
gntem:esm-modules-note-for-invalid-importshttps://github.com/gntem/node/tree/esm-modules-note-for-invalid-imports
https://github.com/gntem
gntemhttps://github.com/gntem
Aug 3, 2019https://github.com/nodejs/node/pull/28950#issue-476453287
commit guidelineshttps://github.com/nodejs/node/blob/master/doc/guides/contributing/pull-requests.md#commit-message-guidelines
Please reload this pagehttps://github.com/nodejs/node/pull/28950
https://github.com/guybedford
guybedfordhttps://github.com/guybedford
Aug 4, 2019https://github.com/nodejs/node/pull/28950#issuecomment-517963592
Please reload this pagehttps://github.com/nodejs/node/pull/28950
@gntemhttps://github.com/gntem
Please reload this pagehttps://github.com/nodejs/node/pull/28950
https://github.com/guybedford
guybedfordhttps://github.com/guybedford
Aug 4, 2019https://github.com/nodejs/node/pull/28950#issuecomment-517963615
Please reload this pagehttps://github.com/nodejs/node/pull/28950
https://github.com/bmeck
bmeckhttps://github.com/bmeck
Aug 4, 2019 https://github.com/nodejs/node/pull/28950#pullrequestreview-270477421
View reviewed changes https://github.com/nodejs/node/pull/28950/files
bmeckhttps://github.com/bmeck
https://github.com/nodejs/node/pull/28950#pullrequestreview-270477421
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/28950
lib/internal/modules/cjs/loader.jshttps://github.com/nodejs/node/pull/28950/files#diff-5b5902273122e094ff474fda358605ffa45a4a58b51cd0bf4c1acb93779df142
Please reload this pagehttps://github.com/nodejs/node/pull/28950
lib/internal/modules/cjs/loader.jshttps://github.com/nodejs/node/pull/28950/files#diff-5b5902273122e094ff474fda358605ffa45a4a58b51cd0bf4c1acb93779df142
Please reload this pagehttps://github.com/nodejs/node/pull/28950
https://github.com/ljharb
ljharbhttps://github.com/ljharb
Aug 4, 2019 https://github.com/nodejs/node/pull/28950#pullrequestreview-270477700
View reviewed changes https://github.com/nodejs/node/pull/28950/files
ljharbhttps://github.com/ljharb
https://github.com/nodejs/node/pull/28950#pullrequestreview-270477700
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
@bmeckhttps://github.com/bmeck
Please reload this pagehttps://github.com/nodejs/node/pull/28950
https://github.com/gntem
gntemhttps://github.com/gntem
force-pushedhttps://github.com/nodejs/node/compare/c829d543a4be11736b0849524a747217096116dc..dc3792d5716ccb2b3558ab0fca79e57ba1a7ffe7
c829d54https://github.com/nodejs/node/commit/c829d543a4be11736b0849524a747217096116dc
dc3792dhttps://github.com/nodejs/node/commit/dc3792d5716ccb2b3558ab0fca79e57ba1a7ffe7
Compare https://github.com/nodejs/node/compare/c829d543a4be11736b0849524a747217096116dc..dc3792d5716ccb2b3558ab0fca79e57ba1a7ffe7
August 5, 2019 06:41https://github.com/nodejs/node/pull/28950#event-2532455962
https://github.com/Trott
Trotthttps://github.com/Trott
Aug 5, 2019 https://github.com/nodejs/node/pull/28950#pullrequestreview-270802727
View reviewed changes https://github.com/nodejs/node/pull/28950/files
lib/internal/modules/cjs/loader.jshttps://github.com/nodejs/node/pull/28950/files#diff-5b5902273122e094ff474fda358605ffa45a4a58b51cd0bf4c1acb93779df142
Please reload this pagehttps://github.com/nodejs/node/pull/28950
https://github.com/hybrist
hybristhttps://github.com/hybrist
Aug 5, 2019 https://github.com/nodejs/node/pull/28950#pullrequestreview-270830198
View reviewed changes https://github.com/nodejs/node/pull/28950/files
lib/internal/modules/cjs/loader.jshttps://github.com/nodejs/node/pull/28950/files#diff-5b5902273122e094ff474fda358605ffa45a4a58b51cd0bf4c1acb93779df142
Please reload this pagehttps://github.com/nodejs/node/pull/28950
test/fixtures/es-modules/es-note-promiserej-import-2.cjshttps://github.com/nodejs/node/pull/28950/files#diff-0618826d64c40e3b20cb8d6eba3abc4980d247ee6b8ce2a58accedc3a8a53afb
Please reload this pagehttps://github.com/nodejs/node/pull/28950
https://github.com/gntem
gntemhttps://github.com/gntem
force-pushedhttps://github.com/nodejs/node/compare/610067eaca4750c072e6e3c086b905493404b25c..d2ede7dae1de7b7b9058f70ce4429534f8126f98
610067ehttps://github.com/nodejs/node/commit/610067eaca4750c072e6e3c086b905493404b25c
d2ede7dhttps://github.com/nodejs/node/commit/d2ede7dae1de7b7b9058f70ce4429534f8126f98
Compare https://github.com/nodejs/node/compare/610067eaca4750c072e6e3c086b905493404b25c..d2ede7dae1de7b7b9058f70ce4429534f8126f98
August 6, 2019 15:04https://github.com/nodejs/node/pull/28950#event-2537112777
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
Aug 7, 2019https://github.com/nodejs/node/pull/28950#issuecomment-518918450
https://ci.nodejs.org/job/node-test-pull-request/24874/https://ci.nodejs.org/job/node-test-pull-request/24874/
Please reload this pagehttps://github.com/nodejs/node/pull/28950
https://github.com/Trott
Trotthttps://github.com/Trott
Aug 7, 2019 https://github.com/nodejs/node/pull/28950#pullrequestreview-271732741
View reviewed changes https://github.com/nodejs/node/pull/28950/files
test/es-module/test-esm-cjs-load-error-note.mjshttps://github.com/nodejs/node/pull/28950/files#diff-5292d6fe472b136e0740267b60638f6cbe582148e7b777d2a6dc0e29283fe875
Please reload this pagehttps://github.com/nodejs/node/pull/28950
https://github.com/gntem
gntemhttps://github.com/gntem
force-pushedhttps://github.com/nodejs/node/compare/d2ede7dae1de7b7b9058f70ce4429534f8126f98..3d5741ce9cf0b349b63c83b6795fcb8554d03532
d2ede7dhttps://github.com/nodejs/node/commit/d2ede7dae1de7b7b9058f70ce4429534f8126f98
3d5741chttps://github.com/nodejs/node/commit/3d5741ce9cf0b349b63c83b6795fcb8554d03532
Compare https://github.com/nodejs/node/compare/d2ede7dae1de7b7b9058f70ce4429534f8126f98..3d5741ce9cf0b349b63c83b6795fcb8554d03532
August 7, 2019 07:09https://github.com/nodejs/node/pull/28950#event-2539014765
https://github.com/targos
targoshttps://github.com/targos
Aug 7, 2019https://github.com/nodejs/node/pull/28950#event-2539066923
https://github.com/bmeck
bmeckhttps://github.com/bmeck
Aug 7, 2019https://github.com/nodejs/node/pull/28950#issuecomment-519100524
Please reload this pagehttps://github.com/nodejs/node/pull/28950
https://github.com/targos
targoshttps://github.com/targos
Aug 7, 2019https://github.com/nodejs/node/pull/28950#issuecomment-519104121
Please reload this pagehttps://github.com/nodejs/node/pull/28950
https://github.com/targos
targoshttps://github.com/targos
Aug 7, 2019https://github.com/nodejs/node/pull/28950#event-2540136120
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
Aug 9, 2019https://github.com/nodejs/node/pull/28950#issuecomment-520013646
https://ci.nodejs.org/job/node-test-pull-request/24906/https://ci.nodejs.org/job/node-test-pull-request/24906/
Please reload this pagehttps://github.com/nodejs/node/pull/28950
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
Aug 9, 2019https://github.com/nodejs/node/pull/28950#issuecomment-520021257
https://ci.nodejs.org/job/node-test-pull-request/24911/https://ci.nodejs.org/job/node-test-pull-request/24911/
Please reload this pagehttps://github.com/nodejs/node/pull/28950
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
Aug 11, 2019https://github.com/nodejs/node/pull/28950#issuecomment-520203963
https://ci.nodejs.org/job/node-test-pull-request/24934/https://ci.nodejs.org/job/node-test-pull-request/24934/
Please reload this pagehttps://github.com/nodejs/node/pull/28950
https://github.com/guybedford
guybedfordhttps://github.com/guybedford
Aug 11, 2019https://github.com/nodejs/node/pull/28950#issuecomment-520207836
Please reload this pagehttps://github.com/nodejs/node/pull/28950
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
Aug 11, 2019https://github.com/nodejs/node/pull/28950#issuecomment-520237384
https://ci.nodejs.org/job/node-test-pull-request/24937/https://ci.nodejs.org/job/node-test-pull-request/24937/
Please reload this pagehttps://github.com/nodejs/node/pull/28950
https://github.com/Trott
Trotthttps://github.com/Trott
Aug 11, 2019 https://github.com/nodejs/node/pull/28950#pullrequestreview-273480875
View reviewed changes https://github.com/nodejs/node/pull/28950/files
lib/internal/modules/cjs/loader.jshttps://github.com/nodejs/node/pull/28950/files#diff-5b5902273122e094ff474fda358605ffa45a4a58b51cd0bf4c1acb93779df142
Trotthttps://github.com/Trott
Aug 11, 2019https://github.com/nodejs/node/pull/28950#discussion_r312755622
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/28950
https://github.com/Trott
Trotthttps://github.com/Trott
Aug 11, 2019 https://github.com/nodejs/node/pull/28950#pullrequestreview-273480936
View reviewed changes https://github.com/nodejs/node/pull/28950/files
test/es-module/test-esm-cjs-load-error-note.mjshttps://github.com/nodejs/node/pull/28950/files#diff-5292d6fe472b136e0740267b60638f6cbe582148e7b777d2a6dc0e29283fe875
Trotthttps://github.com/Trott
Aug 11, 2019https://github.com/nodejs/node/pull/28950#discussion_r312755669
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/28950
https://github.com/Trott
Trotthttps://github.com/Trott
force-pushedhttps://github.com/nodejs/node/compare/53c40372b96aa5e3d10ca90894363ec942a099c4..1bc60b0cec1967fcc253778b349d36ccd0021dc9
53c4037https://github.com/nodejs/node/commit/53c40372b96aa5e3d10ca90894363ec942a099c4
1bc60b0https://github.com/nodejs/node/commit/1bc60b0cec1967fcc253778b349d36ccd0021dc9
Compare https://github.com/nodejs/node/compare/53c40372b96aa5e3d10ca90894363ec942a099c4..1bc60b0cec1967fcc253778b349d36ccd0021dc9
August 11, 2019 21:54https://github.com/nodejs/node/pull/28950#event-2548856721
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
Aug 11, 2019https://github.com/nodejs/node/pull/28950#issuecomment-520264283
https://ci.nodejs.org/job/node-test-pull-request/24941/https://ci.nodejs.org/job/node-test-pull-request/24941/
Please reload this pagehttps://github.com/nodejs/node/pull/28950
https://github.com/Trott
Trotthttps://github.com/Trott
Aug 11, 2019 https://github.com/nodejs/node/pull/28950#pullrequestreview-273481108
View reviewed changes https://github.com/nodejs/node/pull/28950/files
https://github.com/Trott
Trotthttps://github.com/Trott
stale reviewhttps://github.com/nodejs/node/pull/28950#pullrequestreview-273481108
August 11, 2019 21:56https://github.com/nodejs/node/pull/28950#event-2548857829
https://github.com/Trott
Trotthttps://github.com/Trott
Aug 11, 2019 https://github.com/nodejs/node/pull/28950#pullrequestreview-273481243
View reviewed changes https://github.com/nodejs/node/pull/28950/files
lib/internal/modules/cjs/loader.jshttps://github.com/nodejs/node/pull/28950/files#diff-5b5902273122e094ff474fda358605ffa45a4a58b51cd0bf4c1acb93779df142
Trotthttps://github.com/Trott
Aug 11, 2019https://github.com/nodejs/node/pull/28950#discussion_r312755905
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/28950
ljharbhttps://github.com/ljharb
Aug 11, 2019https://github.com/nodejs/node/pull/28950#discussion_r312756319
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/28950
guybedfordhttps://github.com/guybedford
Aug 12, 2019https://github.com/nodejs/node/pull/28950#discussion_r312857506
Please reload this pagehttps://github.com/nodejs/node/pull/28950
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/28950
guybedfordhttps://github.com/guybedford
Aug 12, 2019https://github.com/nodejs/node/pull/28950#discussion_r312857681
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/28950
Trotthttps://github.com/Trott
Aug 12, 2019https://github.com/nodejs/node/pull/28950#discussion_r312972517
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/28950
ljharbhttps://github.com/ljharb
Aug 12, 2019https://github.com/nodejs/node/pull/28950#discussion_r312980939
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/28950
gntemhttps://github.com/gntem
Aug 12, 2019https://github.com/nodejs/node/pull/28950#discussion_r312995764
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/28950
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
Aug 12, 2019https://github.com/nodejs/node/pull/28950#issuecomment-520306090
https://ci.nodejs.org/job/node-test-pull-request/24944/https://ci.nodejs.org/job/node-test-pull-request/24944/
Please reload this pagehttps://github.com/nodejs/node/pull/28950
https://github.com/Trott
Trotthttps://github.com/Trott
Aug 12, 2019 https://github.com/nodejs/node/pull/28950#pullrequestreview-273843072
View reviewed changes https://github.com/nodejs/node/pull/28950/files
lib/internal/modules/cjs/loader.jshttps://github.com/nodejs/node/pull/28950/files#diff-5b5902273122e094ff474fda358605ffa45a4a58b51cd0bf4c1acb93779df142
Trotthttps://github.com/Trott
Aug 12, 2019https://github.com/nodejs/node/pull/28950#discussion_r313042779
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/28950
gntemhttps://github.com/gntem
Aug 12, 2019https://github.com/nodejs/node/pull/28950#discussion_r313098346
Please reload this pagehttps://github.com/nodejs/node/pull/28950
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/28950
Trotthttps://github.com/Trott
Aug 12, 2019https://github.com/nodejs/node/pull/28950#discussion_r313132548
Please reload this pagehttps://github.com/nodejs/node/pull/28950
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/28950
Trotthttps://github.com/Trott
Aug 12, 2019https://github.com/nodejs/node/pull/28950#discussion_r313142218
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/28950
Trotthttps://github.com/Trott
Aug 12, 2019https://github.com/nodejs/node/pull/28950#discussion_r313149326
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/28950
https://github.com/gntem
https://github.com/Trott
module: add warning when import,export is detected in CJS contexthttps://github.com/nodejs/node/pull/28950/commits/33728605ef1d5cd70ce2ae225c1b8c9dbff5392a
3372860https://github.com/nodejs/node/pull/28950/commits/33728605ef1d5cd70ce2ae225c1b8c9dbff5392a
https://github.com/Trott
Trotthttps://github.com/Trott
force-pushedhttps://github.com/nodejs/node/compare/d25077d9973221ff6de113b937a6ea63b3cf5159..33728605ef1d5cd70ce2ae225c1b8c9dbff5392a
d25077dhttps://github.com/nodejs/node/commit/d25077d9973221ff6de113b937a6ea63b3cf5159
3372860https://github.com/nodejs/node/commit/33728605ef1d5cd70ce2ae225c1b8c9dbff5392a
Compare https://github.com/nodejs/node/compare/d25077d9973221ff6de113b937a6ea63b3cf5159..33728605ef1d5cd70ce2ae225c1b8c9dbff5392a
August 12, 2019 22:31https://github.com/nodejs/node/pull/28950#event-2551690419
https://github.com/Trott
Trotthttps://github.com/Trott
Aug 12, 2019https://github.com/nodejs/node/pull/28950#issuecomment-520619427
Please reload this pagehttps://github.com/nodejs/node/pull/28950
https://github.com/Trott
Trotthttps://github.com/Trott
Aug 12, 2019 https://github.com/nodejs/node/pull/28950#pullrequestreview-273984389
View reviewed changes https://github.com/nodejs/node/pull/28950/files/33728605ef1d5cd70ce2ae225c1b8c9dbff5392a
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
Aug 12, 2019https://github.com/nodejs/node/pull/28950#issuecomment-520619662
https://ci.nodejs.org/job/node-test-pull-request/24955/https://ci.nodejs.org/job/node-test-pull-request/24955/
Please reload this pagehttps://github.com/nodejs/node/pull/28950
https://github.com/guybedford
guybedfordhttps://github.com/guybedford
Aug 13, 2019 https://github.com/nodejs/node/pull/28950#pullrequestreview-274175307
View reviewed changes https://github.com/nodejs/node/pull/28950/files/33728605ef1d5cd70ce2ae225c1b8c9dbff5392a
guybedfordhttps://github.com/guybedford
https://github.com/nodejs/node/pull/28950#pullrequestreview-274175307
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/28950
https://github.com/Trott
Trotthttps://github.com/Trott
Aug 13, 2019https://github.com/nodejs/node/pull/28950#issuecomment-520949342
427e534https://github.com/nodejs/node/commit/427e5348a267b7c88879b47f8d942fc3e84b30e9
Please reload this pagehttps://github.com/nodejs/node/pull/28950
https://github.com/Trott
Trotthttps://github.com/Trott
Aug 13, 2019https://github.com/nodejs/node/pull/28950#event-2554289482
Trotthttps://github.com/Trott
Aug 13, 2019 https://github.com/nodejs/node/pull/28950#ref-commit-427e534
https://github.com/gntem
https://github.com/Trott
module: add warning when import,export is detected in CJS contexthttps://github.com/Trott/io.js/commit/427e5348a267b7c88879b47f8d942fc3e84b30e9
427e534https://github.com/Trott/io.js/commit/427e5348a267b7c88879b47f8d942fc3e84b30e9
nodejs#28950https://github.com/nodejs/node/pull/28950
https://github.com/Trott
Trotthttps://github.com/Trott
Aug 13, 2019https://github.com/nodejs/node/pull/28950#issuecomment-520949432
Please reload this pagehttps://github.com/nodejs/node/pull/28950
https://github.com/gntem
gntemhttps://github.com/gntem
August 14, 2019 06:49https://github.com/nodejs/node/pull/28950#event-2555563900
targoshttps://github.com/targos
Aug 19, 2019 https://github.com/nodejs/node/pull/28950#ref-commit-b17505a
https://github.com/gntem
https://github.com/targos
module: add warning when import,export is detected in CJS contexthttps://github.com/nodejs/node/commit/b17505af621dbe5a2465d811b524bb8a59cb1434
b17505ahttps://github.com/nodejs/node/commit/b17505af621dbe5a2465d811b524bb8a59cb1434
#28950https://github.com/nodejs/node/pull/28950
targoshttps://github.com/targos
Aug 19, 2019 https://github.com/nodejs/node/pull/28950#ref-commit-925e40c
https://github.com/gntem
https://github.com/targos
module: add warning when import,export is detected in CJS contexthttps://github.com/nodejs/node/commit/925e40cfa7b9ecee9502900d3bb730c06ba9ceee
925e40chttps://github.com/nodejs/node/commit/925e40cfa7b9ecee9502900d3bb730c06ba9ceee
#28950https://github.com/nodejs/node/pull/28950
https://github.com/targos
targoshttps://github.com/targos
Aug 19, 2019 https://github.com/nodejs/node/pull/28950#ref-pullrequest-482485175
v12.9.0 release proposal #29210 https://github.com/nodejs/node/pull/29210
2019-08-20 Version 12.9.0 (Current) @targos beevelop/docker-android-nodejs#328 https://github.com/beevelop/docker-android-nodejs/issues/328
2019-08-20 Version 12.9.0 (Current) @targos beevelop/docker-android-nodejs#329 https://github.com/beevelop/docker-android-nodejs/issues/329
2019-08-20 Version 12.9.0 (Current) @targos beevelop/docker-android-nodejs#330 https://github.com/beevelop/docker-android-nodejs/issues/330
2019-08-20 Version 12.9.0 (Current) @targos beevelop/docker-nodejs#295 https://github.com/beevelop/docker-nodejs/issues/295
2019-08-20 Version 12.9.0 (Current) @targos beevelop/docker-nodejs#296 https://github.com/beevelop/docker-nodejs/issues/296
2019-08-20 Version 12.9.0 (Current) @targos beevelop/docker-nodejs#297 https://github.com/beevelop/docker-nodejs/issues/297
codebyterehttps://github.com/codebytere
Aug 21, 2019 https://github.com/nodejs/node/pull/28950#ref-commit-35f4186
https://github.com/codebytere
update fixme_use_redefined_version_of_internalmodulestat.patchhttps://github.com/electron/electron/commit/35f4186d6143db5c3bcaf4016cac827b056d3c9d
35f4186https://github.com/electron/electron/commit/35f4186d6143db5c3bcaf4016cac827b056d3c9d
nodejs/node#28950https://github.com/nodejs/node/pull/28950
https://github.co/hiddenchars
https://github.com/nodejs/node/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F28950
https://github.com/ljharb
ljharb https://github.com/ljharb
https://github.com/nodejs/node/pull/28950/files/1bc60b0cec1967fcc253778b349d36ccd0021dc9
https://github.com/hybrist
hybrist https://github.com/hybrist
https://github.com/nodejs/node/pull/28950/files/bf0f355fe11b86d1ea61cc145a86aa2d715ff3c1
https://github.com/guybedford
guybedford https://github.com/guybedford
https://github.com/nodejs/node/pull/28950/files/33728605ef1d5cd70ce2ae225c1b8c9dbff5392a
https://github.com/Trott
Trott https://github.com/Trott
https://github.com/nodejs/node/pull/28950/files/33728605ef1d5cd70ce2ae225c1b8c9dbff5392a
https://github.com/bmeck
bmeck https://github.com/bmeck
https://github.com/nodejs/node/pull/28950/files/c829d543a4be11736b0849524a747217096116dc
Please reload this pagehttps://github.com/nodejs/node/pull/28950
https://github.com/gntem
https://github.com/guybedford
https://github.com/nodejs-github-bot
https://github.com/bmeck
https://github.com/targos
https://github.com/Trott
https://github.com/ljharb
https://github.com/hybrist
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.