René's URL Explorer Experiment


Title: modules: Package exports validations and fallbacks by guybedford · Pull Request #28949 · nodejs/node · GitHub

Open Graph Title: modules: Package exports validations and fallbacks by guybedford · Pull Request #28949 · nodejs/node

X Title: modules: Package exports validations and fallbacks by guybedford · Pull Request #28949 · nodejs/node

Description: Node.js JavaScript runtime ✨🐢🚀✨. Contribute to nodejs/node development by creating an account on GitHub.

Open Graph Description: This clarifies and specifies the package "exports" proposal validations roughly in a way similar to as specified for import maps (except slightly more restrictive - no URLs or backtrackin...

X Description: This clarifies and specifies the package "exports" proposal validations roughly in a way similar to as specified for import maps (except slightly more restrictive - no URLs or bac...

Opengraph URL: https://github.com/nodejs/node/pull/28949

X: @github

direct link

Domain: github.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:9e909042-695f-0c27-0b7d-5efc98c036af
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idD83A:3AF9A7:496DCA8:668A074:6A4F7C47
html-safe-nonceb14cbffe978f51980226819b6ad970db3654c9e7486491a401ca5d21b47231de
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJEODNBOjNBRjlBNzo0OTZEQ0E4OjY2OEEwNzQ6NkE0RjdDNDciLCJ2aXNpdG9yX2lkIjoiNjk5MDYwMTEwMzMyNzg1MzYzOSIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmac4d378f062047d8e6f6c4085ffa597ee84d6a7f79d49d52d37dd0dc028274e4f3
hovercard-subject-tagpull_request:303977644
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/28949/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/a848100508c304c4074ceb26d8b42a417ced346978fb23595e8f444bfb22c3a2/nodejs/node/pull/28949
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/a848100508c304c4074ceb26d8b42a417ced346978fb23595e8f444bfb22c3a2/nodejs/node/pull/28949
og:image:altThis clarifies and specifies the package "exports" proposal validations roughly in a way similar to as specified for import maps (except slightly more restrictive - no URLs or backtrackin...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernameguybedford
hostnamegithub.com
expected-hostnamegithub.com
Noneb92d11c0aa4a77d54ef4af1078b6a15fb5a70a215b30c4ecf28889d5a8e656d9
turbo-cache-controlno-cache
go-importgithub.com/nodejs/node git https://github.com/nodejs/node.git
octolytics-dimension-user_id9950313
octolytics-dimension-user_loginnodejs
octolytics-dimension-repository_id27193779
octolytics-dimension-repository_nwonodejs/node
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id27193779
octolytics-dimension-repository_network_root_nwonodejs/node
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release4b249b445842943ed31549e027f57a8ade9881ed
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/nodejs/node/pull/28949#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F28949
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub Copilot appDirect agents from issue to mergehttps://github.com/features/ai/github-app
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
View all resourceshttps://github.com/resources
GitHub SponsorsFund open source developershttps://github.com/open-source/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/open-source/accelerator
GitHub Starshttps://stars.github.com
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F28949
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode
Reloadhttps://github.com/nodejs/node/pull/28949
Reloadhttps://github.com/nodejs/node/pull/28949
Reloadhttps://github.com/nodejs/node/pull/28949
Please reload this pagehttps://github.com/nodejs/node/pull/28949
nodejs https://github.com/nodejs
nodehttps://github.com/nodejs/node
Please reload this pagehttps://github.com/nodejs/node/pull/28949
Notifications https://github.com/login?return_to=%2Fnodejs%2Fnode
Fork 36k https://github.com/login?return_to=%2Fnodejs%2Fnode
Star 118k https://github.com/login?return_to=%2Fnodejs%2Fnode
Code https://github.com/nodejs/node
Issues 1.3k https://github.com/nodejs/node/issues
Pull requests 973 https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects https://github.com/nodejs/node/projects
Security and quality 0 https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
Code https://github.com/nodejs/node
Issues https://github.com/nodejs/node/issues
Pull requests https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects https://github.com/nodejs/node/projects
Security and quality https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
guybedfordhttps://github.com/guybedford
nodejs:masterhttps://github.com/nodejs/node/tree/master
guybedford:exports-validationshttps://github.com/guybedford/node/tree/exports-validations
Conversationhttps://github.com/nodejs/node/pull/28949
Commits11 (11)https://github.com/nodejs/node/pull/28949/commits
Checkshttps://github.com/nodejs/node/pull/28949/checks
Files changedhttps://github.com/nodejs/node/pull/28949/files
modules: Package exports validations and fallbackshttps://github.com/nodejs/node/pull/28949#top
guybedfordhttps://github.com/guybedford
nodejs:masterhttps://github.com/nodejs/node/tree/master
guybedford:exports-validationshttps://github.com/guybedford/node/tree/exports-validations
https://github.com/guybedford
guybedfordhttps://github.com/guybedford
Aug 3, 2019https://github.com/nodejs/node/pull/28949#issue-476417174
Please reload this pagehttps://github.com/nodejs/node/pull/28949
commit guidelineshttps://github.com/nodejs/node/blob/master/doc/guides/contributing/pull-requests.md#commit-message-guidelines
Please reload this pagehttps://github.com/nodejs/node/pull/28949
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
c++ https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Ac%2B%2B
Aug 3, 2019https://github.com/nodejs/node/pull/28949#event-2531152588
https://github.com/guybedford
guybedfordhttps://github.com/guybedford
hybristhttps://github.com/hybrist
August 3, 2019 05:17https://github.com/nodejs/node/pull/28949#event-2531152934
https://github.com/guybedford
guybedfordhttps://github.com/guybedford
force-pushedhttps://github.com/nodejs/node/compare/b158078b9e5a34587eb8ba484b24d977a0e765b8..01f017bcc2bba9f8c63d7386f525db6d51bbd617
b158078https://github.com/nodejs/node/commit/b158078b9e5a34587eb8ba484b24d977a0e765b8
01f017bhttps://github.com/nodejs/node/commit/01f017bcc2bba9f8c63d7386f525db6d51bbd617
Compare https://github.com/nodejs/node/compare/b158078b9e5a34587eb8ba484b24d977a0e765b8..01f017bcc2bba9f8c63d7386f525db6d51bbd617
August 3, 2019 06:08https://github.com/nodejs/node/pull/28949#event-2531167618
https://github.com/guybedford
guybedfordhttps://github.com/guybedford
Aug 3, 2019https://github.com/nodejs/node/pull/28949#issuecomment-517899118
Please reload this pagehttps://github.com/nodejs/node/pull/28949
https://github.com/bmeck
bmeckhttps://github.com/bmeck
Aug 3, 2019https://github.com/nodejs/node/pull/28949#issuecomment-517918995
Please reload this pagehttps://github.com/nodejs/node/pull/28949
https://github.com/bmeck
bmeckhttps://github.com/bmeck
Aug 3, 2019 https://github.com/nodejs/node/pull/28949#pullrequestreview-270457366
View reviewed changes https://github.com/nodejs/node/pull/28949/files
bmeckhttps://github.com/bmeck
https://github.com/nodejs/node/pull/28949#pullrequestreview-270457366
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/28949
lib/internal/modules/cjs/loader.jshttps://github.com/nodejs/node/pull/28949/files#diff-5b5902273122e094ff474fda358605ffa45a4a58b51cd0bf4c1acb93779df142
Please reload this pagehttps://github.com/nodejs/node/pull/28949
src/module_wrap.cchttps://github.com/nodejs/node/pull/28949/files#diff-ea501528b0419a0e268dba0a111869879926d671b7e4240a7f8177e9eb384a4b
Please reload this pagehttps://github.com/nodejs/node/pull/28949
test/es-module/test-esm-exports.mjshttps://github.com/nodejs/node/pull/28949/files#diff-4eaf23a91cb7a683205696ec3d4e59ffd7dad8786878f87d00b5dc006bfc7913
Please reload this pagehttps://github.com/nodejs/node/pull/28949
https://github.com/ljharb
ljharbhttps://github.com/ljharb
Aug 3, 2019 https://github.com/nodejs/node/pull/28949#pullrequestreview-270463076
View reviewed changes https://github.com/nodejs/node/pull/28949/files
doc/api/esm.mdhttps://github.com/nodejs/node/pull/28949/files#diff-f404db6c314f6baf7acc00e537fd4ade2761d9674199268712e6102ee3136c6b
ljharbhttps://github.com/ljharb
Aug 3, 2019https://github.com/nodejs/node/pull/28949#discussion_r310354498
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/28949
guybedfordhttps://github.com/guybedford
Aug 4, 2019https://github.com/nodejs/node/pull/28949#discussion_r310366544
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/28949
ljharbhttps://github.com/ljharb
Aug 4, 2019https://github.com/nodejs/node/pull/28949#discussion_r310367388
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/28949
hybristhttps://github.com/hybrist
Aug 5, 2019https://github.com/nodejs/node/pull/28949#discussion_r310662466
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/28949
ljharbhttps://github.com/ljharb
Aug 5, 2019https://github.com/nodejs/node/pull/28949#discussion_r310825178
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/28949
guybedfordhttps://github.com/guybedford
Aug 6, 2019https://github.com/nodejs/node/pull/28949#discussion_r310874986
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/28949
ljharbhttps://github.com/ljharb
Aug 6, 2019https://github.com/nodejs/node/pull/28949#discussion_r310878619
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/28949
guybedfordhttps://github.com/guybedford
Aug 6, 2019https://github.com/nodejs/node/pull/28949#discussion_r310900073
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/28949
ljharbhttps://github.com/ljharb
Aug 6, 2019https://github.com/nodejs/node/pull/28949#discussion_r311105544
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/28949
guybedfordhttps://github.com/guybedford
Aug 7, 2019https://github.com/nodejs/node/pull/28949#discussion_r311331222
Please reload this pagehttps://github.com/nodejs/node/pull/28949
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/28949
lib/internal/modules/cjs/loader.jshttps://github.com/nodejs/node/pull/28949/files#diff-5b5902273122e094ff474fda358605ffa45a4a58b51cd0bf4c1acb93779df142
Please reload this pagehttps://github.com/nodejs/node/pull/28949
lib/internal/modules/cjs/loader.jshttps://github.com/nodejs/node/pull/28949/files#diff-5b5902273122e094ff474fda358605ffa45a4a58b51cd0bf4c1acb93779df142
Please reload this pagehttps://github.com/nodejs/node/pull/28949
src/module_wrap.cchttps://github.com/nodejs/node/pull/28949/files#diff-ea501528b0419a0e268dba0a111869879926d671b7e4240a7f8177e9eb384a4b
Please reload this pagehttps://github.com/nodejs/node/pull/28949
https://github.com/guybedford
guybedfordhttps://github.com/guybedford
Aug 4, 2019https://github.com/nodejs/node/pull/28949#issuecomment-517964686
Please reload this pagehttps://github.com/nodejs/node/pull/28949
https://github.com/bmeck
bmeckhttps://github.com/bmeck
Aug 4, 2019https://github.com/nodejs/node/pull/28949#issuecomment-517965826
@guybedfordhttps://github.com/guybedford
Please reload this pagehttps://github.com/nodejs/node/pull/28949
https://github.com/guybedford
guybedfordhttps://github.com/guybedford
Aug 4, 2019https://github.com/nodejs/node/pull/28949#issuecomment-517966789
Please reload this pagehttps://github.com/nodejs/node/pull/28949
https://github.com/ljharb
ljharbhttps://github.com/ljharb
Aug 4, 2019 https://github.com/nodejs/node/pull/28949#pullrequestreview-270477705
View reviewed changes https://github.com/nodejs/node/pull/28949/files
lib/internal/modules/cjs/loader.jshttps://github.com/nodejs/node/pull/28949/files#diff-5b5902273122e094ff474fda358605ffa45a4a58b51cd0bf4c1acb93779df142
Please reload this pagehttps://github.com/nodejs/node/pull/28949
doc/api/esm.mdhttps://github.com/nodejs/node/pull/28949/files#diff-f404db6c314f6baf7acc00e537fd4ade2761d9674199268712e6102ee3136c6b
ljharbhttps://github.com/ljharb
Aug 4, 2019https://github.com/nodejs/node/pull/28949#discussion_r310367388
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/28949
https://github.com/guybedford
guybedfordhttps://github.com/guybedford
Aug 4, 2019https://github.com/nodejs/node/pull/28949#issuecomment-517967460
Please reload this pagehttps://github.com/nodejs/node/pull/28949
https://github.com/hybrist
hybristhttps://github.com/hybrist
Aug 4, 2019https://github.com/nodejs/node/pull/28949#issuecomment-517968432
…https://github.com/nodejs/node/pull/28949
#28949https://github.com/nodejs/node/pull/28949
https://github.com/notifications/unsubscribe-auth/AAEKR5E6F2HFVZQWMJKMD4DQCYZ5VANCNFSM4IJCID4Ahttps://github.com/notifications/unsubscribe-auth/AAEKR5E6F2HFVZQWMJKMD4DQCYZ5VANCNFSM4IJCID4A
Please reload this pagehttps://github.com/nodejs/node/pull/28949
https://github.com/guybedford
guybedfordhttps://github.com/guybedford
Aug 4, 2019https://github.com/nodejs/node/pull/28949#issuecomment-517970087
Please reload this pagehttps://github.com/nodejs/node/pull/28949
https://github.com/guybedford
guybedfordhttps://github.com/guybedford
bmeckhttps://github.com/bmeck
August 4, 2019 03:13https://github.com/nodejs/node/pull/28949#event-2531572629
https://github.com/vsemozhetbyt
vsemozhetbythttps://github.com/vsemozhetbyt
Aug 4, 2019 https://github.com/nodejs/node/pull/28949#pullrequestreview-270483961
View reviewed changes https://github.com/nodejs/node/pull/28949/files
doc/api/esm.mdhttps://github.com/nodejs/node/pull/28949/files#diff-f404db6c314f6baf7acc00e537fd4ade2761d9674199268712e6102ee3136c6b
Please reload this pagehttps://github.com/nodejs/node/pull/28949
https://github.com/vsemozhetbyt
vsemozhetbythttps://github.com/vsemozhetbyt
Aug 4, 2019 https://github.com/nodejs/node/pull/28949#pullrequestreview-270484055
View reviewed changes https://github.com/nodejs/node/pull/28949/files
doc/api/esm.mdhttps://github.com/nodejs/node/pull/28949/files#diff-f404db6c314f6baf7acc00e537fd4ade2761d9674199268712e6102ee3136c6b
Please reload this pagehttps://github.com/nodejs/node/pull/28949
https://github.com/bmeck
bmeckhttps://github.com/bmeck
Aug 5, 2019 https://github.com/nodejs/node/pull/28949#pullrequestreview-270782322
View reviewed changes https://github.com/nodejs/node/pull/28949/files
lib/internal/modules/cjs/loader.jshttps://github.com/nodejs/node/pull/28949/files#diff-5b5902273122e094ff474fda358605ffa45a4a58b51cd0bf4c1acb93779df142
Please reload this pagehttps://github.com/nodejs/node/pull/28949
https://github.com/bmeck
bmeckhttps://github.com/bmeck
Aug 5, 2019 https://github.com/nodejs/node/pull/28949#pullrequestreview-270782520
View reviewed changes https://github.com/nodejs/node/pull/28949/files
lib/internal/modules/cjs/loader.jshttps://github.com/nodejs/node/pull/28949/files#diff-5b5902273122e094ff474fda358605ffa45a4a58b51cd0bf4c1acb93779df142
Please reload this pagehttps://github.com/nodejs/node/pull/28949
https://github.com/bmeck
bmeckhttps://github.com/bmeck
Aug 5, 2019 https://github.com/nodejs/node/pull/28949#pullrequestreview-270782853
View reviewed changes https://github.com/nodejs/node/pull/28949/files
bmeckhttps://github.com/bmeck
https://github.com/nodejs/node/pull/28949#pullrequestreview-270782853
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/28949
https://github.com/bmeck
bmeckhttps://github.com/bmeck
Aug 5, 2019https://github.com/nodejs/node/pull/28949#issuecomment-518245621
Please reload this pagehttps://github.com/nodejs/node/pull/28949
https://github.com/hybrist
hybristhttps://github.com/hybrist
Aug 5, 2019 https://github.com/nodejs/node/pull/28949#pullrequestreview-270845441
View reviewed changes https://github.com/nodejs/node/pull/28949/files
hybristhttps://github.com/hybrist
https://github.com/nodejs/node/pull/28949#pullrequestreview-270845441
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/28949
doc/api/modules.mdhttps://github.com/nodejs/node/pull/28949/files#diff-ab8461c2cc1f015131fdce810140965ab708f259aacb95c493d8faac53f7e6a8
hybristhttps://github.com/hybrist
Aug 5, 2019https://github.com/nodejs/node/pull/28949#discussion_r310665128
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/28949
guybedfordhttps://github.com/guybedford
August 5, 2019 21:41https://github.com/nodejs/node/pull/28949#commits-pushed-fe2648c
https://github.com/guybedford
module: pkg exports validations and fallbackshttps://github.com/nodejs/node/pull/28949/commits/fe2648c28056ad31ffc05a56c1c6f07781e1bfc3
fe2648chttps://github.com/nodejs/node/pull/28949/commits/fe2648c28056ad31ffc05a56c1c6f07781e1bfc3
https://github.com/guybedford
feedback, ownproperty checkshttps://github.com/nodejs/node/pull/28949/commits/3a1d4938862af6c88941e12a2d5c3e062774afb5
3a1d493https://github.com/nodejs/node/pull/28949/commits/3a1d4938862af6c88941e12a2d5c3e062774afb5
https://github.com/guybedford
node_modules filtering in exports and boundarieshttps://github.com/nodejs/node/pull/28949/commits/7597165e428789a1455c71fe42d184dec0988da3
7597165https://github.com/nodejs/node/pull/28949/commits/7597165e428789a1455c71fe42d184dec0988da3
https://github.com/guybedford
linting fixeshttps://github.com/nodejs/node/pull/28949/commits/6cdcf6c084f4f23bb60658537c694749edd69cbb
6cdcf6chttps://github.com/nodejs/node/pull/28949/commits/6cdcf6c084f4f23bb60658537c694749edd69cbb
https://github.com/guybedford
https://github.com/vsemozhetbyt
Fixup backslash escapinghttps://github.com/nodejs/node/pull/28949/commits/20f06d8d72c6dada5cec4cc3e3ba9c73a9975c39
20f06d8https://github.com/nodejs/node/pull/28949/commits/20f06d8d72c6dada5cec4cc3e3ba9c73a9975c39
https://github.com/guybedford
https://github.com/vsemozhetbyt
Closing brackethttps://github.com/nodejs/node/pull/28949/commits/110fa261f0e29edc0171e46413ea9851d34f78c2
110fa26https://github.com/nodejs/node/pull/28949/commits/110fa261f0e29edc0171e46413ea9851d34f78c2
https://github.com/guybedford
fixup double node_modules checkhttps://github.com/nodejs/node/pull/28949/commits/406cb0209f0934f6880d51c2e51d555b03b617a4
406cb02https://github.com/nodejs/node/pull/28949/commits/406cb0209f0934f6880d51c2e51d555b03b617a4
https://github.com/guybedford
guybedfordhttps://github.com/guybedford
force-pushedhttps://github.com/nodejs/node/compare/677ee4e751dcd57bde92181a1f1109601b07a2b9..5e588104a1e0f5520bfc31f36c1bae28a767e8f9
677ee4ehttps://github.com/nodejs/node/commit/677ee4e751dcd57bde92181a1f1109601b07a2b9
5e58810https://github.com/nodejs/node/commit/5e588104a1e0f5520bfc31f36c1bae28a767e8f9
Compare https://github.com/nodejs/node/compare/677ee4e751dcd57bde92181a1f1109601b07a2b9..5e588104a1e0f5520bfc31f36c1bae28a767e8f9
August 6, 2019 01:50https://github.com/nodejs/node/pull/28949#event-2535204164
https://github.com/hybrist
hybristhttps://github.com/hybrist
Aug 6, 2019 https://github.com/nodejs/node/pull/28949#pullrequestreview-271091440
View reviewed changes https://github.com/nodejs/node/pull/28949/files/a7e3e76762b6fe46846c9f5c04489fdc90df1cc8
lib/internal/modules/cjs/loader.jshttps://github.com/nodejs/node/pull/28949/files/a7e3e76762b6fe46846c9f5c04489fdc90df1cc8#diff-5b5902273122e094ff474fda358605ffa45a4a58b51cd0bf4c1acb93779df142
Please reload this pagehttps://github.com/nodejs/node/pull/28949
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
Aug 6, 2019https://github.com/nodejs/node/pull/28949#issuecomment-518477032
https://ci.nodejs.org/job/node-test-pull-request/24852/https://ci.nodejs.org/job/node-test-pull-request/24852/
Please reload this pagehttps://github.com/nodejs/node/pull/28949
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
Aug 6, 2019https://github.com/nodejs/node/pull/28949#issuecomment-518489069
https://ci.nodejs.org/job/node-test-pull-request/24854/https://ci.nodejs.org/job/node-test-pull-request/24854/
Please reload this pagehttps://github.com/nodejs/node/pull/28949
https://github.com/bmeck
bmeckhttps://github.com/bmeck
Aug 6, 2019 https://github.com/nodejs/node/pull/28949#pullrequestreview-271404456
View reviewed changes https://github.com/nodejs/node/pull/28949/files/a7e3e76762b6fe46846c9f5c04489fdc90df1cc8
https://github.com/guybedford
or -> and spec fixuphttps://github.com/nodejs/node/pull/28949/commits/0274de77f5beb3245c343d3cd27708403a747a54
0274de7https://github.com/nodejs/node/pull/28949/commits/0274de77f5beb3245c343d3cd27708403a747a54
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
Aug 8, 2019https://github.com/nodejs/node/pull/28949#issuecomment-519343251
https://ci.nodejs.org/job/node-test-pull-request/24887/https://ci.nodejs.org/job/node-test-pull-request/24887/
Please reload this pagehttps://github.com/nodejs/node/pull/28949
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
Aug 8, 2019https://github.com/nodejs/node/pull/28949#issuecomment-519367649
https://ci.nodejs.org/job/node-test-pull-request/24888/https://ci.nodejs.org/job/node-test-pull-request/24888/
Please reload this pagehttps://github.com/nodejs/node/pull/28949
https://github.com/Trott
Trotthttps://github.com/Trott
Aug 8, 2019https://github.com/nodejs/node/pull/28949#issuecomment-519595851
@ljharbhttps://github.com/ljharb
Please reload this pagehttps://github.com/nodejs/node/pull/28949
https://github.com/ljharb
ljharbhttps://github.com/ljharb
Aug 8, 2019 https://github.com/nodejs/node/pull/28949#pullrequestreview-272701253
View reviewed changes https://github.com/nodejs/node/pull/28949/files/0274de77f5beb3245c343d3cd27708403a747a54
ljharbhttps://github.com/ljharb
https://github.com/nodejs/node/pull/28949#pullrequestreview-272701253
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/28949
https://github.com/guybedford
guybedfordhttps://github.com/guybedford
author ready https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22author%20ready%22
Aug 9, 2019https://github.com/nodejs/node/pull/28949#event-2545111781
https://github.com/guybedford
guybedfordhttps://github.com/guybedford
Aug 10, 2019https://github.com/nodejs/node/pull/28949#issuecomment-520116068
Please reload this pagehttps://github.com/nodejs/node/pull/28949
https://github.com/hybrist
hybristhttps://github.com/hybrist
Aug 10, 2019 https://github.com/nodejs/node/pull/28949#pullrequestreview-273427834
View reviewed changes https://github.com/nodejs/node/pull/28949/files/0274de77f5beb3245c343d3cd27708403a747a54
lib/internal/modules/cjs/loader.jshttps://github.com/nodejs/node/pull/28949/files/0274de77f5beb3245c343d3cd27708403a747a54#diff-5b5902273122e094ff474fda358605ffa45a4a58b51cd0bf4c1acb93779df142
Please reload this pagehttps://github.com/nodejs/node/pull/28949
https://github.com/guybedford
ensure target dir mappings remain in target dirhttps://github.com/nodejs/node/pull/28949/commits/52fb8462ad9feb8f4bb67ba478eed56d863b8332
52fb846https://github.com/nodejs/node/pull/28949/commits/52fb8462ad9feb8f4bb67ba478eed56d863b8332
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
Aug 11, 2019https://github.com/nodejs/node/pull/28949#issuecomment-520204158
https://ci.nodejs.org/job/node-test-pull-request/24935/https://ci.nodejs.org/job/node-test-pull-request/24935/
Please reload this pagehttps://github.com/nodejs/node/pull/28949
https://github.com/guybedford
guybedfordhttps://github.com/guybedford
Aug 12, 2019https://github.com/nodejs/node/pull/28949#issuecomment-520373263
2103ae4https://github.com/nodejs/node/commit/2103ae483547831281e1e3882029e37d445689a7
Please reload this pagehttps://github.com/nodejs/node/pull/28949
https://github.com/guybedford
guybedfordhttps://github.com/guybedford
Aug 12, 2019https://github.com/nodejs/node/pull/28949#event-2549752057
https://github.com/guybedford
guybedfordhttps://github.com/guybedford
August 12, 2019 10:31https://github.com/nodejs/node/pull/28949#event-2549752413
guybedfordhttps://github.com/guybedford
Aug 12, 2019 https://github.com/nodejs/node/pull/28949#ref-commit-2103ae4
https://github.com/guybedford
module: pkg exports validations and fallbackshttps://github.com/nodejs/node/commit/2103ae483547831281e1e3882029e37d445689a7
2103ae4https://github.com/nodejs/node/commit/2103ae483547831281e1e3882029e37d445689a7
#28949https://github.com/nodejs/node/pull/28949
https://github.com/hybrist
hybristhttps://github.com/hybrist
Aug 13, 2019 https://github.com/nodejs/node/pull/28949#ref-issue-471782298
Validate exports keys and values nodejs/modules#359 https://github.com/nodejs/modules/issues/359
targoshttps://github.com/targos
Aug 19, 2019 https://github.com/nodejs/node/pull/28949#ref-commit-cb16229
https://github.com/guybedford
https://github.com/targos
module: pkg exports validations and fallbackshttps://github.com/nodejs/node/commit/cb162298eb08a0ee658895823920e5431332fd61
cb16229https://github.com/nodejs/node/commit/cb162298eb08a0ee658895823920e5431332fd61
#28949https://github.com/nodejs/node/pull/28949
https://github.com/targos
targoshttps://github.com/targos
Aug 19, 2019 https://github.com/nodejs/node/pull/28949#ref-pullrequest-482485175
v12.9.0 release proposal #29210 https://github.com/nodejs/node/pull/29210
2019-08-20 Version 12.9.0 (Current) @targos beevelop/docker-android-nodejs#328 https://github.com/beevelop/docker-android-nodejs/issues/328
2019-08-20 Version 12.9.0 (Current) @targos beevelop/docker-android-nodejs#329 https://github.com/beevelop/docker-android-nodejs/issues/329
2019-08-20 Version 12.9.0 (Current) @targos beevelop/docker-android-nodejs#330 https://github.com/beevelop/docker-android-nodejs/issues/330
2019-08-20 Version 12.9.0 (Current) @targos beevelop/docker-nodejs#295 https://github.com/beevelop/docker-nodejs/issues/295
2019-08-20 Version 12.9.0 (Current) @targos beevelop/docker-nodejs#296 https://github.com/beevelop/docker-nodejs/issues/296
2019-08-20 Version 12.9.0 (Current) @targos beevelop/docker-nodejs#297 https://github.com/beevelop/docker-nodejs/issues/297
https://github.co/hiddenchars
https://github.com/nodejs/node/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F28949
https://github.com/hybrist
hybrist https://github.com/hybrist
https://github.com/nodejs/node/pull/28949/files/0274de77f5beb3245c343d3cd27708403a747a54
https://github.com/ljharb
ljharb https://github.com/ljharb
https://github.com/nodejs/node/pull/28949/files/0274de77f5beb3245c343d3cd27708403a747a54
https://github.com/vsemozhetbyt
vsemozhetbyt https://github.com/vsemozhetbyt
https://github.com/nodejs/node/pull/28949/files/5be6a9cfed0a034841b4b67761f35c1375284984
https://github.com/bmeck
bmeck https://github.com/bmeck
https://github.com/nodejs/node/pull/28949/files/a7e3e76762b6fe46846c9f5c04489fdc90df1cc8
author ready https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22author%20ready%22
c++ https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Ac%2B%2B
Please reload this pagehttps://github.com/nodejs/node/pull/28949
https://github.com/guybedford
https://github.com/bmeck
https://github.com/hybrist
https://github.com/nodejs-github-bot
https://github.com/Trott
https://github.com/ljharb
https://github.com/vsemozhetbyt
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.