| route-pattern | /_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format) |
| route-controller | voltron_pull_requests_fragments |
| route-action | pull_request_layout |
| fetch-nonce | v2:5d973b56-4de8-7a5c-2c2b-70e6dd247e0e |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | ED2C:16195D:28E08B4:385775E:6A4F5099 |
| html-safe-nonce | 3239472406bee8941bfd22d6073392fddb4d9c0b0adabac2da3a5d935d90f892 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJFRDJDOjE2MTk1RDoyOEUwOEI0OjM4NTc3NUU6NkE0RjUwOTkiLCJ2aXNpdG9yX2lkIjoiNjM4ODQ0ODMxOTM4ODU5MTYyIiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0= |
| visitor-hmac | 8525d4e54411248a0955212518e3917fae59e2374bd048b2fe036cf61125d394 |
| hovercard-subject-tag | pull_request:45129960 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///voltron/pull_requests_fragments/pull_request_layout |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/2893/pull_request_layout |
| twitter:image | https://opengraph.githubassets.com/ccb67c4c8b2f32d065d0a3fe3ace9c9beddd203f36c2d1a67b046432c606a7ba/nodejs/node/pull/2893 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/ccb67c4c8b2f32d065d0a3fe3ace9c9beddd203f36c2d1a67b046432c606a7ba/nodejs/node/pull/2893 |
| og:image:alt | By default v8 allocates typed arrays <= 64 bytes inside the v8 heap. In
these cases the memory pointer returned by Buffer::Data() can change
while the memory is being operated on. Resolve by pas... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | trevnorris |
| hostname | github.com |
| expected-hostname | github.com |
| None | b92d11c0aa4a77d54ef4af1078b6a15fb5a70a215b30c4ecf28889d5a8e656d9 |
| turbo-cache-control | no-cache |
| go-import | github.com/nodejs/node git https://github.com/nodejs/node.git |
| octolytics-dimension-user_id | 9950313 |
| octolytics-dimension-user_login | nodejs |
| octolytics-dimension-repository_id | 27193779 |
| octolytics-dimension-repository_nwo | nodejs/node |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 27193779 |
| octolytics-dimension-repository_network_root_nwo | nodejs/node |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 4b249b445842943ed31549e027f57a8ade9881ed |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| Skip to content | https://github.com/nodejs/node/pull/2893#start-of-content |
|
| https://github.com/ |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F2893 |
| GitHub CopilotWrite better code with AI | https://github.com/features/copilot |
| GitHub Copilot appDirect agents from issue to merge | https://github.com/features/ai/github-app |
| MCP RegistryNewIntegrate external tools | https://github.com/mcp |
| ActionsAutomate any workflow | https://github.com/features/actions |
| CodespacesInstant dev environments | https://github.com/features/codespaces |
| IssuesPlan and track work | https://github.com/features/issues |
| Code ReviewManage code changes | https://github.com/features/code-review |
| GitHub Advanced SecurityFind and fix vulnerabilities | https://github.com/security/advanced-security |
| Code securitySecure your code as you build | https://github.com/security/advanced-security/code-security |
| Secret protectionStop leaks before they start | https://github.com/security/advanced-security/secret-protection |
| Why GitHub | https://github.com/why-github |
| Documentation | https://docs.github.com |
| Blog | https://github.blog |
| Changelog | https://github.blog/changelog |
| Marketplace | https://github.com/marketplace |
| View all features | https://github.com/features |
| Enterprises | https://github.com/enterprise |
| Small and medium teams | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| App Modernization | https://github.com/solutions/use-case/app-modernization |
| DevSecOps | https://github.com/solutions/use-case/devsecops |
| DevOps | https://github.com/solutions/use-case/devops |
| CI/CD | https://github.com/solutions/use-case/ci-cd |
| View all use cases | https://github.com/solutions/use-case |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| View all industries | https://github.com/solutions/industry |
| View all solutions | https://github.com/solutions |
| AI | https://github.com/resources/articles?topic=ai |
| Software Development | https://github.com/resources/articles?topic=software-development |
| DevOps | https://github.com/resources/articles?topic=devops |
| Security | https://github.com/resources/articles?topic=security |
| View all topics | https://github.com/resources/articles |
| Customer stories | https://github.com/customer-stories |
| Events & webinars | https://github.com/resources/events |
| Ebooks & reports | https://github.com/resources/whitepapers |
| Business insights | https://github.com/solutions/executive-insights |
| GitHub Skills | https://skills.github.com |
| Documentation | https://docs.github.com |
| Customer support | https://support.github.com |
| Community forum | https://github.com/orgs/community/discussions |
| Trust center | https://github.com/trust-center |
| Partners | https://github.com/partners |
| View all resources | https://github.com/resources |
| GitHub SponsorsFund open source developers | https://github.com/open-source/sponsors |
| Security Lab | https://securitylab.github.com |
| Maintainer Community | https://maintainers.github.com |
| Accelerator | https://github.com/open-source/accelerator |
| GitHub Stars | https://stars.github.com |
| Archive Program | https://archiveprogram.github.com |
| Topics | https://github.com/topics |
| Trending | https://github.com/trending |
| Collections | https://github.com/collections |
| Enterprise platformAI-powered developer platform | https://github.com/enterprise |
| GitHub Advanced SecurityEnterprise-grade security features | https://github.com/security/advanced-security |
| Copilot for BusinessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/enterprise/premium-support |
| Pricing | https://github.com/pricing |
| Search syntax tips | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
| documentation | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F2893 |
|
Sign up
| https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode |
| Reload | https://github.com/nodejs/node/pull/2893 |
| Reload | https://github.com/nodejs/node/pull/2893 |
| Reload | https://github.com/nodejs/node/pull/2893 |
| Please reload this page | https://github.com/nodejs/node/pull/2893 |
|
nodejs
| https://github.com/nodejs |
| node | https://github.com/nodejs/node |
| Please reload this page | https://github.com/nodejs/node/pull/2893 |
|
Notifications
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Fork
36k
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Star
118k
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Code
| https://github.com/nodejs/node |
|
Issues
1.3k
| https://github.com/nodejs/node/issues |
|
Pull requests
970
| https://github.com/nodejs/node/pulls |
|
Actions
| https://github.com/nodejs/node/actions |
|
Projects
| https://github.com/nodejs/node/projects |
|
Security and quality
0
| https://github.com/nodejs/node/security |
|
Insights
| https://github.com/nodejs/node/pulse |
|
Code
| https://github.com/nodejs/node |
|
Issues
| https://github.com/nodejs/node/issues |
|
Pull requests
| https://github.com/nodejs/node/pulls |
|
Actions
| https://github.com/nodejs/node/actions |
|
Projects
| https://github.com/nodejs/node/projects |
|
Security and quality
| https://github.com/nodejs/node/security |
|
Insights
| https://github.com/nodejs/node/pulse |
| trevnorris | https://github.com/trevnorris |
| nodejs:master | https://github.com/nodejs/node/tree/master |
| trevnorris:no-ab-heap-alloc | https://github.com/trevnorris/node/tree/no-ab-heap-alloc |
| Conversation | https://github.com/nodejs/node/pull/2893 |
| Commits1 (1) | https://github.com/nodejs/node/pull/2893/commits |
| Checks | https://github.com/nodejs/node/pull/2893/checks |
| Files changed | https://github.com/nodejs/node/pull/2893/files |
| buffer: always allocate typed arrays outside heap | https://github.com/nodejs/node/pull/2893#top |
| trevnorris | https://github.com/trevnorris |
| nodejs:master | https://github.com/nodejs/node/tree/master |
| trevnorris:no-ab-heap-alloc | https://github.com/trevnorris/node/tree/no-ab-heap-alloc |
|
| https://github.com/trevnorris |
| trevnorris | https://github.com/trevnorris |
| Sep 16, 2015 | https://github.com/nodejs/node/pull/2893#issue-106695828 |
| 74178a5 | https://github.com/nodejs/node/commit/74178a5682958d499896e0fa1af6bc0321ec1935 |
| @indutny | https://github.com/indutny |
| @bnoordhuis | https://github.com/bnoordhuis |
| Please reload this page | https://github.com/nodejs/node/pull/2893 |
|
| https://github.com/trevnorris |
| buffer: always allocate typed arrays outside heap | https://github.com/nodejs/node/pull/2893/commits/3b5181336f06c5697214de0d1bef41ab42b838c5 |
| 3b51813 | https://github.com/nodejs/node/pull/2893/commits/3b5181336f06c5697214de0d1bef41ab42b838c5 |
| 74178a5 | https://github.com/trevnorris/node/commit/74178a5682958d499896e0fa1af6bc0321ec1935 |
| https://github.com/trevnorris |
| trevnorris | https://github.com/trevnorris |
| Sep 16, 2015 | https://github.com/nodejs/node/pull/2893#issuecomment-140622948 |
| https://ci.nodejs.org/job/node-test-pull-request/312/ | https://ci.nodejs.org/job/node-test-pull-request/312/ |
| Please reload this page | https://github.com/nodejs/node/pull/2893 |
| https://github.com/targos |
| targos | https://github.com/targos |
| Sep 16, 2015 | https://github.com/nodejs/node/pull/2893#issuecomment-140623512 |
| Please reload this page | https://github.com/nodejs/node/pull/2893 |
| https://github.com/trevnorris |
| trevnorris | https://github.com/trevnorris |
| Sep 16, 2015 | https://github.com/nodejs/node/pull/2893#issuecomment-140624502 |
| @targos | https://github.com/targos |
| #2882 (comment) | https://github.com/nodejs/node/issues/2882#issuecomment-140558136 |
| Please reload this page | https://github.com/nodejs/node/pull/2893 |
| https://github.com/ChALkeR |
| ChALkeR | https://github.com/ChALkeR |
|
buffer
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Abuffer |
|
c++
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Ac%2B%2B |
| Sep 16, 2015 | https://github.com/nodejs/node/pull/2893#event-410564477 |
| https://github.com/indutny |
| indutny | https://github.com/indutny |
| Sep 16, 2015 | https://github.com/nodejs/node/pull/2893#issuecomment-140627921 |
| Please reload this page | https://github.com/nodejs/node/pull/2893 |
| trevnorris | https://github.com/trevnorris |
|
Sep 16, 2015
| https://github.com/nodejs/node/pull/2893#ref-commit-16f86d6 |
|
| https://github.com/trevnorris |
| buffer: always allocate typed arrays outside heap | https://github.com/nodejs/node/commit/16f86d6c578ff7aec708c7d736558a199d290e9c |
| 16f86d6 | https://github.com/nodejs/node/commit/16f86d6c578ff7aec708c7d736558a199d290e9c |
| 74178a5 | https://github.com/nodejs/node/commit/74178a5682958d499896e0fa1af6bc0321ec1935 |
| #2893 | https://github.com/nodejs/node/pull/2893 |
| https://github.com/trevnorris |
| trevnorris | https://github.com/trevnorris |
| Sep 16, 2015 | https://github.com/nodejs/node/pull/2893#issuecomment-140628610 |
| 16f86d6 | https://github.com/nodejs/node/commit/16f86d6c578ff7aec708c7d736558a199d290e9c |
| Please reload this page | https://github.com/nodejs/node/pull/2893 |
| https://github.com/trevnorris |
| trevnorris | https://github.com/trevnorris |
| Sep 16, 2015 | https://github.com/nodejs/node/pull/2893#event-410575292 |
| https://github.com/trevnorris |
| trevnorris | https://github.com/trevnorris |
|
land-on-v4.x
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aland-on-v4.x |
| Sep 16, 2015 | https://github.com/nodejs/node/pull/2893#event-410575344 |
| https://github.com/trevnorris |
| trevnorris | https://github.com/trevnorris |
| Sep 16, 2015 | https://github.com/nodejs/node/pull/2893#issuecomment-140628675 |
| @Fishrock123 | https://github.com/Fishrock123 |
| Please reload this page | https://github.com/nodejs/node/pull/2893 |
| https://github.com/bnoordhuis |
| bnoordhuis | https://github.com/bnoordhuis |
| Sep 16, 2015 | https://github.com/nodejs/node/pull/2893#issuecomment-140689723 |
| Please reload this page | https://github.com/nodejs/node/pull/2893 |
| trevnorris | https://github.com/trevnorris |
|
Sep 16, 2015
| https://github.com/nodejs/node/pull/2893#ref-commit-4b4cfa2 |
|
| https://github.com/trevnorris |
|
| https://github.com/Fishrock123 |
| buffer: always allocate typed arrays outside heap | https://github.com/nodejs/node/commit/4b4cfa2d44da199855dea7fd114890b7e4f98583 |
| 4b4cfa2 | https://github.com/nodejs/node/commit/4b4cfa2d44da199855dea7fd114890b7e4f98583 |
| 74178a5 | https://github.com/nodejs/node/commit/74178a5682958d499896e0fa1af6bc0321ec1935 |
| #2893 | https://github.com/nodejs/node/pull/2893 |
| https://github.com/Fishrock123 |
| Fishrock123 | https://github.com/Fishrock123 |
|
Sep 16, 2015
| https://github.com/nodejs/node/pull/2893#ref-issue-106216415 |
|
Release proposal: v4.1.0
#2844
| https://github.com/nodejs/node/issues/2844 |
| https://github.com/trevnorris |
| trevnorris | https://github.com/trevnorris |
| September 16, 2015 17:22 | https://github.com/nodejs/node/pull/2893#event-411207814 |
| https://github.com/trevnorris |
| trevnorris | https://github.com/trevnorris |
| Sep 16, 2015 | https://github.com/nodejs/node/pull/2893#issuecomment-140871573 |
| @bnoordhuis | https://github.com/bnoordhuis |
| Please reload this page | https://github.com/nodejs/node/pull/2893 |
| https://github.com/rvagg |
| rvagg | https://github.com/rvagg |
|
Sep 22, 2015
| https://github.com/nodejs/node/pull/2893#ref-pullrequest-107656289 |
|
Release proposal: v4.1.1
#2995
| https://github.com/nodejs/node/pull/2995 |
| https://github.com/jasnell |
| jasnell | https://github.com/jasnell |
|
lts-landed-on-v4.x
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Alts-landed-on-v4.x |
| Oct 7, 2015 | https://github.com/nodejs/node/pull/2893#event-429731321 |
| https://github.com/MylesBorins |
| MylesBorins | https://github.com/MylesBorins |
| Nov 16, 2015 | https://github.com/nodejs/node/pull/2893#issuecomment-157139177 |
| 4b4cfa2 | https://github.com/nodejs/node/commit/4b4cfa2d44da199855dea7fd114890b7e4f98583 |
| Please reload this page | https://github.com/nodejs/node/pull/2893 |
| https://github.com/MylesBorins |
| MylesBorins | https://github.com/MylesBorins |
|
land-on-v4.x
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aland-on-v4.x |
| Nov 16, 2015 | https://github.com/nodejs/node/pull/2893#event-465818880 |
| https://github.com/addaleax |
| addaleax | https://github.com/addaleax |
|
Feb 25, 2019
| https://github.com/nodejs/node/pull/2893#ref-pullrequest-414253425 |
|
src,buffer: allow heap-allocated typed arrays
#26301
| https://github.com/nodejs/node/pull/26301 |
| addaleax | https://github.com/addaleax |
|
Feb 25, 2019
| https://github.com/nodejs/node/pull/2893#ref-commit-356a143 |
|
| https://github.com/addaleax |
| build: remove v8_typed_array_max_size_in_heap option | https://github.com/addaleax/node/commit/356a143cf93e9bbd6c0f6966d14160cf86da19f2 |
| 356a143 | https://github.com/addaleax/node/commit/356a143cf93e9bbd6c0f6966d14160cf86da19f2 |
| 16f86d6 | https://github.com/addaleax/node/commit/16f86d6c578ff7aec708c7d736558a199d290e9c |
| nodejs@16f86d6 | https://github.com/nodejs/node/commit/16f86d6c578ff7aec708c7d736558a199d290e9c |
| nodejs#2893 | https://github.com/nodejs/node/pull/2893 |
| nodejs@74178a5#commitcomment-13250880 | https://github.com/nodejs/node/commit/74178a5682958d499896e0fa1af6bc0321ec1935#commitcomment-13250880 |
| http://logs.libuv.org/node-dev/2015-09-15 | http://logs.libuv.org/node-dev/2015-09-15 |
| addaleax | https://github.com/addaleax |
|
Mar 1, 2019
| https://github.com/nodejs/node/pull/2893#ref-commit-e2baa68 |
|
| https://github.com/addaleax |
| build: remove v8_typed_array_max_size_in_heap option | https://github.com/nodejs/node/commit/e2baa6836b2c9ef60435ad68278b42d6ff06d48a |
| e2baa68 | https://github.com/nodejs/node/commit/e2baa6836b2c9ef60435ad68278b42d6ff06d48a |
| 16f86d6 | https://github.com/nodejs/node/commit/16f86d6c578ff7aec708c7d736558a199d290e9c |
| 16f86d6 | https://github.com/nodejs/node/commit/16f86d6c578ff7aec708c7d736558a199d290e9c |
| #2893 | https://github.com/nodejs/node/pull/2893 |
| 74178a5#commitcomment-13250880 | https://github.com/nodejs/node/commit/74178a5682958d499896e0fa1af6bc0321ec1935#commitcomment-13250880 |
| http://logs.libuv.org/node-dev/2015-09-15 | http://logs.libuv.org/node-dev/2015-09-15 |
| #26301 | https://github.com/nodejs/node/pull/26301 |
| addaleax | https://github.com/addaleax |
|
Mar 1, 2019
| https://github.com/nodejs/node/pull/2893#ref-commit-b42dcb0 |
|
| https://github.com/addaleax |
| build: remove v8_typed_array_max_size_in_heap option | https://github.com/nodejs/node/commit/b42dcb0eeb2d2c302b0ecabbc1092605a54213d6 |
| b42dcb0 | https://github.com/nodejs/node/commit/b42dcb0eeb2d2c302b0ecabbc1092605a54213d6 |
| 16f86d6 | https://github.com/nodejs/node/commit/16f86d6c578ff7aec708c7d736558a199d290e9c |
| 16f86d6 | https://github.com/nodejs/node/commit/16f86d6c578ff7aec708c7d736558a199d290e9c |
| #2893 | https://github.com/nodejs/node/pull/2893 |
| 74178a5#commitcomment-13250880 | https://github.com/nodejs/node/commit/74178a5682958d499896e0fa1af6bc0321ec1935#commitcomment-13250880 |
| http://logs.libuv.org/node-dev/2015-09-15 | http://logs.libuv.org/node-dev/2015-09-15 |
| #26301 | https://github.com/nodejs/node/pull/26301 |
| https://github.co/hiddenchars |
| https://github.com/nodejs/node/pull/{{ revealButtonHref }} |
| Sign up for free | https://github.com/join?source=comment-repo |
| Sign in to comment | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F2893 |
|
buffer
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Abuffer |
|
c++
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Ac%2B%2B |
| Please reload this page | https://github.com/nodejs/node/pull/2893 |
|
| https://github.com/trevnorris |
|
| https://github.com/targos |
|
| https://github.com/indutny |
|
| https://github.com/bnoordhuis |
|
| https://github.com/MylesBorins |
|
| https://github.com/ChALkeR |
|
| https://github.com/jasnell |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |