René's URL Explorer Experiment


Title: Revert "src: remove trace_sync_io_ from env" by ChALkeR · Pull Request #28926 · nodejs/node · GitHub

Open Graph Title: Revert "src: remove trace_sync_io_ from env" by ChALkeR · Pull Request #28926 · nodejs/node

X Title: Revert "src: remove trace_sync_io_ from env" by ChALkeR · Pull Request #28926 · nodejs/node

Description: Node.js JavaScript runtime ✨🐢🚀✨. Contribute to nodejs/node development by creating an account on GitHub.

Open Graph Description: This reverts commit 7fa5f54. Fixes: #28913 7fa5f54 breaks the logic behind --trace-sync-io, it should be enabled only at a certain point in time, while that commit enables it from the very start, c...

X Description: This reverts commit 7fa5f54. Fixes: #28913 7fa5f54 breaks the logic behind --trace-sync-io, it should be enabled only at a certain point in time, while that commit enables it from the very start, c...

Opengraph URL: https://github.com/nodejs/node/pull/28926

X: @github

direct link

Domain: github.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:963d9bce-6844-0345-a000-3c1284246981
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idDF54:33952:195F324:228BFF0:6A4F139D
html-safe-nonceb8452cb325be16a3f8a84a154304fee6f313327e77c1b6fb3f1e720f4355faec
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJERjU0OjMzOTUyOjE5NUYzMjQ6MjI4QkZGMDo2QTRGMTM5RCIsInZpc2l0b3JfaWQiOiI1MzYyNDM5MDQ5MzUxOTkyMjIxIiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmac3ea72a4bd862cefe6d20e80ec77c5d4176fed46cd70ef9451319e79e55e0131e
hovercard-subject-tagpull_request:303439956
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/28926/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/83580c71594899dd3b1f7a21d3b8c0ec24a8231a75b9496fdb28cce82903d738/nodejs/node/pull/28926
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/83580c71594899dd3b1f7a21d3b8c0ec24a8231a75b9496fdb28cce82903d738/nodejs/node/pull/28926
og:image:altThis reverts commit 7fa5f54. Fixes: #28913 7fa5f54 breaks the logic behind --trace-sync-io, it should be enabled only at a certain point in time, while that commit enables it from the very start, c...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernameChALkeR
hostnamegithub.com
expected-hostnamegithub.com
Noneb92d11c0aa4a77d54ef4af1078b6a15fb5a70a215b30c4ecf28889d5a8e656d9
turbo-cache-controlno-cache
go-importgithub.com/nodejs/node git https://github.com/nodejs/node.git
octolytics-dimension-user_id9950313
octolytics-dimension-user_loginnodejs
octolytics-dimension-repository_id27193779
octolytics-dimension-repository_nwonodejs/node
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id27193779
octolytics-dimension-repository_network_root_nwonodejs/node
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release2b8f23afb982271f1b22258a94aede67a6b77760
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/nodejs/node/pull/28926#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F28926
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub Copilot appDirect agents from issue to mergehttps://github.com/features/ai/github-app
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
View all resourceshttps://github.com/resources
GitHub SponsorsFund open source developershttps://github.com/open-source/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/open-source/accelerator
GitHub Starshttps://stars.github.com
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F28926
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode
Reloadhttps://github.com/nodejs/node/pull/28926
Reloadhttps://github.com/nodejs/node/pull/28926
Reloadhttps://github.com/nodejs/node/pull/28926
Please reload this pagehttps://github.com/nodejs/node/pull/28926
nodejs https://github.com/nodejs
nodehttps://github.com/nodejs/node
Please reload this pagehttps://github.com/nodejs/node/pull/28926
Notifications https://github.com/login?return_to=%2Fnodejs%2Fnode
Fork 36k https://github.com/login?return_to=%2Fnodejs%2Fnode
Star 118k https://github.com/login?return_to=%2Fnodejs%2Fnode
Code https://github.com/nodejs/node
Issues 1.3k https://github.com/nodejs/node/issues
Pull requests 967 https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects https://github.com/nodejs/node/projects
Security and quality 0 https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
Code https://github.com/nodejs/node
Issues https://github.com/nodejs/node/issues
Pull requests https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects https://github.com/nodejs/node/projects
Security and quality https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
ChALkeRhttps://github.com/ChALkeR
nodejs:masterhttps://github.com/nodejs/node/tree/master
ChALkeR:revert-7fa5f54e6fhttps://github.com/ChALkeR/io.js/tree/revert-7fa5f54e6f
Conversationhttps://github.com/nodejs/node/pull/28926
Commits1 (1)https://github.com/nodejs/node/pull/28926/commits
Checkshttps://github.com/nodejs/node/pull/28926/checks
Files changedhttps://github.com/nodejs/node/pull/28926/files
Revert "src: remove trace_sync_io_ from env"https://github.com/nodejs/node/pull/28926#top
ChALkeRhttps://github.com/ChALkeR
nodejs:masterhttps://github.com/nodejs/node/tree/master
ChALkeR:revert-7fa5f54e6fhttps://github.com/ChALkeR/io.js/tree/revert-7fa5f54e6f
https://github.com/ChALkeR
ChALkeRhttps://github.com/ChALkeR
Aug 1, 2019https://github.com/nodejs/node/pull/28926#issue-475749948
Please reload this pagehttps://github.com/nodejs/node/pull/28926
7fa5f54https://github.com/nodejs/node/commit/7fa5f54e6f2854183e45e0e105a1e22a381aac60
#28913https://github.com/nodejs/node/issues/28913
https://nodejs.org/api/cli.html#cli_trace_sync_iohttps://nodejs.org/api/cli.html#cli_trace_sync_io
#22726https://github.com/nodejs/node/pull/22726
commit guidelineshttps://github.com/nodejs/node/blob/master/doc/guides/contributing/pull-requests.md#commit-message-guidelines
Please reload this pagehttps://github.com/nodejs/node/pull/28926
https://github.com/ChALkeR
ChALkeRhttps://github.com/ChALkeR
c++ https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Ac%2B%2B
lib / src https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22lib%20%2F%20src%22
regression https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aregression
Aug 1, 2019https://github.com/nodejs/node/pull/28926#event-2526988383
https://github.com/ChALkeR
ChALkeRhttps://github.com/ChALkeR
Fishrock123https://github.com/Fishrock123
addaleaxhttps://github.com/addaleax
danbevhttps://github.com/danbev
jasnellhttps://github.com/jasnell
August 1, 2019 15:31https://github.com/nodejs/node/pull/28926#event-2526988401
https://github.com/ChALkeR
ChALkeRhttps://github.com/ChALkeR
Aug 1, 2019 https://github.com/nodejs/node/pull/28926#ref-issue-475314302
--trace-sync-io regression between v10.10 and v10.11 #28913 https://github.com/nodejs/node/issues/28913
https://github.com/cjihrig
cjihrighttps://github.com/cjihrig
Aug 1, 2019https://github.com/nodejs/node/pull/28926#issuecomment-517343718
Please reload this pagehttps://github.com/nodejs/node/pull/28926
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
Aug 1, 2019 https://github.com/nodejs/node/pull/28926#pullrequestreview-269716425
View reviewed changes https://github.com/nodejs/node/pull/28926/files
addaleaxhttps://github.com/addaleax
https://github.com/nodejs/node/pull/28926#pullrequestreview-269716425
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/28926
https://github.com/ChALkeR
ChALkeRhttps://github.com/ChALkeR
Aug 1, 2019https://github.com/nodejs/node/pull/28926#issuecomment-517350282
Please reload this pagehttps://github.com/nodejs/node/pull/28926
@cjihrighttps://github.com/cjihrig
Please reload this pagehttps://github.com/nodejs/node/pull/28926
https://github.com/Trott
Trotthttps://github.com/Trott
Aug 1, 2019 https://github.com/nodejs/node/pull/28926#pullrequestreview-269722999
View reviewed changes https://github.com/nodejs/node/pull/28926/files
https://github.com/cjihrig
cjihrighttps://github.com/cjihrig
Aug 1, 2019 https://github.com/nodejs/node/pull/28926#pullrequestreview-269728690
View reviewed changes https://github.com/nodejs/node/pull/28926/files
https://github.com/jasnell
jasnellhttps://github.com/jasnell
Aug 1, 2019 https://github.com/nodejs/node/pull/28926#pullrequestreview-269798879
View reviewed changes https://github.com/nodejs/node/pull/28926/files
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
Aug 2, 2019https://github.com/nodejs/node/pull/28926#issuecomment-517517718
https://ci.nodejs.org/job/node-test-pull-request/24817/https://ci.nodejs.org/job/node-test-pull-request/24817/
Please reload this pagehttps://github.com/nodejs/node/pull/28926
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
Aug 2, 2019https://github.com/nodejs/node/pull/28926#issuecomment-517538875
https://ci.nodejs.org/job/node-test-pull-request/24821/https://ci.nodejs.org/job/node-test-pull-request/24821/
Please reload this pagehttps://github.com/nodejs/node/pull/28926
https://github.com/ChALkeR
Revert "src: remove trace_sync_io_ from env"https://github.com/nodejs/node/pull/28926/commits/31973cc1628523c31f6e04457765d884d5cb62a3
31973cchttps://github.com/nodejs/node/pull/28926/commits/31973cc1628523c31f6e04457765d884d5cb62a3
7fa5f54https://github.com/ChALkeR/io.js/commit/7fa5f54e6f2854183e45e0e105a1e22a381aac60
nodejs#28913https://github.com/nodejs/node/issues/28913
nodejs#22726https://github.com/nodejs/node/pull/22726
https://nodejs.org/api/cli.html#cli_trace_sync_iohttps://nodejs.org/api/cli.html#cli_trace_sync_io
nodejs#28926https://github.com/nodejs/node/pull/28926
https://github.com/ChALkeR
ChALkeRhttps://github.com/ChALkeR
force-pushedhttps://github.com/nodejs/node/compare/31cbdd79bd24aa1718632003ae7253a340fe6964..31973cc1628523c31f6e04457765d884d5cb62a3
31cbdd7https://github.com/nodejs/node/commit/31cbdd79bd24aa1718632003ae7253a340fe6964
31973cchttps://github.com/nodejs/node/commit/31973cc1628523c31f6e04457765d884d5cb62a3
Compare https://github.com/nodejs/node/compare/31cbdd79bd24aa1718632003ae7253a340fe6964..31973cc1628523c31f6e04457765d884d5cb62a3
August 2, 2019 13:34https://github.com/nodejs/node/pull/28926#event-2529683096
https://github.com/ChALkeR
ChALkeRhttps://github.com/ChALkeR
Aug 2, 2019https://github.com/nodejs/node/pull/28926#issuecomment-517702863
Please reload this pagehttps://github.com/nodejs/node/pull/28926
Please reload this pagehttps://github.com/nodejs/node/pull/28926
https://github.com/ChALkeR
ChALkeRhttps://github.com/ChALkeR
Aug 2, 2019 https://github.com/nodejs/node/pull/28926#ref-pullrequest-476202890
process: add .stillSynchronous #28941 https://github.com/nodejs/node/pull/28941
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
author ready https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22author%20ready%22
Aug 2, 2019https://github.com/nodejs/node/pull/28926#event-2529837746
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
Aug 2, 2019https://github.com/nodejs/node/pull/28926#issuecomment-517806893
https://ci.nodejs.org/job/node-test-pull-request/24831/https://ci.nodejs.org/job/node-test-pull-request/24831/
Please reload this pagehttps://github.com/nodejs/node/pull/28926
https://github.com/Trott
Trotthttps://github.com/Trott
Aug 4, 2019https://github.com/nodejs/node/pull/28926#issuecomment-517971185
aa252ebhttps://github.com/nodejs/node/commit/aa252ebf66c4ba5a5861293e7b95beb3436ff780
Please reload this pagehttps://github.com/nodejs/node/pull/28926
https://github.com/Trott
Trotthttps://github.com/Trott
Aug 4, 2019https://github.com/nodejs/node/pull/28926#event-2531578971
Trotthttps://github.com/Trott
Aug 4, 2019 https://github.com/nodejs/node/pull/28926#ref-commit-aa252eb
https://github.com/ChALkeR
https://github.com/Trott
Revert "src: remove trace_sync_io_ from env"https://github.com/Trott/io.js/commit/aa252ebf66c4ba5a5861293e7b95beb3436ff780
aa252ebhttps://github.com/Trott/io.js/commit/aa252ebf66c4ba5a5861293e7b95beb3436ff780
7fa5f54https://github.com/Trott/io.js/commit/7fa5f54e6f2854183e45e0e105a1e22a381aac60
nodejs#28913https://github.com/nodejs/node/issues/28913
nodejs#22726https://github.com/nodejs/node/pull/22726
https://nodejs.org/api/cli.html#cli_trace_sync_iohttps://nodejs.org/api/cli.html#cli_trace_sync_io
nodejs#28926https://github.com/nodejs/node/pull/28926
https://github.com/ChALkeR
ChALkeRhttps://github.com/ChALkeR
August 4, 2019 09:29https://github.com/nodejs/node/pull/28926#event-2531680162
BridgeARhttps://github.com/BridgeAR
Aug 6, 2019 https://github.com/nodejs/node/pull/28926#ref-commit-4a747f6
https://github.com/ChALkeR
https://github.com/BridgeAR
Revert "src: remove trace_sync_io_ from env"https://github.com/nodejs/node/commit/4a747f6037c7a589ae88b7a0238fea4218cce471
4a747f6https://github.com/nodejs/node/commit/4a747f6037c7a589ae88b7a0238fea4218cce471
7fa5f54https://github.com/nodejs/node/commit/7fa5f54e6f2854183e45e0e105a1e22a381aac60
#28913https://github.com/nodejs/node/issues/28913
#22726https://github.com/nodejs/node/pull/22726
https://nodejs.org/api/cli.html#cli_trace_sync_iohttps://nodejs.org/api/cli.html#cli_trace_sync_io
#28926https://github.com/nodejs/node/pull/28926
https://github.com/BridgeAR
BridgeARhttps://github.com/BridgeAR
Aug 6, 2019 https://github.com/nodejs/node/pull/28926#ref-pullrequest-477378713
v12.8.0 release proposal #29017 https://github.com/nodejs/node/pull/29017
https://github.co/hiddenchars
https://github.com/nodejs/node/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F28926
https://github.com/jasnell
jasnell https://github.com/jasnell
https://github.com/nodejs/node/pull/28926/files/31cbdd79bd24aa1718632003ae7253a340fe6964
https://github.com/Trott
Trott https://github.com/Trott
https://github.com/nodejs/node/pull/28926/files/31cbdd79bd24aa1718632003ae7253a340fe6964
https://github.com/addaleax
addaleax https://github.com/addaleax
https://github.com/nodejs/node/pull/28926/files/31cbdd79bd24aa1718632003ae7253a340fe6964
https://github.com/cjihrig
cjihrig https://github.com/cjihrig
https://github.com/nodejs/node/pull/28926/files/31cbdd79bd24aa1718632003ae7253a340fe6964
https://github.com/danbev
danbev https://github.com/danbev
https://github.com/Fishrock123
Fishrock123 https://github.com/Fishrock123
author ready https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22author%20ready%22
c++ https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Ac%2B%2B
lib / src https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22lib%20%2F%20src%22
regression https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aregression
--trace-sync-io regression between v10.10 and v10.11 https://github.com/nodejs/node/issues/28913
Please reload this pagehttps://github.com/nodejs/node/pull/28926
https://github.com/ChALkeR
https://github.com/cjihrig
https://github.com/nodejs-github-bot
https://github.com/Trott
https://github.com/jasnell
https://github.com/addaleax
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.