René's URL Explorer Experiment


Title: http2: destroy when call settingsFn throw an error by himself65 · Pull Request #28908 · nodejs/node · GitHub

Open Graph Title: http2: destroy when call settingsFn throw an error by himself65 · Pull Request #28908 · nodejs/node

X Title: http2: destroy when call settingsFn throw an error by himself65 · Pull Request #28908 · nodejs/node

Description: Node.js JavaScript runtime ✨🐢🚀✨. Contribute to nodejs/node development by creating an account on GitHub.

Open Graph Description: fix #28895 Checklist make -j4 test (UNIX), or vcbuild test (Windows) passes tests and/or benchmarks are included commit message follows commit guidelines

X Description: fix #28895 Checklist make -j4 test (UNIX), or vcbuild test (Windows) passes tests and/or benchmarks are included commit message follows commit guidelines

Opengraph URL: https://github.com/nodejs/node/pull/28908

X: @github

direct link

Domain: github.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:22865c1c-9a45-6ec3-363b-6d07c90bc43d
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idD478:3F60C6:151A0AC:1CC3733:6A4F01FB
html-safe-noncecbb1b3bc05c4deae748d0b71a5a0135ab9cc634b75194fcaba614c8a8801b9e1
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJENDc4OjNGNjBDNjoxNTFBMEFDOjFDQzM3MzM6NkE0RjAxRkIiLCJ2aXNpdG9yX2lkIjoiMzIxOTc1MjE2MjU2MjA4MTI3NSIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmaccc007d8f4bea9756e6a5e8248bf619814dfb70167be1984559f9b3607da55d3b
hovercard-subject-tagpull_request:302996121
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/28908/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/dd2984d8f78adc2257290d6c88b0180de7e59f3a3c8607af493c0b516f9f4a3a/nodejs/node/pull/28908
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/dd2984d8f78adc2257290d6c88b0180de7e59f3a3c8607af493c0b516f9f4a3a/nodejs/node/pull/28908
og:image:altfix #28895 Checklist make -j4 test (UNIX), or vcbuild test (Windows) passes tests and/or benchmarks are included commit message follows commit guidelines
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamehimself65
hostnamegithub.com
expected-hostnamegithub.com
Noneb92d11c0aa4a77d54ef4af1078b6a15fb5a70a215b30c4ecf28889d5a8e656d9
turbo-cache-controlno-cache
go-importgithub.com/nodejs/node git https://github.com/nodejs/node.git
octolytics-dimension-user_id9950313
octolytics-dimension-user_loginnodejs
octolytics-dimension-repository_id27193779
octolytics-dimension-repository_nwonodejs/node
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id27193779
octolytics-dimension-repository_network_root_nwonodejs/node
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release2b8f23afb982271f1b22258a94aede67a6b77760
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/nodejs/node/pull/28908#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F28908
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub Copilot appDirect agents from issue to mergehttps://github.com/features/ai/github-app
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
View all resourceshttps://github.com/resources
GitHub SponsorsFund open source developershttps://github.com/open-source/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/open-source/accelerator
GitHub Starshttps://stars.github.com
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F28908
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode
Reloadhttps://github.com/nodejs/node/pull/28908
Reloadhttps://github.com/nodejs/node/pull/28908
Reloadhttps://github.com/nodejs/node/pull/28908
Please reload this pagehttps://github.com/nodejs/node/pull/28908
nodejs https://github.com/nodejs
nodehttps://github.com/nodejs/node
Please reload this pagehttps://github.com/nodejs/node/pull/28908
Notifications https://github.com/login?return_to=%2Fnodejs%2Fnode
Fork 36k https://github.com/login?return_to=%2Fnodejs%2Fnode
Star 118k https://github.com/login?return_to=%2Fnodejs%2Fnode
Code https://github.com/nodejs/node
Issues 1.3k https://github.com/nodejs/node/issues
Pull requests 965 https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects https://github.com/nodejs/node/projects
Security and quality 0 https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
Code https://github.com/nodejs/node
Issues https://github.com/nodejs/node/issues
Pull requests https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects https://github.com/nodejs/node/projects
Security and quality https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
himself65https://github.com/himself65
nodejs:masterhttps://github.com/nodejs/node/tree/master
himself65:28895https://github.com/himself65/node/tree/28895
Conversationhttps://github.com/nodejs/node/pull/28908
Commits2 (2)https://github.com/nodejs/node/pull/28908/commits
Checkshttps://github.com/nodejs/node/pull/28908/checks
Files changedhttps://github.com/nodejs/node/pull/28908/files
http2: destroy when call settingsFn throw an errorhttps://github.com/nodejs/node/pull/28908#top
himself65https://github.com/himself65
nodejs:masterhttps://github.com/nodejs/node/tree/master
himself65:28895https://github.com/himself65/node/tree/28895
https://github.com/himself65
himself65https://github.com/himself65
Jul 31, 2019https://github.com/nodejs/node/pull/28908#issue-475195965
#28895https://github.com/nodejs/node/issues/28895
commit guidelineshttps://github.com/nodejs/node/blob/master/doc/guides/contributing/pull-requests.md#commit-message-guidelines
Please reload this pagehttps://github.com/nodejs/node/pull/28908
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
http2 https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Ahttp2
Jul 31, 2019https://github.com/nodejs/node/pull/28908#event-2523529873
https://github.com/lpinca
lpincahttps://github.com/lpinca
Jul 31, 2019 https://github.com/nodejs/node/pull/28908#pullrequestreview-269219245
View reviewed changes https://github.com/nodejs/node/pull/28908/files
test/parallel/test-http2-connect.jshttps://github.com/nodejs/node/pull/28908/files#diff-28dbe64db2f88234075785ee876812d90a64896274b3e8fb471207ef45addcab
Please reload this pagehttps://github.com/nodejs/node/pull/28908
https://github.com/himself65
himself65https://github.com/himself65
force-pushedhttps://github.com/nodejs/node/compare/52cde569dc8ede48484e657d241176acfbc3a64f..f8371b2255040962af0c6405e5a8fcc375db6397
52cde56https://github.com/nodejs/node/commit/52cde569dc8ede48484e657d241176acfbc3a64f
f8371b2https://github.com/nodejs/node/commit/f8371b2255040962af0c6405e5a8fcc375db6397
Compare https://github.com/nodejs/node/compare/52cde569dc8ede48484e657d241176acfbc3a64f..f8371b2255040962af0c6405e5a8fcc375db6397
August 1, 2019 06:50https://github.com/nodejs/node/pull/28908#event-2525437793
himself65https://github.com/himself65
August 1, 2019 15:02https://github.com/nodejs/node/pull/28908#commits-pushed-7b3d2da
https://github.com/himself65
http2: destroy when call settingsFn throw an errorhttps://github.com/nodejs/node/pull/28908/commits/7b3d2dad4863fb1878dbb5c83b1d437ebd728ab7
7b3d2dahttps://github.com/nodejs/node/pull/28908/commits/7b3d2dad4863fb1878dbb5c83b1d437ebd728ab7
https://github.com/himself65
test: http2.connect call destroy when init failhttps://github.com/nodejs/node/pull/28908/commits/43454d48482ac7c60f04d5656f6d4f0355ed6eb3
43454d4https://github.com/nodejs/node/pull/28908/commits/43454d48482ac7c60f04d5656f6d4f0355ed6eb3
https://github.com/himself65
himself65https://github.com/himself65
force-pushedhttps://github.com/nodejs/node/compare/f8371b2255040962af0c6405e5a8fcc375db6397..43454d48482ac7c60f04d5656f6d4f0355ed6eb3
f8371b2https://github.com/nodejs/node/commit/f8371b2255040962af0c6405e5a8fcc375db6397
43454d4https://github.com/nodejs/node/commit/43454d48482ac7c60f04d5656f6d4f0355ed6eb3
Compare https://github.com/nodejs/node/compare/f8371b2255040962af0c6405e5a8fcc375db6397..43454d48482ac7c60f04d5656f6d4f0355ed6eb3
August 1, 2019 07:03https://github.com/nodejs/node/pull/28908#event-2525468931
https://github.com/himself65
himself65https://github.com/himself65
Aug 1, 2019https://github.com/nodejs/node/pull/28908#issuecomment-517149988
Please reload this pagehttps://github.com/nodejs/node/pull/28908
https://github.com/trivikr
trivikrhttps://github.com/trivikr
Aug 1, 2019 https://github.com/nodejs/node/pull/28908#pullrequestreview-269625463
View reviewed changes https://github.com/nodejs/node/pull/28908/files/43454d48482ac7c60f04d5656f6d4f0355ed6eb3
https://github.com/jasnell
jasnellhttps://github.com/jasnell
Aug 1, 2019 https://github.com/nodejs/node/pull/28908#pullrequestreview-269792996
View reviewed changes https://github.com/nodejs/node/pull/28908/files/43454d48482ac7c60f04d5656f6d4f0355ed6eb3
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
Aug 2, 2019https://github.com/nodejs/node/pull/28908#issuecomment-517780217
https://ci.nodejs.org/job/node-test-pull-request/24828/https://ci.nodejs.org/job/node-test-pull-request/24828/
Please reload this pagehttps://github.com/nodejs/node/pull/28908
https://github.com/Trott
Trotthttps://github.com/Trott
Aug 2, 2019 https://github.com/nodejs/node/pull/28908#pullrequestreview-270299415
View reviewed changes https://github.com/nodejs/node/pull/28908/files/43454d48482ac7c60f04d5656f6d4f0355ed6eb3
https://github.com/Trott
Trotthttps://github.com/Trott
author ready https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22author%20ready%22
Aug 2, 2019https://github.com/nodejs/node/pull/28908#event-2530301953
https://github.com/Trott
Trotthttps://github.com/Trott
Aug 2, 2019https://github.com/nodejs/node/pull/28908#issuecomment-517811312
2b03e1dhttps://github.com/nodejs/node/commit/2b03e1d0a5ef2a52e4d7ce550b74a961c62e185a
Please reload this pagehttps://github.com/nodejs/node/pull/28908
https://github.com/Trott
Trotthttps://github.com/Trott
Aug 2, 2019https://github.com/nodejs/node/pull/28908#event-2530538425
Trotthttps://github.com/Trott
Aug 2, 2019 https://github.com/nodejs/node/pull/28908#ref-commit-2b03e1d
https://github.com/himself65
https://github.com/Trott
http2: destroy when settingsFn throws an errorhttps://github.com/Trott/io.js/commit/2b03e1d0a5ef2a52e4d7ce550b74a961c62e185a
2b03e1dhttps://github.com/Trott/io.js/commit/2b03e1d0a5ef2a52e4d7ce550b74a961c62e185a
nodejs#28908https://github.com/nodejs/node/pull/28908
targoshttps://github.com/targos
Aug 2, 2019 https://github.com/nodejs/node/pull/28908#ref-commit-7d9eb17
https://github.com/himself65
https://github.com/targos
http2: destroy when settingsFn throws an errorhttps://github.com/nodejs/node/commit/7d9eb17d30112b362567ea079323e557902ba8ec
7d9eb17https://github.com/nodejs/node/commit/7d9eb17d30112b362567ea079323e557902ba8ec
#28908https://github.com/nodejs/node/pull/28908
https://github.com/lpinca
lpincahttps://github.com/lpinca
Aug 5, 2019 https://github.com/nodejs/node/pull/28908#ref-issue-474197493
Some http2 errors are not captured #28895 https://github.com/nodejs/node/issues/28895
https://github.com/himself65
himself65https://github.com/himself65
August 5, 2019 16:47https://github.com/nodejs/node/pull/28908#event-2534143342
https://github.com/BridgeAR
BridgeARhttps://github.com/BridgeAR
Aug 6, 2019 https://github.com/nodejs/node/pull/28908#ref-pullrequest-477378713
v12.8.0 release proposal #29017 https://github.com/nodejs/node/pull/29017
https://github.co/hiddenchars
https://github.com/nodejs/node/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F28908
https://github.com/jasnell
jasnell https://github.com/jasnell
https://github.com/nodejs/node/pull/28908/files/43454d48482ac7c60f04d5656f6d4f0355ed6eb3
https://github.com/Trott
Trott https://github.com/Trott
https://github.com/nodejs/node/pull/28908/files/43454d48482ac7c60f04d5656f6d4f0355ed6eb3
https://github.com/lpinca
lpinca https://github.com/lpinca
https://github.com/nodejs/node/pull/28908/files/b558f0ff42377856f6774ffe316f41bd5ef67e56
https://github.com/trivikr
trivikr https://github.com/trivikr
https://github.com/nodejs/node/pull/28908/files/43454d48482ac7c60f04d5656f6d4f0355ed6eb3
author ready https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22author%20ready%22
http2 https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Ahttp2
Some http2 errors are not captured https://github.com/nodejs/node/issues/28895
Please reload this pagehttps://github.com/nodejs/node/pull/28908
https://github.com/himself65
https://github.com/nodejs-github-bot
https://github.com/Trott
https://github.com/jasnell
https://github.com/lpinca
https://github.com/trivikr
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.