René's URL Explorer Experiment


Title: modules: missing exports as MODULE_NOT_FOUND by guybedford · Pull Request #28905 · nodejs/node · GitHub

Open Graph Title: modules: missing exports as MODULE_NOT_FOUND by guybedford · Pull Request #28905 · nodejs/node

X Title: modules: missing exports as MODULE_NOT_FOUND by guybedford · Pull Request #28905 · nodejs/node

Description: Node.js JavaScript runtime ✨🐢🚀✨. Contribute to nodejs/node development by creating an account on GitHub.

Open Graph Description: It seems I missed this change when reviewing #28759, where previously the package.json "exports" would throw a MODULE_NOT_FOUND error if trying to import something from a package that was...

X Description: It seems I missed this change when reviewing #28759, where previously the package.json "exports" would throw a MODULE_NOT_FOUND error if trying to import something from a package ...

Opengraph URL: https://github.com/nodejs/node/pull/28905

X: @github

direct link

Domain: github.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:456cf747-1edc-2f72-6d25-4f956dd9978c
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idBB08:50919:6535A32:8DCF2F8:6A4FB0D0
html-safe-nonce56099e01679865ab6ae76512cb1668d9824a520ab343362b67af0a29a6907f6e
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJCQjA4OjUwOTE5OjY1MzVBMzI6OERDRjJGODo2QTRGQjBEMCIsInZpc2l0b3JfaWQiOiI0NDQ4NTEwNDExNTIwNTg1OTM2IiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmac0589529805757c2ee4f935a05d3dee178002e42437397926fed929132b818e44
hovercard-subject-tagpull_request:302756009
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/28905/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/5c0a11d2464f68a8306f0eaa6fb9b9a727c444a6986f3e1a4eac3af6e4368e18/nodejs/node/pull/28905
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/5c0a11d2464f68a8306f0eaa6fb9b9a727c444a6986f3e1a4eac3af6e4368e18/nodejs/node/pull/28905
og:image:altIt seems I missed this change when reviewing #28759, where previously the package.json "exports" would throw a MODULE_NOT_FOUND error if trying to import something from a package that was...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernameguybedford
hostnamegithub.com
expected-hostnamegithub.com
Noneb92d11c0aa4a77d54ef4af1078b6a15fb5a70a215b30c4ecf28889d5a8e656d9
turbo-cache-controlno-cache
go-importgithub.com/nodejs/node git https://github.com/nodejs/node.git
octolytics-dimension-user_id9950313
octolytics-dimension-user_loginnodejs
octolytics-dimension-repository_id27193779
octolytics-dimension-repository_nwonodejs/node
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id27193779
octolytics-dimension-repository_network_root_nwonodejs/node
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release4b249b445842943ed31549e027f57a8ade9881ed
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/nodejs/node/pull/28905#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F28905
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub Copilot appDirect agents from issue to mergehttps://github.com/features/ai/github-app
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
View all resourceshttps://github.com/resources
GitHub SponsorsFund open source developershttps://github.com/open-source/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/open-source/accelerator
GitHub Starshttps://stars.github.com
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F28905
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode
Reloadhttps://github.com/nodejs/node/pull/28905
Reloadhttps://github.com/nodejs/node/pull/28905
Reloadhttps://github.com/nodejs/node/pull/28905
Please reload this pagehttps://github.com/nodejs/node/pull/28905
nodejs https://github.com/nodejs
nodehttps://github.com/nodejs/node
Please reload this pagehttps://github.com/nodejs/node/pull/28905
Notifications https://github.com/login?return_to=%2Fnodejs%2Fnode
Fork 36k https://github.com/login?return_to=%2Fnodejs%2Fnode
Star 118k https://github.com/login?return_to=%2Fnodejs%2Fnode
Code https://github.com/nodejs/node
Issues 1.3k https://github.com/nodejs/node/issues
Pull requests 972 https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects https://github.com/nodejs/node/projects
Security and quality 0 https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
Code https://github.com/nodejs/node
Issues https://github.com/nodejs/node/issues
Pull requests https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects https://github.com/nodejs/node/projects
Security and quality https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
guybedfordhttps://github.com/guybedford
nodejs:masterhttps://github.com/nodejs/node/tree/master
guybedford:exports-errhttps://github.com/guybedford/node/tree/exports-err
Conversationhttps://github.com/nodejs/node/pull/28905
Commits1 (1)https://github.com/nodejs/node/pull/28905/commits
Checkshttps://github.com/nodejs/node/pull/28905/checks
Files changedhttps://github.com/nodejs/node/pull/28905/files
modules: missing exports as MODULE_NOT_FOUNDhttps://github.com/nodejs/node/pull/28905#top
guybedfordhttps://github.com/guybedford
nodejs:masterhttps://github.com/nodejs/node/tree/master
guybedford:exports-errhttps://github.com/guybedford/node/tree/exports-err
https://github.com/guybedford
guybedfordhttps://github.com/guybedford
Jul 31, 2019https://github.com/nodejs/node/pull/28905#issue-474895994
Please reload this pagehttps://github.com/nodejs/node/pull/28905
#28759https://github.com/nodejs/node/pull/28759
https://github.com/nodejs/node/pull/28759/files#diff-4a5950be44f56dfca2e7fa3c4e1fc0e4https://github.com/nodejs/node/pull/28759/files#diff-4a5950be44f56dfca2e7fa3c4e1fc0e4
commit guidelineshttps://github.com/nodejs/node/blob/master/doc/guides/contributing/pull-requests.md#commit-message-guidelines
Please reload this pagehttps://github.com/nodejs/node/pull/28905
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
c++ https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Ac%2B%2B
errors https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aerrors
Jul 31, 2019https://github.com/nodejs/node/pull/28905#event-2521725586
https://github.com/guybedford
guybedfordhttps://github.com/guybedford
Jul 31, 2019https://github.com/nodejs/node/pull/28905#issuecomment-516661767
Please reload this pagehttps://github.com/nodejs/node/pull/28905
https://github.com/guybedford
guybedfordhttps://github.com/guybedford
Jul 31, 2019https://github.com/nodejs/node/pull/28905#event-2521733518
https://github.com/guybedford
guybedfordhttps://github.com/guybedford
Jul 31, 2019https://github.com/nodejs/node/pull/28905#issuecomment-516662051
Please reload this pagehttps://github.com/nodejs/node/pull/28905
https://github.com/ljharb
ljharbhttps://github.com/ljharb
Jul 31, 2019 https://github.com/nodejs/node/pull/28905#pullrequestreview-268764345
View reviewed changes https://github.com/nodejs/node/pull/28905/files
ljharbhttps://github.com/ljharb
https://github.com/nodejs/node/pull/28905#pullrequestreview-268764345
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/28905
https://github.com/guybedford
guybedfordhttps://github.com/guybedford
force-pushedhttps://github.com/nodejs/node/compare/3db0301cc4694ffde92b7e1ca8f6ebdfc547ee00..5b7070301a6990160dbc9b5ddf45baa7fd3621fe
3db0301https://github.com/nodejs/node/commit/3db0301cc4694ffde92b7e1ca8f6ebdfc547ee00
5b70703https://github.com/nodejs/node/commit/5b7070301a6990160dbc9b5ddf45baa7fd3621fe
Compare https://github.com/nodejs/node/compare/3db0301cc4694ffde92b7e1ca8f6ebdfc547ee00..5b7070301a6990160dbc9b5ddf45baa7fd3621fe
July 31, 2019 04:03https://github.com/nodejs/node/pull/28905#event-2521891610
https://github.com/Trott
Trotthttps://github.com/Trott
Jul 31, 2019 https://github.com/nodejs/node/pull/28905#pullrequestreview-268775497
View reviewed changes https://github.com/nodejs/node/pull/28905/files
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
Jul 31, 2019https://github.com/nodejs/node/pull/28905#issuecomment-516686149
https://ci.nodejs.org/job/node-test-pull-request/24794/https://ci.nodejs.org/job/node-test-pull-request/24794/
Please reload this pagehttps://github.com/nodejs/node/pull/28905
https://github.com/cjihrig
cjihrighttps://github.com/cjihrig
Jul 31, 2019 https://github.com/nodejs/node/pull/28905#pullrequestreview-268787596
View reviewed changes https://github.com/nodejs/node/pull/28905/files
https://github.com/hybrist
hybristhttps://github.com/hybrist
Jul 31, 2019 https://github.com/nodejs/node/pull/28905#pullrequestreview-269084127
View reviewed changes https://github.com/nodejs/node/pull/28905/files
https://github.com/hybrist
hybristhttps://github.com/hybrist
Jul 31, 2019 https://github.com/nodejs/node/pull/28905#ref-issue-472403234
Use consistent error codes for MODULE_NOT_FOUND nodejs/modules#360 https://github.com/nodejs/modules/issues/360
https://github.com/hybrist
hybristhttps://github.com/hybrist
author ready https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22author%20ready%22
Jul 31, 2019https://github.com/nodejs/node/pull/28905#event-2523612252
https://github.com/lpinca
lpincahttps://github.com/lpinca
Jul 31, 2019 https://github.com/nodejs/node/pull/28905#pullrequestreview-269224344
View reviewed changes https://github.com/nodejs/node/pull/28905/files
https://github.com/trivikr
trivikrhttps://github.com/trivikr
Jul 31, 2019 https://github.com/nodejs/node/pull/28905#pullrequestreview-269334856
View reviewed changes https://github.com/nodejs/node/pull/28905/files
https://github.com/guybedford
module: exports error as MODULE_NOT_FOUNDhttps://github.com/nodejs/node/pull/28905/commits/e2bed65407ab69918d9215d608a1fe0a63943c84
e2bed65https://github.com/nodejs/node/pull/28905/commits/e2bed65407ab69918d9215d608a1fe0a63943c84
https://github.com/guybedford
guybedfordhttps://github.com/guybedford
force-pushedhttps://github.com/nodejs/node/compare/5b7070301a6990160dbc9b5ddf45baa7fd3621fe..e2bed65407ab69918d9215d608a1fe0a63943c84
5b70703https://github.com/nodejs/node/commit/5b7070301a6990160dbc9b5ddf45baa7fd3621fe
e2bed65https://github.com/nodejs/node/commit/e2bed65407ab69918d9215d608a1fe0a63943c84
Compare https://github.com/nodejs/node/compare/5b7070301a6990160dbc9b5ddf45baa7fd3621fe..e2bed65407ab69918d9215d608a1fe0a63943c84
August 1, 2019 06:08https://github.com/nodejs/node/pull/28905#event-2525354772
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
Aug 1, 2019https://github.com/nodejs/node/pull/28905#issuecomment-517461037
https://ci.nodejs.org/job/node-test-pull-request/24815/https://ci.nodejs.org/job/node-test-pull-request/24815/
Please reload this pagehttps://github.com/nodejs/node/pull/28905
https://github.com/Trott
Trotthttps://github.com/Trott
Aug 2, 2019https://github.com/nodejs/node/pull/28905#issuecomment-517535251
452b393https://github.com/nodejs/node/commit/452b393c1fc993c50acd447eb84eeea529b89111
Please reload this pagehttps://github.com/nodejs/node/pull/28905
https://github.com/Trott
Trotthttps://github.com/Trott
Aug 2, 2019https://github.com/nodejs/node/pull/28905#event-2528414080
Trotthttps://github.com/Trott
Aug 2, 2019 https://github.com/nodejs/node/pull/28905#ref-commit-452b393
https://github.com/guybedford
https://github.com/Trott
module: exports error as MODULE_NOT_FOUNDhttps://github.com/Trott/io.js/commit/452b393c1fc993c50acd447eb84eeea529b89111
452b393https://github.com/Trott/io.js/commit/452b393c1fc993c50acd447eb84eeea529b89111
nodejs#28905https://github.com/nodejs/node/pull/28905
targoshttps://github.com/targos
Aug 2, 2019 https://github.com/nodejs/node/pull/28905#ref-commit-2236aff
https://github.com/guybedford
https://github.com/targos
module: exports error as MODULE_NOT_FOUNDhttps://github.com/nodejs/node/commit/2236affbf8815a36d3da4641fc103bfc33992dcf
2236affhttps://github.com/nodejs/node/commit/2236affbf8815a36d3da4641fc103bfc33992dcf
#28905https://github.com/nodejs/node/pull/28905
https://github.com/BridgeAR
BridgeARhttps://github.com/BridgeAR
Aug 6, 2019 https://github.com/nodejs/node/pull/28905#ref-pullrequest-477378713
v12.8.0 release proposal #29017 https://github.com/nodejs/node/pull/29017
https://github.co/hiddenchars
https://github.com/nodejs/node/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F28905
https://github.com/ljharb
ljharb https://github.com/ljharb
https://github.com/nodejs/node/pull/28905/files/3db0301cc4694ffde92b7e1ca8f6ebdfc547ee00
https://github.com/hybrist
hybrist https://github.com/hybrist
https://github.com/nodejs/node/pull/28905/files/5b7070301a6990160dbc9b5ddf45baa7fd3621fe
https://github.com/Trott
Trott https://github.com/Trott
https://github.com/nodejs/node/pull/28905/files/5b7070301a6990160dbc9b5ddf45baa7fd3621fe
https://github.com/lpinca
lpinca https://github.com/lpinca
https://github.com/nodejs/node/pull/28905/files/5b7070301a6990160dbc9b5ddf45baa7fd3621fe
https://github.com/cjihrig
cjihrig https://github.com/cjihrig
https://github.com/nodejs/node/pull/28905/files/5b7070301a6990160dbc9b5ddf45baa7fd3621fe
https://github.com/trivikr
trivikr https://github.com/trivikr
https://github.com/nodejs/node/pull/28905/files/5b7070301a6990160dbc9b5ddf45baa7fd3621fe
author ready https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22author%20ready%22
c++ https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Ac%2B%2B
errors https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aerrors
Please reload this pagehttps://github.com/nodejs/node/pull/28905
https://github.com/guybedford
https://github.com/nodejs-github-bot
https://github.com/Trott
https://github.com/ljharb
https://github.com/hybrist
https://github.com/lpinca
https://github.com/cjihrig
https://github.com/trivikr
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.