René's URL Explorer Experiment


Title: [v10.x] tls: group chunks into TLS segments by mildsunrise · Pull Request #28904 · nodejs/node · GitHub

Open Graph Title: [v10.x] tls: group chunks into TLS segments by mildsunrise · Pull Request #28904 · nodejs/node

X Title: [v10.x] tls: group chunks into TLS segments by mildsunrise · Pull Request #28904 · nodejs/node

Description: Node.js JavaScript runtime ✨🐢🚀✨. Contribute to nodejs/node development by creating an account on GitHub.

Open Graph Description: Backport of #27861 (and also #27891 and #28903 to fix tests). The original code uses AllocatedBuffer, so we would need to also backport #26207 (specifically 6c257cd). Instead I've defined it as...

X Description: Backport of #27861 (and also #27891 and #28903 to fix tests). The original code uses AllocatedBuffer, so we would need to also backport #26207 (specifically 6c257cd). Instead I've defined i...

Opengraph URL: https://github.com/nodejs/node/pull/28904

X: @github

direct link

Domain: github.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:034f2f3a-6eb5-b427-7836-2e9a3685ab54
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idA304:14011B:525ECD:6F510E:6A4EBAE6
html-safe-nonce3d73b6b87283ea83c381abf122d150e4425bb61b6fdfac5d28ecf9c975655344
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJBMzA0OjE0MDExQjo1MjVFQ0Q6NkY1MTBFOjZBNEVCQUU2IiwidmlzaXRvcl9pZCI6IjcxOTYyNzg4MDY0MzYyOTc0NDYiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmac4663926e5deadc485ee5b14817c09f6bb4f05cc332bfa5f7f5b398ce6c8bd4f0
hovercard-subject-tagpull_request:302704209
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/28904/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/85b471f5dae0cf1edbab57667651dfa23dbc83d7ce54a9de44a1cc6459498050/nodejs/node/pull/28904
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/85b471f5dae0cf1edbab57667651dfa23dbc83d7ce54a9de44a1cc6459498050/nodejs/node/pull/28904
og:image:altBackport of #27861 (and also #27891 and #28903 to fix tests). The original code uses AllocatedBuffer, so we would need to also backport #26207 (specifically 6c257cd). Instead I've defined it as...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamemildsunrise
hostnamegithub.com
expected-hostnamegithub.com
None41b6ab3ba6d20a71766ac245b5a4a94c6fc672a9cd4da7d44c1b33ab8bf6a21c
turbo-cache-controlno-cache
go-importgithub.com/nodejs/node git https://github.com/nodejs/node.git
octolytics-dimension-user_id9950313
octolytics-dimension-user_loginnodejs
octolytics-dimension-repository_id27193779
octolytics-dimension-repository_nwonodejs/node
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id27193779
octolytics-dimension-repository_network_root_nwonodejs/node
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
releasee6a744804e8e70f97b4d5a18a94dcc63db22f97a
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/nodejs/node/pull/28904#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F28904
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub Copilot appDirect agents from issue to mergehttps://github.com/features/ai/github-app
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
View all resourceshttps://github.com/resources
GitHub SponsorsFund open source developershttps://github.com/open-source/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/open-source/accelerator
GitHub Starshttps://stars.github.com
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F28904
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode
Reloadhttps://github.com/nodejs/node/pull/28904
Reloadhttps://github.com/nodejs/node/pull/28904
Reloadhttps://github.com/nodejs/node/pull/28904
Please reload this pagehttps://github.com/nodejs/node/pull/28904
nodejs https://github.com/nodejs
nodehttps://github.com/nodejs/node
Please reload this pagehttps://github.com/nodejs/node/pull/28904
Notifications https://github.com/login?return_to=%2Fnodejs%2Fnode
Fork 36k https://github.com/login?return_to=%2Fnodejs%2Fnode
Star 118k https://github.com/login?return_to=%2Fnodejs%2Fnode
Code https://github.com/nodejs/node
Issues 1.3k https://github.com/nodejs/node/issues
Pull requests 964 https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects https://github.com/nodejs/node/projects
Security and quality 0 https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
Code https://github.com/nodejs/node
Issues https://github.com/nodejs/node/issues
Pull requests https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects https://github.com/nodejs/node/projects
Security and quality https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
mildsunrisehttps://github.com/mildsunrise
nodejs:v10.x-staginghttps://github.com/nodejs/node/tree/v10.x-staging
mildsunrise:v10.x-tls-writevhttps://github.com/mildsunrise/node/tree/v10.x-tls-writev
Conversationhttps://github.com/nodejs/node/pull/28904
Commits3 (3)https://github.com/nodejs/node/pull/28904/commits
Checkshttps://github.com/nodejs/node/pull/28904/checks
Files changedhttps://github.com/nodejs/node/pull/28904/files
[v10.x] tls: group chunks into TLS segmentshttps://github.com/nodejs/node/pull/28904#top
mildsunrisehttps://github.com/mildsunrise
nodejs:v10.x-staginghttps://github.com/nodejs/node/tree/v10.x-staging
mildsunrise:v10.x-tls-writevhttps://github.com/mildsunrise/node/tree/v10.x-tls-writev
https://github.com/mildsunrise
mildsunrisehttps://github.com/mildsunrise
Jul 30, 2019https://github.com/nodejs/node/pull/28904#issue-474831385
#27861https://github.com/nodejs/node/pull/27861
#27891https://github.com/nodejs/node/pull/27891
#28903https://github.com/nodejs/node/pull/28903
#26207https://github.com/nodejs/node/pull/26207
6c257cdhttps://github.com/nodejs/node/commit/6c257cdf271384555d0ced77104a1d6b0480e246
Please reload this pagehttps://github.com/nodejs/node/pull/28904
mildsunrisehttps://github.com/mildsunrise
July 30, 2019 07:28https://github.com/nodejs/node/pull/28904#commits-pushed-100d8ef
https://github.com/mildsunrise
doc,test: clarify that Http2Stream is destroyed after data is readhttps://github.com/nodejs/node/pull/28904/commits/100d8ef236a4434bc9eb39290e97baa291e06e69
100d8efhttps://github.com/nodejs/node/pull/28904/commits/100d8ef236a4434bc9eb39290e97baa291e06e69
nodejs#27863https://github.com/nodejs/node/issues/27863
nodejs#27891https://github.com/nodejs/node/pull/27891
https://github.com/mildsunrise
test: fix race in test-http2-originhttps://github.com/nodejs/node/pull/28904/commits/a7b4a6f1704f11301e4e4543afbe789940b2bdae
a7b4a6fhttps://github.com/nodejs/node/pull/28904/commits/a7b4a6f1704f11301e4e4543afbe789940b2bdae
nodejs#28903https://github.com/nodejs/node/pull/28903
https://github.com/mildsunrise
tls: group chunks into TLS segmentshttps://github.com/nodejs/node/pull/28904/commits/01a3271501d4a6a112742a0e107eb593bac3bbbb
01a3271https://github.com/nodejs/node/pull/28904/commits/01a3271501d4a6a112742a0e107eb593bac3bbbb
nodejs#27573 (comment)https://github.com/nodejs/node/issues/27573#issuecomment-493787867
nodejs#27573https://github.com/nodejs/node/issues/27573
nodejs#27861https://github.com/nodejs/node/pull/27861
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
c++ https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Ac%2B%2B
tls https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Atls
v10.x https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Av10.x
Jul 30, 2019https://github.com/nodejs/node/pull/28904#event-2521332594
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
Jul 31, 2019https://github.com/nodejs/node/pull/28904#issuecomment-516804200
https://ci.nodejs.org/job/node-test-pull-request/24798/https://ci.nodejs.org/job/node-test-pull-request/24798/
Please reload this pagehttps://github.com/nodejs/node/pull/28904
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
Aug 2, 2019https://github.com/nodejs/node/pull/28904#issuecomment-517535631
https://ci.nodejs.org/job/node-test-pull-request/24818/https://ci.nodejs.org/job/node-test-pull-request/24818/
Please reload this pagehttps://github.com/nodejs/node/pull/28904
https://github.com/Trott
Trotthttps://github.com/Trott
Aug 2, 2019https://github.com/nodejs/node/pull/28904#issuecomment-517556868
Please reload this pagehttps://github.com/nodejs/node/pull/28904
https://github.com/Trott
Trotthttps://github.com/Trott
Aug 2, 2019https://github.com/nodejs/node/pull/28904#issuecomment-517557049
Please reload this pagehttps://github.com/nodejs/node/pull/28904
https://github.com/bnoordhuis
bnoordhuishttps://github.com/bnoordhuis
Aug 3, 2019 https://github.com/nodejs/node/pull/28904#pullrequestreview-270471286
View reviewed changes https://github.com/nodejs/node/pull/28904/files/01a3271501d4a6a112742a0e107eb593bac3bbbb
bnoordhuishttps://github.com/bnoordhuis
https://github.com/nodejs/node/pull/28904#pullrequestreview-270471286
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/28904
https://github.com/mildsunrise
mildsunrisehttps://github.com/mildsunrise
Aug 3, 2019https://github.com/nodejs/node/pull/28904#issuecomment-517956927
#26207https://github.com/nodejs/node/pull/26207
Please reload this pagehttps://github.com/nodejs/node/pull/28904
https://github.com/mildsunrise
mildsunrisehttps://github.com/mildsunrise
Aug 6, 2019https://github.com/nodejs/node/pull/28904#issuecomment-518634380
#26207https://github.com/nodejs/node/pull/26207
84e02b1https://github.com/nodejs/node/commit/84e02b178ad14fae0df2a514e8a39bfa50ffdc2d
Please reload this pagehttps://github.com/nodejs/node/pull/28904
https://github.com/bnoordhuis
bnoordhuishttps://github.com/bnoordhuis
Aug 6, 2019https://github.com/nodejs/node/pull/28904#issuecomment-518641474
Please reload this pagehttps://github.com/nodejs/node/pull/28904
https://github.com/BethGriggs
BethGriggshttps://github.com/BethGriggs
Oct 7, 2019 https://github.com/nodejs/node/pull/28904#pullrequestreview-298039210
View reviewed changes https://github.com/nodejs/node/pull/28904/files/01a3271501d4a6a112742a0e107eb593bac3bbbb
BethGriggshttps://github.com/BethGriggs
Oct 7, 2019 https://github.com/nodejs/node/pull/28904#ref-commit-56a834a
https://github.com/mildsunrise
https://github.com/BethGriggs
doc,test: clarify that Http2Stream is destroyed after data is readhttps://github.com/nodejs/node/commit/56a834a53f7e1651b2f5b7533da3b1df27bb8498
56a834ahttps://github.com/nodejs/node/commit/56a834a53f7e1651b2f5b7533da3b1df27bb8498
#27863https://github.com/nodejs/node/issues/27863
#28904https://github.com/nodejs/node/pull/28904
#27891https://github.com/nodejs/node/pull/27891
BethGriggshttps://github.com/BethGriggs
Oct 7, 2019 https://github.com/nodejs/node/pull/28904#ref-commit-f78ecc3
https://github.com/mildsunrise
https://github.com/BethGriggs
test: fix race in test-http2-originhttps://github.com/nodejs/node/commit/f78ecc3f939b37f3d91346b5995e42e9b2dec793
f78ecc3https://github.com/nodejs/node/commit/f78ecc3f939b37f3d91346b5995e42e9b2dec793
#28904https://github.com/nodejs/node/pull/28904
#28903https://github.com/nodejs/node/pull/28903
BethGriggshttps://github.com/BethGriggs
Oct 7, 2019 https://github.com/nodejs/node/pull/28904#ref-commit-fe58bca
https://github.com/mildsunrise
https://github.com/BethGriggs
tls: group chunks into TLS segmentshttps://github.com/nodejs/node/commit/fe58bca878ee1925199a2a86ea4ff0fb3deecf71
fe58bcahttps://github.com/nodejs/node/commit/fe58bca878ee1925199a2a86ea4ff0fb3deecf71
#27573 (comment)https://github.com/nodejs/node/issues/27573#issuecomment-493787867
#27573https://github.com/nodejs/node/issues/27573
#28904https://github.com/nodejs/node/pull/28904
#27861https://github.com/nodejs/node/pull/27861
https://github.com/BethGriggs
BethGriggshttps://github.com/BethGriggs
Oct 7, 2019https://github.com/nodejs/node/pull/28904#issuecomment-538948554
7f48519...fe58bcahttps://github.com/nodejs/node/compare/7f48519413775ab71c0c13852778430708e3c181...fe58bca878ee1925199a2a86ea4ff0fb3deecf71
Please reload this pagehttps://github.com/nodejs/node/pull/28904
https://github.com/BethGriggs
BethGriggshttps://github.com/BethGriggs
Oct 7, 2019https://github.com/nodejs/node/pull/28904#event-2691358869
https://github.com/mildsunrise
mildsunrisehttps://github.com/mildsunrise
October 7, 2019 10:52https://github.com/nodejs/node/pull/28904#event-2691366072
https://github.co/hiddenchars
https://github.com/nodejs/node/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F28904
https://github.com/bnoordhuis
bnoordhuis https://github.com/bnoordhuis
https://github.com/nodejs/node/pull/28904/files/01a3271501d4a6a112742a0e107eb593bac3bbbb
https://github.com/BethGriggs
BethGriggs https://github.com/BethGriggs
https://github.com/nodejs/node/pull/28904/files/01a3271501d4a6a112742a0e107eb593bac3bbbb
c++ https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Ac%2B%2B
tls https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Atls
Please reload this pagehttps://github.com/nodejs/node/pull/28904
https://github.com/mildsunrise
https://github.com/nodejs-github-bot
https://github.com/Trott
https://github.com/bnoordhuis
https://github.com/BethGriggs
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.