René's URL Explorer Experiment


Title: build: do not mix spaces and tabs in Makefile by lpinca · Pull Request #28881 · nodejs/node · GitHub

Open Graph Title: build: do not mix spaces and tabs in Makefile by lpinca · Pull Request #28881 · nodejs/node

X Title: build: do not mix spaces and tabs in Makefile by lpinca · Pull Request #28881 · nodejs/node

Description: Node.js JavaScript runtime ✨🐢🚀✨. Contribute to nodejs/node development by creating an account on GitHub.

Open Graph Description: Checklist make -j4 test (UNIX), or vcbuild test (Windows) passes commit message follows commit guidelines

X Description: Checklist make -j4 test (UNIX), or vcbuild test (Windows) passes commit message follows commit guidelines

Opengraph URL: https://github.com/nodejs/node/pull/28881

X: @github

direct link

Domain: github.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:840e962a-1161-440c-2b7a-923b79e09830
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-id9612:633B1:365A547:4AFDCF6:6A4F336F
html-safe-noncee61c257004619236b5b24e77691e8b52afd2a7d457d57873cd72de14556ae5d0
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI5NjEyOjYzM0IxOjM2NUE1NDc6NEFGRENGNjo2QTRGMzM2RiIsInZpc2l0b3JfaWQiOiIxNzM4MjA0MjU0NjYzODE2MDQ4IiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmac2ec841fa3db8c4ffe65023586c798f019a11f79d1d28d0844dfdc4f90d359c1f
hovercard-subject-tagpull_request:301834116
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/28881/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/f1954fc23fde1aacfeda9dfa17c1171822733ee20fb47aca5e6f7b2956a38c35/nodejs/node/pull/28881
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/f1954fc23fde1aacfeda9dfa17c1171822733ee20fb47aca5e6f7b2956a38c35/nodejs/node/pull/28881
og:image:altChecklist make -j4 test (UNIX), or vcbuild test (Windows) passes commit message follows commit guidelines
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamelpinca
hostnamegithub.com
expected-hostnamegithub.com
Noneb92d11c0aa4a77d54ef4af1078b6a15fb5a70a215b30c4ecf28889d5a8e656d9
turbo-cache-controlno-cache
go-importgithub.com/nodejs/node git https://github.com/nodejs/node.git
octolytics-dimension-user_id9950313
octolytics-dimension-user_loginnodejs
octolytics-dimension-repository_id27193779
octolytics-dimension-repository_nwonodejs/node
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id27193779
octolytics-dimension-repository_network_root_nwonodejs/node
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release2b8f23afb982271f1b22258a94aede67a6b77760
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/nodejs/node/pull/28881#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F28881
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub Copilot appDirect agents from issue to mergehttps://github.com/features/ai/github-app
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
View all resourceshttps://github.com/resources
GitHub SponsorsFund open source developershttps://github.com/open-source/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/open-source/accelerator
GitHub Starshttps://stars.github.com
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F28881
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode
Reloadhttps://github.com/nodejs/node/pull/28881
Reloadhttps://github.com/nodejs/node/pull/28881
Reloadhttps://github.com/nodejs/node/pull/28881
Please reload this pagehttps://github.com/nodejs/node/pull/28881
nodejs https://github.com/nodejs
nodehttps://github.com/nodejs/node
Please reload this pagehttps://github.com/nodejs/node/pull/28881
Notifications https://github.com/login?return_to=%2Fnodejs%2Fnode
Fork 36k https://github.com/login?return_to=%2Fnodejs%2Fnode
Star 118k https://github.com/login?return_to=%2Fnodejs%2Fnode
Code https://github.com/nodejs/node
Issues 1.3k https://github.com/nodejs/node/issues
Pull requests 971 https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects https://github.com/nodejs/node/projects
Security and quality 0 https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
Code https://github.com/nodejs/node
Issues https://github.com/nodejs/node/issues
Pull requests https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects https://github.com/nodejs/node/projects
Security and quality https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
lpincahttps://github.com/lpinca
nodejs:masterhttps://github.com/nodejs/node/tree/master
lpinca:replace/spaces-with-tabshttps://github.com/lpinca/node/tree/replace/spaces-with-tabs
Conversationhttps://github.com/nodejs/node/pull/28881
Commits1 (1)https://github.com/nodejs/node/pull/28881/commits
Checkshttps://github.com/nodejs/node/pull/28881/checks
Files changedhttps://github.com/nodejs/node/pull/28881/files
build: do not mix spaces and tabs in Makefilehttps://github.com/nodejs/node/pull/28881#top
lpincahttps://github.com/lpinca
nodejs:masterhttps://github.com/nodejs/node/tree/master
lpinca:replace/spaces-with-tabshttps://github.com/lpinca/node/tree/replace/spaces-with-tabs
https://github.com/lpinca
lpincahttps://github.com/lpinca
Jul 28, 2019https://github.com/nodejs/node/pull/28881#issue-473747809
commit guidelineshttps://github.com/nodejs/node/blob/master/doc/guides/contributing/pull-requests.md#commit-message-guidelines
Please reload this pagehttps://github.com/nodejs/node/pull/28881
https://github.com/lpinca
build: do not mix spaces and tabs in Makefilehttps://github.com/nodejs/node/pull/28881/commits/3572a7e7982e3ed624353568debcd04e73128e8d
3572a7ehttps://github.com/nodejs/node/pull/28881/commits/3572a7e7982e3ed624353568debcd04e73128e8d
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
build https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Abuild
Jul 28, 2019https://github.com/nodejs/node/pull/28881#event-2514742792
https://github.com/lpinca
lpincahttps://github.com/lpinca
Jul 28, 2019https://github.com/nodejs/node/pull/28881#issuecomment-515765749
https://github.com/nodejs/node/pull/28881/files?ts=2https://github.com/nodejs/node/pull/28881/files?ts=2
Please reload this pagehttps://github.com/nodejs/node/pull/28881
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
Jul 28, 2019 https://github.com/nodejs/node/pull/28881#pullrequestreview-267510109
View reviewed changes https://github.com/nodejs/node/pull/28881/files/3572a7e7982e3ed624353568debcd04e73128e8d
https://github.com/targos
targoshttps://github.com/targos
Jul 28, 2019 https://github.com/nodejs/node/pull/28881#pullrequestreview-267511770
View reviewed changes https://github.com/nodejs/node/pull/28881/files/3572a7e7982e3ed624353568debcd04e73128e8d
https://github.com/ZYSzys
ZYSzyshttps://github.com/ZYSzys
Jul 28, 2019 https://github.com/nodejs/node/pull/28881#pullrequestreview-267512719
View reviewed changes https://github.com/nodejs/node/pull/28881/files/3572a7e7982e3ed624353568debcd04e73128e8d
https://github.com/trivikr
trivikrhttps://github.com/trivikr
Jul 29, 2019 https://github.com/nodejs/node/pull/28881#pullrequestreview-267560267
View reviewed changes https://github.com/nodejs/node/pull/28881/files/3572a7e7982e3ed624353568debcd04e73128e8d
https://github.com/ChALkeR
ChALkeRhttps://github.com/ChALkeR
Jul 29, 2019 https://github.com/nodejs/node/pull/28881#pullrequestreview-267698879
View reviewed changes https://github.com/nodejs/node/pull/28881/files/3572a7e7982e3ed624353568debcd04e73128e8d
ChALkeRhttps://github.com/ChALkeR
Please reload this pagehttps://github.com/nodejs/node/pull/28881
https://github.com/nodejs/node/pull/28881#pullrequestreview-267698879
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
https://github.com/nodejs/node/blob/master/.editorconfig#L14-L16https://github.com/nodejs/node/blob/master/.editorconfig#L14-L16
Please reload this pagehttps://github.com/nodejs/node/pull/28881
https://github.com/BethGriggs
BethGriggshttps://github.com/BethGriggs
Jul 29, 2019 https://github.com/nodejs/node/pull/28881#pullrequestreview-267718742
View reviewed changes https://github.com/nodejs/node/pull/28881/files/3572a7e7982e3ed624353568debcd04e73128e8d
https://github.com/cjihrig
cjihrighttps://github.com/cjihrig
Jul 29, 2019 https://github.com/nodejs/node/pull/28881#pullrequestreview-267806540
View reviewed changes https://github.com/nodejs/node/pull/28881/files/3572a7e7982e3ed624353568debcd04e73128e8d
https://github.com/jasnell
jasnellhttps://github.com/jasnell
Jul 29, 2019 https://github.com/nodejs/node/pull/28881#pullrequestreview-267850491
View reviewed changes https://github.com/nodejs/node/pull/28881/files/3572a7e7982e3ed624353568debcd04e73128e8d
https://github.com/richardlau
richardlauhttps://github.com/richardlau
Jul 29, 2019 https://github.com/nodejs/node/pull/28881#pullrequestreview-267852140
View reviewed changes https://github.com/nodejs/node/pull/28881/files/3572a7e7982e3ed624353568debcd04e73128e8d
https://github.com/Trott
Trotthttps://github.com/Trott
Jul 30, 2019 https://github.com/nodejs/node/pull/28881#pullrequestreview-268591926
View reviewed changes https://github.com/nodejs/node/pull/28881/files/3572a7e7982e3ed624353568debcd04e73128e8d
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
Jul 30, 2019https://github.com/nodejs/node/pull/28881#issuecomment-516543601
https://ci.nodejs.org/job/node-test-pull-request/24780/https://ci.nodejs.org/job/node-test-pull-request/24780/
Please reload this pagehttps://github.com/nodejs/node/pull/28881
https://github.com/Trott
Trotthttps://github.com/Trott
author ready https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22author%20ready%22
Jul 30, 2019https://github.com/nodejs/node/pull/28881#event-2520821529
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
Jul 30, 2019https://github.com/nodejs/node/pull/28881#issuecomment-516579879
https://ci.nodejs.org/job/node-test-pull-request/24783/https://ci.nodejs.org/job/node-test-pull-request/24783/
Please reload this pagehttps://github.com/nodejs/node/pull/28881
https://github.com/Trott
Trotthttps://github.com/Trott
Jul 30, 2019https://github.com/nodejs/node/pull/28881#issuecomment-516584193
ab15533https://github.com/nodejs/node/commit/ab155335bc7d4b393a1997a8fb43feee485ed785
Please reload this pagehttps://github.com/nodejs/node/pull/28881
https://github.com/Trott
Trotthttps://github.com/Trott
Jul 30, 2019https://github.com/nodejs/node/pull/28881#event-2521178993
Trotthttps://github.com/Trott
Jul 30, 2019 https://github.com/nodejs/node/pull/28881#ref-commit-ab15533
https://github.com/lpinca
https://github.com/Trott
build: do not mix spaces and tabs in Makefilehttps://github.com/Trott/io.js/commit/ab155335bc7d4b393a1997a8fb43feee485ed785
ab15533https://github.com/Trott/io.js/commit/ab155335bc7d4b393a1997a8fb43feee485ed785
nodejs#28881https://github.com/nodejs/node/pull/28881
https://github.com/lpinca
lpincahttps://github.com/lpinca
July 31, 2019 18:54https://github.com/nodejs/node/pull/28881#event-2524217737
targoshttps://github.com/targos
Aug 2, 2019 https://github.com/nodejs/node/pull/28881#ref-commit-fb57bc4
https://github.com/lpinca
https://github.com/targos
build: do not mix spaces and tabs in Makefilehttps://github.com/nodejs/node/commit/fb57bc4be44dcde11ef00832a34c52bb3e58b47f
fb57bc4https://github.com/nodejs/node/commit/fb57bc4be44dcde11ef00832a34c52bb3e58b47f
#28881https://github.com/nodejs/node/pull/28881
https://github.com/BridgeAR
BridgeARhttps://github.com/BridgeAR
Aug 6, 2019 https://github.com/nodejs/node/pull/28881#ref-pullrequest-477378713
v12.8.0 release proposal #29017 https://github.com/nodejs/node/pull/29017
https://github.com/pd4d10
pd4d10https://github.com/pd4d10
May 7, 2021 https://github.com/nodejs/node/pull/28881#ref-issue-878413940
JOBS=1 make does not work at macOS #38578 https://github.com/nodejs/node/issues/38578
https://github.co/hiddenchars
https://github.com/nodejs/node/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F28881
https://github.com/ChALkeR
ChALkeR https://github.com/ChALkeR
https://github.com/nodejs/node/pull/28881/files/3572a7e7982e3ed624353568debcd04e73128e8d
https://github.com/jasnell
jasnell https://github.com/jasnell
https://github.com/nodejs/node/pull/28881/files/3572a7e7982e3ed624353568debcd04e73128e8d
https://github.com/Trott
Trott https://github.com/Trott
https://github.com/nodejs/node/pull/28881/files/3572a7e7982e3ed624353568debcd04e73128e8d
https://github.com/addaleax
addaleax https://github.com/addaleax
https://github.com/nodejs/node/pull/28881/files/3572a7e7982e3ed624353568debcd04e73128e8d
https://github.com/targos
targos https://github.com/targos
https://github.com/nodejs/node/pull/28881/files/3572a7e7982e3ed624353568debcd04e73128e8d
https://github.com/cjihrig
cjihrig https://github.com/cjihrig
https://github.com/nodejs/node/pull/28881/files/3572a7e7982e3ed624353568debcd04e73128e8d
https://github.com/richardlau
richardlau https://github.com/richardlau
https://github.com/nodejs/node/pull/28881/files/3572a7e7982e3ed624353568debcd04e73128e8d
https://github.com/BethGriggs
BethGriggs https://github.com/BethGriggs
https://github.com/nodejs/node/pull/28881/files/3572a7e7982e3ed624353568debcd04e73128e8d
https://github.com/trivikr
trivikr https://github.com/trivikr
https://github.com/nodejs/node/pull/28881/files/3572a7e7982e3ed624353568debcd04e73128e8d
https://github.com/ZYSzys
ZYSzys https://github.com/ZYSzys
https://github.com/nodejs/node/pull/28881/files/3572a7e7982e3ed624353568debcd04e73128e8d
author ready https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22author%20ready%22
build https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Abuild
Please reload this pagehttps://github.com/nodejs/node/pull/28881
https://github.com/lpinca
https://github.com/nodejs-github-bot
https://github.com/Trott
https://github.com/ChALkeR
https://github.com/jasnell
https://github.com/addaleax
https://github.com/targos
https://github.com/cjihrig
https://github.com/richardlau
https://github.com/BethGriggs
https://github.com/trivikr
https://github.com/ZYSzys
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.