René's URL Explorer Experiment


Title: Revert "module: implement "exports" proposal for CommonJS" by Trott · Pull Request #28847 · nodejs/node · GitHub

Open Graph Title: Revert "module: implement "exports" proposal for CommonJS" by Trott · Pull Request #28847 · nodejs/node

X Title: Revert "module: implement "exports" proposal for CommonJS" by Trott · Pull Request #28847 · nodejs/node

Description: Node.js JavaScript runtime ✨🐢🚀✨. Contribute to nodejs/node development by creating an account on GitHub.

Open Graph Description: This reverts commit dcb6929. Unfortunately, dcb6929 was landed despite apparently-unrelated tests failing in CI on the debug build. However, after it landed, those tests started failing 100% on mas...

X Description: This reverts commit dcb6929. Unfortunately, dcb6929 was landed despite apparently-unrelated tests failing in CI on the debug build. However, after it landed, those tests started failing 100% on mas...

Opengraph URL: https://github.com/nodejs/node/pull/28847

X: @github

direct link

Domain: github.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:fddbdc3f-c4e1-a8e5-72de-e9699f5393a3
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idE570:141FAF:4069D4B:59044DA:6A4F4565
html-safe-nonce6a2902010f612d5b39c179b17186c8458e2b06fab00e3bdb2e03632c1644f53c
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJFNTcwOjE0MUZBRjo0MDY5RDRCOjU5MDQ0REE6NkE0RjQ1NjUiLCJ2aXNpdG9yX2lkIjoiNzkwOTUyMTQ2Njk4NzE2NTE3IiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmacd1e35817db40f8ff766464249b95c6bd235050d3311a335d58fb78caec1584f0
hovercard-subject-tagpull_request:300909285
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/28847/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/a7c6473769d2143f9a2703214a8afd57d0b69c4780cd40e6dffa9b14e31cfe19/nodejs/node/pull/28847
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/a7c6473769d2143f9a2703214a8afd57d0b69c4780cd40e6dffa9b14e31cfe19/nodejs/node/pull/28847
og:image:altThis reverts commit dcb6929. Unfortunately, dcb6929 was landed despite apparently-unrelated tests failing in CI on the debug build. However, after it landed, those tests started failing 100% on mas...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernameTrott
hostnamegithub.com
expected-hostnamegithub.com
Noneb92d11c0aa4a77d54ef4af1078b6a15fb5a70a215b30c4ecf28889d5a8e656d9
turbo-cache-controlno-cache
go-importgithub.com/nodejs/node git https://github.com/nodejs/node.git
octolytics-dimension-user_id9950313
octolytics-dimension-user_loginnodejs
octolytics-dimension-repository_id27193779
octolytics-dimension-repository_nwonodejs/node
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id27193779
octolytics-dimension-repository_network_root_nwonodejs/node
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release4b249b445842943ed31549e027f57a8ade9881ed
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/nodejs/node/pull/28847#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F28847
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub Copilot appDirect agents from issue to mergehttps://github.com/features/ai/github-app
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
View all resourceshttps://github.com/resources
GitHub SponsorsFund open source developershttps://github.com/open-source/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/open-source/accelerator
GitHub Starshttps://stars.github.com
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F28847
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode
Reloadhttps://github.com/nodejs/node/pull/28847
Reloadhttps://github.com/nodejs/node/pull/28847
Reloadhttps://github.com/nodejs/node/pull/28847
Please reload this pagehttps://github.com/nodejs/node/pull/28847
nodejs https://github.com/nodejs
nodehttps://github.com/nodejs/node
Please reload this pagehttps://github.com/nodejs/node/pull/28847
Notifications https://github.com/login?return_to=%2Fnodejs%2Fnode
Fork 36k https://github.com/login?return_to=%2Fnodejs%2Fnode
Star 118k https://github.com/login?return_to=%2Fnodejs%2Fnode
Code https://github.com/nodejs/node
Issues 1.3k https://github.com/nodejs/node/issues
Pull requests 969 https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects https://github.com/nodejs/node/projects
Security and quality 0 https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
Code https://github.com/nodejs/node
Issues https://github.com/nodejs/node/issues
Pull requests https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects https://github.com/nodejs/node/projects
Security and quality https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
Trotthttps://github.com/Trott
nodejs:masterhttps://github.com/nodejs/node/tree/master
Trott:revert-dcb6929https://github.com/Trott/io.js/tree/revert-dcb6929
Conversationhttps://github.com/nodejs/node/pull/28847
Commits1 (1)https://github.com/nodejs/node/pull/28847/commits
Checkshttps://github.com/nodejs/node/pull/28847/checks
Files changedhttps://github.com/nodejs/node/pull/28847/files
Revert "module: implement "exports" proposal for CommonJS"https://github.com/nodejs/node/pull/28847#top
Trotthttps://github.com/Trott
nodejs:masterhttps://github.com/nodejs/node/tree/master
Trott:revert-dcb6929https://github.com/Trott/io.js/tree/revert-dcb6929
https://github.com/Trott
Trotthttps://github.com/Trott
Jul 24, 2019https://github.com/nodejs/node/pull/28847#issue-472556338
dcb6929https://github.com/nodejs/node/commit/dcb692918348986945cbd4fbce8158b2b97a8418
dcb6929https://github.com/nodejs/node/commit/dcb692918348986945cbd4fbce8158b2b97a8418
dcb6929https://github.com/nodejs/node/commit/dcb692918348986945cbd4fbce8158b2b97a8418
commit guidelineshttps://github.com/nodejs/node/blob/master/doc/guides/contributing/pull-requests.md#commit-message-guidelines
Please reload this pagehttps://github.com/nodejs/node/pull/28847
https://github.com/Trott
Revert "module: implement "exports" proposal for CommonJS"https://github.com/nodejs/node/pull/28847/commits/f9e0170f3a88a1068ea2c4d68ca19cfab9473436
f9e0170https://github.com/nodejs/node/pull/28847/commits/f9e0170f3a88a1068ea2c4d68ca19cfab9473436
dcb6929https://github.com/Trott/io.js/commit/dcb692918348986945cbd4fbce8158b2b97a8418
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
c++ https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Ac%2B%2B
lib / src https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22lib%20%2F%20src%22
Jul 24, 2019https://github.com/nodejs/node/pull/28847#event-2507753196
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
Jul 24, 2019https://github.com/nodejs/node/pull/28847#issuecomment-514814278
https://ci.nodejs.org/job/node-test-pull-request/24671/https://ci.nodejs.org/job/node-test-pull-request/24671/
Please reload this pagehttps://github.com/nodejs/node/pull/28847
https://github.com/Trott
Trotthttps://github.com/Trott
Jul 24, 2019https://github.com/nodejs/node/pull/28847#issuecomment-514814598
https://ci.nodejs.org/job/node-daily-master/1621/https://ci.nodejs.org/job/node-daily-master/1621/
Please reload this pagehttps://github.com/nodejs/node/pull/28847
https://github.com/Trott
Trotthttps://github.com/Trott
Jul 24, 2019 https://github.com/nodejs/node/pull/28847#ref-pullrequest-470137924
module: implement "exports" proposal for CommonJS #28759 https://github.com/nodejs/node/pull/28759
https://github.com/Trott
Trotthttps://github.com/Trott
Jul 24, 2019https://github.com/nodejs/node/pull/28847#issuecomment-514818961
Please reload this pagehttps://github.com/nodejs/node/pull/28847
https://ci.nodejs.org/job/node-test-commit-linux-containered/14070/nodes=ubuntu1604_sharedlibs_debug_x64/consolehttps://ci.nodejs.org/job/node-test-commit-linux-containered/14070/nodes=ubuntu1604_sharedlibs_debug_x64/console
Please reload this pagehttps://github.com/nodejs/node/pull/28847
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
Jul 24, 2019 https://github.com/nodejs/node/pull/28847#pullrequestreview-266314283
View reviewed changes https://github.com/nodejs/node/pull/28847/files/f9e0170f3a88a1068ea2c4d68ca19cfab9473436
addaleaxhttps://github.com/addaleax
https://github.com/nodejs/node/pull/28847#pullrequestreview-266314283
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/28847
https://github.com/hybrist
hybristhttps://github.com/hybrist
Jul 24, 2019 https://github.com/nodejs/node/pull/28847#pullrequestreview-266315125
View reviewed changes https://github.com/nodejs/node/pull/28847/files/f9e0170f3a88a1068ea2c4d68ca19cfab9473436
hybristhttps://github.com/hybrist
https://github.com/nodejs/node/pull/28847#pullrequestreview-266315125
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/28847
https://github.com/Trott
Trotthttps://github.com/Trott
dont-land-on-v10.x https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Adont-land-on-v10.x
Jul 24, 2019https://github.com/nodejs/node/pull/28847#event-2507799593
https://github.com/Trott
Trotthttps://github.com/Trott
Jul 24, 2019https://github.com/nodejs/node/pull/28847#issuecomment-514823456
Please reload this pagehttps://github.com/nodejs/node/pull/28847
Please reload this pagehttps://github.com/nodejs/node/pull/28847
https://github.com/Trott
Trotthttps://github.com/Trott
fast-track https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Afast-track
author ready https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22author%20ready%22
Jul 24, 2019https://github.com/nodejs/node/pull/28847#event-2507817815
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
Jul 24, 2019https://github.com/nodejs/node/pull/28847#issuecomment-514827498
Please reload this pagehttps://github.com/nodejs/node/pull/28847
#28453https://github.com/nodejs/node/pull/28453
v8/v8@b107214https://github.com/v8/v8/commit/b10721426503b87d013ecf314ca139fa5334ebb7
Please reload this pagehttps://github.com/nodejs/node/pull/28847
addaleaxhttps://github.com/addaleax
Jul 24, 2019 https://github.com/nodejs/node/pull/28847#ref-commit-1575a46
https://github.com/addaleax
deps: backport b107214 from upstream V8https://github.com/addaleax/node/commit/1575a46e0a7c505c051cbda3916f421cba7110b0
1575a46https://github.com/addaleax/node/commit/1575a46e0a7c505c051cbda3916f421cba7110b0
https://chromium-review.googlesource.com/c/v8/v8/+/1647695https://chromium-review.googlesource.com/c/v8/v8/+/1647695
nodejs#62012https://github.com/nodejs/node/issues/62012
v8/v8@b107214https://github.com/v8/v8/commit/b10721426503b87d013ecf314ca139fa5334ebb7
nodejs#28847https://github.com/nodejs/node/pull/28847
https://github.com/Trott
Trotthttps://github.com/Trott
fast-track https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Afast-track
Jul 24, 2019https://github.com/nodejs/node/pull/28847#event-2507865124
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
Jul 24, 2019 https://github.com/nodejs/node/pull/28847#ref-pullrequest-472589552
deps: backport b107214 from upstream V8 #28850 https://github.com/nodejs/node/pull/28850
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
Jul 24, 2019https://github.com/nodejs/node/pull/28847#issuecomment-514840301
#28850https://github.com/nodejs/node/pull/28850
Please reload this pagehttps://github.com/nodejs/node/pull/28847
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
Jul 24, 2019https://github.com/nodejs/node/pull/28847#event-2507930504
addaleaxhttps://github.com/addaleax
Jul 24, 2019 https://github.com/nodejs/node/pull/28847#ref-commit-49eb2b8
https://github.com/addaleax
deps: backport b107214 from upstream V8https://github.com/nodejs/node/commit/49eb2b8e2a1d964fe78d9dcf4bb1f6c7e967a931
49eb2b8https://github.com/nodejs/node/commit/49eb2b8e2a1d964fe78d9dcf4bb1f6c7e967a931
v8:9333https://bugs.chromium.org/p/v8/issues/detail?id=9333
https://chromium-review.googlesource.com/c/v8/v8/+/1647695https://chromium-review.googlesource.com/c/v8/v8/+/1647695
#62012https://github.com/nodejs/node/issues/62012
v8/v8@b107214https://github.com/v8/v8/commit/b10721426503b87d013ecf314ca139fa5334ebb7
#28847https://github.com/nodejs/node/pull/28847
#28850https://github.com/nodejs/node/pull/28850
https://github.com/Trott
Trotthttps://github.com/Trott
Jul 25, 2019https://github.com/nodejs/node/pull/28847#issuecomment-514879224
@addaleaxhttps://github.com/addaleax
Please reload this pagehttps://github.com/nodejs/node/pull/28847
gntemhttps://github.com/gntem
Jul 27, 2019 https://github.com/nodejs/node/pull/28847#ref-commit-8614a83
https://github.com/addaleax
https://github.com/gntem
deps: backport b107214 from upstream V8https://github.com/gntem/node/commit/8614a83ea760c3087a93d98158257c51d753b6c9
8614a83https://github.com/gntem/node/commit/8614a83ea760c3087a93d98158257c51d753b6c9
https://chromium-review.googlesource.com/c/v8/v8/+/1647695https://chromium-review.googlesource.com/c/v8/v8/+/1647695
nodejs#62012https://github.com/nodejs/node/issues/62012
v8/v8@b107214https://github.com/v8/v8/commit/b10721426503b87d013ecf314ca139fa5334ebb7
nodejs#28847https://github.com/nodejs/node/pull/28847
nodejs#28850https://github.com/nodejs/node/pull/28850
targoshttps://github.com/targos
Aug 2, 2019 https://github.com/nodejs/node/pull/28847#ref-commit-ae56a23
https://github.com/addaleax
https://github.com/targos
deps: backport b107214 from upstream V8https://github.com/nodejs/node/commit/ae56a232e16f138e1458ea6b9e50ce7e5f45c106
ae56a23https://github.com/nodejs/node/commit/ae56a232e16f138e1458ea6b9e50ce7e5f45c106
v8:9333https://bugs.chromium.org/p/v8/issues/detail?id=9333
https://chromium-review.googlesource.com/c/v8/v8/+/1647695https://chromium-review.googlesource.com/c/v8/v8/+/1647695
#62012https://github.com/nodejs/node/issues/62012
v8/v8@b107214https://github.com/v8/v8/commit/b10721426503b87d013ecf314ca139fa5334ebb7
#28847https://github.com/nodejs/node/pull/28847
#28850https://github.com/nodejs/node/pull/28850
vikashk1https://github.com/vikashk1
Aug 13, 2019 https://github.com/nodejs/node/pull/28847#ref-commit-9af17ad
https://github.com/vikashk1
Please ignore this msg (https://github.com/vikashk1/node/commit/9af17ad05c8161db7f52de5fd3331a94857e33fc
#1https://github.com/vikashk1/node/pull/1
)https://github.com/vikashk1/node/commit/9af17ad05c8161db7f52de5fd3331a94857e33fc
9af17adhttps://github.com/vikashk1/node/commit/9af17ad05c8161db7f52de5fd3331a94857e33fc
https://github.com/Trott
Trotthttps://github.com/Trott
January 13, 2022 22:51https://github.com/nodejs/node/pull/28847#event-5890975321
https://github.co/hiddenchars
https://github.com/nodejs/node/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F28847
https://github.com/hybrist
hybrist https://github.com/hybrist
https://github.com/nodejs/node/pull/28847/files/f9e0170f3a88a1068ea2c4d68ca19cfab9473436
https://github.com/addaleax
addaleax https://github.com/addaleax
https://github.com/nodejs/node/pull/28847/files/f9e0170f3a88a1068ea2c4d68ca19cfab9473436
author ready https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22author%20ready%22
c++ https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Ac%2B%2B
lib / src https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22lib%20%2F%20src%22
Please reload this pagehttps://github.com/nodejs/node/pull/28847
https://github.com/Trott
https://github.com/nodejs-github-bot
https://github.com/addaleax
https://github.com/hybrist
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.