René's URL Explorer Experiment


Title: crypto: fix handling of malicious getters (scrypt) by tniessen · Pull Request #28838 · nodejs/node · GitHub

Open Graph Title: crypto: fix handling of malicious getters (scrypt) by tniessen · Pull Request #28838 · nodejs/node

X Title: crypto: fix handling of malicious getters (scrypt) by tniessen · Pull Request #28838 · nodejs/node

Description: Node.js JavaScript runtime ✨🐢🚀✨. Contribute to nodejs/node development by creating an account on GitHub.

Open Graph Description: It is possible to bypass parameter validation in crypto.scrypt and crypto.scryptSync by crafting option objects with malicious getters as demonstrated in the regression test. After bypassing valida...

X Description: It is possible to bypass parameter validation in crypto.scrypt and crypto.scryptSync by crafting option objects with malicious getters as demonstrated in the regression test. After bypassing valida...

Opengraph URL: https://github.com/nodejs/node/pull/28838

X: @github

direct link

Domain: github.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:a1738aca-247f-1f02-efeb-bc204c21ad10
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-id817A:381ACD:2F9CCC9:4188F2F:6A507283
html-safe-nonce9a20851750f88bdbdca17fd4f8150127a6c45ee85c132e0c0383d407cc5ef5d9
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI4MTdBOjM4MUFDRDoyRjlDQ0M5OjQxODhGMkY6NkE1MDcyODMiLCJ2aXNpdG9yX2lkIjoiNTk4ODM3ODY3MTAxMzk4Mjg1MSIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmac09d03984fc89975c20eb54104da476644764f703d7b5c3eb424631cc02e873e1
hovercard-subject-tagpull_request:300651795
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/28838/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/44e647db1437781be872fc40d33d30750f10e78dde86abbc5335e0de48313e66/nodejs/node/pull/28838
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/44e647db1437781be872fc40d33d30750f10e78dde86abbc5335e0de48313e66/nodejs/node/pull/28838
og:image:altIt is possible to bypass parameter validation in crypto.scrypt and crypto.scryptSync by crafting option objects with malicious getters as demonstrated in the regression test. After bypassing valida...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernametniessen
hostnamegithub.com
expected-hostnamegithub.com
Noned6dc8294eb500fa36bbc57472d61fe87c522f9c3c1d64f70f4926f66a66a7efb
turbo-cache-controlno-cache
go-importgithub.com/nodejs/node git https://github.com/nodejs/node.git
octolytics-dimension-user_id9950313
octolytics-dimension-user_loginnodejs
octolytics-dimension-repository_id27193779
octolytics-dimension-repository_nwonodejs/node
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id27193779
octolytics-dimension-repository_network_root_nwonodejs/node
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release7ac0ad2f2c7e4b9056617355fd9e33e22b0c8df9
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/nodejs/node/pull/28838#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F28838
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub Copilot appDirect agents from issue to mergehttps://github.com/features/ai/github-app
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
View all resourceshttps://github.com/resources
GitHub SponsorsFund open source developershttps://github.com/open-source/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/open-source/accelerator
GitHub Starshttps://stars.github.com
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F28838
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode
Reloadhttps://github.com/nodejs/node/pull/28838
Reloadhttps://github.com/nodejs/node/pull/28838
Reloadhttps://github.com/nodejs/node/pull/28838
Please reload this pagehttps://github.com/nodejs/node/pull/28838
nodejs https://github.com/nodejs
nodehttps://github.com/nodejs/node
Please reload this pagehttps://github.com/nodejs/node/pull/28838
Notifications https://github.com/login?return_to=%2Fnodejs%2Fnode
Fork 36k https://github.com/login?return_to=%2Fnodejs%2Fnode
Star 118k https://github.com/login?return_to=%2Fnodejs%2Fnode
Code https://github.com/nodejs/node
Issues 1.3k https://github.com/nodejs/node/issues
Pull requests 979 https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects https://github.com/nodejs/node/projects
Security and quality 0 https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
Code https://github.com/nodejs/node
Issues https://github.com/nodejs/node/issues
Pull requests https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects https://github.com/nodejs/node/projects
Security and quality https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
tniessenhttps://github.com/tniessen
nodejs:masterhttps://github.com/nodejs/node/tree/master
tniessen:crypto-protect-scrypt-against-gettershttps://github.com/tniessen/node/tree/crypto-protect-scrypt-against-getters
Conversationhttps://github.com/nodejs/node/pull/28838
Commits1 (1)https://github.com/nodejs/node/pull/28838/commits
Checkshttps://github.com/nodejs/node/pull/28838/checks
Files changedhttps://github.com/nodejs/node/pull/28838/files
crypto: fix handling of malicious getters (scrypt)https://github.com/nodejs/node/pull/28838#top
tniessenhttps://github.com/tniessen
nodejs:masterhttps://github.com/nodejs/node/tree/master
tniessen:crypto-protect-scrypt-against-gettershttps://github.com/tniessen/node/tree/crypto-protect-scrypt-against-getters
https://github.com/tniessen
tniessenhttps://github.com/tniessen
Jul 24, 2019https://github.com/nodejs/node/pull/28838#issue-472194728
#28836https://github.com/nodejs/node/issues/28836
commit guidelineshttps://github.com/nodejs/node/blob/master/doc/guides/contributing/pull-requests.md#commit-message-guidelines
Please reload this pagehttps://github.com/nodejs/node/pull/28838
https://github.com/tniessen
crypto: fix handling of malicious getters (scrypt)https://github.com/nodejs/node/pull/28838/commits/b287ab9ff87399dfb18a29eded66fb0d92e97d38
b287ab9https://github.com/nodejs/node/pull/28838/commits/b287ab9ff87399dfb18a29eded66fb0d92e97d38
nodejs#28836https://github.com/nodejs/node/issues/28836
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
crypto https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Acrypto
Jul 24, 2019https://github.com/nodejs/node/pull/28838#event-2505798472
https://github.com/targos
targoshttps://github.com/targos
Jul 24, 2019 https://github.com/nodejs/node/pull/28838#pullrequestreview-265921241
View reviewed changes https://github.com/nodejs/node/pull/28838/files/b287ab9ff87399dfb18a29eded66fb0d92e97d38
https://github.com/cjihrig
cjihrighttps://github.com/cjihrig
Jul 24, 2019 https://github.com/nodejs/node/pull/28838#pullrequestreview-265974892
View reviewed changes https://github.com/nodejs/node/pull/28838/files/b287ab9ff87399dfb18a29eded66fb0d92e97d38
https://github.com/BridgeAR
BridgeARhttps://github.com/BridgeAR
Jul 24, 2019 https://github.com/nodejs/node/pull/28838#pullrequestreview-265989313
View reviewed changes https://github.com/nodejs/node/pull/28838/files/b287ab9ff87399dfb18a29eded66fb0d92e97d38
https://github.com/sam-github
sam-githubhttps://github.com/sam-github
Jul 24, 2019 https://github.com/nodejs/node/pull/28838#pullrequestreview-266015605
View reviewed changes https://github.com/nodejs/node/pull/28838/files/b287ab9ff87399dfb18a29eded66fb0d92e97d38
sam-githubhttps://github.com/sam-github
https://github.com/nodejs/node/pull/28838#pullrequestreview-266015605
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/28838
https://github.com/Trott
Trotthttps://github.com/Trott
Jul 24, 2019 https://github.com/nodejs/node/pull/28838#pullrequestreview-266197564
View reviewed changes https://github.com/nodejs/node/pull/28838/files/b287ab9ff87399dfb18a29eded66fb0d92e97d38
https://github.com/Trott
Trotthttps://github.com/Trott
Jul 24, 2019https://github.com/nodejs/node/pull/28838#issuecomment-514742038
Please reload this pagehttps://github.com/nodejs/node/pull/28838
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
Jul 24, 2019https://github.com/nodejs/node/pull/28838#issuecomment-514742443
https://ci.nodejs.org/job/node-test-pull-request/24663/https://ci.nodejs.org/job/node-test-pull-request/24663/
Please reload this pagehttps://github.com/nodejs/node/pull/28838
https://github.com/lpinca
lpincahttps://github.com/lpinca
Jul 24, 2019 https://github.com/nodejs/node/pull/28838#pullrequestreview-266238837
View reviewed changes https://github.com/nodejs/node/pull/28838/files/b287ab9ff87399dfb18a29eded66fb0d92e97d38
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
Jul 25, 2019https://github.com/nodejs/node/pull/28838#issuecomment-515026077
https://ci.nodejs.org/job/node-test-pull-request/24686/https://ci.nodejs.org/job/node-test-pull-request/24686/
Please reload this pagehttps://github.com/nodejs/node/pull/28838
https://github.com/Trott
Trotthttps://github.com/Trott
Jul 26, 2019https://github.com/nodejs/node/pull/28838#issuecomment-515533190
Please reload this pagehttps://github.com/nodejs/node/pull/28838
https://github.com/Trott
Trotthttps://github.com/Trott
Jul 26, 2019https://github.com/nodejs/node/pull/28838#event-2513218694
Trotthttps://github.com/Trott
Jul 26, 2019 https://github.com/nodejs/node/pull/28838#ref-commit-499533f
https://github.com/tniessen
https://github.com/Trott
crypto: fix handling of malicious getters (scrypt)https://github.com/Trott/io.js/commit/499533f72a2dce111d6fde9c21b90b51fff35ab6
499533fhttps://github.com/Trott/io.js/commit/499533f72a2dce111d6fde9c21b90b51fff35ab6
nodejs#28836https://github.com/nodejs/node/issues/28836
nodejs#28838https://github.com/nodejs/node/pull/28838
gntemhttps://github.com/gntem
Jul 27, 2019 https://github.com/nodejs/node/pull/28838#ref-commit-8878678
https://github.com/tniessen
https://github.com/gntem
crypto: fix handling of malicious getters (scrypt)https://github.com/gntem/node/commit/8878678bce2086d22a6fde06d2d2c4483627f1c4
8878678https://github.com/gntem/node/commit/8878678bce2086d22a6fde06d2d2c4483627f1c4
nodejs#28836https://github.com/nodejs/node/issues/28836
nodejs#28838https://github.com/nodejs/node/pull/28838
https://github.com/tniessen
tniessenhttps://github.com/tniessen
Jul 29, 2019https://github.com/nodejs/node/pull/28838#issuecomment-516175826
@sam-githubhttps://github.com/sam-github
Please reload this pagehttps://github.com/nodejs/node/pull/28838
targoshttps://github.com/targos
Aug 2, 2019 https://github.com/nodejs/node/pull/28838#ref-commit-3a62202
https://github.com/tniessen
https://github.com/targos
crypto: fix handling of malicious getters (scrypt)https://github.com/nodejs/node/commit/3a62202a54d7eee86e26f2f241a2412c528bb971
3a62202https://github.com/nodejs/node/commit/3a62202a54d7eee86e26f2f241a2412c528bb971
#28836https://github.com/nodejs/node/issues/28836
#28838https://github.com/nodejs/node/pull/28838
https://github.com/BridgeAR
BridgeARhttps://github.com/BridgeAR
Aug 6, 2019 https://github.com/nodejs/node/pull/28838#ref-pullrequest-477378713
v12.8.0 release proposal #29017 https://github.com/nodejs/node/pull/29017
vikashk1https://github.com/vikashk1
Aug 13, 2019 https://github.com/nodejs/node/pull/28838#ref-commit-9af17ad
https://github.com/vikashk1
Please ignore this msg (https://github.com/vikashk1/node/commit/9af17ad05c8161db7f52de5fd3331a94857e33fc
#1https://github.com/vikashk1/node/pull/1
)https://github.com/vikashk1/node/commit/9af17ad05c8161db7f52de5fd3331a94857e33fc
9af17adhttps://github.com/vikashk1/node/commit/9af17ad05c8161db7f52de5fd3331a94857e33fc
https://github.co/hiddenchars
https://github.com/nodejs/node/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F28838
https://github.com/Trott
Trott https://github.com/Trott
https://github.com/nodejs/node/pull/28838/files/b287ab9ff87399dfb18a29eded66fb0d92e97d38
https://github.com/lpinca
lpinca https://github.com/lpinca
https://github.com/nodejs/node/pull/28838/files/b287ab9ff87399dfb18a29eded66fb0d92e97d38
https://github.com/targos
targos https://github.com/targos
https://github.com/nodejs/node/pull/28838/files/b287ab9ff87399dfb18a29eded66fb0d92e97d38
https://github.com/cjihrig
cjihrig https://github.com/cjihrig
https://github.com/nodejs/node/pull/28838/files/b287ab9ff87399dfb18a29eded66fb0d92e97d38
https://github.com/BridgeAR
BridgeAR https://github.com/BridgeAR
https://github.com/nodejs/node/pull/28838/files/b287ab9ff87399dfb18a29eded66fb0d92e97d38
https://github.com/sam-github
sam-github https://github.com/sam-github
https://github.com/nodejs/node/pull/28838/files/b287ab9ff87399dfb18a29eded66fb0d92e97d38
crypto https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Acrypto
Malicious getters can make scrypt crash https://github.com/nodejs/node/issues/28836
Please reload this pagehttps://github.com/nodejs/node/pull/28838
https://github.com/tniessen
https://github.com/Trott
https://github.com/nodejs-github-bot
https://github.com/sam-github
https://github.com/lpinca
https://github.com/targos
https://github.com/cjihrig
https://github.com/BridgeAR
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.