René's URL Explorer Experiment


Title: [backport v10.x] src: handle empty Maybe in uv binding initialize by Trott · Pull Request #28832 · nodejs/node · GitHub

Open Graph Title: [backport v10.x] src: handle empty Maybe in uv binding initialize by Trott · Pull Request #28832 · nodejs/node

X Title: [backport v10.x] src: handle empty Maybe in uv binding initialize by Trott · Pull Request #28832 · nodejs/node

Description: Node.js JavaScript runtime ✨🐢🚀✨. Contribute to nodejs/node development by creating an account on GitHub.

Open Graph Description: This can fail when terminating a Worker that loads the uv binding at the same time. Refs: #25061 (comment) Fixes: #25134 PR-URL: #25079 Reviewed-By: James M Snell jasnell@gmail.com Reviewed-By: Dan...

X Description: This can fail when terminating a Worker that loads the uv binding at the same time. Refs: #25061 (comment) Fixes: #25134 PR-URL: #25079 Reviewed-By: James M Snell jasnell@gmail.com Reviewed-By: Dan...

Mail addresses
jasnell@gmail.com
daniel.bevenius@gmail.com
gpunathi@in.ibm.com
cjihrig@gmail.com

Opengraph URL: https://github.com/nodejs/node/pull/28832

X: @github

direct link

Domain: github.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:da07b2a7-7e1b-4134-ccc6-025da3d1e86c
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idC9C2:1F0B:222BB72:2F01857:6A4F4BB7
html-safe-nonce1b612e9ccc30519bc672bfc639af144e4d6c8a6d402b4bb61b9135559db45b00
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJDOUMyOjFGMEI6MjIyQkI3MjoyRjAxODU3OjZBNEY0QkI3IiwidmlzaXRvcl9pZCI6IjI0ODk0Njk1NTMxNDQxODc4MzEiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmac381d7f1b93b2154e643b26075accc8f270025b11cb85b085306a741a41025daa
hovercard-subject-tagpull_request:300565370
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/28832/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/a7c6473769d2143f9a2703214a8afd57d0b69c4780cd40e6dffa9b14e31cfe19/nodejs/node/pull/28832
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/a7c6473769d2143f9a2703214a8afd57d0b69c4780cd40e6dffa9b14e31cfe19/nodejs/node/pull/28832
og:image:altThis can fail when terminating a Worker that loads the uv binding at the same time. Refs: #25061 (comment) Fixes: #25134 PR-URL: #25079 Reviewed-By: James M Snell jasnell@gmail.com Reviewed-By: Dan...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernameTrott
hostnamegithub.com
expected-hostnamegithub.com
Noneb92d11c0aa4a77d54ef4af1078b6a15fb5a70a215b30c4ecf28889d5a8e656d9
turbo-cache-controlno-cache
go-importgithub.com/nodejs/node git https://github.com/nodejs/node.git
octolytics-dimension-user_id9950313
octolytics-dimension-user_loginnodejs
octolytics-dimension-repository_id27193779
octolytics-dimension-repository_nwonodejs/node
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id27193779
octolytics-dimension-repository_network_root_nwonodejs/node
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release4b249b445842943ed31549e027f57a8ade9881ed
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/nodejs/node/pull/28832#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F28832
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub Copilot appDirect agents from issue to mergehttps://github.com/features/ai/github-app
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
View all resourceshttps://github.com/resources
GitHub SponsorsFund open source developershttps://github.com/open-source/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/open-source/accelerator
GitHub Starshttps://stars.github.com
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F28832
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode
Reloadhttps://github.com/nodejs/node/pull/28832
Reloadhttps://github.com/nodejs/node/pull/28832
Reloadhttps://github.com/nodejs/node/pull/28832
Please reload this pagehttps://github.com/nodejs/node/pull/28832
nodejs https://github.com/nodejs
nodehttps://github.com/nodejs/node
Please reload this pagehttps://github.com/nodejs/node/pull/28832
Notifications https://github.com/login?return_to=%2Fnodejs%2Fnode
Fork 36k https://github.com/login?return_to=%2Fnodejs%2Fnode
Star 118k https://github.com/login?return_to=%2Fnodejs%2Fnode
Code https://github.com/nodejs/node
Issues 1.3k https://github.com/nodejs/node/issues
Pull requests 969 https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects https://github.com/nodejs/node/projects
Security and quality 0 https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
Code https://github.com/nodejs/node
Issues https://github.com/nodejs/node/issues
Pull requests https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects https://github.com/nodejs/node/projects
Security and quality https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
Trotthttps://github.com/Trott
nodejs:v10.x-staginghttps://github.com/nodejs/node/tree/v10.x-staging
Trott:backport-25079https://github.com/Trott/io.js/tree/backport-25079
Conversationhttps://github.com/nodejs/node/pull/28832
Commits1 (1)https://github.com/nodejs/node/pull/28832/commits
Checkshttps://github.com/nodejs/node/pull/28832/checks
Files changedhttps://github.com/nodejs/node/pull/28832/files
[backport v10.x] src: handle empty Maybe in uv binding initializehttps://github.com/nodejs/node/pull/28832#top
Trotthttps://github.com/Trott
nodejs:v10.x-staginghttps://github.com/nodejs/node/tree/v10.x-staging
Trott:backport-25079https://github.com/Trott/io.js/tree/backport-25079
https://github.com/Trott
Trotthttps://github.com/Trott
Jul 24, 2019https://github.com/nodejs/node/pull/28832#issue-472086140
#25061 (comment)https://github.com/nodejs/node/pull/25061#issuecomment-447648475
#25134https://github.com/nodejs/node/issues/25134
#25079https://github.com/nodejs/node/pull/25079
commit guidelineshttps://github.com/nodejs/node/blob/master/doc/guides/contributing/pull-requests.md#commit-message-guidelines
Please reload this pagehttps://github.com/nodejs/node/pull/28832
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
c++ https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Ac%2B%2B
libuv https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Alibuv
v10.x https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Av10.x
Jul 24, 2019https://github.com/nodejs/node/pull/28832#event-2505135980
https://github.com/Trott
Trotthttps://github.com/Trott
force-pushedhttps://github.com/nodejs/node/compare/fadf27e11a7d725cc99fbb679bba12bf5acc4f02..c19fca6db1fb1666066019779986f44c68e77624
fadf27ehttps://github.com/nodejs/node/commit/fadf27e11a7d725cc99fbb679bba12bf5acc4f02
c19fca6https://github.com/nodejs/node/commit/c19fca6db1fb1666066019779986f44c68e77624
Compare https://github.com/nodejs/node/compare/fadf27e11a7d725cc99fbb679bba12bf5acc4f02..c19fca6db1fb1666066019779986f44c68e77624
July 24, 2019 05:30https://github.com/nodejs/node/pull/28832#event-2505136567
https://github.com/nodejs-github-bot
Sign in to viewhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F28832
https://github.com/Trott
Trotthttps://github.com/Trott
Jul 24, 2019https://github.com/nodejs/node/pull/28832#event-2505169179
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
Jul 24, 2019 https://github.com/nodejs/node/pull/28832#pullrequestreview-265888633
View reviewed changes https://github.com/nodejs/node/pull/28832/files
addaleaxhttps://github.com/addaleax
https://github.com/nodejs/node/pull/28832#pullrequestreview-265888633
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/28832
src/uv.cchttps://github.com/nodejs/node/pull/28832/files#diff-95f83085be17f94fb327fae2409d65723957415d3996c2937c903250143353c7
Please reload this pagehttps://github.com/nodejs/node/pull/28832
https://github.com/Trott
Trotthttps://github.com/Trott
Jul 26, 2019https://github.com/nodejs/node/pull/28832#event-2511543868
https://github.com/Trott
Trotthttps://github.com/Trott
force-pushedhttps://github.com/nodejs/node/compare/c19fca6db1fb1666066019779986f44c68e77624..56578ceb2eb0e447ffe779804c63f4182ce48e9c
c19fca6https://github.com/nodejs/node/commit/c19fca6db1fb1666066019779986f44c68e77624
56578cehttps://github.com/nodejs/node/commit/56578ceb2eb0e447ffe779804c63f4182ce48e9c
Compare https://github.com/nodejs/node/compare/c19fca6db1fb1666066019779986f44c68e77624..56578ceb2eb0e447ffe779804c63f4182ce48e9c
July 26, 2019 05:56https://github.com/nodejs/node/pull/28832#event-2511544782
https://github.com/nodejs-github-bot
Sign in to viewhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F28832
https://github.com/addaleax
https://github.com/Trott
src: handle empty Maybe in uv binding initializehttps://github.com/nodejs/node/pull/28832/commits/ca4a22e8d4ae7a6947afb3452e56d2e807e0a635
ca4a22ehttps://github.com/nodejs/node/pull/28832/commits/ca4a22e8d4ae7a6947afb3452e56d2e807e0a635
nodejs#25061 (comment)https://github.com/nodejs/node/pull/25061#issuecomment-447648475
nodejs#25134https://github.com/nodejs/node/issues/25134
nodejs#25079https://github.com/nodejs/node/pull/25079
nodejs#28832https://github.com/nodejs/node/pull/28832
https://github.com/Trott
Trotthttps://github.com/Trott
force-pushedhttps://github.com/nodejs/node/compare/56578ceb2eb0e447ffe779804c63f4182ce48e9c..ca4a22e8d4ae7a6947afb3452e56d2e807e0a635
56578cehttps://github.com/nodejs/node/commit/56578ceb2eb0e447ffe779804c63f4182ce48e9c
ca4a22ehttps://github.com/nodejs/node/commit/ca4a22e8d4ae7a6947afb3452e56d2e807e0a635
Compare https://github.com/nodejs/node/compare/56578ceb2eb0e447ffe779804c63f4182ce48e9c..ca4a22e8d4ae7a6947afb3452e56d2e807e0a635
July 26, 2019 06:06https://github.com/nodejs/node/pull/28832#event-2511561638
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
Jul 26, 2019https://github.com/nodejs/node/pull/28832#issuecomment-515322512
Please reload this pagehttps://github.com/nodejs/node/pull/28832
https://ci.nodejs.org/job/node-test-pull-request/24715/https://ci.nodejs.org/job/node-test-pull-request/24715/
Please reload this pagehttps://github.com/nodejs/node/pull/28832
src: handle empty Maybe in uv binding initialize #25079 https://github.com/nodejs/node/pull/25079
[v10.x] doc: describe tls.DEFAULT_MIN_VERSION/_MAX_VERSION #28827 https://github.com/nodejs/node/pull/28827
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
Jul 26, 2019 https://github.com/nodejs/node/pull/28832#pullrequestreview-267106198
View reviewed changes https://github.com/nodejs/node/pull/28832/files/ca4a22e8d4ae7a6947afb3452e56d2e807e0a635
https://github.com/BethGriggs
BethGriggshttps://github.com/BethGriggs
Jul 30, 2019 https://github.com/nodejs/node/pull/28832#pullrequestreview-268575891
View reviewed changes https://github.com/nodejs/node/pull/28832/files/ca4a22e8d4ae7a6947afb3452e56d2e807e0a635
BethGriggshttps://github.com/BethGriggs
Jul 30, 2019 https://github.com/nodejs/node/pull/28832#ref-commit-0339fba
https://github.com/addaleax
https://github.com/BethGriggs
src: handle empty Maybe in uv binding initializehttps://github.com/nodejs/node/commit/0339fba1bb39535517176978815b892ae70882ed
0339fbahttps://github.com/nodejs/node/commit/0339fba1bb39535517176978815b892ae70882ed
#25061 (comment)https://github.com/nodejs/node/pull/25061#issuecomment-447648475
#25134https://github.com/nodejs/node/issues/25134
#25079https://github.com/nodejs/node/pull/25079
#28832https://github.com/nodejs/node/pull/28832
https://github.com/BethGriggs
BethGriggshttps://github.com/BethGriggs
Jul 30, 2019https://github.com/nodejs/node/pull/28832#issuecomment-516580027
Please reload this pagehttps://github.com/nodejs/node/pull/28832
https://github.com/BethGriggs
BethGriggshttps://github.com/BethGriggs
Jul 30, 2019https://github.com/nodejs/node/pull/28832#event-2521148167
https://github.com/Trott
Trotthttps://github.com/Trott
January 13, 2022 22:51https://github.com/nodejs/node/pull/28832#event-5890975323
https://github.co/hiddenchars
https://github.com/nodejs/node/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F28832
https://github.com/addaleax
addaleax https://github.com/addaleax
https://github.com/nodejs/node/pull/28832/files/ca4a22e8d4ae7a6947afb3452e56d2e807e0a635
https://github.com/BethGriggs
BethGriggs https://github.com/BethGriggs
https://github.com/nodejs/node/pull/28832/files/ca4a22e8d4ae7a6947afb3452e56d2e807e0a635
c++ https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Ac%2B%2B
libuv https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Alibuv
Please reload this pagehttps://github.com/nodejs/node/pull/28832
https://github.com/Trott
https://github.com/nodejs-github-bot
https://github.com/BethGriggs
https://github.com/addaleax
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.