| route-pattern | /_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format) |
| route-controller | voltron_pull_requests_fragments |
| route-action | pull_request_layout |
| fetch-nonce | v2:617f01e1-c87b-5887-fa93-08fb2198f99a |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | C4C2:3463DE:28091A2:37827F4:6A4F5648 |
| html-safe-nonce | 0d255758b6b14d7dffd7de64a141bab2314f6d7daf4bbcca2c07f9a7ec6aa703 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJDNEMyOjM0NjNERToyODA5MUEyOjM3ODI3RjQ6NkE0RjU2NDgiLCJ2aXNpdG9yX2lkIjoiNTk0MTQwMjEzNTUwMTQyODI5NyIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9 |
| visitor-hmac | f4b51756650cf5c52057756645d99d3d4ce7ba3214133877ca089ddb7dea5c93 |
| hovercard-subject-tag | pull_request:300489642 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///voltron/pull_requests_fragments/pull_request_layout |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/28827/pull_request_layout |
| twitter:image | https://opengraph.githubassets.com/57ad64e36d46932a0ad6be892144a57b8b1a8fc961130f6fc604b9890879b92d/nodejs/node/pull/28827 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/57ad64e36d46932a0ad6be892144a57b8b1a8fc961130f6fc604b9890879b92d/nodejs/node/pull/28827 |
| og:image:alt | Add documentation for tls.DEFAULT_MAX_VERSION and
tls.DEFAULT_MIN_VERSION, which existed in v10.6.0
Fixes: #28758
Refs: #26821
Checklist
make -j4 test (UNIX), or vcbuild test (Windows) passes
do... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | ckarande |
| hostname | github.com |
| expected-hostname | github.com |
| None | b92d11c0aa4a77d54ef4af1078b6a15fb5a70a215b30c4ecf28889d5a8e656d9 |
| turbo-cache-control | no-cache |
| go-import | github.com/nodejs/node git https://github.com/nodejs/node.git |
| octolytics-dimension-user_id | 9950313 |
| octolytics-dimension-user_login | nodejs |
| octolytics-dimension-repository_id | 27193779 |
| octolytics-dimension-repository_nwo | nodejs/node |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 27193779 |
| octolytics-dimension-repository_network_root_nwo | nodejs/node |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | b14b8c6d72fdb96ca48aba85dec94fe96ce5adbe |
| ui-target | canary-2 |
| theme-color | #1e2327 |
| color-scheme | light dark |
| Skip to content | https://github.com/nodejs/node/pull/28827#start-of-content |
|
| https://github.com/ |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F28827 |
| GitHub CopilotWrite better code with AI | https://github.com/features/copilot |
| GitHub Copilot appDirect agents from issue to merge | https://github.com/features/ai/github-app |
| MCP RegistryNewIntegrate external tools | https://github.com/mcp |
| ActionsAutomate any workflow | https://github.com/features/actions |
| CodespacesInstant dev environments | https://github.com/features/codespaces |
| IssuesPlan and track work | https://github.com/features/issues |
| Code ReviewManage code changes | https://github.com/features/code-review |
| GitHub Advanced SecurityFind and fix vulnerabilities | https://github.com/security/advanced-security |
| Code securitySecure your code as you build | https://github.com/security/advanced-security/code-security |
| Secret protectionStop leaks before they start | https://github.com/security/advanced-security/secret-protection |
| Why GitHub | https://github.com/why-github |
| Documentation | https://docs.github.com |
| Blog | https://github.blog |
| Changelog | https://github.blog/changelog |
| Marketplace | https://github.com/marketplace |
| View all features | https://github.com/features |
| Enterprises | https://github.com/enterprise |
| Small and medium teams | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| App Modernization | https://github.com/solutions/use-case/app-modernization |
| DevSecOps | https://github.com/solutions/use-case/devsecops |
| DevOps | https://github.com/solutions/use-case/devops |
| CI/CD | https://github.com/solutions/use-case/ci-cd |
| View all use cases | https://github.com/solutions/use-case |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| View all industries | https://github.com/solutions/industry |
| View all solutions | https://github.com/solutions |
| AI | https://github.com/resources/articles?topic=ai |
| Software Development | https://github.com/resources/articles?topic=software-development |
| DevOps | https://github.com/resources/articles?topic=devops |
| Security | https://github.com/resources/articles?topic=security |
| View all topics | https://github.com/resources/articles |
| Customer stories | https://github.com/customer-stories |
| Events & webinars | https://github.com/resources/events |
| Ebooks & reports | https://github.com/resources/whitepapers |
| Business insights | https://github.com/solutions/executive-insights |
| GitHub Skills | https://skills.github.com |
| Documentation | https://docs.github.com |
| Customer support | https://support.github.com |
| Community forum | https://github.com/orgs/community/discussions |
| Trust center | https://github.com/trust-center |
| Partners | https://github.com/partners |
| View all resources | https://github.com/resources |
| GitHub SponsorsFund open source developers | https://github.com/open-source/sponsors |
| Security Lab | https://securitylab.github.com |
| Maintainer Community | https://maintainers.github.com |
| Accelerator | https://github.com/open-source/accelerator |
| GitHub Stars | https://stars.github.com |
| Archive Program | https://archiveprogram.github.com |
| Topics | https://github.com/topics |
| Trending | https://github.com/trending |
| Collections | https://github.com/collections |
| Enterprise platformAI-powered developer platform | https://github.com/enterprise |
| GitHub Advanced SecurityEnterprise-grade security features | https://github.com/security/advanced-security |
| Copilot for BusinessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/enterprise/premium-support |
| Pricing | https://github.com/pricing |
| Search syntax tips | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
| documentation | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F28827 |
|
Sign up
| https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode |
| Reload | https://github.com/nodejs/node/pull/28827 |
| Reload | https://github.com/nodejs/node/pull/28827 |
| Reload | https://github.com/nodejs/node/pull/28827 |
| Please reload this page | https://github.com/nodejs/node/pull/28827 |
|
nodejs
| https://github.com/nodejs |
| node | https://github.com/nodejs/node |
| Please reload this page | https://github.com/nodejs/node/pull/28827 |
|
Notifications
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Fork
36k
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Star
118k
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Code
| https://github.com/nodejs/node |
|
Issues
1.3k
| https://github.com/nodejs/node/issues |
|
Pull requests
970
| https://github.com/nodejs/node/pulls |
|
Actions
| https://github.com/nodejs/node/actions |
|
Projects
| https://github.com/nodejs/node/projects |
|
Security and quality
0
| https://github.com/nodejs/node/security |
|
Insights
| https://github.com/nodejs/node/pulse |
|
Code
| https://github.com/nodejs/node |
|
Issues
| https://github.com/nodejs/node/issues |
|
Pull requests
| https://github.com/nodejs/node/pulls |
|
Actions
| https://github.com/nodejs/node/actions |
|
Projects
| https://github.com/nodejs/node/projects |
|
Security and quality
| https://github.com/nodejs/node/security |
|
Insights
| https://github.com/nodejs/node/pulse |
| ckarande | https://github.com/ckarande |
| nodejs:v10.x-staging | https://github.com/nodejs/node/tree/v10.x-staging |
| ckarande:backport-26821-to-v10.x | https://github.com/ckarande/node/tree/backport-26821-to-v10.x |
| Conversation | https://github.com/nodejs/node/pull/28827 |
| Commits2 (2) | https://github.com/nodejs/node/pull/28827/commits |
| Checks | https://github.com/nodejs/node/pull/28827/checks |
| Files changed | https://github.com/nodejs/node/pull/28827/files |
| [v10.x] doc: describe tls.DEFAULT_MIN_VERSION/_MAX_VERSION | https://github.com/nodejs/node/pull/28827#top |
| ckarande | https://github.com/ckarande |
| nodejs:v10.x-staging | https://github.com/nodejs/node/tree/v10.x-staging |
| ckarande:backport-26821-to-v10.x | https://github.com/ckarande/node/tree/backport-26821-to-v10.x |
|
| https://github.com/ckarande |
| ckarande | https://github.com/ckarande |
| Jul 23, 2019 | https://github.com/nodejs/node/pull/28827#issue-471984403 |
| #28758 | https://github.com/nodejs/node/issues/28758 |
| #26821 | https://github.com/nodejs/node/pull/26821 |
| commit guidelines | https://github.com/nodejs/node/blob/master/doc/guides/contributing/pull-requests.md#commit-message-guidelines |
| Please reload this page | https://github.com/nodejs/node/pull/28827 |
|
| https://github.com/ckarande |
| doc: describe tls.DEFAULT_MIN_VERSION/_MAX_VERSION | https://github.com/nodejs/node/pull/28827/commits/e3ebd5192aa01d307cf50a10be6f326cfa2d8a1d |
| e3ebd51 | https://github.com/nodejs/node/pull/28827/commits/e3ebd5192aa01d307cf50a10be6f326cfa2d8a1d |
| nodejs#28758 | https://github.com/nodejs/node/issues/28758 |
| nodejs#26821 | https://github.com/nodejs/node/pull/26821 |
| https://github.com/nodejs-github-bot |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
|
doc
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Adoc |
|
v10.x
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Av10.x |
| Jul 23, 2019 | https://github.com/nodejs/node/pull/28827#event-2504559331 |
| https://github.com/addaleax |
| addaleax | https://github.com/addaleax |
| Jul 23, 2019 | https://github.com/nodejs/node/pull/28827#event-2504562203 |
| https://github.com/addaleax |
| addaleax | https://github.com/addaleax |
|
Jul 23, 2019
| https://github.com/nodejs/node/pull/28827#pullrequestreview-265704713 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/28827/files/e3ebd5192aa01d307cf50a10be6f326cfa2d8a1d |
| doc/api/cli.md | https://github.com/nodejs/node/pull/28827/files/e3ebd5192aa01d307cf50a10be6f326cfa2d8a1d#diff-7349c17bce4d97526eefcb6f8291d617e7edb92ed9927fd3b9264e8014fc4e7c |
| addaleax | https://github.com/addaleax |
| Jul 23, 2019 | https://github.com/nodejs/node/pull/28827#discussion_r306555425 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/28827 |
| ckarande | https://github.com/ckarande |
| Jul 23, 2019 | https://github.com/nodejs/node/pull/28827#discussion_r306560492 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| commit | https://github.com/nodejs/node/pull/26821/files#diff-85b6573bc4afd5e06ed3b9d9b553635dR924 |
| Please reload this page | https://github.com/nodejs/node/pull/28827 |
| ckarande | https://github.com/ckarande |
| Jul 24, 2019 | https://github.com/nodejs/node/pull/28827#discussion_r306585827 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/28827 |
| doc/api/tls.md | https://github.com/nodejs/node/pull/28827/files/e3ebd5192aa01d307cf50a10be6f326cfa2d8a1d#diff-6114e55c49ec9bc0edc33830f7770a335a46373a84b8372957c387d88a23b7de |
| addaleax | https://github.com/addaleax |
| Jul 23, 2019 | https://github.com/nodejs/node/pull/28827#discussion_r306555575 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/28827 |
| https://github.com/nitinsurana |
| nitinsurana | https://github.com/nitinsurana |
| Jul 24, 2019 | https://github.com/nodejs/node/pull/28827#issuecomment-514427726 |
| Please reload this page | https://github.com/nodejs/node/pull/28827 |
| Please reload this page | https://github.com/nodejs/node/pull/28827 |
|
| https://github.com/ckarande |
| doc: fix the links tls default version sections | https://github.com/nodejs/node/pull/28827/commits/c5a360b711b31455acc29ade8f630168c42675ef |
| c5a360b | https://github.com/nodejs/node/pull/28827/commits/c5a360b711b31455acc29ade8f630168c42675ef |
| https://github.com/ckarande |
| ckarande | https://github.com/ckarande |
| Jul 24, 2019 | https://github.com/nodejs/node/pull/28827#issuecomment-514436062 |
| @nitinsurana | https://github.com/nitinsurana |
| @addaleax | https://github.com/addaleax |
| Please reload this page | https://github.com/nodejs/node/pull/28827 |
| https://github.com/nodejs-github-bot |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
| Jul 25, 2019 | https://github.com/nodejs/node/pull/28827#issuecomment-515119499 |
| https://ci.nodejs.org/job/node-test-pull-request/24693/ | https://ci.nodejs.org/job/node-test-pull-request/24693/ |
| Please reload this page | https://github.com/nodejs/node/pull/28827 |
| https://github.com/Trott |
| Trott | https://github.com/Trott |
| Jul 26, 2019 | https://github.com/nodejs/node/pull/28827#issuecomment-515307059 |
| #25079 | https://github.com/nodejs/node/pull/25079 |
| Please reload this page | https://github.com/nodejs/node/pull/28827 |
| https://github.com/nodejs-github-bot |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
| Jul 26, 2019 | https://github.com/nodejs/node/pull/28827#issuecomment-515307156 |
| https://ci.nodejs.org/job/node-test-pull-request/24708/ | https://ci.nodejs.org/job/node-test-pull-request/24708/ |
| Please reload this page | https://github.com/nodejs/node/pull/28827 |
| https://github.com/Trott |
| Trott | https://github.com/Trott |
| Jul 26, 2019 | https://github.com/nodejs/node/pull/28827#issuecomment-515322678 |
| #25079 | https://github.com/nodejs/node/pull/25079 |
| #28832 | https://github.com/nodejs/node/pull/28832 |
| Please reload this page | https://github.com/nodejs/node/pull/28827 |
| https://github.com/Trott |
| Trott | https://github.com/Trott |
| Aug 2, 2019 | https://github.com/nodejs/node/pull/28827#issuecomment-517537579 |
| #25079 | https://github.com/nodejs/node/pull/25079 |
| #28832 | https://github.com/nodejs/node/pull/28832 |
| Please reload this page | https://github.com/nodejs/node/pull/28827 |
| https://github.com/nodejs-github-bot |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
| Aug 2, 2019 | https://github.com/nodejs/node/pull/28827#issuecomment-517537642 |
| https://ci.nodejs.org/job/node-test-pull-request/24819/ | https://ci.nodejs.org/job/node-test-pull-request/24819/ |
| Please reload this page | https://github.com/nodejs/node/pull/28827 |
| https://github.com/nodejs-github-bot |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
| Sep 18, 2019 | https://github.com/nodejs/node/pull/28827#issuecomment-532648817 |
| https://ci.nodejs.org/job/node-test-pull-request/25543/ | https://ci.nodejs.org/job/node-test-pull-request/25543/ |
| Please reload this page | https://github.com/nodejs/node/pull/28827 |
| https://github.com/nodejs-github-bot |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
| Sep 18, 2019 | https://github.com/nodejs/node/pull/28827#issuecomment-532674003 |
| https://ci.nodejs.org/job/node-test-pull-request/25546/ | https://ci.nodejs.org/job/node-test-pull-request/25546/ |
| Please reload this page | https://github.com/nodejs/node/pull/28827 |
| https://github.com/BethGriggs |
| BethGriggs | https://github.com/BethGriggs |
|
Oct 7, 2019
| https://github.com/nodejs/node/pull/28827#pullrequestreview-298256836 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/28827/files/c5a360b711b31455acc29ade8f630168c42675ef |
| BethGriggs | https://github.com/BethGriggs |
|
Oct 7, 2019
| https://github.com/nodejs/node/pull/28827#ref-commit-cef5010 |
|
| https://github.com/ckarande |
|
| https://github.com/BethGriggs |
| doc: describe tls.DEFAULT_MIN_VERSION/_MAX_VERSION | https://github.com/nodejs/node/commit/cef501013541476dff0cc0b5e153627da7f0af48 |
| cef5010 | https://github.com/nodejs/node/commit/cef501013541476dff0cc0b5e153627da7f0af48 |
| #28758 | https://github.com/nodejs/node/issues/28758 |
| #26821 | https://github.com/nodejs/node/pull/26821 |
| #28827 | https://github.com/nodejs/node/pull/28827 |
| BethGriggs | https://github.com/BethGriggs |
|
Oct 7, 2019
| https://github.com/nodejs/node/pull/28827#ref-commit-c285e69 |
|
| https://github.com/ckarande |
|
| https://github.com/BethGriggs |
| doc: fix the links tls default version sections | https://github.com/nodejs/node/commit/c285e694e2444d1bee5b5dcb1ea414b7068d04e4 |
| c285e69 | https://github.com/nodejs/node/commit/c285e694e2444d1bee5b5dcb1ea414b7068d04e4 |
| #28827 | https://github.com/nodejs/node/pull/28827 |
| #28758 | https://github.com/nodejs/node/issues/28758 |
| #26821 | https://github.com/nodejs/node/pull/26821 |
| https://github.com/BethGriggs |
| BethGriggs | https://github.com/BethGriggs |
| Oct 7, 2019 | https://github.com/nodejs/node/pull/28827#issuecomment-539102156 |
| c285e69 | https://github.com/nodejs/node/commit/c285e694e2444d1bee5b5dcb1ea414b7068d04e4 |
| @ckarande | https://github.com/ckarande |
| Please reload this page | https://github.com/nodejs/node/pull/28827 |
| https://github.com/BethGriggs |
| BethGriggs | https://github.com/BethGriggs |
| Oct 7, 2019 | https://github.com/nodejs/node/pull/28827#event-2692548529 |
| https://github.com/BethGriggs |
| BethGriggs | https://github.com/BethGriggs |
|
Oct 7, 2019
| https://github.com/nodejs/node/pull/28827#ref-pullrequest-503572635 |
|
v10.17.0 proposal
#29875
| https://github.com/nodejs/node/pull/29875 |
| https://github.co/hiddenchars |
| https://github.com/nodejs/node/pull/{{ revealButtonHref }} |
| Sign up for free | https://github.com/join?source=comment-repo |
| Sign in to comment | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F28827 |
|
| https://github.com/addaleax |
|
addaleax
| https://github.com/addaleax |
|
| https://github.com/nodejs/node/pull/28827/files/e3ebd5192aa01d307cf50a10be6f326cfa2d8a1d |
|
| https://github.com/BethGriggs |
|
BethGriggs
| https://github.com/BethGriggs |
|
| https://github.com/nodejs/node/pull/28827/files/c5a360b711b31455acc29ade8f630168c42675ef |
|
doc
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Adoc |
| Please reload this page | https://github.com/nodejs/node/pull/28827 |
|
| https://github.com/ckarande |
|
| https://github.com/nitinsurana |
|
| https://github.com/nodejs-github-bot |
|
| https://github.com/Trott |
|
| https://github.com/BethGriggs |
|
| https://github.com/addaleax |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |