René's URL Explorer Experiment


Title: [backport v10.x] test: fix pty test hangs on aix by Trott · Pull Request #28826 · nodejs/node · GitHub

Open Graph Title: [backport v10.x] test: fix pty test hangs on aix by Trott · Pull Request #28826 · nodejs/node

X Title: [backport v10.x] test: fix pty test hangs on aix by Trott · Pull Request #28826 · nodejs/node

Description: Node.js JavaScript runtime ✨🐢🚀✨. Contribute to nodejs/node development by creating an account on GitHub.

Open Graph Description: Original PRs: #28600 #28516 #28469 Some pty tests persistently hung on the AIX CI buildbots. Fix that by adding a helper script that properly sets up the pty before spawning the script under test. ...

X Description: Original PRs: #28600 #28516 #28469 Some pty tests persistently hung on the AIX CI buildbots. Fix that by adding a helper script that properly sets up the pty before spawning the script under test. ...

Mail addresses
riclau@uk.ibm.com
vieuxtech@gmail.com
anna@addaleax.net

Opengraph URL: https://github.com/nodejs/node/pull/28826

X: @github

direct link

Domain: github.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:cfedc474-cb8b-7313-b350-5fc6a3f8c61e
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idB5E0:20853D:521B6D3:7206465:6A4F781E
html-safe-noncea84c63246160e7480f07a619e468eea280d3908cb0e6eaabda37122d73ef4b66
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJCNUUwOjIwODUzRDo1MjFCNkQzOjcyMDY0NjU6NkE0Rjc4MUUiLCJ2aXNpdG9yX2lkIjoiNjc3NjE4OTkwNjM0NTQ5MDQ2MyIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmacbd283c78422a7fbbfd3ad6d4ae54ed11b7675f17ada4f7a9fd02d3b6416a99e3
hovercard-subject-tagpull_request:300485251
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/28826/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/a7c6473769d2143f9a2703214a8afd57d0b69c4780cd40e6dffa9b14e31cfe19/nodejs/node/pull/28826
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/a7c6473769d2143f9a2703214a8afd57d0b69c4780cd40e6dffa9b14e31cfe19/nodejs/node/pull/28826
og:image:altOriginal PRs: #28600 #28516 #28469 Some pty tests persistently hung on the AIX CI buildbots. Fix that by adding a helper script that properly sets up the pty before spawning the script under test. ...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernameTrott
hostnamegithub.com
expected-hostnamegithub.com
Noneb92d11c0aa4a77d54ef4af1078b6a15fb5a70a215b30c4ecf28889d5a8e656d9
turbo-cache-controlno-cache
go-importgithub.com/nodejs/node git https://github.com/nodejs/node.git
octolytics-dimension-user_id9950313
octolytics-dimension-user_loginnodejs
octolytics-dimension-repository_id27193779
octolytics-dimension-repository_nwonodejs/node
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id27193779
octolytics-dimension-repository_network_root_nwonodejs/node
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release4b249b445842943ed31549e027f57a8ade9881ed
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/nodejs/node/pull/28826#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F28826
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub Copilot appDirect agents from issue to mergehttps://github.com/features/ai/github-app
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
View all resourceshttps://github.com/resources
GitHub SponsorsFund open source developershttps://github.com/open-source/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/open-source/accelerator
GitHub Starshttps://stars.github.com
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F28826
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode
Reloadhttps://github.com/nodejs/node/pull/28826
Reloadhttps://github.com/nodejs/node/pull/28826
Reloadhttps://github.com/nodejs/node/pull/28826
Please reload this pagehttps://github.com/nodejs/node/pull/28826
nodejs https://github.com/nodejs
nodehttps://github.com/nodejs/node
Please reload this pagehttps://github.com/nodejs/node/pull/28826
Notifications https://github.com/login?return_to=%2Fnodejs%2Fnode
Fork 36k https://github.com/login?return_to=%2Fnodejs%2Fnode
Star 118k https://github.com/login?return_to=%2Fnodejs%2Fnode
Code https://github.com/nodejs/node
Issues 1.3k https://github.com/nodejs/node/issues
Pull requests 973 https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects https://github.com/nodejs/node/projects
Security and quality 0 https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
Code https://github.com/nodejs/node
Issues https://github.com/nodejs/node/issues
Pull requests https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects https://github.com/nodejs/node/projects
Security and quality https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
Trotthttps://github.com/Trott
nodejs:v10.x-staginghttps://github.com/nodejs/node/tree/v10.x-staging
Trott:backport-28600whttps://github.com/Trott/io.js/tree/backport-28600w
Conversationhttps://github.com/nodejs/node/pull/28826
Commits3 (3)https://github.com/nodejs/node/pull/28826/commits
Checkshttps://github.com/nodejs/node/pull/28826/checks
Files changedhttps://github.com/nodejs/node/pull/28826/files
[backport v10.x] test: fix pty test hangs on aixhttps://github.com/nodejs/node/pull/28826#top
Trotthttps://github.com/Trott
nodejs:v10.x-staginghttps://github.com/nodejs/node/tree/v10.x-staging
Trott:backport-28600whttps://github.com/Trott/io.js/tree/backport-28600w
https://github.com/Trott
Trotthttps://github.com/Trott
Jul 23, 2019https://github.com/nodejs/node/pull/28826#issue-471975443
Please reload this pagehttps://github.com/nodejs/node/pull/28826
#28600https://github.com/nodejs/node/pull/28600
#28516https://github.com/nodejs/node/pull/28516
#28469https://github.com/nodejs/node/pull/28469
nodejs/build#1820https://github.com/nodejs/build/issues/1820
#28489https://github.com/nodejs/node/issues/28489
#28600https://github.com/nodejs/node/pull/28600
commit guidelineshttps://github.com/nodejs/node/blob/master/doc/guides/contributing/pull-requests.md#commit-message-guidelines
Please reload this pagehttps://github.com/nodejs/node/pull/28826
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
test https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Atest
tools https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Atools
v10.x https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Av10.x
Jul 23, 2019https://github.com/nodejs/node/pull/28826#event-2504527915
https://github.com/Trott
Trotthttps://github.com/Trott
force-pushedhttps://github.com/nodejs/node/compare/f55a97c9d5ffc226d7647d45d5a8b632c55f2cf8..91715fef9618134843766a159ffa1e983c59ceae
f55a97chttps://github.com/nodejs/node/commit/f55a97c9d5ffc226d7647d45d5a8b632c55f2cf8
91715fehttps://github.com/nodejs/node/commit/91715fef9618134843766a159ffa1e983c59ceae
Compare https://github.com/nodejs/node/compare/f55a97c9d5ffc226d7647d45d5a8b632c55f2cf8..91715fef9618134843766a159ffa1e983c59ceae
July 23, 2019 21:53https://github.com/nodejs/node/pull/28826#event-2504528986
https://github.com/nodejs-github-bot
Sign in to viewhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F28826
https://github.com/Trott
Trotthttps://github.com/Trott
Jul 23, 2019https://github.com/nodejs/node/pull/28826#issuecomment-514398171
Please reload this pagehttps://github.com/nodejs/node/pull/28826
https://github.com/Trott
Trotthttps://github.com/Trott
Jul 23, 2019https://github.com/nodejs/node/pull/28826#issuecomment-514398610
@bnoordhuishttps://github.com/bnoordhuis
@BethGriggshttps://github.com/BethGriggs
Please reload this pagehttps://github.com/nodejs/node/pull/28826
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
Jul 23, 2019https://github.com/nodejs/node/pull/28826#issuecomment-514403412
https://ci.nodejs.org/job/node-test-pull-request/24645/https://ci.nodejs.org/job/node-test-pull-request/24645/
Please reload this pagehttps://github.com/nodejs/node/pull/28826
https://github.com/Trott
Trotthttps://github.com/Trott
Jul 23, 2019https://github.com/nodejs/node/pull/28826#issuecomment-514407819
Please reload this pagehttps://github.com/nodejs/node/pull/28826
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
Jul 23, 2019https://github.com/nodejs/node/pull/28826#issuecomment-514407969
https://ci.nodejs.org/job/node-test-pull-request/24646/https://ci.nodejs.org/job/node-test-pull-request/24646/
Please reload this pagehttps://github.com/nodejs/node/pull/28826
https://github.com/Trott
Trotthttps://github.com/Trott
Jul 23, 2019https://github.com/nodejs/node/pull/28826#issuecomment-514412050
Please reload this pagehttps://github.com/nodejs/node/pull/28826
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
Jul 23, 2019https://github.com/nodejs/node/pull/28826#issuecomment-514412385
https://ci.nodejs.org/job/node-test-pull-request/24648/https://ci.nodejs.org/job/node-test-pull-request/24648/
Please reload this pagehttps://github.com/nodejs/node/pull/28826
https://github.com/Trott
Trotthttps://github.com/Trott
Jul 23, 2019https://github.com/nodejs/node/pull/28826#issuecomment-514412394
Please reload this pagehttps://github.com/nodejs/node/pull/28826
https://github.com/sam-github
sam-githubhttps://github.com/sam-github
Jul 23, 2019 https://github.com/nodejs/node/pull/28826#ref-issue-459324103
Failures due to java.nio.channels.ClosedChannelException, AIX specific? nodejs/build#1849 https://github.com/nodejs/build/issues/1849
https://github.com/sam-github
sam-githubhttps://github.com/sam-github
Jul 23, 2019https://github.com/nodejs/node/pull/28826#issuecomment-514414241
nodejs/build#1849 (comment)https://github.com/nodejs/build/issues/1849#issuecomment-514414165
Please reload this pagehttps://github.com/nodejs/node/pull/28826
https://github.com/Trott
Trotthttps://github.com/Trott
Jul 23, 2019https://github.com/nodejs/node/pull/28826#issuecomment-514415905
1245acahttps://github.com/nodejs/node/commit/1245aca41ca91e60cc4cee2cd724d28b73534ace
Please reload this pagehttps://github.com/nodejs/node/pull/28826
https://github.com/Trott
Trotthttps://github.com/Trott
Jul 23, 2019https://github.com/nodejs/node/pull/28826#issuecomment-514416226
Please reload this pagehttps://github.com/nodejs/node/pull/28826
https://github.com/Trott
Trotthttps://github.com/Trott
force-pushedhttps://github.com/nodejs/node/compare/6ee1342b903bbd5556db335021795039e237205a..c5f761619dfb3ec8afc6e0e1ab239249c7461eec
6ee1342https://github.com/nodejs/node/commit/6ee1342b903bbd5556db335021795039e237205a
c5f7616https://github.com/nodejs/node/commit/c5f761619dfb3ec8afc6e0e1ab239249c7461eec
Compare https://github.com/nodejs/node/compare/6ee1342b903bbd5556db335021795039e237205a..c5f761619dfb3ec8afc6e0e1ab239249c7461eec
July 23, 2019 23:10https://github.com/nodejs/node/pull/28826#event-2504660624
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
Jul 23, 2019https://github.com/nodejs/node/pull/28826#issuecomment-514416381
https://ci.nodejs.org/job/node-test-pull-request/24649/https://ci.nodejs.org/job/node-test-pull-request/24649/
Please reload this pagehttps://github.com/nodejs/node/pull/28826
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
Jul 24, 2019https://github.com/nodejs/node/pull/28826#issuecomment-514445354
https://ci.nodejs.org/job/node-test-pull-request/24650/https://ci.nodejs.org/job/node-test-pull-request/24650/
Please reload this pagehttps://github.com/nodejs/node/pull/28826
https://github.com/Trott
Trotthttps://github.com/Trott
Jul 24, 2019https://github.com/nodejs/node/pull/28826#issuecomment-514456083
Please reload this pagehttps://github.com/nodejs/node/pull/28826
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
Jul 24, 2019https://github.com/nodejs/node/pull/28826#issuecomment-514456609
https://ci.nodejs.org/job/node-test-pull-request/24652/https://ci.nodejs.org/job/node-test-pull-request/24652/
Please reload this pagehttps://github.com/nodejs/node/pull/28826
https://github.com/Trott
Trotthttps://github.com/Trott
force-pushedhttps://github.com/nodejs/node/compare/c5f761619dfb3ec8afc6e0e1ab239249c7461eec..eecd8bd36e14f4a907bb47d0f57296e0c2af5fa2
c5f7616https://github.com/nodejs/node/commit/c5f761619dfb3ec8afc6e0e1ab239249c7461eec
eecd8bdhttps://github.com/nodejs/node/commit/eecd8bd36e14f4a907bb47d0f57296e0c2af5fa2
Compare https://github.com/nodejs/node/compare/c5f761619dfb3ec8afc6e0e1ab239249c7461eec..eecd8bd36e14f4a907bb47d0f57296e0c2af5fa2
July 24, 2019 04:35https://github.com/nodejs/node/pull/28826#event-2505065122
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
Jul 24, 2019https://github.com/nodejs/node/pull/28826#issuecomment-514475995
https://ci.nodejs.org/job/node-test-pull-request/24653/https://ci.nodejs.org/job/node-test-pull-request/24653/
Please reload this pagehttps://github.com/nodejs/node/pull/28826
https://github.com/Trott
Trotthttps://github.com/Trott
Jul 24, 2019https://github.com/nodejs/node/pull/28826#issuecomment-514476029
#28469https://github.com/nodejs/node/pull/28469
Please reload this pagehttps://github.com/nodejs/node/pull/28826
https://github.com/Trott
Trotthttps://github.com/Trott
Jul 24, 2019https://github.com/nodejs/node/pull/28826#issuecomment-514478382
Please reload this pagehttps://github.com/nodejs/node/pull/28826
https://github.com/richardlau
richardlauhttps://github.com/richardlau
Jul 24, 2019https://github.com/nodejs/node/pull/28826#issuecomment-514485073
Please reload this pagehttps://github.com/nodejs/node/pull/28826
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
Jul 24, 2019https://github.com/nodejs/node/pull/28826#issuecomment-514485789
https://ci.nodejs.org/job/node-test-pull-request/24655/https://ci.nodejs.org/job/node-test-pull-request/24655/
Please reload this pagehttps://github.com/nodejs/node/pull/28826
sam-githubhttps://github.com/sam-github
July 23, 2019 23:05https://github.com/nodejs/node/pull/28826#commits-pushed-5412a62
https://github.com/sam-github
https://github.com/Trott
test: skip tests related to CI failures on AIXhttps://github.com/nodejs/node/pull/28826/commits/5412a62e7207df9a544fa80cd7584386dc190a28
5412a62https://github.com/nodejs/node/pull/28826/commits/5412a62e7207df9a544fa80cd7584386dc190a28
nodejs/build#1820 (comment)https://github.com/nodejs/build/issues/1820#issuecomment-505998851
nodejs/build#1847 (comment)https://github.com/nodejs/build/issues/1847#issuecomment-504210708
nodejs#28469https://github.com/nodejs/node/pull/28469
nodejs#28826https://github.com/nodejs/node/pull/28826
https://github.com/sam-github
https://github.com/Trott
test: skip stringbytes-external-exceed-max on AIXhttps://github.com/nodejs/node/pull/28826/commits/e0cbe729185d1386060ab0079677f945cee50353
e0cbe72https://github.com/nodejs/node/pull/28826/commits/e0cbe729185d1386060ab0079677f945cee50353
nodejs#28516https://github.com/nodejs/node/pull/28516
nodejs#28826https://github.com/nodejs/node/pull/28826
https://github.com/bnoordhuis
https://github.com/Trott
test: fix pty test hangs on aixhttps://github.com/nodejs/node/pull/28826/commits/dc4b64f731ed90780f6ad33c4088b8aa3811369e
dc4b64fhttps://github.com/nodejs/node/pull/28826/commits/dc4b64f731ed90780f6ad33c4088b8aa3811369e
nodejs/build#1820https://github.com/nodejs/build/issues/1820
nodejs#28489https://github.com/nodejs/node/issues/28489
nodejs#28600https://github.com/nodejs/node/pull/28600
nodejs#28826https://github.com/nodejs/node/pull/28826
https://github.com/Trott
Trotthttps://github.com/Trott
force-pushedhttps://github.com/nodejs/node/compare/eecd8bd36e14f4a907bb47d0f57296e0c2af5fa2..dc4b64f731ed90780f6ad33c4088b8aa3811369e
eecd8bdhttps://github.com/nodejs/node/commit/eecd8bd36e14f4a907bb47d0f57296e0c2af5fa2
dc4b64fhttps://github.com/nodejs/node/commit/dc4b64f731ed90780f6ad33c4088b8aa3811369e
Compare https://github.com/nodejs/node/compare/eecd8bd36e14f4a907bb47d0f57296e0c2af5fa2..dc4b64f731ed90780f6ad33c4088b8aa3811369e
July 24, 2019 06:07https://github.com/nodejs/node/pull/28826#event-2505193745
https://github.com/Trott
Trotthttps://github.com/Trott
Jul 24, 2019https://github.com/nodejs/node/pull/28826#issuecomment-514493796
Please reload this pagehttps://github.com/nodejs/node/pull/28826
https://github.com/nodejs-github-bot
Sign in to viewhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F28826
https://github.com/richardlau
richardlauhttps://github.com/richardlau
Jul 24, 2019 https://github.com/nodejs/node/pull/28826#pullrequestreview-265810038
View reviewed changes https://github.com/nodejs/node/pull/28826/files/dc4b64f731ed90780f6ad33c4088b8aa3811369e
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
Jul 24, 2019https://github.com/nodejs/node/pull/28826#issuecomment-514507187
Please reload this pagehttps://github.com/nodejs/node/pull/28826
https://ci.nodejs.org/job/node-test-pull-request/24657/https://ci.nodejs.org/job/node-test-pull-request/24657/
Please reload this pagehttps://github.com/nodejs/node/pull/28826
https://github.com/BethGriggs
BethGriggshttps://github.com/BethGriggs
Jul 24, 2019 https://github.com/nodejs/node/pull/28826#pullrequestreview-265912544
View reviewed changes https://github.com/nodejs/node/pull/28826/files/dc4b64f731ed90780f6ad33c4088b8aa3811369e
https://github.com/sam-github
sam-githubhttps://github.com/sam-github
Jul 24, 2019 https://github.com/nodejs/node/pull/28826#pullrequestreview-266013451
View reviewed changes https://github.com/nodejs/node/pull/28826/files/dc4b64f731ed90780f6ad33c4088b8aa3811369e
sam-githubhttps://github.com/sam-github
https://github.com/nodejs/node/pull/28826#pullrequestreview-266013451
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/28826
https://github.com/mhdawson
mhdawsonhttps://github.com/mhdawson
Jul 24, 2019 https://github.com/nodejs/node/pull/28826#pullrequestreview-266190645
View reviewed changes https://github.com/nodejs/node/pull/28826/files/dc4b64f731ed90780f6ad33c4088b8aa3811369e
mhdawsonhttps://github.com/mhdawson
https://github.com/nodejs/node/pull/28826#pullrequestreview-266190645
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/28826
https://github.com/mhdawson
mhdawsonhttps://github.com/mhdawson
Jul 24, 2019https://github.com/nodejs/node/pull/28826#issuecomment-514737504
Please reload this pagehttps://github.com/nodejs/node/pull/28826
https://github.com/Trott
Trotthttps://github.com/Trott
Jul 24, 2019 https://github.com/nodejs/node/pull/28826#ref-pullrequest-470750894
[v10.x backport] test: remove util.inherits() usage #28795 https://github.com/nodejs/node/pull/28795
https://github.com/Trott
Trotthttps://github.com/Trott
Jul 25, 2019https://github.com/nodejs/node/pull/28826#issuecomment-514882163
Please reload this pagehttps://github.com/nodejs/node/pull/28826
https://github.com/ZYSzys
ZYSzyshttps://github.com/ZYSzys
Jul 25, 2019 https://github.com/nodejs/node/pull/28826#pullrequestreview-266405084
View reviewed changes https://github.com/nodejs/node/pull/28826/files/dc4b64f731ed90780f6ad33c4088b8aa3811369e
https://github.com/Trott
Trotthttps://github.com/Trott
Jul 25, 2019 https://github.com/nodejs/node/pull/28826#ref-pullrequest-469382870
[v10.x backport] tools: replace rollup with ncc #28736 https://github.com/nodejs/node/pull/28736
https://github.com/ZYSzys
ZYSzyshttps://github.com/ZYSzys
Jul 25, 2019https://github.com/nodejs/node/pull/28826#issuecomment-514901241
Please reload this pagehttps://github.com/nodejs/node/pull/28826
https://github.com/ZYSzys
ZYSzyshttps://github.com/ZYSzys
fast-track https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Afast-track
Jul 25, 2019https://github.com/nodejs/node/pull/28826#event-2508344663
BethGriggshttps://github.com/BethGriggs
Jul 25, 2019 https://github.com/nodejs/node/pull/28826#ref-commit-39637cb
https://github.com/sam-github
https://github.com/BethGriggs
test: skip tests related to CI failures on AIXhttps://github.com/nodejs/node/commit/39637cb95f72a07c9e7fbe322e257be03924a04b
39637cbhttps://github.com/nodejs/node/commit/39637cb95f72a07c9e7fbe322e257be03924a04b
nodejs/build#1820 (comment)https://github.com/nodejs/build/issues/1820#issuecomment-505998851
nodejs/build#1847 (comment)https://github.com/nodejs/build/issues/1847#issuecomment-504210708
#28469https://github.com/nodejs/node/pull/28469
#28826https://github.com/nodejs/node/pull/28826
BethGriggshttps://github.com/BethGriggs
Jul 25, 2019 https://github.com/nodejs/node/pull/28826#ref-commit-2ae9916
https://github.com/sam-github
https://github.com/BethGriggs
test: skip stringbytes-external-exceed-max on AIXhttps://github.com/nodejs/node/commit/2ae99160e501d22dd28321c211cc17038c7de053
2ae9916https://github.com/nodejs/node/commit/2ae99160e501d22dd28321c211cc17038c7de053
#28516https://github.com/nodejs/node/pull/28516
#28826https://github.com/nodejs/node/pull/28826
BethGriggshttps://github.com/BethGriggs
Jul 25, 2019 https://github.com/nodejs/node/pull/28826#ref-commit-ada0ed5
https://github.com/bnoordhuis
https://github.com/BethGriggs
test: fix pty test hangs on aixhttps://github.com/nodejs/node/commit/ada0ed55d13002442d0f3075cc2a521830bfe042
ada0ed5https://github.com/nodejs/node/commit/ada0ed55d13002442d0f3075cc2a521830bfe042
nodejs/build#1820https://github.com/nodejs/build/issues/1820
#28489https://github.com/nodejs/node/issues/28489
#28600https://github.com/nodejs/node/pull/28600
#28826https://github.com/nodejs/node/pull/28826
https://github.com/BethGriggs
BethGriggshttps://github.com/BethGriggs
Jul 25, 2019https://github.com/nodejs/node/pull/28826#issuecomment-515112126
Please reload this pagehttps://github.com/nodejs/node/pull/28826
https://github.com/BethGriggs
BethGriggshttps://github.com/BethGriggs
Jul 25, 2019https://github.com/nodejs/node/pull/28826#event-2510085125
https://github.com/Trott
Trotthttps://github.com/Trott
January 13, 2022 22:51https://github.com/nodejs/node/pull/28826#event-5890975339
https://github.co/hiddenchars
https://github.com/nodejs/node/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F28826
https://github.com/richardlau
richardlau https://github.com/richardlau
https://github.com/nodejs/node/pull/28826/files/dc4b64f731ed90780f6ad33c4088b8aa3811369e
https://github.com/BethGriggs
BethGriggs https://github.com/BethGriggs
https://github.com/nodejs/node/pull/28826/files/dc4b64f731ed90780f6ad33c4088b8aa3811369e
https://github.com/ZYSzys
ZYSzys https://github.com/ZYSzys
https://github.com/nodejs/node/pull/28826/files/dc4b64f731ed90780f6ad33c4088b8aa3811369e
https://github.com/sam-github
sam-github https://github.com/sam-github
https://github.com/nodejs/node/pull/28826/files/dc4b64f731ed90780f6ad33c4088b8aa3811369e
https://github.com/mhdawson
mhdawson https://github.com/mhdawson
https://github.com/nodejs/node/pull/28826/files/dc4b64f731ed90780f6ad33c4088b8aa3811369e
fast-track https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Afast-track
test https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Atest
tools https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Atools
Please reload this pagehttps://github.com/nodejs/node/pull/28826
https://github.com/Trott
https://github.com/nodejs-github-bot
https://github.com/sam-github
https://github.com/richardlau
https://github.com/mhdawson
https://github.com/ZYSzys
https://github.com/BethGriggs
https://github.com/bnoordhuis
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.