| route-pattern | /_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format) |
| route-controller | voltron_pull_requests_fragments |
| route-action | pull_request_layout |
| fetch-nonce | v2:39d2815e-645b-043a-b30d-c53900fea6e2 |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | B3D6:7E3D2:2447023:326A4D7:6A4F569D |
| html-safe-nonce | d3859db9016e80e6915eb851bd19feba7bf393816c1a51dd0d084467bdd545c2 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJCM0Q2OjdFM0QyOjI0NDcwMjM6MzI2QTRENzo2QTRGNTY5RCIsInZpc2l0b3JfaWQiOiIxNzgyNjg0OTY3NTAwNzMyMDYxIiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0= |
| visitor-hmac | 50375e94fa5893bcd281876af96755728bff01cc99630c813b7c3f9bd3535572 |
| hovercard-subject-tag | pull_request:300426388 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///voltron/pull_requests_fragments/pull_request_layout |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/28824/pull_request_layout |
| twitter:image | https://opengraph.githubassets.com/8bc4b5411d666800d9896d1f0e07e0af41e09951f768bd1f023f273b85535622/nodejs/node/pull/28824 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/8bc4b5411d666800d9896d1f0e07e0af41e09951f768bd1f023f273b85535622/nodejs/node/pull/28824 |
| og:image:alt | Often, the word “identical” when referring to JS objects will
be read as referring to having the same object identity (which is
called “reference equality” here), but what the error message is
tryi... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | addaleax |
| hostname | github.com |
| expected-hostname | github.com |
| None | b92d11c0aa4a77d54ef4af1078b6a15fb5a70a215b30c4ecf28889d5a8e656d9 |
| turbo-cache-control | no-cache |
| go-import | github.com/nodejs/node git https://github.com/nodejs/node.git |
| octolytics-dimension-user_id | 9950313 |
| octolytics-dimension-user_login | nodejs |
| octolytics-dimension-repository_id | 27193779 |
| octolytics-dimension-repository_nwo | nodejs/node |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 27193779 |
| octolytics-dimension-repository_network_root_nwo | nodejs/node |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 4b249b445842943ed31549e027f57a8ade9881ed |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| Skip to content | https://github.com/nodejs/node/pull/28824#start-of-content |
|
| https://github.com/ |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F28824 |
| GitHub CopilotWrite better code with AI | https://github.com/features/copilot |
| GitHub Copilot appDirect agents from issue to merge | https://github.com/features/ai/github-app |
| MCP RegistryNewIntegrate external tools | https://github.com/mcp |
| ActionsAutomate any workflow | https://github.com/features/actions |
| CodespacesInstant dev environments | https://github.com/features/codespaces |
| IssuesPlan and track work | https://github.com/features/issues |
| Code ReviewManage code changes | https://github.com/features/code-review |
| GitHub Advanced SecurityFind and fix vulnerabilities | https://github.com/security/advanced-security |
| Code securitySecure your code as you build | https://github.com/security/advanced-security/code-security |
| Secret protectionStop leaks before they start | https://github.com/security/advanced-security/secret-protection |
| Why GitHub | https://github.com/why-github |
| Documentation | https://docs.github.com |
| Blog | https://github.blog |
| Changelog | https://github.blog/changelog |
| Marketplace | https://github.com/marketplace |
| View all features | https://github.com/features |
| Enterprises | https://github.com/enterprise |
| Small and medium teams | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| App Modernization | https://github.com/solutions/use-case/app-modernization |
| DevSecOps | https://github.com/solutions/use-case/devsecops |
| DevOps | https://github.com/solutions/use-case/devops |
| CI/CD | https://github.com/solutions/use-case/ci-cd |
| View all use cases | https://github.com/solutions/use-case |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| View all industries | https://github.com/solutions/industry |
| View all solutions | https://github.com/solutions |
| AI | https://github.com/resources/articles?topic=ai |
| Software Development | https://github.com/resources/articles?topic=software-development |
| DevOps | https://github.com/resources/articles?topic=devops |
| Security | https://github.com/resources/articles?topic=security |
| View all topics | https://github.com/resources/articles |
| Customer stories | https://github.com/customer-stories |
| Events & webinars | https://github.com/resources/events |
| Ebooks & reports | https://github.com/resources/whitepapers |
| Business insights | https://github.com/solutions/executive-insights |
| GitHub Skills | https://skills.github.com |
| Documentation | https://docs.github.com |
| Customer support | https://support.github.com |
| Community forum | https://github.com/orgs/community/discussions |
| Trust center | https://github.com/trust-center |
| Partners | https://github.com/partners |
| View all resources | https://github.com/resources |
| GitHub SponsorsFund open source developers | https://github.com/open-source/sponsors |
| Security Lab | https://securitylab.github.com |
| Maintainer Community | https://maintainers.github.com |
| Accelerator | https://github.com/open-source/accelerator |
| GitHub Stars | https://stars.github.com |
| Archive Program | https://archiveprogram.github.com |
| Topics | https://github.com/topics |
| Trending | https://github.com/trending |
| Collections | https://github.com/collections |
| Enterprise platformAI-powered developer platform | https://github.com/enterprise |
| GitHub Advanced SecurityEnterprise-grade security features | https://github.com/security/advanced-security |
| Copilot for BusinessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/enterprise/premium-support |
| Pricing | https://github.com/pricing |
| Search syntax tips | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
| documentation | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F28824 |
|
Sign up
| https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode |
| Reload | https://github.com/nodejs/node/pull/28824 |
| Reload | https://github.com/nodejs/node/pull/28824 |
| Reload | https://github.com/nodejs/node/pull/28824 |
| Please reload this page | https://github.com/nodejs/node/pull/28824 |
|
nodejs
| https://github.com/nodejs |
| node | https://github.com/nodejs/node |
| Please reload this page | https://github.com/nodejs/node/pull/28824 |
|
Notifications
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Fork
36k
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Star
118k
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Code
| https://github.com/nodejs/node |
|
Issues
1.3k
| https://github.com/nodejs/node/issues |
|
Pull requests
970
| https://github.com/nodejs/node/pulls |
|
Actions
| https://github.com/nodejs/node/actions |
|
Projects
| https://github.com/nodejs/node/projects |
|
Security and quality
0
| https://github.com/nodejs/node/security |
|
Insights
| https://github.com/nodejs/node/pulse |
|
Code
| https://github.com/nodejs/node |
|
Issues
| https://github.com/nodejs/node/issues |
|
Pull requests
| https://github.com/nodejs/node/pulls |
|
Actions
| https://github.com/nodejs/node/actions |
|
Projects
| https://github.com/nodejs/node/projects |
|
Security and quality
| https://github.com/nodejs/node/security |
|
Insights
| https://github.com/nodejs/node/pulse |
| addaleax | https://github.com/addaleax |
| nodejs:master | https://github.com/nodejs/node/tree/master |
| addaleax:assert-identical | https://github.com/addaleax/node/tree/assert-identical |
| Conversation | https://github.com/nodejs/node/pull/28824 |
| Commits1 (1) | https://github.com/nodejs/node/pull/28824/commits |
| Checks | https://github.com/nodejs/node/pull/28824/checks |
| Files changed | https://github.com/nodejs/node/pull/28824/files |
| assert: avoid potentially misleading reference to object identity | https://github.com/nodejs/node/pull/28824#top |
| addaleax | https://github.com/addaleax |
| nodejs:master | https://github.com/nodejs/node/tree/master |
| addaleax:assert-identical | https://github.com/addaleax/node/tree/assert-identical |
|
| https://github.com/addaleax |
| addaleax | https://github.com/addaleax |
| Jul 23, 2019 | https://github.com/nodejs/node/pull/28824#issue-471871991 |
| commit guidelines | https://github.com/nodejs/node/blob/master/doc/guides/contributing/pull-requests.md#commit-message-guidelines |
| Please reload this page | https://github.com/nodejs/node/pull/28824 |
|
| https://github.com/addaleax |
| assert: avoid potentially misleading reference to object identity | https://github.com/nodejs/node/pull/28824/commits/43cc4443522f3c86796e56f0cd814419072fe251 |
| 43cc444 | https://github.com/nodejs/node/pull/28824/commits/43cc4443522f3c86796e56f0cd814419072fe251 |
| https://github.com/addaleax |
| addaleax | https://github.com/addaleax |
| BridgeAR | https://github.com/BridgeAR |
| July 23, 2019 18:53 | https://github.com/nodejs/node/pull/28824#event-2504081363 |
| https://github.com/nodejs-github-bot |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
|
assert
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aassert |
| Jul 23, 2019 | https://github.com/nodejs/node/pull/28824#event-2504081537 |
| https://github.com/cjihrig |
| cjihrig | https://github.com/cjihrig |
|
Jul 23, 2019
| https://github.com/nodejs/node/pull/28824#pullrequestreview-265612818 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/28824/files/43cc4443522f3c86796e56f0cd814419072fe251 |
| https://github.com/lpinca |
| lpinca | https://github.com/lpinca |
|
Jul 23, 2019
| https://github.com/nodejs/node/pull/28824#pullrequestreview-265631273 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/28824/files/43cc4443522f3c86796e56f0cd814419072fe251 |
| https://github.com/Trott |
| Trott | https://github.com/Trott |
|
Jul 23, 2019
| https://github.com/nodejs/node/pull/28824#pullrequestreview-265653700 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/28824/files/43cc4443522f3c86796e56f0cd814419072fe251 |
| https://github.com/trivikr |
| trivikr | https://github.com/trivikr |
|
Jul 23, 2019
| https://github.com/nodejs/node/pull/28824#pullrequestreview-265677203 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/28824/files/43cc4443522f3c86796e56f0cd814419072fe251 |
| https://github.com/BridgeAR |
| BridgeAR | https://github.com/BridgeAR |
|
Jul 24, 2019
| https://github.com/nodejs/node/pull/28824#pullrequestreview-265837643 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/28824/files/43cc4443522f3c86796e56f0cd814419072fe251 |
| BridgeAR | https://github.com/BridgeAR |
| https://github.com/nodejs/node/pull/28824#pullrequestreview-265837643 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/28824 |
| https://github.com/Trott |
| Trott | https://github.com/Trott |
|
author ready
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22author%20ready%22 |
| Jul 25, 2019 | https://github.com/nodejs/node/pull/28824#event-2510905485 |
| https://github.com/nodejs-github-bot |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
| Jul 25, 2019 | https://github.com/nodejs/node/pull/28824#issuecomment-515225158 |
| https://ci.nodejs.org/job/node-test-pull-request/24700/ | https://ci.nodejs.org/job/node-test-pull-request/24700/ |
| Please reload this page | https://github.com/nodejs/node/pull/28824 |
| https://github.com/nodejs-github-bot |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
| Jul 26, 2019 | https://github.com/nodejs/node/pull/28824#issuecomment-515307197 |
| https://ci.nodejs.org/job/node-test-pull-request/24709/ | https://ci.nodejs.org/job/node-test-pull-request/24709/ |
| Please reload this page | https://github.com/nodejs/node/pull/28824 |
| https://github.com/Trott |
| Trott | https://github.com/Trott |
| Jul 26, 2019 | https://github.com/nodejs/node/pull/28824#issuecomment-515316010 |
| 64e4b0c | https://github.com/nodejs/node/commit/64e4b0c0ac5073e6606b1ccd79a464f2c5925741 |
| Please reload this page | https://github.com/nodejs/node/pull/28824 |
| https://github.com/Trott |
| Trott | https://github.com/Trott |
| Jul 26, 2019 | https://github.com/nodejs/node/pull/28824#event-2511516350 |
| Trott | https://github.com/Trott |
|
Jul 26, 2019
| https://github.com/nodejs/node/pull/28824#ref-commit-64e4b0c |
|
| https://github.com/addaleax |
|
| https://github.com/Trott |
| assert: avoid potentially misleading reference to object identity | https://github.com/Trott/io.js/commit/64e4b0c0ac5073e6606b1ccd79a464f2c5925741 |
| 64e4b0c | https://github.com/Trott/io.js/commit/64e4b0c0ac5073e6606b1ccd79a464f2c5925741 |
| nodejs#28824 | https://github.com/nodejs/node/pull/28824 |
| gntem | https://github.com/gntem |
|
Jul 27, 2019
| https://github.com/nodejs/node/pull/28824#ref-commit-a64af45 |
|
| https://github.com/addaleax |
|
| https://github.com/gntem |
| assert: avoid potentially misleading reference to object identity | https://github.com/gntem/node/commit/a64af4534f04b111df8bc1ab3027b67ad7aba87e |
| a64af45 | https://github.com/gntem/node/commit/a64af4534f04b111df8bc1ab3027b67ad7aba87e |
| nodejs#28824 | https://github.com/nodejs/node/pull/28824 |
| targos | https://github.com/targos |
|
Aug 2, 2019
| https://github.com/nodejs/node/pull/28824#ref-commit-d3426ee |
|
| https://github.com/addaleax |
|
| https://github.com/targos |
| assert: avoid potentially misleading reference to object identity | https://github.com/nodejs/node/commit/d3426ee9f187db92671cec1e1e3f1ace4c04c89b |
| d3426ee | https://github.com/nodejs/node/commit/d3426ee9f187db92671cec1e1e3f1ace4c04c89b |
| #28824 | https://github.com/nodejs/node/pull/28824 |
| https://github.com/BridgeAR |
| BridgeAR | https://github.com/BridgeAR |
|
Aug 6, 2019
| https://github.com/nodejs/node/pull/28824#ref-pullrequest-477378713 |
|
v12.8.0 release proposal
#29017
| https://github.com/nodejs/node/pull/29017 |
| vikashk1 | https://github.com/vikashk1 |
|
Aug 13, 2019
| https://github.com/nodejs/node/pull/28824#ref-commit-9af17ad |
|
| https://github.com/vikashk1 |
| Please ignore this msg ( | https://github.com/vikashk1/node/commit/9af17ad05c8161db7f52de5fd3331a94857e33fc |
| #1 | https://github.com/vikashk1/node/pull/1 |
| ) | https://github.com/vikashk1/node/commit/9af17ad05c8161db7f52de5fd3331a94857e33fc |
| 9af17ad | https://github.com/vikashk1/node/commit/9af17ad05c8161db7f52de5fd3331a94857e33fc |
| https://github.co/hiddenchars |
| https://github.com/nodejs/node/pull/{{ revealButtonHref }} |
| Sign up for free | https://github.com/join?source=comment-repo |
| Sign in to comment | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F28824 |
|
| https://github.com/Trott |
|
Trott
| https://github.com/Trott |
|
| https://github.com/nodejs/node/pull/28824/files/43cc4443522f3c86796e56f0cd814419072fe251 |
|
| https://github.com/lpinca |
|
lpinca
| https://github.com/lpinca |
|
| https://github.com/nodejs/node/pull/28824/files/43cc4443522f3c86796e56f0cd814419072fe251 |
|
| https://github.com/cjihrig |
|
cjihrig
| https://github.com/cjihrig |
|
| https://github.com/nodejs/node/pull/28824/files/43cc4443522f3c86796e56f0cd814419072fe251 |
|
| https://github.com/BridgeAR |
|
BridgeAR
| https://github.com/BridgeAR |
|
| https://github.com/nodejs/node/pull/28824/files/43cc4443522f3c86796e56f0cd814419072fe251 |
|
| https://github.com/trivikr |
|
trivikr
| https://github.com/trivikr |
|
| https://github.com/nodejs/node/pull/28824/files/43cc4443522f3c86796e56f0cd814419072fe251 |
|
assert
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aassert |
|
author ready
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22author%20ready%22 |
| Please reload this page | https://github.com/nodejs/node/pull/28824 |
|
| https://github.com/addaleax |
|
| https://github.com/nodejs-github-bot |
|
| https://github.com/Trott |
|
| https://github.com/lpinca |
|
| https://github.com/cjihrig |
|
| https://github.com/BridgeAR |
|
| https://github.com/trivikr |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |