René's URL Explorer Experiment


Title: stream: finished cleanup by ronag · Pull Request #28820 · nodejs/node · GitHub

Open Graph Title: stream: finished cleanup by ronag · Pull Request #28820 · nodejs/node

X Title: stream: finished cleanup by ronag · Pull Request #28820 · nodejs/node

Description: Node.js JavaScript runtime ✨🐢🚀✨. Contribute to nodejs/node development by creating an account on GitHub.

Open Graph Description: finished should not leave dangling listeners and leave the stream in the same state after as before. Checklist make -j4 test (UNIX), or vcbuild test (Windows) passes tests and/or benchmarks are...

X Description: finished should not leave dangling listeners and leave the stream in the same state after as before. Checklist make -j4 test (UNIX), or vcbuild test (Windows) passes tests and/or benchmarks are...

Opengraph URL: https://github.com/nodejs/node/pull/28820

X: @github

direct link

Domain: github.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:c1e62010-00eb-569a-e394-886de43b665d
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idB192:1D00CE:72582E:97C82A:6A52A5E7
html-safe-nonce6ed07888444319b93c38a65e4c0b4e51bccb9b464568991283260fef4f72373f
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJCMTkyOjFEMDBDRTo3MjU4MkU6OTdDODJBOjZBNTJBNUU3IiwidmlzaXRvcl9pZCI6Ijc3MDE5NDAyNDQwOTA4ODk3MDMiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmac1b1aa82b84ae1849fd80cde068f27369390124760891f2ed73a959c0a8fd80e1
hovercard-subject-tagpull_request:300302959
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/28820/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/eb7d2c35a1029c0e375d44201f7c62da05e3da7e82d20276afc0d83a1fb301d2/nodejs/node/pull/28820
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/eb7d2c35a1029c0e375d44201f7c62da05e3da7e82d20276afc0d83a1fb301d2/nodejs/node/pull/28820
og:image:altfinished should not leave dangling listeners and leave the stream in the same state after as before. Checklist make -j4 test (UNIX), or vcbuild test (Windows) passes tests and/or benchmarks are...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernameronag
hostnamegithub.com
expected-hostnamegithub.com
Noneb9a586c06a05a7a86fc7e3f4dbd03e42f6869085879aa184aa6369456dbd50fb
turbo-cache-controlno-cache
go-importgithub.com/nodejs/node git https://github.com/nodejs/node.git
octolytics-dimension-user_id9950313
octolytics-dimension-user_loginnodejs
octolytics-dimension-repository_id27193779
octolytics-dimension-repository_nwonodejs/node
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id27193779
octolytics-dimension-repository_network_root_nwonodejs/node
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release07a982c1d40157c619b364352b704c3ce66bb332
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/nodejs/node/pull/28820#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F28820
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub Copilot appDirect agents from issue to mergehttps://github.com/features/ai/github-app
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
View all resourceshttps://github.com/resources
GitHub SponsorsFund open source developershttps://github.com/open-source/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/open-source/accelerator
GitHub Starshttps://stars.github.com
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F28820
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode
Reloadhttps://github.com/nodejs/node/pull/28820
Reloadhttps://github.com/nodejs/node/pull/28820
Reloadhttps://github.com/nodejs/node/pull/28820
Please reload this pagehttps://github.com/nodejs/node/pull/28820
nodejs https://github.com/nodejs
nodehttps://github.com/nodejs/node
Please reload this pagehttps://github.com/nodejs/node/pull/28820
Notifications https://github.com/login?return_to=%2Fnodejs%2Fnode
Fork 36.2k https://github.com/login?return_to=%2Fnodejs%2Fnode
Star 118k https://github.com/login?return_to=%2Fnodejs%2Fnode
Code https://github.com/nodejs/node
Issues 1.4k https://github.com/nodejs/node/issues
Pull requests 988 https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects https://github.com/nodejs/node/projects
Security and quality 0 https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
Code https://github.com/nodejs/node
Issues https://github.com/nodejs/node/issues
Pull requests https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects https://github.com/nodejs/node/projects
Security and quality https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
ronaghttps://github.com/ronag
nodejs:masterhttps://github.com/nodejs/node/tree/master
nxtedition:fix-eos-cleanuphttps://github.com/nxtedition/node/tree/fix-eos-cleanup
Conversationhttps://github.com/nodejs/node/pull/28820
Commits1 (1)https://github.com/nodejs/node/pull/28820/commits
Checkshttps://github.com/nodejs/node/pull/28820/checks
Files changedhttps://github.com/nodejs/node/pull/28820/files
stream: finished cleanuphttps://github.com/nodejs/node/pull/28820#top
ronaghttps://github.com/ronag
nodejs:masterhttps://github.com/nodejs/node/tree/master
nxtedition:fix-eos-cleanuphttps://github.com/nxtedition/node/tree/fix-eos-cleanup
https://github.com/ronag
ronaghttps://github.com/ronag
Jul 23, 2019https://github.com/nodejs/node/pull/28820#issue-471705052
commit guidelineshttps://github.com/nodejs/node/blob/master/doc/guides/contributing/pull-requests.md#commit-message-guidelines
Please reload this pagehttps://github.com/nodejs/node/pull/28820
https://github.com/mscdex
mscdexhttps://github.com/mscdex
Jul 23, 2019 https://github.com/nodejs/node/pull/28820#pullrequestreview-265427465
View reviewed changes https://github.com/nodejs/node/pull/28820/files
lib/internal/streams/end-of-stream.jshttps://github.com/nodejs/node/pull/28820/files#diff-f355a772a51133f54ef288a365ec05a70b9f3f2e0a2f46f5ba2612e31a62f810
Please reload this pagehttps://github.com/nodejs/node/pull/28820
https://github.com/ronag
ronaghttps://github.com/ronag
force-pushedhttps://github.com/nodejs/node/compare/157348b74d61abfda216e864624fd0538a4f8686..e66269c5a735c44b303e567311b8c2c1c1ce465d
157348bhttps://github.com/nodejs/node/commit/157348b74d61abfda216e864624fd0538a4f8686
e66269chttps://github.com/nodejs/node/commit/e66269c5a735c44b303e567311b8c2c1c1ce465d
Compare https://github.com/nodejs/node/compare/157348b74d61abfda216e864624fd0538a4f8686..e66269c5a735c44b303e567311b8c2c1c1ce465d
July 24, 2019 09:51https://github.com/nodejs/node/pull/28820#event-2505754023
https://github.com/addaleax
https://github.com/ronag
src: do not include partial AsyncWrap instances in heap dumphttps://github.com/nodejs/node/pull/28820/commits/77bfb2032f06760f2aaaeec2242f44892fb6cd60
77bfb20https://github.com/nodejs/node/pull/28820/commits/77bfb2032f06760f2aaaeec2242f44892fb6cd60
nodejs#28786https://github.com/nodejs/node/issues/28786
nodejs#28789https://github.com/nodejs/node/pull/28789
https://github.com/ronag
ronaghttps://github.com/ronag
force-pushedhttps://github.com/nodejs/node/compare/ce8805951d864c2d294944fef620b1e14b5379d4..77bfb2032f06760f2aaaeec2242f44892fb6cd60
ce88059https://github.com/nodejs/node/commit/ce8805951d864c2d294944fef620b1e14b5379d4
77bfb20https://github.com/nodejs/node/commit/77bfb2032f06760f2aaaeec2242f44892fb6cd60
Compare https://github.com/nodejs/node/compare/ce8805951d864c2d294944fef620b1e14b5379d4..77bfb2032f06760f2aaaeec2242f44892fb6cd60
July 24, 2019 09:54https://github.com/nodejs/node/pull/28820#event-2505762354
https://github.com/Fishrock123
Fishrock123https://github.com/Fishrock123
stream https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Astream
Jul 24, 2019https://github.com/nodejs/node/pull/28820#event-2507587570
https://github.com/Trott
Trotthttps://github.com/Trott
Jul 25, 2019https://github.com/nodejs/node/pull/28820#issuecomment-515226750
Please reload this pagehttps://github.com/nodejs/node/pull/28820
@addaleaxhttps://github.com/addaleax
Please reload this pagehttps://github.com/nodejs/node/pull/28820
https://github.com/mscdex
mscdexhttps://github.com/mscdex
Jul 26, 2019https://github.com/nodejs/node/pull/28820#issuecomment-515262338
Please reload this pagehttps://github.com/nodejs/node/pull/28820
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
Jul 26, 2019https://github.com/nodejs/node/pull/28820#issuecomment-515266889
@Trotthttps://github.com/Trott
Please reload this pagehttps://github.com/nodejs/node/pull/28820
https://github.com/Trott
Trotthttps://github.com/Trott
Jul 26, 2019https://github.com/nodejs/node/pull/28820#issuecomment-515307324
@Trotthttps://github.com/Trott
Please reload this pagehttps://github.com/nodejs/node/pull/28820
https://github.com/ronag
ronaghttps://github.com/ronag
Jul 26, 2019https://github.com/nodejs/node/pull/28820#issuecomment-515394177
Please reload this pagehttps://github.com/nodejs/node/pull/28820
#28818https://github.com/nodejs/node/pull/28818
Please reload this pagehttps://github.com/nodejs/node/pull/28820
https://github.com/Trott
Trotthttps://github.com/Trott
blocked https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Ablocked
Jul 26, 2019https://github.com/nodejs/node/pull/28820#event-2513224386
https://github.com/ronag
ronaghttps://github.com/ronag
Aug 2, 2019 https://github.com/nodejs/node/pull/28820#ref-pullrequest-471557809
stream: pipeline uncaught error #28818 https://github.com/nodejs/node/pull/28818
https://github.com/ronag
ronaghttps://github.com/ronag
Aug 2, 2019https://github.com/nodejs/node/pull/28820#issuecomment-517579137
Please reload this pagehttps://github.com/nodejs/node/pull/28820
https://github.com/ronag
ronaghttps://github.com/ronag
Aug 2, 2019https://github.com/nodejs/node/pull/28820#event-2528712305
https://github.co/hiddenchars
https://github.com/nodejs/node/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F28820
https://github.com/mscdex
mscdex https://github.com/mscdex
https://github.com/nodejs/node/pull/28820/files/0e770a534eafe48222446dacd41c2e59bff494c1
blocked https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Ablocked
stream https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Astream
Please reload this pagehttps://github.com/nodejs/node/pull/28820
https://github.com/ronag
https://github.com/Trott
https://github.com/mscdex
https://github.com/addaleax
https://github.com/Fishrock123
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.