René's URL Explorer Experiment


Title: stream: pipeline uncaught error by ronag · Pull Request #28818 · nodejs/node · GitHub

Open Graph Title: stream: pipeline uncaught error by ronag · Pull Request #28818 · nodejs/node

X Title: stream: pipeline uncaught error by ronag · Pull Request #28818 · nodejs/node

Description: Node.js JavaScript runtime ✨🐢🚀✨. Contribute to nodejs/node development by creating an account on GitHub.

Open Graph Description: There are stream(like)s both in node and ecosystem that can emit an error after finished/eos. This will cause the process to unexpectedly exit with an uncaught error exception. Checklist make -j...

X Description: There are stream(like)s both in node and ecosystem that can emit an error after finished/eos. This will cause the process to unexpectedly exit with an uncaught error exception. Checklist make -j...

Opengraph URL: https://github.com/nodejs/node/pull/28818

X: @github

direct link

Domain: github.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:dfa9a144-2096-d3eb-0abb-be5165605660
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idBEE0:D8572:616F:8011:6A525483
html-safe-nonce1d9e76673c8ea94882ede4ec34ea7efea7cae1742dd5445376d119e0f5a7c22d
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJCRUUwOkQ4NTcyOjYxNkY6ODAxMTo2QTUyNTQ4MyIsInZpc2l0b3JfaWQiOiIzOTYzMjM1MzIzODk5Njk2MjU5IiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmac1cb3e65c5eb89d7733397f7ec103bdb4e73f20258a56a3e6d54aaa693256dec5
hovercard-subject-tagpull_request:300184201
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/28818/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/8e3ccc18eb58c4bec3568b0312fa1915779b807e304daaadb345896ea88e05a0/nodejs/node/pull/28818
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/8e3ccc18eb58c4bec3568b0312fa1915779b807e304daaadb345896ea88e05a0/nodejs/node/pull/28818
og:image:altThere are stream(like)s both in node and ecosystem that can emit an error after finished/eos. This will cause the process to unexpectedly exit with an uncaught error exception. Checklist make -j...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernameronag
hostnamegithub.com
expected-hostnamegithub.com
Noneb9a586c06a05a7a86fc7e3f4dbd03e42f6869085879aa184aa6369456dbd50fb
turbo-cache-controlno-cache
go-importgithub.com/nodejs/node git https://github.com/nodejs/node.git
octolytics-dimension-user_id9950313
octolytics-dimension-user_loginnodejs
octolytics-dimension-repository_id27193779
octolytics-dimension-repository_nwonodejs/node
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id27193779
octolytics-dimension-repository_network_root_nwonodejs/node
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release7aed05249554b889eb33d002851a973eebcc7e91
ui-targetcanary-2
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/nodejs/node/pull/28818#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F28818
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub Copilot appDirect agents from issue to mergehttps://github.com/features/ai/github-app
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
View all resourceshttps://github.com/resources
GitHub SponsorsFund open source developershttps://github.com/open-source/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/open-source/accelerator
GitHub Starshttps://stars.github.com
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F28818
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode
Reloadhttps://github.com/nodejs/node/pull/28818
Reloadhttps://github.com/nodejs/node/pull/28818
Reloadhttps://github.com/nodejs/node/pull/28818
Please reload this pagehttps://github.com/nodejs/node/pull/28818
nodejs https://github.com/nodejs
nodehttps://github.com/nodejs/node
Please reload this pagehttps://github.com/nodejs/node/pull/28818
Notifications https://github.com/login?return_to=%2Fnodejs%2Fnode
Fork 36.2k https://github.com/login?return_to=%2Fnodejs%2Fnode
Star 118k https://github.com/login?return_to=%2Fnodejs%2Fnode
Code https://github.com/nodejs/node
Issues 1.4k https://github.com/nodejs/node/issues
Pull requests 984 https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects https://github.com/nodejs/node/projects
Security and quality 0 https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
Code https://github.com/nodejs/node
Issues https://github.com/nodejs/node/issues
Pull requests https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects https://github.com/nodejs/node/projects
Security and quality https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
ronaghttps://github.com/ronag
nodejs:masterhttps://github.com/nodejs/node/tree/master
nxtedition:stream-pipeline-uncaughthttps://github.com/nxtedition/node/tree/stream-pipeline-uncaught
Conversationhttps://github.com/nodejs/node/pull/28818
Commits1 (1)https://github.com/nodejs/node/pull/28818/commits
Checkshttps://github.com/nodejs/node/pull/28818/checks
Files changedhttps://github.com/nodejs/node/pull/28818/files
stream: pipeline uncaught errorhttps://github.com/nodejs/node/pull/28818#top
ronaghttps://github.com/ronag
nodejs:masterhttps://github.com/nodejs/node/tree/master
nxtedition:stream-pipeline-uncaughthttps://github.com/nxtedition/node/tree/stream-pipeline-uncaught
https://github.com/ronag
ronaghttps://github.com/ronag
Jul 23, 2019https://github.com/nodejs/node/pull/28818#issue-471557809
Please reload this pagehttps://github.com/nodejs/node/pull/28818
commit guidelineshttps://github.com/nodejs/node/blob/master/doc/guides/contributing/pull-requests.md#commit-message-guidelines
Please reload this pagehttps://github.com/nodejs/node/pull/28818
https://github.com/ronag
ronaghttps://github.com/ronag
force-pushedhttps://github.com/nodejs/node/compare/dcc86f825659f08e63ec138dfa450be4c4fc0e40..9136ca1499db5a45f5ebb39abbfa9fd1708c7f9f
dcc86f8https://github.com/nodejs/node/commit/dcc86f825659f08e63ec138dfa450be4c4fc0e40
9136ca1https://github.com/nodejs/node/commit/9136ca1499db5a45f5ebb39abbfa9fd1708c7f9f
Compare https://github.com/nodejs/node/compare/dcc86f825659f08e63ec138dfa450be4c4fc0e40..9136ca1499db5a45f5ebb39abbfa9fd1708c7f9f
July 23, 2019 08:56https://github.com/nodejs/node/pull/28818#event-2502302360
https://github.com/Fishrock123
Fishrock123https://github.com/Fishrock123
stream https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Astream
Jul 24, 2019https://github.com/nodejs/node/pull/28818#event-2507583745
https://github.com/Fishrock123
Fishrock123https://github.com/Fishrock123
Jul 24, 2019https://github.com/nodejs/node/pull/28818#issuecomment-514791763
Please reload this pagehttps://github.com/nodejs/node/pull/28818
https://github.com/ronag
ronaghttps://github.com/ronag
Jul 24, 2019https://github.com/nodejs/node/pull/28818#issuecomment-514807228
Please reload this pagehttps://github.com/nodejs/node/pull/28818
https://github.com/ronag
ronaghttps://github.com/ronag
Jul 24, 2019https://github.com/nodejs/node/pull/28818#issuecomment-514807717
Please reload this pagehttps://github.com/nodejs/node/pull/28818
https://github.com/ronag
ronaghttps://github.com/ronag
Jul 24, 2019https://github.com/nodejs/node/pull/28818#issuecomment-514807950
Please reload this pagehttps://github.com/nodejs/node/pull/28818
https://github.com/Trott
Trotthttps://github.com/Trott
Jul 25, 2019https://github.com/nodejs/node/pull/28818#issuecomment-515228359
@ronaghttps://github.com/ronag
Please reload this pagehttps://github.com/nodejs/node/pull/28818
https://github.com/ronag
ronaghttps://github.com/ronag
Jul 26, 2019https://github.com/nodejs/node/pull/28818#issuecomment-515258244
Please reload this pagehttps://github.com/nodejs/node/pull/28818
https://github.com/Trott
Trotthttps://github.com/Trott
Jul 26, 2019https://github.com/nodejs/node/pull/28818#issuecomment-515309891
Please reload this pagehttps://github.com/nodejs/node/pull/28818
https://github.com/mcollina
mcollinahttps://github.com/mcollina
Jul 26, 2019 https://github.com/nodejs/node/pull/28818#pullrequestreview-266996779
View reviewed changes https://github.com/nodejs/node/pull/28818/files
mcollinahttps://github.com/mcollina
https://github.com/nodejs/node/pull/28818#pullrequestreview-266996779
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/28818
https://github.com/mafintosh
mafintoshhttps://github.com/mafintosh
Jul 26, 2019https://github.com/nodejs/node/pull/28818#issuecomment-515316446
Please reload this pagehttps://github.com/nodejs/node/pull/28818
https://github.com/ronag
ronaghttps://github.com/ronag
Jul 26, 2019https://github.com/nodejs/node/pull/28818#issuecomment-515393709
@lpincahttps://github.com/lpinca
@mcollinahttps://github.com/mcollina
Please reload this pagehttps://github.com/nodejs/node/pull/28818
https://github.com/ronag
ronaghttps://github.com/ronag
Jul 26, 2019 https://github.com/nodejs/node/pull/28818#ref-pullrequest-471705052
stream: finished cleanup #28820 https://github.com/nodejs/node/pull/28820
https://github.com/ronag
ronaghttps://github.com/ronag
force-pushedhttps://github.com/nodejs/node/compare/e85141deb7f398cd2aad3adf4712f616722f920c..31b89c38064d5c55013a83f4480209b49f1497a8
e85141dhttps://github.com/nodejs/node/commit/e85141deb7f398cd2aad3adf4712f616722f920c
31b89c3https://github.com/nodejs/node/commit/31b89c38064d5c55013a83f4480209b49f1497a8
Compare https://github.com/nodejs/node/compare/e85141deb7f398cd2aad3adf4712f616722f920c..31b89c38064d5c55013a83f4480209b49f1497a8
July 26, 2019 10:13https://github.com/nodejs/node/pull/28818#event-2512130829
https://github.com/ronag
ronaghttps://github.com/ronag
Aug 2, 2019https://github.com/nodejs/node/pull/28818#issuecomment-517573565
Please reload this pagehttps://github.com/nodejs/node/pull/28818
@mcollinahttps://github.com/mcollina
Please reload this pagehttps://github.com/nodejs/node/pull/28818
https://github.com/ronag
ronaghttps://github.com/ronag
force-pushedhttps://github.com/nodejs/node/compare/31b89c38064d5c55013a83f4480209b49f1497a8..626289cb839051acb1f7f019ed419b9b4d2652b0
31b89c3https://github.com/nodejs/node/commit/31b89c38064d5c55013a83f4480209b49f1497a8
626289chttps://github.com/nodejs/node/commit/626289cb839051acb1f7f019ed419b9b4d2652b0
Compare https://github.com/nodejs/node/compare/31b89c38064d5c55013a83f4480209b49f1497a8..626289cb839051acb1f7f019ed419b9b4d2652b0
August 2, 2019 06:37https://github.com/nodejs/node/pull/28818#event-2528675826
https://github.com/mcollina
mcollinahttps://github.com/mcollina
Aug 2, 2019 https://github.com/nodejs/node/pull/28818#pullrequestreview-270006654
View reviewed changes https://github.com/nodejs/node/pull/28818/files
mcollinahttps://github.com/mcollina
https://github.com/nodejs/node/pull/28818#pullrequestreview-270006654
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/28818
https://github.com/ronag
stream: pipeline uncaught errorhttps://github.com/nodejs/node/pull/28818/commits/633fffe67e0bcf2b663908af6ee525f0c74a9ce3
633fffehttps://github.com/nodejs/node/pull/28818/commits/633fffe67e0bcf2b663908af6ee525f0c74a9ce3
https://github.com/ronag
ronaghttps://github.com/ronag
force-pushedhttps://github.com/nodejs/node/compare/626289cb839051acb1f7f019ed419b9b4d2652b0..633fffe67e0bcf2b663908af6ee525f0c74a9ce3
626289chttps://github.com/nodejs/node/commit/626289cb839051acb1f7f019ed419b9b4d2652b0
633fffehttps://github.com/nodejs/node/commit/633fffe67e0bcf2b663908af6ee525f0c74a9ce3
Compare https://github.com/nodejs/node/compare/626289cb839051acb1f7f019ed419b9b4d2652b0..633fffe67e0bcf2b663908af6ee525f0c74a9ce3
August 2, 2019 06:40https://github.com/nodejs/node/pull/28818#event-2528682149
https://github.com/ronag
ronaghttps://github.com/ronag
Aug 2, 2019https://github.com/nodejs/node/pull/28818#issuecomment-517575239
Please reload this pagehttps://github.com/nodejs/node/pull/28818
@mcollinahttps://github.com/mcollina
Please reload this pagehttps://github.com/nodejs/node/pull/28818
https://github.com/mcollina
mcollinahttps://github.com/mcollina
Aug 2, 2019https://github.com/nodejs/node/pull/28818#issuecomment-517576505
Please reload this pagehttps://github.com/nodejs/node/pull/28818
https://github.com/ronag
ronaghttps://github.com/ronag
Aug 2, 2019https://github.com/nodejs/node/pull/28818#issuecomment-517578169
@lpincahttps://github.com/lpinca
Please reload this pagehttps://github.com/nodejs/node/pull/28818
https://github.com/ronag
ronaghttps://github.com/ronag
Aug 2, 2019https://github.com/nodejs/node/pull/28818#issuecomment-517578570
@mcollinahttps://github.com/mcollina
#28820https://github.com/nodejs/node/pull/28820
Please reload this pagehttps://github.com/nodejs/node/pull/28818
https://github.com/ronag
ronaghttps://github.com/ronag
Aug 2, 2019https://github.com/nodejs/node/pull/28818#event-2528713738
https://github.com/mcollina
mcollinahttps://github.com/mcollina
Aug 2, 2019https://github.com/nodejs/node/pull/28818#issuecomment-517579914
Please reload this pagehttps://github.com/nodejs/node/pull/28818
https://github.com/ronag
ronaghttps://github.com/ronag
Aug 2, 2019https://github.com/nodejs/node/pull/28818#issuecomment-517581051
#28935https://github.com/nodejs/node/pull/28935
Please reload this pagehttps://github.com/nodejs/node/pull/28818
https://github.co/hiddenchars
https://github.com/nodejs/node/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F28818
https://github.com/mcollina
mcollina https://github.com/mcollina
https://github.com/nodejs/node/pull/28818/files/626289cb839051acb1f7f019ed419b9b4d2652b0
stream https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Astream
Please reload this pagehttps://github.com/nodejs/node/pull/28818
https://github.com/ronag
https://github.com/Fishrock123
https://github.com/Trott
https://github.com/mafintosh
https://github.com/mcollina
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.