| route-pattern | /_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format) |
| route-controller | voltron_pull_requests_fragments |
| route-action | pull_request_layout |
| fetch-nonce | v2:894d94ed-b257-3f78-1e8a-50c70b008a2c |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | A822:EBB89:66B190:8BEA99:6A514FC6 |
| html-safe-nonce | ec0867431ce7a1d740f610eab5d7c01e6fe6d1b01d3e9db0a8ecec5f20af129f |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJBODIyOkVCQjg5OjY2QjE5MDo4QkVBOTk6NkE1MTRGQzYiLCJ2aXNpdG9yX2lkIjoiNTg3NDg3ODM4Nzc4MTE5MzY3MCIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9 |
| visitor-hmac | 5f35c98dc70686ab4dec80ba42a0ae48c7a1f2fbf427ac38433bb69de318fba6 |
| hovercard-subject-tag | pull_request:299607738 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///voltron/pull_requests_fragments/pull_request_layout |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/28792/pull_request_layout |
| twitter:image | https://opengraph.githubassets.com/6488a72f7face8d922bceb8f1ffbb6bf158b6beae972b084d110a94b6614a056/nodejs/node/pull/28792 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/6488a72f7face8d922bceb8f1ffbb6bf158b6beae972b084d110a94b6614a056/nodejs/node/pull/28792 |
| og:image:alt | Fixes: #28790
Checklist
make -j4 test (UNIX), or vcbuild test (Windows) passes
commit message follows commit guidelines |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | mscdex |
| hostname | github.com |
| expected-hostname | github.com |
| None | 6f17634ed2af1d116850bcea6c63a70a4d72970f33ade1dd3eef3764b7e16994 |
| turbo-cache-control | no-cache |
| go-import | github.com/nodejs/node git https://github.com/nodejs/node.git |
| octolytics-dimension-user_id | 9950313 |
| octolytics-dimension-user_login | nodejs |
| octolytics-dimension-repository_id | 27193779 |
| octolytics-dimension-repository_nwo | nodejs/node |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 27193779 |
| octolytics-dimension-repository_network_root_nwo | nodejs/node |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 511bff6ea06e144ed085ff736aea4c6404987b00 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| Skip to content | https://github.com/nodejs/node/pull/28792#start-of-content |
|
| https://github.com/ |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F28792 |
| GitHub CopilotWrite better code with AI | https://github.com/features/copilot |
| GitHub Copilot appDirect agents from issue to merge | https://github.com/features/ai/github-app |
| MCP RegistryNewIntegrate external tools | https://github.com/mcp |
| ActionsAutomate any workflow | https://github.com/features/actions |
| CodespacesInstant dev environments | https://github.com/features/codespaces |
| IssuesPlan and track work | https://github.com/features/issues |
| Code ReviewManage code changes | https://github.com/features/code-review |
| GitHub Advanced SecurityFind and fix vulnerabilities | https://github.com/security/advanced-security |
| Code securitySecure your code as you build | https://github.com/security/advanced-security/code-security |
| Secret protectionStop leaks before they start | https://github.com/security/advanced-security/secret-protection |
| Why GitHub | https://github.com/why-github |
| Documentation | https://docs.github.com |
| Blog | https://github.blog |
| Changelog | https://github.blog/changelog |
| Marketplace | https://github.com/marketplace |
| View all features | https://github.com/features |
| Enterprises | https://github.com/enterprise |
| Small and medium teams | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| App Modernization | https://github.com/solutions/use-case/app-modernization |
| DevSecOps | https://github.com/solutions/use-case/devsecops |
| DevOps | https://github.com/solutions/use-case/devops |
| CI/CD | https://github.com/solutions/use-case/ci-cd |
| View all use cases | https://github.com/solutions/use-case |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| View all industries | https://github.com/solutions/industry |
| View all solutions | https://github.com/solutions |
| AI | https://github.com/resources/articles?topic=ai |
| Software Development | https://github.com/resources/articles?topic=software-development |
| DevOps | https://github.com/resources/articles?topic=devops |
| Security | https://github.com/resources/articles?topic=security |
| View all topics | https://github.com/resources/articles |
| Customer stories | https://github.com/customer-stories |
| Events & webinars | https://github.com/resources/events |
| Ebooks & reports | https://github.com/resources/whitepapers |
| Business insights | https://github.com/solutions/executive-insights |
| GitHub Skills | https://skills.github.com |
| Documentation | https://docs.github.com |
| Customer support | https://support.github.com |
| Community forum | https://github.com/orgs/community/discussions |
| Trust center | https://github.com/trust-center |
| Partners | https://github.com/partners |
| View all resources | https://github.com/resources |
| GitHub SponsorsFund open source developers | https://github.com/open-source/sponsors |
| Security Lab | https://securitylab.github.com |
| Maintainer Community | https://maintainers.github.com |
| Accelerator | https://github.com/open-source/accelerator |
| GitHub Stars | https://stars.github.com |
| Archive Program | https://archiveprogram.github.com |
| Topics | https://github.com/topics |
| Trending | https://github.com/trending |
| Collections | https://github.com/collections |
| Enterprise platformAI-powered developer platform | https://github.com/enterprise |
| GitHub Advanced SecurityEnterprise-grade security features | https://github.com/security/advanced-security |
| Copilot for BusinessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/enterprise/premium-support |
| Pricing | https://github.com/pricing |
| Search syntax tips | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
| documentation | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F28792 |
|
Sign up
| https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode |
| Reload | https://github.com/nodejs/node/pull/28792 |
| Reload | https://github.com/nodejs/node/pull/28792 |
| Reload | https://github.com/nodejs/node/pull/28792 |
| Please reload this page | https://github.com/nodejs/node/pull/28792 |
|
nodejs
| https://github.com/nodejs |
| node | https://github.com/nodejs/node |
| Please reload this page | https://github.com/nodejs/node/pull/28792 |
|
Notifications
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Fork
36.1k
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Star
118k
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Code
| https://github.com/nodejs/node |
|
Issues
1.4k
| https://github.com/nodejs/node/issues |
|
Pull requests
978
| https://github.com/nodejs/node/pulls |
|
Actions
| https://github.com/nodejs/node/actions |
|
Projects
| https://github.com/nodejs/node/projects |
|
Security and quality
0
| https://github.com/nodejs/node/security |
|
Insights
| https://github.com/nodejs/node/pulse |
|
Code
| https://github.com/nodejs/node |
|
Issues
| https://github.com/nodejs/node/issues |
|
Pull requests
| https://github.com/nodejs/node/pulls |
|
Actions
| https://github.com/nodejs/node/actions |
|
Projects
| https://github.com/nodejs/node/projects |
|
Security and quality
| https://github.com/nodejs/node/security |
|
Insights
| https://github.com/nodejs/node/pulse |
| mscdex | https://github.com/mscdex |
| nodejs:master | https://github.com/nodejs/node/tree/master |
| mscdex:dns-fix-unsigned-values | https://github.com/mscdex/io.js/tree/dns-fix-unsigned-values |
| Conversation | https://github.com/nodejs/node/pull/28792 |
| Commits1 (1) | https://github.com/nodejs/node/pull/28792/commits |
| Checks | https://github.com/nodejs/node/pull/28792/checks |
| Files changed | https://github.com/nodejs/node/pull/28792/files |
| dns: fix unsigned record values | https://github.com/nodejs/node/pull/28792#top |
| mscdex | https://github.com/mscdex |
| nodejs:master | https://github.com/nodejs/node/tree/master |
| mscdex:dns-fix-unsigned-values | https://github.com/mscdex/io.js/tree/dns-fix-unsigned-values |
|
| https://github.com/mscdex |
| mscdex | https://github.com/mscdex |
| Jul 21, 2019 | https://github.com/nodejs/node/pull/28792#issue-470739296 |
| #28790 | https://github.com/nodejs/node/issues/28790 |
| commit guidelines | https://github.com/nodejs/node/blob/master/doc/guides/contributing/pull-requests.md#commit-message-guidelines |
| Please reload this page | https://github.com/nodejs/node/pull/28792 |
| https://github.com/mscdex |
| mscdex | https://github.com/mscdex |
|
dns
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Adns |
| Jul 21, 2019 | https://github.com/nodejs/node/pull/28792#event-2497849146 |
| https://github.com/nodejs-github-bot |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
|
c++
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Ac%2B%2B |
|
cares
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Acares |
| Jul 21, 2019 | https://github.com/nodejs/node/pull/28792#event-2497849169 |
| https://github.com/mscdex |
| mscdex | https://github.com/mscdex |
| Jul 21, 2019 | https://github.com/nodejs/node/pull/28792#issuecomment-513517989 |
| Please reload this page | https://github.com/nodejs/node/pull/28792 |
| Please reload this page | https://github.com/nodejs/node/pull/28792 |
| https://github.com/nodejs-github-bot |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
| Jul 21, 2019 | https://github.com/nodejs/node/pull/28792#issuecomment-513518087 |
| https://ci.nodejs.org/job/node-test-pull-request/24591/ | https://ci.nodejs.org/job/node-test-pull-request/24591/ |
| Please reload this page | https://github.com/nodejs/node/pull/28792 |
| https://github.com/cjihrig |
| cjihrig | https://github.com/cjihrig |
|
Jul 21, 2019
| https://github.com/nodejs/node/pull/28792#pullrequestreview-264519227 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/28792/files |
| https://github.com/Trott |
| Trott | https://github.com/Trott |
|
Jul 21, 2019
| https://github.com/nodejs/node/pull/28792#pullrequestreview-264519411 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/28792/files |
| https://github.com/schamberg97 |
| schamberg97 | https://github.com/schamberg97 |
| Jul 21, 2019 | https://github.com/nodejs/node/pull/28792#issuecomment-513536644 |
| Please reload this page | https://github.com/nodejs/node/pull/28792 |
| https://github.com/addaleax |
| addaleax | https://github.com/addaleax |
|
Jul 21, 2019
| https://github.com/nodejs/node/pull/28792#pullrequestreview-264528247 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/28792/files |
| https://github.com/addaleax |
| addaleax | https://github.com/addaleax |
| Jul 21, 2019 | https://github.com/nodejs/node/pull/28792#issuecomment-513539119 |
| Please reload this page | https://github.com/nodejs/node/pull/28792 |
|
| https://github.com/mscdex |
| dns: fix unsigned record values | https://github.com/nodejs/node/pull/28792/commits/e25f0ca71de8986ea98bc67720de7d8bb04789dd |
| e25f0ca | https://github.com/nodejs/node/pull/28792/commits/e25f0ca71de8986ea98bc67720de7d8bb04789dd |
| nodejs#28790 | https://github.com/nodejs/node/issues/28790 |
| https://github.com/mscdex |
| mscdex | https://github.com/mscdex |
| force-pushed | https://github.com/nodejs/node/compare/9db27174e65597c4aeb9eedb11b50af3918af575..e25f0ca71de8986ea98bc67720de7d8bb04789dd |
| 9db2717 | https://github.com/nodejs/node/commit/9db27174e65597c4aeb9eedb11b50af3918af575 |
| e25f0ca | https://github.com/nodejs/node/commit/e25f0ca71de8986ea98bc67720de7d8bb04789dd |
|
Compare
| https://github.com/nodejs/node/compare/9db27174e65597c4aeb9eedb11b50af3918af575..e25f0ca71de8986ea98bc67720de7d8bb04789dd |
| July 21, 2019 14:06 | https://github.com/nodejs/node/pull/28792#event-2498065910 |
| https://github.com/nodejs-github-bot |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
| Jul 21, 2019 | https://github.com/nodejs/node/pull/28792#issuecomment-513557536 |
| https://ci.nodejs.org/job/node-test-pull-request/24603/ | https://ci.nodejs.org/job/node-test-pull-request/24603/ |
| Please reload this page | https://github.com/nodejs/node/pull/28792 |
| https://github.com/mscdex |
| mscdex | https://github.com/mscdex |
| Jul 21, 2019 | https://github.com/nodejs/node/pull/28792#issuecomment-513558459 |
| Please reload this page | https://github.com/nodejs/node/pull/28792 |
| https://github.com/nodejs-github-bot |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
| Jul 21, 2019 | https://github.com/nodejs/node/pull/28792#issuecomment-513580602 |
| https://ci.nodejs.org/job/node-test-pull-request/24606/ | https://ci.nodejs.org/job/node-test-pull-request/24606/ |
| Please reload this page | https://github.com/nodejs/node/pull/28792 |
| https://github.com/addaleax |
| addaleax | https://github.com/addaleax |
|
Jul 21, 2019
| https://github.com/nodejs/node/pull/28792#pullrequestreview-264551834 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/28792/files/e25f0ca71de8986ea98bc67720de7d8bb04789dd |
| https://github.com/bnoordhuis |
| bnoordhuis | https://github.com/bnoordhuis |
|
Jul 21, 2019
| https://github.com/nodejs/node/pull/28792#pullrequestreview-264552754 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/28792/files/e25f0ca71de8986ea98bc67720de7d8bb04789dd |
| https://github.com/Trott |
| Trott | https://github.com/Trott |
| Jul 23, 2019 | https://github.com/nodejs/node/pull/28792#issuecomment-514060767 |
| 03317f0 | https://github.com/nodejs/node/commit/03317f0e8ea9d0d4718bc29eb80fc54ac5669208 |
| Please reload this page | https://github.com/nodejs/node/pull/28792 |
| https://github.com/Trott |
| Trott | https://github.com/Trott |
| Jul 23, 2019 | https://github.com/nodejs/node/pull/28792#event-2501842167 |
| Trott | https://github.com/Trott |
|
Jul 23, 2019
| https://github.com/nodejs/node/pull/28792#ref-commit-03317f0 |
|
| https://github.com/mscdex |
|
| https://github.com/Trott |
| dns: fix unsigned record values | https://github.com/Trott/io.js/commit/03317f0e8ea9d0d4718bc29eb80fc54ac5669208 |
| 03317f0 | https://github.com/Trott/io.js/commit/03317f0e8ea9d0d4718bc29eb80fc54ac5669208 |
| nodejs#28790 | https://github.com/nodejs/node/issues/28790 |
| nodejs#28792 | https://github.com/nodejs/node/pull/28792 |
| targos | https://github.com/targos |
|
Jul 23, 2019
| https://github.com/nodejs/node/pull/28792#ref-commit-0ee1298 |
|
| https://github.com/mscdex |
|
| https://github.com/targos |
| dns: fix unsigned record values | https://github.com/nodejs/node/commit/0ee12980561cd7b5c51708a3ba85c6991710dd0d |
| 0ee1298 | https://github.com/nodejs/node/commit/0ee12980561cd7b5c51708a3ba85c6991710dd0d |
| #28790 | https://github.com/nodejs/node/issues/28790 |
| #28792 | https://github.com/nodejs/node/pull/28792 |
| https://github.com/mscdex |
| mscdex | https://github.com/mscdex |
| July 23, 2019 07:47 | https://github.com/nodejs/node/pull/28792#event-2502101695 |
|
v12.7.0 release proposal
#28816
| https://github.com/nodejs/node/pull/28816 |
|
v12.7.0 release proposal
#28817
| https://github.com/nodejs/node/pull/28817 |
| gntem | https://github.com/gntem |
|
Jul 27, 2019
| https://github.com/nodejs/node/pull/28792#ref-commit-00bd55d |
|
| https://github.com/mscdex |
|
| https://github.com/gntem |
| dns: fix unsigned record values | https://github.com/gntem/node/commit/00bd55d9a25a5973f4ae9c3d5af31eb87bb7c4bd |
| 00bd55d | https://github.com/gntem/node/commit/00bd55d9a25a5973f4ae9c3d5af31eb87bb7c4bd |
| nodejs#28790 | https://github.com/nodejs/node/issues/28790 |
| nodejs#28792 | https://github.com/nodejs/node/pull/28792 |
| vikashk1 | https://github.com/vikashk1 |
|
Aug 13, 2019
| https://github.com/nodejs/node/pull/28792#ref-commit-9af17ad |
|
| https://github.com/vikashk1 |
| Please ignore this msg ( | https://github.com/vikashk1/node/commit/9af17ad05c8161db7f52de5fd3331a94857e33fc |
| #1 | https://github.com/vikashk1/node/pull/1 |
| ) | https://github.com/vikashk1/node/commit/9af17ad05c8161db7f52de5fd3331a94857e33fc |
| 9af17ad | https://github.com/vikashk1/node/commit/9af17ad05c8161db7f52de5fd3331a94857e33fc |
| https://github.co/hiddenchars |
| https://github.com/nodejs/node/pull/{{ revealButtonHref }} |
| Sign up for free | https://github.com/join?source=comment-repo |
| Sign in to comment | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F28792 |
|
| https://github.com/bnoordhuis |
|
bnoordhuis
| https://github.com/bnoordhuis |
|
| https://github.com/nodejs/node/pull/28792/files/e25f0ca71de8986ea98bc67720de7d8bb04789dd |
|
| https://github.com/Trott |
|
Trott
| https://github.com/Trott |
|
| https://github.com/nodejs/node/pull/28792/files/9db27174e65597c4aeb9eedb11b50af3918af575 |
|
| https://github.com/addaleax |
|
addaleax
| https://github.com/addaleax |
|
| https://github.com/nodejs/node/pull/28792/files/e25f0ca71de8986ea98bc67720de7d8bb04789dd |
|
| https://github.com/cjihrig |
|
cjihrig
| https://github.com/cjihrig |
|
| https://github.com/nodejs/node/pull/28792/files/9db27174e65597c4aeb9eedb11b50af3918af575 |
|
c++
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Ac%2B%2B |
|
cares
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Acares |
|
dns
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Adns |
|
DNS SOA Serial bug
| https://github.com/nodejs/node/issues/28790 |
| Please reload this page | https://github.com/nodejs/node/pull/28792 |
|
| https://github.com/mscdex |
|
| https://github.com/nodejs-github-bot |
|
| https://github.com/schamberg97 |
|
| https://github.com/addaleax |
|
| https://github.com/Trott |
|
| https://github.com/bnoordhuis |
|
| https://github.com/cjihrig |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |