René's URL Explorer Experiment


Title: src: do not include partial AsyncWrap instances in heap dump by addaleax · Pull Request #28789 · nodejs/node · GitHub

Open Graph Title: src: do not include partial AsyncWrap instances in heap dump by addaleax · Pull Request #28789 · nodejs/node

X Title: src: do not include partial AsyncWrap instances in heap dump by addaleax · Pull Request #28789 · nodejs/node

Description: Node.js JavaScript runtime ✨🐢🚀✨. Contribute to nodejs/node development by creating an account on GitHub.

Open Graph Description: Heap dumps can be taken either through the inspector or the public API for it during an async_hooks init() hook, but at that point the AsyncWrap in question is not done initializing yet and virtual...

X Description: Heap dumps can be taken either through the inspector or the public API for it during an async_hooks init() hook, but at that point the AsyncWrap in question is not done initializing yet and virtual...

Opengraph URL: https://github.com/nodejs/node/pull/28789

X: @github

direct link

Domain: github.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:21edada2-2c5e-2c4a-ef34-e5468be4e25f
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idC916:1CD42A:848141:BA4341:6A4FD295
html-safe-nonce0894d75b2f1fee8adb2fc6d10f8eec911ad96cadfdf6fd51dcf6e66953ac9dc6
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJDOTE2OjFDRDQyQTo4NDgxNDE6QkE0MzQxOjZBNEZEMjk1IiwidmlzaXRvcl9pZCI6IjUzMDQ3MDgzMTUxNjIzMzM4NDUiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmac9f00b2ba93de3037bf2e847c958be6246cffaa4f2332eec5a11f47f83629cb63
hovercard-subject-tagpull_request:299591421
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/28789/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/8ae0898959ae3fb647f6e001c42c86b34e3dea49993e91fab8e08cc23c53040b/nodejs/node/pull/28789
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/8ae0898959ae3fb647f6e001c42c86b34e3dea49993e91fab8e08cc23c53040b/nodejs/node/pull/28789
og:image:altHeap dumps can be taken either through the inspector or the public API for it during an async_hooks init() hook, but at that point the AsyncWrap in question is not done initializing yet and virtual...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernameaddaleax
hostnamegithub.com
expected-hostnamegithub.com
None19b98c3d9767bb8a56238a89ff8401d1cbdf3bc5c353799aacf49fe6c76b4b7c
turbo-cache-controlno-cache
go-importgithub.com/nodejs/node git https://github.com/nodejs/node.git
octolytics-dimension-user_id9950313
octolytics-dimension-user_loginnodejs
octolytics-dimension-repository_id27193779
octolytics-dimension-repository_nwonodejs/node
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id27193779
octolytics-dimension-repository_network_root_nwonodejs/node
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release142593e66413bbae27fd485859993597d5a3b104
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/nodejs/node/pull/28789#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F28789
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub Copilot appDirect agents from issue to mergehttps://github.com/features/ai/github-app
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
View all resourceshttps://github.com/resources
GitHub SponsorsFund open source developershttps://github.com/open-source/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/open-source/accelerator
GitHub Starshttps://stars.github.com
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F28789
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode
Reloadhttps://github.com/nodejs/node/pull/28789
Reloadhttps://github.com/nodejs/node/pull/28789
Reloadhttps://github.com/nodejs/node/pull/28789
Please reload this pagehttps://github.com/nodejs/node/pull/28789
nodejs https://github.com/nodejs
nodehttps://github.com/nodejs/node
Please reload this pagehttps://github.com/nodejs/node/pull/28789
Notifications https://github.com/login?return_to=%2Fnodejs%2Fnode
Fork 36k https://github.com/login?return_to=%2Fnodejs%2Fnode
Star 118k https://github.com/login?return_to=%2Fnodejs%2Fnode
Code https://github.com/nodejs/node
Issues 1.3k https://github.com/nodejs/node/issues
Pull requests 973 https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects https://github.com/nodejs/node/projects
Security and quality 0 https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
Code https://github.com/nodejs/node
Issues https://github.com/nodejs/node/issues
Pull requests https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects https://github.com/nodejs/node/projects
Security and quality https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
addaleaxhttps://github.com/addaleax
nodejs:masterhttps://github.com/nodejs/node/tree/master
addaleax:async-wrap-init-heapdumphttps://github.com/addaleax/node/tree/async-wrap-init-heapdump
Conversationhttps://github.com/nodejs/node/pull/28789
Commits1 (1)https://github.com/nodejs/node/pull/28789/commits
Checkshttps://github.com/nodejs/node/pull/28789/checks
Files changedhttps://github.com/nodejs/node/pull/28789/files
src: do not include partial AsyncWrap instances in heap dumphttps://github.com/nodejs/node/pull/28789#top
addaleaxhttps://github.com/addaleax
nodejs:masterhttps://github.com/nodejs/node/tree/master
addaleax:async-wrap-init-heapdumphttps://github.com/addaleax/node/tree/async-wrap-init-heapdump
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
Jul 20, 2019https://github.com/nodejs/node/pull/28789#issue-470715221
#28786https://github.com/nodejs/node/issues/28786
commit guidelineshttps://github.com/nodejs/node/blob/master/doc/guides/contributing/pull-requests.md#commit-message-guidelines
Please reload this pagehttps://github.com/nodejs/node/pull/28789
https://github.com/addaleax
src: do not include partial AsyncWrap instances in heap dumphttps://github.com/nodejs/node/pull/28789/commits/ece22105f16bd017d4f20892ddaa631cd80fa301
ece2210https://github.com/nodejs/node/pull/28789/commits/ece22105f16bd017d4f20892ddaa631cd80fa301
nodejs#28786https://github.com/nodejs/node/issues/28786
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
c++ https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Ac%2B%2B
Jul 20, 2019https://github.com/nodejs/node/pull/28789#event-2497744327
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
async_hooks https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aasync_hooks
inspector https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Ainspector
async_wrap https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aasync_wrap
Jul 20, 2019https://github.com/nodejs/node/pull/28789#event-2497744436
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
Jul 20, 2019 https://github.com/nodejs/node/pull/28789#ref-issue-470707674
"pure virtual method called" when creating a heap snapshot #28786 https://github.com/nodejs/node/issues/28786
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
Jul 20, 2019https://github.com/nodejs/node/pull/28789#issuecomment-513499897
https://ci.nodejs.org/job/node-test-pull-request/24590/https://ci.nodejs.org/job/node-test-pull-request/24590/
Please reload this pagehttps://github.com/nodejs/node/pull/28789
https://github.com/Trott
Trotthttps://github.com/Trott
Jul 20, 2019https://github.com/nodejs/node/pull/28789#issuecomment-513501854
Please reload this pagehttps://github.com/nodejs/node/pull/28789
https://github.com/bnoordhuis
bnoordhuishttps://github.com/bnoordhuis
Jul 22, 2019 https://github.com/nodejs/node/pull/28789#pullrequestreview-264850365
View reviewed changes https://github.com/nodejs/node/pull/28789/files/ece22105f16bd017d4f20892ddaa631cd80fa301
bnoordhuishttps://github.com/bnoordhuis
https://github.com/nodejs/node/pull/28789#pullrequestreview-264850365
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/28789
https://github.com/Trott
Trotthttps://github.com/Trott
Jul 22, 2019 https://github.com/nodejs/node/pull/28789#pullrequestreview-265109988
View reviewed changes https://github.com/nodejs/node/pull/28789/files/ece22105f16bd017d4f20892ddaa631cd80fa301
https://github.com/Trott
Trotthttps://github.com/Trott
Jul 22, 2019https://github.com/nodejs/node/pull/28789#issuecomment-513995231
9949fbdhttps://github.com/nodejs/node/commit/9949fbda469e70acc45975f5e50eedd2a3cde57d
Please reload this pagehttps://github.com/nodejs/node/pull/28789
https://github.com/Trott
Trotthttps://github.com/Trott
Jul 22, 2019https://github.com/nodejs/node/pull/28789#event-2501403499
Trotthttps://github.com/Trott
Jul 22, 2019 https://github.com/nodejs/node/pull/28789#ref-commit-9949fbd
https://github.com/addaleax
https://github.com/Trott
src: do not include partial AsyncWrap instances in heap dumphttps://github.com/Trott/io.js/commit/9949fbda469e70acc45975f5e50eedd2a3cde57d
9949fbdhttps://github.com/Trott/io.js/commit/9949fbda469e70acc45975f5e50eedd2a3cde57d
nodejs#28786https://github.com/nodejs/node/issues/28786
nodejs#28789https://github.com/nodejs/node/pull/28789
targoshttps://github.com/targos
Jul 23, 2019 https://github.com/nodejs/node/pull/28789#ref-commit-302865e
https://github.com/addaleax
https://github.com/targos
src: do not include partial AsyncWrap instances in heap dumphttps://github.com/nodejs/node/commit/302865e8b9756812b45d9ff60403c2a231c01152
302865ehttps://github.com/nodejs/node/commit/302865e8b9756812b45d9ff60403c2a231c01152
#28786https://github.com/nodejs/node/issues/28786
#28789https://github.com/nodejs/node/pull/28789
v12.7.0 release proposal #28816 https://github.com/nodejs/node/pull/28816
v12.7.0 release proposal #28817 https://github.com/nodejs/node/pull/28817
ronaghttps://github.com/ronag
Jul 24, 2019 https://github.com/nodejs/node/pull/28789#ref-commit-77bfb20
https://github.com/addaleax
https://github.com/ronag
src: do not include partial AsyncWrap instances in heap dumphttps://github.com/nxtedition/node/commit/77bfb2032f06760f2aaaeec2242f44892fb6cd60
77bfb20https://github.com/nxtedition/node/commit/77bfb2032f06760f2aaaeec2242f44892fb6cd60
nodejs#28786https://github.com/nodejs/node/issues/28786
nodejs#28789https://github.com/nodejs/node/pull/28789
gntemhttps://github.com/gntem
Jul 27, 2019 https://github.com/nodejs/node/pull/28789#ref-commit-f6219ee
https://github.com/addaleax
https://github.com/gntem
src: do not include partial AsyncWrap instances in heap dumphttps://github.com/gntem/node/commit/f6219eeba8f44a46d1bbe53b24ce2b76f5466dd6
f6219eehttps://github.com/gntem/node/commit/f6219eeba8f44a46d1bbe53b24ce2b76f5466dd6
nodejs#28786https://github.com/nodejs/node/issues/28786
nodejs#28789https://github.com/nodejs/node/pull/28789
vikashk1https://github.com/vikashk1
Aug 13, 2019 https://github.com/nodejs/node/pull/28789#ref-commit-9af17ad
https://github.com/vikashk1
Please ignore this msg (https://github.com/vikashk1/node/commit/9af17ad05c8161db7f52de5fd3331a94857e33fc
#1https://github.com/vikashk1/node/pull/1
)https://github.com/vikashk1/node/commit/9af17ad05c8161db7f52de5fd3331a94857e33fc
9af17adhttps://github.com/vikashk1/node/commit/9af17ad05c8161db7f52de5fd3331a94857e33fc
https://github.co/hiddenchars
https://github.com/nodejs/node/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F28789
https://github.com/bnoordhuis
bnoordhuis https://github.com/bnoordhuis
https://github.com/nodejs/node/pull/28789/files/ece22105f16bd017d4f20892ddaa631cd80fa301
https://github.com/Trott
Trott https://github.com/Trott
https://github.com/nodejs/node/pull/28789/files/ece22105f16bd017d4f20892ddaa631cd80fa301
async_hooks https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aasync_hooks
c++ https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Ac%2B%2B
inspector https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Ainspector
"pure virtual method called" when creating a heap snapshot https://github.com/nodejs/node/issues/28786
Please reload this pagehttps://github.com/nodejs/node/pull/28789
https://github.com/addaleax
https://github.com/nodejs-github-bot
https://github.com/Trott
https://github.com/bnoordhuis
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.