René's URL Explorer Experiment


Title: worker: fix crash when SharedArrayBuffer outlives creating thread by addaleax · Pull Request #28788 · nodejs/node · GitHub

Open Graph Title: worker: fix crash when SharedArrayBuffer outlives creating thread by addaleax · Pull Request #28788 · nodejs/node

X Title: worker: fix crash when SharedArrayBuffer outlives creating thread by addaleax · Pull Request #28788 · nodejs/node

Description: Node.js JavaScript runtime ✨🐢🚀✨. Contribute to nodejs/node development by creating an account on GitHub.

Open Graph Description: Use the parent thread’s ArrayBuffer::Allocator when creating a Worker instance, as that allocator is guaranteed to outlive the Worker itself. Fixes: #28777 Fixes: #28773 Checklist make -j4 test...

X Description: Use the parent thread’s ArrayBuffer::Allocator when creating a Worker instance, as that allocator is guaranteed to outlive the Worker itself. Fixes: #28777 Fixes: #28773 Checklist make -j4 test...

Opengraph URL: https://github.com/nodejs/node/pull/28788

X: @github

direct link

Domain: github.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:42a78fbc-2bfa-ce63-e979-2190e331bc79
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-id8D0A:2E5A81:8D3B0:B94BB:6A513335
html-safe-nonceac4f62f1ad3554dfcbdc5ef1c4ed5611e062db3a3a3966aa39798fd71de6c59b
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI4RDBBOjJFNUE4MTo4RDNCMDpCOTRCQjo2QTUxMzMzNSIsInZpc2l0b3JfaWQiOiI1OTUzNjUzNTgxMjUyOTk3OTQxIiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmaca27d1bb7303cf3ca0cf3a8f8b6f597849e822e2d061f86b0d671ebd635a21468
hovercard-subject-tagpull_request:299591223
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/28788/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/316d5d260799b7db2a5568cbd2f1b24af0d5cdb81d0a1a93d0d018592f3e4768/nodejs/node/pull/28788
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/316d5d260799b7db2a5568cbd2f1b24af0d5cdb81d0a1a93d0d018592f3e4768/nodejs/node/pull/28788
og:image:altUse the parent thread’s ArrayBuffer::Allocator when creating a Worker instance, as that allocator is guaranteed to outlive the Worker itself. Fixes: #28777 Fixes: #28773 Checklist make -j4 test...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernameaddaleax
hostnamegithub.com
expected-hostnamegithub.com
Nonee840f405b2718e8f2d55aafa9ff27dbce17e29d0c253011d05ea0fea3c78baff
turbo-cache-controlno-cache
go-importgithub.com/nodejs/node git https://github.com/nodejs/node.git
octolytics-dimension-user_id9950313
octolytics-dimension-user_loginnodejs
octolytics-dimension-repository_id27193779
octolytics-dimension-repository_nwonodejs/node
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id27193779
octolytics-dimension-repository_network_root_nwonodejs/node
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release4ae6027e8ba70c79dc08249bb6cdc1a09d788496
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/nodejs/node/pull/28788#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F28788
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub Copilot appDirect agents from issue to mergehttps://github.com/features/ai/github-app
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
View all resourceshttps://github.com/resources
GitHub SponsorsFund open source developershttps://github.com/open-source/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/open-source/accelerator
GitHub Starshttps://stars.github.com
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F28788
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode
Reloadhttps://github.com/nodejs/node/pull/28788
Reloadhttps://github.com/nodejs/node/pull/28788
Reloadhttps://github.com/nodejs/node/pull/28788
Please reload this pagehttps://github.com/nodejs/node/pull/28788
nodejs https://github.com/nodejs
nodehttps://github.com/nodejs/node
Please reload this pagehttps://github.com/nodejs/node/pull/28788
Notifications https://github.com/login?return_to=%2Fnodejs%2Fnode
Fork 36.1k https://github.com/login?return_to=%2Fnodejs%2Fnode
Star 118k https://github.com/login?return_to=%2Fnodejs%2Fnode
Code https://github.com/nodejs/node
Issues 1.4k https://github.com/nodejs/node/issues
Pull requests 978 https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects https://github.com/nodejs/node/projects
Security and quality 0 https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
Code https://github.com/nodejs/node
Issues https://github.com/nodejs/node/issues
Pull requests https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects https://github.com/nodejs/node/projects
Security and quality https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
addaleaxhttps://github.com/addaleax
nodejs:masterhttps://github.com/nodejs/node/tree/master
addaleax:worker-sharedarraybuffer-childthreadhttps://github.com/addaleax/node/tree/worker-sharedarraybuffer-childthread
Conversationhttps://github.com/nodejs/node/pull/28788
Commits1 (1)https://github.com/nodejs/node/pull/28788/commits
Checkshttps://github.com/nodejs/node/pull/28788/checks
Files changedhttps://github.com/nodejs/node/pull/28788/files
worker: fix crash when SharedArrayBuffer outlives creating threadhttps://github.com/nodejs/node/pull/28788#top
addaleaxhttps://github.com/addaleax
nodejs:masterhttps://github.com/nodejs/node/tree/master
addaleax:worker-sharedarraybuffer-childthreadhttps://github.com/addaleax/node/tree/worker-sharedarraybuffer-childthread
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
Jul 20, 2019https://github.com/nodejs/node/pull/28788#issue-470714911
#28777https://github.com/nodejs/node/issues/28777
#28773https://github.com/nodejs/node/issues/28773
commit guidelineshttps://github.com/nodejs/node/blob/master/doc/guides/contributing/pull-requests.md#commit-message-guidelines
Please reload this pagehttps://github.com/nodejs/node/pull/28788
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
c++ https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Ac%2B%2B
worker https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aworker
Jul 20, 2019https://github.com/nodejs/node/pull/28788#event-2497742992
segfault when using SharedArrayBuffer from an unrefed worker thread #28777 https://github.com/nodejs/node/issues/28777
Access Violation #28773 https://github.com/nodejs/node/issues/28773
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
Jul 20, 2019https://github.com/nodejs/node/pull/28788#issuecomment-513499891
https://ci.nodejs.org/job/node-test-pull-request/24589/https://ci.nodejs.org/job/node-test-pull-request/24589/
Please reload this pagehttps://github.com/nodejs/node/pull/28788
https://github.com/Trott
Trotthttps://github.com/Trott
Jul 20, 2019 https://github.com/nodejs/node/pull/28788#pullrequestreview-264512440
View reviewed changes https://github.com/nodejs/node/pull/28788/files
https://github.com/Trott
Trotthttps://github.com/Trott
Jul 20, 2019https://github.com/nodejs/node/pull/28788#issuecomment-513501785
Please reload this pagehttps://github.com/nodejs/node/pull/28788
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
Jul 20, 2019https://github.com/nodejs/node/pull/28788#issuecomment-513502809
@Trotthttps://github.com/Trott
Please reload this pagehttps://github.com/nodejs/node/pull/28788
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
Jul 20, 2019https://github.com/nodejs/node/pull/28788#issuecomment-513505164
Please reload this pagehttps://github.com/nodejs/node/pull/28788
https://github.com/addaleax
worker: fix crash when SharedArrayBuffer outlives creating threadhttps://github.com/nodejs/node/pull/28788/commits/14d4ad0de613ea440d6a0cae1f4f721c5144ac4f
14d4ad0https://github.com/nodejs/node/pull/28788/commits/14d4ad0de613ea440d6a0cae1f4f721c5144ac4f
nodejs#28777https://github.com/nodejs/node/issues/28777
nodejs#28773https://github.com/nodejs/node/issues/28773
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
force-pushedhttps://github.com/nodejs/node/compare/446d7c59e6afad2702cf094d209c57d9bd6e918b..14d4ad0de613ea440d6a0cae1f4f721c5144ac4f
446d7c5https://github.com/nodejs/node/commit/446d7c59e6afad2702cf094d209c57d9bd6e918b
14d4ad0https://github.com/nodejs/node/commit/14d4ad0de613ea440d6a0cae1f4f721c5144ac4f
Compare https://github.com/nodejs/node/compare/446d7c59e6afad2702cf094d209c57d9bd6e918b..14d4ad0de613ea440d6a0cae1f4f721c5144ac4f
July 21, 2019 11:28https://github.com/nodejs/node/pull/28788#event-2497998776
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
Jul 21, 2019https://github.com/nodejs/node/pull/28788#issuecomment-513546821
Please reload this pagehttps://github.com/nodejs/node/pull/28788
https://github.com/cjihrig
cjihrighttps://github.com/cjihrig
Jul 22, 2019 https://github.com/nodejs/node/pull/28788#pullrequestreview-264920697
View reviewed changes https://github.com/nodejs/node/pull/28788/files/14d4ad0de613ea440d6a0cae1f4f721c5144ac4f
https://github.com/Trott
Trotthttps://github.com/Trott
Jul 22, 2019https://github.com/nodejs/node/pull/28788#issuecomment-513995423
Please reload this pagehttps://github.com/nodejs/node/pull/28788
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
Jul 25, 2019https://github.com/nodejs/node/pull/28788#issuecomment-514882549
https://ci.nodejs.org/job/node-test-pull-request/24681/https://ci.nodejs.org/job/node-test-pull-request/24681/
Please reload this pagehttps://github.com/nodejs/node/pull/28788
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
Jul 25, 2019https://github.com/nodejs/node/pull/28788#issuecomment-514914489
https://ci.nodejs.org/job/node-test-pull-request/24683/https://ci.nodejs.org/job/node-test-pull-request/24683/
Please reload this pagehttps://github.com/nodejs/node/pull/28788
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
Jul 26, 2019https://github.com/nodejs/node/pull/28788#issuecomment-515315538
https://ci.nodejs.org/job/node-test-pull-request/24712/https://ci.nodejs.org/job/node-test-pull-request/24712/
Please reload this pagehttps://github.com/nodejs/node/pull/28788
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
Jul 28, 2019https://github.com/nodejs/node/pull/28788#issuecomment-515796390
https://ci.nodejs.org/job/node-test-pull-request/24735/https://ci.nodejs.org/job/node-test-pull-request/24735/
Please reload this pagehttps://github.com/nodejs/node/pull/28788
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
Jul 28, 2019https://github.com/nodejs/node/pull/28788#issuecomment-515796500
@Trotthttps://github.com/Trott
Please reload this pagehttps://github.com/nodejs/node/pull/28788
https://github.com/jasnell
jasnellhttps://github.com/jasnell
Jul 29, 2019 https://github.com/nodejs/node/pull/28788#pullrequestreview-267856238
View reviewed changes https://github.com/nodejs/node/pull/28788/files/14d4ad0de613ea440d6a0cae1f4f721c5144ac4f
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
Aug 5, 2019https://github.com/nodejs/node/pull/28788#issuecomment-518390909
https://ci.nodejs.org/job/node-test-pull-request/24849/https://ci.nodejs.org/job/node-test-pull-request/24849/
Please reload this pagehttps://github.com/nodejs/node/pull/28788
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
Aug 6, 2019https://github.com/nodejs/node/pull/28788#issuecomment-518489329
https://ci.nodejs.org/job/node-test-pull-request/24856/https://ci.nodejs.org/job/node-test-pull-request/24856/
Please reload this pagehttps://github.com/nodejs/node/pull/28788
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
Aug 6, 2019https://github.com/nodejs/node/pull/28788#issuecomment-518522004
https://ci.nodejs.org/job/node-test-pull-request/24858/https://ci.nodejs.org/job/node-test-pull-request/24858/
Please reload this pagehttps://github.com/nodejs/node/pull/28788
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
Aug 7, 2019https://github.com/nodejs/node/pull/28788#issuecomment-518912180
https://ci.nodejs.org/job/node-test-pull-request/24873/https://ci.nodejs.org/job/node-test-pull-request/24873/
Please reload this pagehttps://github.com/nodejs/node/pull/28788
https://github.com/Trott
Trotthttps://github.com/Trott
Aug 7, 2019https://github.com/nodejs/node/pull/28788#issuecomment-518942582
Please reload this pagehttps://github.com/nodejs/node/pull/28788
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
Aug 7, 2019https://github.com/nodejs/node/pull/28788#issuecomment-519085088
Please reload this pagehttps://github.com/nodejs/node/pull/28788
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
Aug 17, 2019https://github.com/nodejs/node/pull/28788#issuecomment-522274049
Please reload this pagehttps://github.com/nodejs/node/pull/28788
#29190https://github.com/nodejs/node/pull/29190
Please reload this pagehttps://github.com/nodejs/node/pull/28788
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
Aug 17, 2019https://github.com/nodejs/node/pull/28788#event-2564170899
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
August 17, 2019 22:08https://github.com/nodejs/node/pull/28788#event-2564170918
addaleaxhttps://github.com/addaleax
Aug 17, 2019 https://github.com/nodejs/node/pull/28788#ref-commit-4d2821f
https://github.com/addaleax
worker: fix crash when SharedArrayBuffer outlives creating threadhttps://github.com/addaleax/node/commit/4d2821f48b24916d32b02437c6153849071483d0
4d2821fhttps://github.com/addaleax/node/commit/4d2821f48b24916d32b02437c6153849071483d0
nodejs#28788https://github.com/nodejs/node/pull/28788
nodejs#28777https://github.com/nodejs/node/issues/28777
nodejs#28773https://github.com/nodejs/node/issues/28773
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
Aug 17, 2019 https://github.com/nodejs/node/pull/28788#ref-pullrequest-481931305
worker: fix crash when SharedArrayBuffer outlives creating thread #29190 https://github.com/nodejs/node/pull/29190
addaleaxhttps://github.com/addaleax
Aug 19, 2019 https://github.com/nodejs/node/pull/28788#ref-commit-119c4cc
https://github.com/addaleax
worker: fix crash when SharedArrayBuffer outlives creating threadhttps://github.com/nodejs/node/commit/119c4ccf0ef2addc84fd638004a631f55c7aefc9
119c4cchttps://github.com/nodejs/node/commit/119c4ccf0ef2addc84fd638004a631f55c7aefc9
#28788https://github.com/nodejs/node/pull/28788
#28777https://github.com/nodejs/node/issues/28777
#28773https://github.com/nodejs/node/issues/28773
#29190https://github.com/nodejs/node/pull/29190
targoshttps://github.com/targos
Aug 20, 2019 https://github.com/nodejs/node/pull/28788#ref-commit-d4e397a
https://github.com/addaleax
https://github.com/targos
worker: fix crash when SharedArrayBuffer outlives creating threadhttps://github.com/nodejs/node/commit/d4e397a90047b6f9f973c4c5e33dae4b59960400
d4e397ahttps://github.com/nodejs/node/commit/d4e397a90047b6f9f973c4c5e33dae4b59960400
#28788https://github.com/nodejs/node/pull/28788
#28777https://github.com/nodejs/node/issues/28777
#28773https://github.com/nodejs/node/issues/28773
#29190https://github.com/nodejs/node/pull/29190
https://github.com/pancaspe87
pancaspe87https://github.com/pancaspe87
Jul 1, 2025 https://github.com/nodejs/node/pull/28788#ref-pullrequest-3190671386
Add rimraf to integration-test devDeps atlassian-labs/atlaspack#662 https://github.com/atlassian-labs/atlaspack/pull/662
https://github.co/hiddenchars
https://github.com/nodejs/node/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F28788
https://github.com/jasnell
jasnell https://github.com/jasnell
https://github.com/nodejs/node/pull/28788/files/14d4ad0de613ea440d6a0cae1f4f721c5144ac4f
https://github.com/Trott
Trott https://github.com/Trott
https://github.com/nodejs/node/pull/28788/files/446d7c59e6afad2702cf094d209c57d9bd6e918b
https://github.com/cjihrig
cjihrig https://github.com/cjihrig
https://github.com/nodejs/node/pull/28788/files/14d4ad0de613ea440d6a0cae1f4f721c5144ac4f
c++ https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Ac%2B%2B
worker https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aworker
segfault when using SharedArrayBuffer from an unrefed worker thread https://github.com/nodejs/node/issues/28777
Access Violation https://github.com/nodejs/node/issues/28773
Please reload this pagehttps://github.com/nodejs/node/pull/28788
https://github.com/addaleax
https://github.com/nodejs-github-bot
https://github.com/Trott
https://github.com/jasnell
https://github.com/cjihrig
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.