René's URL Explorer Experiment


Title: [x] fs: don't emit open after destroy by ronag · Pull Request #28765 · nodejs/node · GitHub

Open Graph Title: [x] fs: don't emit open after destroy by ronag · Pull Request #28765 · nodejs/node

X Title: [x] fs: don't emit open after destroy by ronag · Pull Request #28765 · nodejs/node

Description: Node.js JavaScript runtime ✨🐢🚀✨. Contribute to nodejs/node development by creating an account on GitHub.

Open Graph Description: Not perfect but still better than it was. Refs: #23133 Checklist make -j4 test (UNIX), or vcbuild test (Windows) passes tests and/or benchmarks are included documentation is changed or added ...

X Description: Not perfect but still better than it was. Refs: #23133 Checklist make -j4 test (UNIX), or vcbuild test (Windows) passes tests and/or benchmarks are included documentation is changed or added ...

Opengraph URL: https://github.com/nodejs/node/pull/28765

X: @github

direct link

Domain: github.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:f7af329c-b554-9690-67e9-908506169970
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idAC8E:F87E9:5EB5DC:802E19:6A51EBEA
html-safe-noncebd02d067df00dbb4298644fef8fb32f14ea88531ed395f83d0bcd2da45a03779
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJBQzhFOkY4N0U5OjVFQjVEQzo4MDJFMTk6NkE1MUVCRUEiLCJ2aXNpdG9yX2lkIjoiNDQ1MTk1NjE3MzU4Nzk5OTcyMiIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmac3cb5e3f2eedb16b12bd949dc2a32d13e5ae627049215d389fdaa5929c4499d8d
hovercard-subject-tagpull_request:299352326
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/28765/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/e10e15f8ae5bbe41e3ca80e918531c536c468034eb57adc882ddc1bb414cbb59/nodejs/node/pull/28765
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/e10e15f8ae5bbe41e3ca80e918531c536c468034eb57adc882ddc1bb414cbb59/nodejs/node/pull/28765
og:image:altNot perfect but still better than it was. Refs: #23133 Checklist make -j4 test (UNIX), or vcbuild test (Windows) passes tests and/or benchmarks are included documentation is changed or added ...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernameronag
hostnamegithub.com
expected-hostnamegithub.com
Noneb9a586c06a05a7a86fc7e3f4dbd03e42f6869085879aa184aa6369456dbd50fb
turbo-cache-controlno-cache
go-importgithub.com/nodejs/node git https://github.com/nodejs/node.git
octolytics-dimension-user_id9950313
octolytics-dimension-user_loginnodejs
octolytics-dimension-repository_id27193779
octolytics-dimension-repository_nwonodejs/node
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id27193779
octolytics-dimension-repository_network_root_nwonodejs/node
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release7aed05249554b889eb33d002851a973eebcc7e91
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/nodejs/node/pull/28765#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F28765
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub Copilot appDirect agents from issue to mergehttps://github.com/features/ai/github-app
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
View all resourceshttps://github.com/resources
GitHub SponsorsFund open source developershttps://github.com/open-source/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/open-source/accelerator
GitHub Starshttps://stars.github.com
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F28765
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode
Reloadhttps://github.com/nodejs/node/pull/28765
Reloadhttps://github.com/nodejs/node/pull/28765
Reloadhttps://github.com/nodejs/node/pull/28765
Please reload this pagehttps://github.com/nodejs/node/pull/28765
nodejs https://github.com/nodejs
nodehttps://github.com/nodejs/node
Please reload this pagehttps://github.com/nodejs/node/pull/28765
Notifications https://github.com/login?return_to=%2Fnodejs%2Fnode
Fork 36.2k https://github.com/login?return_to=%2Fnodejs%2Fnode
Star 118k https://github.com/login?return_to=%2Fnodejs%2Fnode
Code https://github.com/nodejs/node
Issues 1.4k https://github.com/nodejs/node/issues
Pull requests 983 https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects https://github.com/nodejs/node/projects
Security and quality 0 https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
Code https://github.com/nodejs/node
Issues https://github.com/nodejs/node/issues
Pull requests https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects https://github.com/nodejs/node/projects
Security and quality https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
ronaghttps://github.com/ronag
nodejs:masterhttps://github.com/nodejs/node/tree/master
nxtedition:fix-fs-open-destroyhttps://github.com/nxtedition/node/tree/fix-fs-open-destroy
Conversationhttps://github.com/nodejs/node/pull/28765
Commits1 (1)https://github.com/nodejs/node/pull/28765/commits
Checkshttps://github.com/nodejs/node/pull/28765/checks
Files changedhttps://github.com/nodejs/node/pull/28765/files
[x] fs: don't emit open after destroyhttps://github.com/nodejs/node/pull/28765#top
ronaghttps://github.com/ronag
nodejs:masterhttps://github.com/nodejs/node/tree/master
nxtedition:fix-fs-open-destroyhttps://github.com/nxtedition/node/tree/fix-fs-open-destroy
https://github.com/ronag
ronaghttps://github.com/ronag
Jul 19, 2019https://github.com/nodejs/node/pull/28765#issue-470347658
Please reload this pagehttps://github.com/nodejs/node/pull/28765
#23133https://github.com/nodejs/node/issues/23133
commit guidelineshttps://github.com/nodejs/node/blob/master/doc/guides/contributing/pull-requests.md#commit-message-guidelines
Please reload this pagehttps://github.com/nodejs/node/pull/28765
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
fs https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Afs
Jul 19, 2019https://github.com/nodejs/node/pull/28765#event-2495973207
https://github.com/ronag
ronaghttps://github.com/ronag
force-pushedhttps://github.com/nodejs/node/compare/d3fdc9b30ca82d889f8b985354a57164969778cb..ff9b6fce16348d32435cc6957d800258f280b374
d3fdc9bhttps://github.com/nodejs/node/commit/d3fdc9b30ca82d889f8b985354a57164969778cb
ff9b6fchttps://github.com/nodejs/node/commit/ff9b6fce16348d32435cc6957d800258f280b374
Compare https://github.com/nodejs/node/compare/d3fdc9b30ca82d889f8b985354a57164969778cb..ff9b6fce16348d32435cc6957d800258f280b374
July 19, 2019 14:21https://github.com/nodejs/node/pull/28765#event-2495998950
https://github.com/mscdex
mscdexhttps://github.com/mscdex
Jul 19, 2019 https://github.com/nodejs/node/pull/28765#pullrequestreview-264253175
View reviewed changes https://github.com/nodejs/node/pull/28765/files
lib/internal/fs/streams.jshttps://github.com/nodejs/node/pull/28765/files#diff-ae08fbeb399934340e8c17e06303e19de6caa7fc1ce2d9ed8db7c7c88d4c4b3b
Please reload this pagehttps://github.com/nodejs/node/pull/28765
https://github.com/ronag
ronaghttps://github.com/ronag
force-pushedhttps://github.com/nodejs/node/compare/f404a6ade9b3b145fe6f2c4ca68828e346d35d37..e7a8e22f5c05047cc800aeb4ae74cd1fded96b1c
f404a6ahttps://github.com/nodejs/node/commit/f404a6ade9b3b145fe6f2c4ca68828e346d35d37
e7a8e22https://github.com/nodejs/node/commit/e7a8e22f5c05047cc800aeb4ae74cd1fded96b1c
Compare https://github.com/nodejs/node/compare/f404a6ade9b3b145fe6f2c4ca68828e346d35d37..e7a8e22f5c05047cc800aeb4ae74cd1fded96b1c
July 19, 2019 17:51https://github.com/nodejs/node/pull/28765#event-2496558107
https://github.com/ronag
ronaghttps://github.com/ronag
Jul 19, 2019https://github.com/nodejs/node/pull/28765#issuecomment-513318694
Please reload this pagehttps://github.com/nodejs/node/pull/28765
https://github.com/ronag
fs: don't emit open after destroyhttps://github.com/nodejs/node/pull/28765/commits/281772e289fb4990d5a1ada4c33fe328f2845b98
281772ehttps://github.com/nodejs/node/pull/28765/commits/281772e289fb4990d5a1ada4c33fe328f2845b98
https://github.com/ronag
ronaghttps://github.com/ronag
force-pushedhttps://github.com/nodejs/node/compare/e7a8e22f5c05047cc800aeb4ae74cd1fded96b1c..281772e289fb4990d5a1ada4c33fe328f2845b98
e7a8e22https://github.com/nodejs/node/commit/e7a8e22f5c05047cc800aeb4ae74cd1fded96b1c
281772ehttps://github.com/nodejs/node/commit/281772e289fb4990d5a1ada4c33fe328f2845b98
Compare https://github.com/nodejs/node/compare/e7a8e22f5c05047cc800aeb4ae74cd1fded96b1c..281772e289fb4990d5a1ada4c33fe328f2845b98
July 19, 2019 17:52https://github.com/nodejs/node/pull/28765#event-2496560382
https://github.com/Trott
Trotthttps://github.com/Trott
Jul 22, 2019https://github.com/nodejs/node/pull/28765#issuecomment-513941327
Please reload this pagehttps://github.com/nodejs/node/pull/28765
https://github.com/jasnell
jasnellhttps://github.com/jasnell
semver-major https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Asemver-major
Jul 29, 2019https://github.com/nodejs/node/pull/28765#event-2516893386
https://github.com/jasnell
jasnellhttps://github.com/jasnell
Jul 29, 2019 https://github.com/nodejs/node/pull/28765#pullrequestreview-267859750
View reviewed changes https://github.com/nodejs/node/pull/28765/files/281772e289fb4990d5a1ada4c33fe328f2845b98
https://github.com/trivikr
trivikrhttps://github.com/trivikr
mscdexhttps://github.com/mscdex
July 29, 2019 20:07https://github.com/nodejs/node/pull/28765#event-2517668610
https://github.com/ronag
ronaghttps://github.com/ronag
Aug 2, 2019https://github.com/nodejs/node/pull/28765#issuecomment-517572216
@Trotthttps://github.com/Trott
Please reload this pagehttps://github.com/nodejs/node/pull/28765
https://github.com/Trott
Trotthttps://github.com/Trott
Aug 2, 2019https://github.com/nodejs/node/pull/28765#issuecomment-517574228
@Trotthttps://github.com/Trott
standard-things/esm#821https://github.com/standard-things/esm/issues/821
Please reload this pagehttps://github.com/nodejs/node/pull/28765
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
Aug 2, 2019https://github.com/nodejs/node/pull/28765#issuecomment-517574484
https://ci.nodejs.org/job/node-test-pull-request/24824/https://ci.nodejs.org/job/node-test-pull-request/24824/
Please reload this pagehttps://github.com/nodejs/node/pull/28765
stream: cleanup #29000 https://github.com/nodejs/node/issues/29000
stream: event contract #29005 https://github.com/nodejs/node/issues/29005
https://github.com/ronag
ronaghttps://github.com/ronag
Aug 25, 2019https://github.com/nodejs/node/pull/28765#issuecomment-524644393
Please reload this pagehttps://github.com/nodejs/node/pull/28765
nxtedition#2https://github.com/nxtedition/node/pull/2
Please reload this pagehttps://github.com/nodejs/node/pull/28765
https://github.com/ronag
ronaghttps://github.com/ronag
Aug 28, 2019https://github.com/nodejs/node/pull/28765#issuecomment-525673052
Please reload this pagehttps://github.com/nodejs/node/pull/28765
Please reload this pagehttps://github.com/nodejs/node/pull/28765
https://github.com/ronag
ronaghttps://github.com/ronag
Aug 28, 2019https://github.com/nodejs/node/pull/28765#event-2589923315
https://github.com/ronag
ronaghttps://github.com/ronag
Aug 28, 2019https://github.com/nodejs/node/pull/28765#event-2589924762
https://github.com/fsouza
fsouzahttps://github.com/fsouza
Nov 19, 2019 https://github.com/nodejs/node/pull/28765#ref-issue-525206607
Option for limiting the number of workers? nexe/resolve-dependencies#1 https://github.com/nexe/resolve-dependencies/issues/1
https://github.co/hiddenchars
https://github.com/nodejs/node/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F28765
https://github.com/jasnell
jasnell https://github.com/jasnell
https://github.com/nodejs/node/pull/28765/files/281772e289fb4990d5a1ada4c33fe328f2845b98
https://github.com/mscdex
mscdex https://github.com/mscdex
fs https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Afs
semver-major https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Asemver-major
Please reload this pagehttps://github.com/nodejs/node/pull/28765
https://github.com/ronag
https://github.com/Trott
https://github.com/nodejs-github-bot
https://github.com/mscdex
https://github.com/jasnell
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.