| route-pattern | /_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format) |
| route-controller | voltron_pull_requests_fragments |
| route-action | pull_request_layout |
| fetch-nonce | v2:dbfd7d72-01b1-f170-e50d-2234fb8d55b5 |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | E0DC:141FAF:50CC5DF:70EC00B:6A4F7C3A |
| html-safe-nonce | 2633f120b14c000a3421c174d83ba692348d5293f14f953bbb23d40bfecf7cc5 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJFMERDOjE0MUZBRjo1MENDNURGOjcwRUMwMEI6NkE0RjdDM0EiLCJ2aXNpdG9yX2lkIjoiNjc1NjIzNjc4MTA3MzQzMTYxMCIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9 |
| visitor-hmac | 8dd9b008608c754a9b707921e1edc19eacaf3d4eff2f2e65d5ad8b582ff69ace |
| hovercard-subject-tag | pull_request:299073454 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///voltron/pull_requests_fragments/pull_request_layout |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/28756/pull_request_layout |
| twitter:image | https://opengraph.githubassets.com/7836dd61e437af2adcd525d6826054fc5125b4364ea264aa65e2549e6a8cc642/nodejs/node/pull/28756 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/7836dd61e437af2adcd525d6826054fc5125b4364ea264aa65e2549e6a8cc642/nodejs/node/pull/28756 |
| og:image:alt | Fixes: #28741
Checklist
make -j4 test (UNIX), or vcbuild test (Windows) passes
commit message follows commit guidelines |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | eugeneo |
| hostname | github.com |
| expected-hostname | github.com |
| None | b92d11c0aa4a77d54ef4af1078b6a15fb5a70a215b30c4ecf28889d5a8e656d9 |
| turbo-cache-control | no-cache |
| go-import | github.com/nodejs/node git https://github.com/nodejs/node.git |
| octolytics-dimension-user_id | 9950313 |
| octolytics-dimension-user_login | nodejs |
| octolytics-dimension-repository_id | 27193779 |
| octolytics-dimension-repository_nwo | nodejs/node |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 27193779 |
| octolytics-dimension-repository_network_root_nwo | nodejs/node |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 4b249b445842943ed31549e027f57a8ade9881ed |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| Skip to content | https://github.com/nodejs/node/pull/28756#start-of-content |
|
| https://github.com/ |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F28756 |
| GitHub CopilotWrite better code with AI | https://github.com/features/copilot |
| GitHub Copilot appDirect agents from issue to merge | https://github.com/features/ai/github-app |
| MCP RegistryNewIntegrate external tools | https://github.com/mcp |
| ActionsAutomate any workflow | https://github.com/features/actions |
| CodespacesInstant dev environments | https://github.com/features/codespaces |
| IssuesPlan and track work | https://github.com/features/issues |
| Code ReviewManage code changes | https://github.com/features/code-review |
| GitHub Advanced SecurityFind and fix vulnerabilities | https://github.com/security/advanced-security |
| Code securitySecure your code as you build | https://github.com/security/advanced-security/code-security |
| Secret protectionStop leaks before they start | https://github.com/security/advanced-security/secret-protection |
| Why GitHub | https://github.com/why-github |
| Documentation | https://docs.github.com |
| Blog | https://github.blog |
| Changelog | https://github.blog/changelog |
| Marketplace | https://github.com/marketplace |
| View all features | https://github.com/features |
| Enterprises | https://github.com/enterprise |
| Small and medium teams | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| App Modernization | https://github.com/solutions/use-case/app-modernization |
| DevSecOps | https://github.com/solutions/use-case/devsecops |
| DevOps | https://github.com/solutions/use-case/devops |
| CI/CD | https://github.com/solutions/use-case/ci-cd |
| View all use cases | https://github.com/solutions/use-case |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| View all industries | https://github.com/solutions/industry |
| View all solutions | https://github.com/solutions |
| AI | https://github.com/resources/articles?topic=ai |
| Software Development | https://github.com/resources/articles?topic=software-development |
| DevOps | https://github.com/resources/articles?topic=devops |
| Security | https://github.com/resources/articles?topic=security |
| View all topics | https://github.com/resources/articles |
| Customer stories | https://github.com/customer-stories |
| Events & webinars | https://github.com/resources/events |
| Ebooks & reports | https://github.com/resources/whitepapers |
| Business insights | https://github.com/solutions/executive-insights |
| GitHub Skills | https://skills.github.com |
| Documentation | https://docs.github.com |
| Customer support | https://support.github.com |
| Community forum | https://github.com/orgs/community/discussions |
| Trust center | https://github.com/trust-center |
| Partners | https://github.com/partners |
| View all resources | https://github.com/resources |
| GitHub SponsorsFund open source developers | https://github.com/open-source/sponsors |
| Security Lab | https://securitylab.github.com |
| Maintainer Community | https://maintainers.github.com |
| Accelerator | https://github.com/open-source/accelerator |
| GitHub Stars | https://stars.github.com |
| Archive Program | https://archiveprogram.github.com |
| Topics | https://github.com/topics |
| Trending | https://github.com/trending |
| Collections | https://github.com/collections |
| Enterprise platformAI-powered developer platform | https://github.com/enterprise |
| GitHub Advanced SecurityEnterprise-grade security features | https://github.com/security/advanced-security |
| Copilot for BusinessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/enterprise/premium-support |
| Pricing | https://github.com/pricing |
| Search syntax tips | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
| documentation | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F28756 |
|
Sign up
| https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode |
| Reload | https://github.com/nodejs/node/pull/28756 |
| Reload | https://github.com/nodejs/node/pull/28756 |
| Reload | https://github.com/nodejs/node/pull/28756 |
| Please reload this page | https://github.com/nodejs/node/pull/28756 |
|
nodejs
| https://github.com/nodejs |
| node | https://github.com/nodejs/node |
| Please reload this page | https://github.com/nodejs/node/pull/28756 |
|
Notifications
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Fork
36k
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Star
118k
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Code
| https://github.com/nodejs/node |
|
Issues
1.3k
| https://github.com/nodejs/node/issues |
|
Pull requests
973
| https://github.com/nodejs/node/pulls |
|
Actions
| https://github.com/nodejs/node/actions |
|
Projects
| https://github.com/nodejs/node/projects |
|
Security and quality
0
| https://github.com/nodejs/node/security |
|
Insights
| https://github.com/nodejs/node/pulse |
|
Code
| https://github.com/nodejs/node |
|
Issues
| https://github.com/nodejs/node/issues |
|
Pull requests
| https://github.com/nodejs/node/pulls |
|
Actions
| https://github.com/nodejs/node/actions |
|
Projects
| https://github.com/nodejs/node/projects |
|
Security and quality
| https://github.com/nodejs/node/security |
|
Insights
| https://github.com/nodejs/node/pulse |
| eugeneo | https://github.com/eugeneo |
| nodejs:master | https://github.com/nodejs/node/tree/master |
| Conversation | https://github.com/nodejs/node/pull/28756 |
| Commits1 (1) | https://github.com/nodejs/node/pull/28756/commits |
| Checks | https://github.com/nodejs/node/pull/28756/checks |
| Files changed | https://github.com/nodejs/node/pull/28756/files |
| inspector: do not spin-wait while waiting for the initial connection | https://github.com/nodejs/node/pull/28756#top |
| eugeneo | https://github.com/eugeneo |
| nodejs:master | https://github.com/nodejs/node/tree/master |
|
| https://github.com/eugeneo |
| eugeneo | https://github.com/eugeneo |
| Jul 18, 2019 | https://github.com/nodejs/node/pull/28756#issue-469967181 |
| #28741 | https://github.com/nodejs/node/issues/28741 |
| commit guidelines | https://github.com/nodejs/node/blob/master/doc/guides/contributing/pull-requests.md#commit-message-guidelines |
| Please reload this page | https://github.com/nodejs/node/pull/28756 |
|
| https://github.com/eugeneo |
| inspector: do not spin-wait while waiting for the initial connection | https://github.com/nodejs/node/pull/28756/commits/c13393d23e894bfcaef5ce0529bfe48d840ea376 |
| c13393d | https://github.com/nodejs/node/pull/28756/commits/c13393d23e894bfcaef5ce0529bfe48d840ea376 |
| #28741 | https://github.com/nodejs/node/issues/28741 |
| https://github.com/nodejs-github-bot |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
|
c++
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Ac%2B%2B |
|
inspector
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Ainspector |
| Jul 18, 2019 | https://github.com/nodejs/node/pull/28756#event-2493889694 |
| https://github.com/eugeneo |
| eugeneo | https://github.com/eugeneo |
| alexkozy | https://github.com/alexkozy |
| July 18, 2019 20:10 | https://github.com/nodejs/node/pull/28756#event-2493889883 |
| https://github.com/bnoordhuis |
| bnoordhuis | https://github.com/bnoordhuis |
|
Jul 18, 2019
| https://github.com/nodejs/node/pull/28756#pullrequestreview-263896899 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/28756/files/c13393d23e894bfcaef5ce0529bfe48d840ea376 |
| https://github.com/nodejs-github-bot |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
| Jul 18, 2019 | https://github.com/nodejs/node/pull/28756#issuecomment-512985608 |
| https://ci.nodejs.org/job/node-test-pull-request/24545/ | https://ci.nodejs.org/job/node-test-pull-request/24545/ |
| Please reload this page | https://github.com/nodejs/node/pull/28756 |
| https://github.com/alexkozy |
| alexkozy | https://github.com/alexkozy |
|
Jul 18, 2019
| https://github.com/nodejs/node/pull/28756#pullrequestreview-263917954 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/28756/files/c13393d23e894bfcaef5ce0529bfe48d840ea376 |
| alexkozy | https://github.com/alexkozy |
| https://github.com/nodejs/node/pull/28756#pullrequestreview-263917954 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/28756 |
| https://github.com/cjihrig |
| cjihrig | https://github.com/cjihrig |
|
Jul 18, 2019
| https://github.com/nodejs/node/pull/28756#pullrequestreview-263918298 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/28756/files/c13393d23e894bfcaef5ce0529bfe48d840ea376 |
| https://github.com/nodejs-github-bot |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
| Jul 18, 2019 | https://github.com/nodejs/node/pull/28756#issuecomment-513001597 |
| https://ci.nodejs.org/job/node-test-pull-request/24547/ | https://ci.nodejs.org/job/node-test-pull-request/24547/ |
| Please reload this page | https://github.com/nodejs/node/pull/28756 |
| https://github.com/pavelfeldman |
| pavelfeldman | https://github.com/pavelfeldman |
| Jul 18, 2019 | https://github.com/nodejs/node/pull/28756#issuecomment-513006623 |
| Please reload this page | https://github.com/nodejs/node/pull/28756 |
| https://github.com/antsmartian |
| antsmartian | https://github.com/antsmartian |
|
Jul 19, 2019
| https://github.com/nodejs/node/pull/28756#pullrequestreview-263972506 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/28756/files/c13393d23e894bfcaef5ce0529bfe48d840ea376 |
| https://github.com/trivikr |
| trivikr | https://github.com/trivikr |
|
Jul 19, 2019
| https://github.com/nodejs/node/pull/28756#pullrequestreview-263981416 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/28756/files/c13393d23e894bfcaef5ce0529bfe48d840ea376 |
| https://github.com/addaleax |
| addaleax | https://github.com/addaleax |
|
Jul 20, 2019
| https://github.com/nodejs/node/pull/28756#pullrequestreview-264506003 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/28756/files/c13393d23e894bfcaef5ce0529bfe48d840ea376 |
| https://github.com/Trott |
| Trott | https://github.com/Trott |
| Jul 20, 2019 | https://github.com/nodejs/node/pull/28756#issuecomment-513501940 |
| 49144ab | https://github.com/nodejs/node/commit/49144ab64d3c5810f70585c2ccb0c90539fec116 |
| Please reload this page | https://github.com/nodejs/node/pull/28756 |
| https://github.com/Trott |
| Trott | https://github.com/Trott |
| Jul 20, 2019 | https://github.com/nodejs/node/pull/28756#event-2497757116 |
| Trott | https://github.com/Trott |
|
Jul 20, 2019
| https://github.com/nodejs/node/pull/28756#ref-commit-49144ab |
|
| https://github.com/eugeneo |
|
| https://github.com/Trott |
| inspector: do not spin-wait while waiting for the initial connection | https://github.com/Trott/io.js/commit/49144ab64d3c5810f70585c2ccb0c90539fec116 |
| 49144ab | https://github.com/Trott/io.js/commit/49144ab64d3c5810f70585c2ccb0c90539fec116 |
| nodejs#28741 | https://github.com/nodejs/node/issues/28741 |
| nodejs#28756 | https://github.com/nodejs/node/pull/28756 |
| https://github.com/targos |
| targos | https://github.com/targos |
|
Jul 21, 2019
| https://github.com/nodejs/node/pull/28756#ref-issue-391474332 |
|
Start node in inspect mode will cause CPU consumption 100%
#25077
| https://github.com/nodejs/node/issues/25077 |
| targos | https://github.com/targos |
|
Jul 22, 2019
| https://github.com/nodejs/node/pull/28756#ref-commit-7b0b06d |
|
| https://github.com/eugeneo |
|
| https://github.com/targos |
| inspector: do not spin-wait while waiting for the initial connection | https://github.com/nodejs/node/commit/7b0b06d735c90c41900efe5948a0aee6c0a745df |
| 7b0b06d | https://github.com/nodejs/node/commit/7b0b06d735c90c41900efe5948a0aee6c0a745df |
| #28741 | https://github.com/nodejs/node/issues/28741 |
| #28756 | https://github.com/nodejs/node/pull/28756 |
|
v12.7.0 release proposal
#28816
| https://github.com/nodejs/node/pull/28816 |
|
v12.7.0 release proposal
#28817
| https://github.com/nodejs/node/pull/28817 |
| gntem | https://github.com/gntem |
|
Jul 27, 2019
| https://github.com/nodejs/node/pull/28756#ref-commit-ec1bd00 |
|
| https://github.com/eugeneo |
|
| https://github.com/gntem |
| inspector: do not spin-wait while waiting for the initial connection | https://github.com/gntem/node/commit/ec1bd00ac31a88563bb1cb141e956a5dd657891d |
| ec1bd00 | https://github.com/gntem/node/commit/ec1bd00ac31a88563bb1cb141e956a5dd657891d |
| nodejs#28741 | https://github.com/nodejs/node/issues/28741 |
| nodejs#28756 | https://github.com/nodejs/node/pull/28756 |
| vikashk1 | https://github.com/vikashk1 |
|
Aug 13, 2019
| https://github.com/nodejs/node/pull/28756#ref-commit-9af17ad |
|
| https://github.com/vikashk1 |
| Please ignore this msg ( | https://github.com/vikashk1/node/commit/9af17ad05c8161db7f52de5fd3331a94857e33fc |
| #1 | https://github.com/vikashk1/node/pull/1 |
| ) | https://github.com/vikashk1/node/commit/9af17ad05c8161db7f52de5fd3331a94857e33fc |
| 9af17ad | https://github.com/vikashk1/node/commit/9af17ad05c8161db7f52de5fd3331a94857e33fc |
| https://github.co/hiddenchars |
| https://github.com/nodejs/node/pull/{{ revealButtonHref }} |
| Sign up for free | https://github.com/join?source=comment-repo |
| Sign in to comment | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F28756 |
|
| https://github.com/bnoordhuis |
|
bnoordhuis
| https://github.com/bnoordhuis |
|
| https://github.com/nodejs/node/pull/28756/files/c13393d23e894bfcaef5ce0529bfe48d840ea376 |
|
| https://github.com/addaleax |
|
addaleax
| https://github.com/addaleax |
|
| https://github.com/nodejs/node/pull/28756/files/c13393d23e894bfcaef5ce0529bfe48d840ea376 |
|
| https://github.com/cjihrig |
|
cjihrig
| https://github.com/cjihrig |
|
| https://github.com/nodejs/node/pull/28756/files/c13393d23e894bfcaef5ce0529bfe48d840ea376 |
|
| https://github.com/trivikr |
|
trivikr
| https://github.com/trivikr |
|
| https://github.com/nodejs/node/pull/28756/files/c13393d23e894bfcaef5ce0529bfe48d840ea376 |
|
| https://github.com/alexkozy |
|
alexkozy
| https://github.com/alexkozy |
|
| https://github.com/nodejs/node/pull/28756/files/c13393d23e894bfcaef5ce0529bfe48d840ea376 |
|
| https://github.com/antsmartian |
|
antsmartian
| https://github.com/antsmartian |
|
| https://github.com/nodejs/node/pull/28756/files/c13393d23e894bfcaef5ce0529bfe48d840ea376 |
|
c++
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Ac%2B%2B |
|
inspector
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Ainspector |
|
node --inspect-brk spins CPU at 100%
| https://github.com/nodejs/node/issues/28741 |
| Please reload this page | https://github.com/nodejs/node/pull/28756 |
|
| https://github.com/eugeneo |
|
| https://github.com/nodejs-github-bot |
|
| https://github.com/pavelfeldman |
|
| https://github.com/Trott |
|
| https://github.com/bnoordhuis |
|
| https://github.com/alexkozy |
|
| https://github.com/addaleax |
|
| https://github.com/antsmartian |
|
| https://github.com/cjihrig |
|
| https://github.com/trivikr |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |