René's URL Explorer Experiment


Title: stream: eos on closed by ronag · Pull Request #28748 · nodejs/node · GitHub

Open Graph Title: stream: eos on closed by ronag · Pull Request #28748 · nodejs/node

X Title: stream: eos on closed by ronag · Pull Request #28748 · nodejs/node

Description: Node.js JavaScript runtime ✨🐢🚀✨. Contribute to nodejs/node development by creating an account on GitHub.

Open Graph Description: stream.finished should be invoked if stream is already closed/destroyed. Currently there is a potential deadlock depending on when stream.finished is called. For writable premature close is close b...

X Description: stream.finished should be invoked if stream is already closed/destroyed. Currently there is a potential deadlock depending on when stream.finished is called. For writable premature close is close b...

Opengraph URL: https://github.com/nodejs/node/pull/28748

X: @github

direct link

Domain: github.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:d04e383e-df2b-eef2-22c7-462c08ea71c6
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idE408:1EE1:88227EC:BFA2734:6A50F750
html-safe-nonce4eedd757ca3a5399e4e19750dcaeae4174fa5de8d74d51e7ead198262cb1705a
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJFNDA4OjFFRTE6ODgyMjdFQzpCRkEyNzM0OjZBNTBGNzUwIiwidmlzaXRvcl9pZCI6IjE4MjI4OTU1MTIxODI5MTI4NDgiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmac47df4ab97a9bc54a8a3013fc056818610b7e1b3cc8b87f96adb15bed54110f90
hovercard-subject-tagpull_request:298866779
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/28748/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/5f81c13a43a37efe280b9c179e459dfca9aeedb3b8483656acc8a6067b39cc40/nodejs/node/pull/28748
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/5f81c13a43a37efe280b9c179e459dfca9aeedb3b8483656acc8a6067b39cc40/nodejs/node/pull/28748
og:image:altstream.finished should be invoked if stream is already closed/destroyed. Currently there is a potential deadlock depending on when stream.finished is called. For writable premature close is close b...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernameronag
hostnamegithub.com
expected-hostnamegithub.com
None5266e58c17a510c403505cc811606465e90a881d2007ee7df1c4800d5c659838
turbo-cache-controlno-cache
go-importgithub.com/nodejs/node git https://github.com/nodejs/node.git
octolytics-dimension-user_id9950313
octolytics-dimension-user_loginnodejs
octolytics-dimension-repository_id27193779
octolytics-dimension-repository_nwonodejs/node
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id27193779
octolytics-dimension-repository_network_root_nwonodejs/node
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release8d836581d020676cc0ef4a83cd2fe17e4af02c3d
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/nodejs/node/pull/28748#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F28748
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub Copilot appDirect agents from issue to mergehttps://github.com/features/ai/github-app
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
View all resourceshttps://github.com/resources
GitHub SponsorsFund open source developershttps://github.com/open-source/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/open-source/accelerator
GitHub Starshttps://stars.github.com
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F28748
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode
Reloadhttps://github.com/nodejs/node/pull/28748
Reloadhttps://github.com/nodejs/node/pull/28748
Reloadhttps://github.com/nodejs/node/pull/28748
Please reload this pagehttps://github.com/nodejs/node/pull/28748
nodejs https://github.com/nodejs
nodehttps://github.com/nodejs/node
Please reload this pagehttps://github.com/nodejs/node/pull/28748
Notifications https://github.com/login?return_to=%2Fnodejs%2Fnode
Fork 36.1k https://github.com/login?return_to=%2Fnodejs%2Fnode
Star 118k https://github.com/login?return_to=%2Fnodejs%2Fnode
Code https://github.com/nodejs/node
Issues 1.4k https://github.com/nodejs/node/issues
Pull requests 979 https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects https://github.com/nodejs/node/projects
Security and quality 0 https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
Code https://github.com/nodejs/node
Issues https://github.com/nodejs/node/issues
Pull requests https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects https://github.com/nodejs/node/projects
Security and quality https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
ronaghttps://github.com/ronag
nodejs:masterhttps://github.com/nodejs/node/tree/master
nxtedition:stream-eos-on-closedhttps://github.com/nxtedition/node/tree/stream-eos-on-closed
Conversationhttps://github.com/nodejs/node/pull/28748
Commits12 (12)https://github.com/nodejs/node/pull/28748/commits
Checkshttps://github.com/nodejs/node/pull/28748/checks
Files changedhttps://github.com/nodejs/node/pull/28748/files
stream: eos on closedhttps://github.com/nodejs/node/pull/28748#top
ronaghttps://github.com/ronag
nodejs:masterhttps://github.com/nodejs/node/tree/master
nxtedition:stream-eos-on-closedhttps://github.com/nxtedition/node/tree/stream-eos-on-closed
https://github.com/ronag
ronaghttps://github.com/ronag
Jul 18, 2019https://github.com/nodejs/node/pull/28748#issue-469711864
Please reload this pagehttps://github.com/nodejs/node/pull/28748
commit guidelineshttps://github.com/nodejs/node/blob/master/doc/guides/contributing/pull-requests.md#commit-message-guidelines
Please reload this pagehttps://github.com/nodejs/node/pull/28748
https://github.com/ronag
ronaghttps://github.com/ronag
force-pushedhttps://github.com/nodejs/node/compare/3c57be4f16c50d6d305b32b682f0b9679ed44073..c9d1e197ff51ebafa89f694883d092170178ce38
3c57be4https://github.com/nodejs/node/commit/3c57be4f16c50d6d305b32b682f0b9679ed44073
c9d1e19https://github.com/nodejs/node/commit/c9d1e197ff51ebafa89f694883d092170178ce38
Compare https://github.com/nodejs/node/compare/3c57be4f16c50d6d305b32b682f0b9679ed44073..c9d1e197ff51ebafa89f694883d092170178ce38
July 22, 2019 06:42https://github.com/nodejs/node/pull/28748#event-2498761960
https://github.com/Trott
Trotthttps://github.com/Trott
Jul 23, 2019https://github.com/nodejs/node/pull/28748#issuecomment-513999192
Please reload this pagehttps://github.com/nodejs/node/pull/28748
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
Jul 23, 2019https://github.com/nodejs/node/pull/28748#issuecomment-513999303
https://ci.nodejs.org/job/node-test-pull-request/24624/https://ci.nodejs.org/job/node-test-pull-request/24624/
Please reload this pagehttps://github.com/nodejs/node/pull/28748
https://github.com/mcollina
mcollinahttps://github.com/mcollina
Jul 23, 2019 https://github.com/nodejs/node/pull/28748#pullrequestreview-265183452
View reviewed changes https://github.com/nodejs/node/pull/28748/files
mcollinahttps://github.com/mcollina
https://github.com/nodejs/node/pull/28748#pullrequestreview-265183452
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/28748
lib/internal/streams/end-of-stream.jshttps://github.com/nodejs/node/pull/28748/files#diff-f355a772a51133f54ef288a365ec05a70b9f3f2e0a2f46f5ba2612e31a62f810
Please reload this pagehttps://github.com/nodejs/node/pull/28748
https://github.com/mcollina
mcollinahttps://github.com/mcollina
Jul 23, 2019 https://github.com/nodejs/node/pull/28748#pullrequestreview-265184319
View reviewed changes https://github.com/nodejs/node/pull/28748/files
lib/internal/streams/end-of-stream.jshttps://github.com/nodejs/node/pull/28748/files#diff-f355a772a51133f54ef288a365ec05a70b9f3f2e0a2f46f5ba2612e31a62f810
Please reload this pagehttps://github.com/nodejs/node/pull/28748
test/parallel/test-stream-eos.jshttps://github.com/nodejs/node/pull/28748/files#diff-285877aa710e94495da6d63e1963bb7a5b6e37aa2ad0d2d6b1c02fa16da0947e
Please reload this pagehttps://github.com/nodejs/node/pull/28748
https://github.com/ronag
ronaghttps://github.com/ronag
Jul 23, 2019 https://github.com/nodejs/node/pull/28748#ref-issue-471528480
stream: finished depends on internal API #28813 https://github.com/nodejs/node/issues/28813
https://github.com/ronag
ronaghttps://github.com/ronag
force-pushedhttps://github.com/nodejs/node/compare/c9d1e197ff51ebafa89f694883d092170178ce38..3816f110bcf40567882a0fe4dae932901d2630b0
c9d1e19https://github.com/nodejs/node/commit/c9d1e197ff51ebafa89f694883d092170178ce38
3816f11https://github.com/nodejs/node/commit/3816f110bcf40567882a0fe4dae932901d2630b0
Compare https://github.com/nodejs/node/compare/c9d1e197ff51ebafa89f694883d092170178ce38..3816f110bcf40567882a0fe4dae932901d2630b0
July 23, 2019 07:30https://github.com/nodejs/node/pull/28748#event-2502060026
https://github.com/ronag
ronaghttps://github.com/ronag
Jul 23, 2019https://github.com/nodejs/node/pull/28748#issuecomment-514090269
@mcollinahttps://github.com/mcollina
Please reload this pagehttps://github.com/nodejs/node/pull/28748
https://github.com/ronag
ronaghttps://github.com/ronag
force-pushedhttps://github.com/nodejs/node/compare/aefe06802aad99250dbb6ba60ed56cbe5b2ef9bc..1588c78a187120fcabaa9410c9fa75d506daff39
aefe068https://github.com/nodejs/node/commit/aefe06802aad99250dbb6ba60ed56cbe5b2ef9bc
1588c78https://github.com/nodejs/node/commit/1588c78a187120fcabaa9410c9fa75d506daff39
Compare https://github.com/nodejs/node/compare/aefe06802aad99250dbb6ba60ed56cbe5b2ef9bc..1588c78a187120fcabaa9410c9fa75d506daff39
July 23, 2019 07:37https://github.com/nodejs/node/pull/28748#event-2502075944
https://github.com/mcollina
mcollinahttps://github.com/mcollina
Jul 23, 2019 https://github.com/nodejs/node/pull/28748#pullrequestreview-265335576
View reviewed changes https://github.com/nodejs/node/pull/28748/files
lib/internal/streams/end-of-stream.jshttps://github.com/nodejs/node/pull/28748/files#diff-f355a772a51133f54ef288a365ec05a70b9f3f2e0a2f46f5ba2612e31a62f810
Please reload this pagehttps://github.com/nodejs/node/pull/28748
https://github.com/mcollina
mcollinahttps://github.com/mcollina
semver-major https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Asemver-major
Jul 23, 2019https://github.com/nodejs/node/pull/28748#event-2502690596
https://github.com/ronag
ronaghttps://github.com/ronag
force-pushedhttps://github.com/nodejs/node/compare/40b4c0b3b3c79818cb1970aab7644ef077d93f4d..39ca23ae861e4703eb70781f739d10237aea82d3
40b4c0bhttps://github.com/nodejs/node/commit/40b4c0b3b3c79818cb1970aab7644ef077d93f4d
39ca23ahttps://github.com/nodejs/node/commit/39ca23ae861e4703eb70781f739d10237aea82d3
Compare https://github.com/nodejs/node/compare/40b4c0b3b3c79818cb1970aab7644ef077d93f4d..39ca23ae861e4703eb70781f739d10237aea82d3
July 24, 2019 09:46https://github.com/nodejs/node/pull/28748#event-2505737300
https://github.com/Fishrock123
Fishrock123https://github.com/Fishrock123
stream https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Astream
Jul 24, 2019https://github.com/nodejs/node/pull/28748#event-2507589887
https://github.com/ronag
ronaghttps://github.com/ronag
Aug 2, 2019https://github.com/nodejs/node/pull/28748#issuecomment-517573224
@benjamingrhttps://github.com/benjamingr
Please reload this pagehttps://github.com/nodejs/node/pull/28748
https://github.com/mcollina
mcollinahttps://github.com/mcollina
Aug 2, 2019 https://github.com/nodejs/node/pull/28748#pullrequestreview-270009720
View reviewed changes https://github.com/nodejs/node/pull/28748/files
mcollinahttps://github.com/mcollina
https://github.com/nodejs/node/pull/28748#pullrequestreview-270009720
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/28748
https://github.com/benjamingr
benjamingrhttps://github.com/benjamingr
Aug 3, 2019 https://github.com/nodejs/node/pull/28748#pullrequestreview-270463562
View reviewed changes https://github.com/nodejs/node/pull/28748/files
https://github.com/mcollina
mcollinahttps://github.com/mcollina
August 3, 2019 16:53https://github.com/nodejs/node/pull/28748#event-2531394581
https://github.com/mcollina
mcollinahttps://github.com/mcollina
Aug 3, 2019https://github.com/nodejs/node/pull/28748#issuecomment-517939064
Please reload this pagehttps://github.com/nodejs/node/pull/28748
https://github.com/ronag
ronaghttps://github.com/ronag
Aug 6, 2019https://github.com/nodejs/node/pull/28748#issuecomment-518589071
@mcollinahttps://github.com/mcollina
Please reload this pagehttps://github.com/nodejs/node/pull/28748
https://github.com/ronag
ronaghttps://github.com/ronag
Aug 6, 2019 https://github.com/nodejs/node/pull/28748#ref-issue-477297321
stream: cleanup #29000 https://github.com/nodejs/node/issues/29000
https://github.com/ronag
ronaghttps://github.com/ronag
Sep 1, 2019 https://github.com/nodejs/node/pull/28748#ref-pullrequest-468735375
stream: eos premature close #28720 https://github.com/nodejs/node/pull/28720
https://github.com/ronag
ronaghttps://github.com/ronag
Sep 1, 2019https://github.com/nodejs/node/pull/28748#issuecomment-526922744
@mcollinahttps://github.com/mcollina
Please reload this pagehttps://github.com/nodejs/node/pull/28748
https://github.com/ronag
ronaghttps://github.com/ronag
Sep 1, 2019https://github.com/nodejs/node/pull/28748#issuecomment-526930595
@Trotthttps://github.com/Trott
Please reload this pagehttps://github.com/nodejs/node/pull/28748
https://github.com/ronag
ronaghttps://github.com/ronag
Sep 1, 2019https://github.com/nodejs/node/pull/28748#issuecomment-526930622
Please reload this pagehttps://github.com/nodejs/node/pull/28748
https://github.com/ronag
ronaghttps://github.com/ronag
Sep 1, 2019 https://github.com/nodejs/node/pull/28748#pullrequestreview-282350758
View reviewed changes https://github.com/nodejs/node/pull/28748/files
lib/internal/streams/end-of-stream.jshttps://github.com/nodejs/node/pull/28748/files#diff-f355a772a51133f54ef288a365ec05a70b9f3f2e0a2f46f5ba2612e31a62f810
ronaghttps://github.com/ronag
Sep 1, 2019https://github.com/nodejs/node/pull/28748#discussion_r319765677
Please reload this pagehttps://github.com/nodejs/node/pull/28748
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/28748
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
Sep 1, 2019https://github.com/nodejs/node/pull/28748#issuecomment-526938964
https://ci.nodejs.org/job/node-test-pull-request/25315/https://ci.nodejs.org/job/node-test-pull-request/25315/
Please reload this pagehttps://github.com/nodejs/node/pull/28748
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
Sep 1, 2019https://github.com/nodejs/node/pull/28748#issuecomment-526940556
https://ci.nodejs.org/job/node-test-pull-request/25317/https://ci.nodejs.org/job/node-test-pull-request/25317/
Please reload this pagehttps://github.com/nodejs/node/pull/28748
https://github.com/mcollina
mcollinahttps://github.com/mcollina
Sep 2, 2019https://github.com/nodejs/node/pull/28748#issuecomment-527169079
Please reload this pagehttps://github.com/nodejs/node/pull/28748
ronaghttps://github.com/ronag
September 2, 2019 16:49https://github.com/nodejs/node/pull/28748#commits-pushed-820074e
https://github.com/ronag
stream: eos on closedhttps://github.com/nodejs/node/pull/28748/commits/820074e0f1294a5974c9fba2658e7ef48cc3f207
820074ehttps://github.com/nodejs/node/pull/28748/commits/820074e0f1294a5974c9fba2658e7ef48cc3f207
https://github.com/ronag
fixup: check ended and finishedhttps://github.com/nodejs/node/pull/28748/commits/729cd0525060e395caa5eb60381b53c3bfed53eb
729cd05https://github.com/nodejs/node/pull/28748/commits/729cd0525060e395caa5eb60381b53c3bfed53eb
https://github.com/ronag
fixup: http response doesn't have destroyed, use aborted insteadhttps://github.com/nodejs/node/pull/28748/commits/e662280a7e9d0867aa7763d90e3921e03c980fac
e662280https://github.com/nodejs/node/pull/28748/commits/e662280a7e9d0867aa7763d90e3921e03c980fac
https://github.com/ronag
fixup: testshttps://github.com/nodejs/node/pull/28748/commits/3ec6ecc3d9da7b6ef8c6a28dfd122d4c9c530d30
3ec6ecchttps://github.com/nodejs/node/pull/28748/commits/3ec6ecc3d9da7b6ef8c6a28dfd122d4c9c530d30
https://github.com/ronag
fixup: more testshttps://github.com/nodejs/node/pull/28748/commits/27a9624ae8e926d3b392359c8e3c44f4e33b1024
27a9624https://github.com/nodejs/node/pull/28748/commits/27a9624ae8e926d3b392359c8e3c44f4e33b1024
https://github.com/ronag
fixup: mergehttps://github.com/nodejs/node/pull/28748/commits/56415908a642e5cf146b3ab1060bad599624c5c1
nodejs#28720https://github.com/nodejs/node/pull/28720
5641590https://github.com/nodejs/node/pull/28748/commits/56415908a642e5cf146b3ab1060bad599624c5c1
https://github.com/ronag
fixup: sligthly simplify and add more testshttps://github.com/nodejs/node/pull/28748/commits/41a692aa7d7e6467300d9191f6ce565fd3c39850
41a692ahttps://github.com/nodejs/node/pull/28748/commits/41a692aa7d7e6467300d9191f6ce565fd3c39850
https://github.com/ronag
fixup: test descriptionshttps://github.com/nodejs/node/pull/28748/commits/3be04545a16f0e344e83fe400749f186d2992c67
3be0454https://github.com/nodejs/node/pull/28748/commits/3be04545a16f0e344e83fe400749f186d2992c67
https://github.com/ronag
fixup: lintinghttps://github.com/nodejs/node/pull/28748/commits/53c04a393cf58100dc1b12b362589b774c28f027
53c04a3https://github.com/nodejs/node/pull/28748/commits/53c04a393cf58100dc1b12b362589b774c28f027
https://github.com/ronag
fixup: merge duplicate test fileshttps://github.com/nodejs/node/pull/28748/commits/e8284ec9b1dabe0525acd96275fb7047fb349737
e8284echttps://github.com/nodejs/node/pull/28748/commits/e8284ec9b1dabe0525acd96275fb7047fb349737
https://github.com/ronag
fixup: comments stylinghttps://github.com/nodejs/node/pull/28748/commits/a4542b755088c00fd54336ebfc1b6059bf856493
a4542b7https://github.com/nodejs/node/pull/28748/commits/a4542b755088c00fd54336ebfc1b6059bf856493
https://github.com/ronag
fixup: typo when merging testshttps://github.com/nodejs/node/pull/28748/commits/9b5a84e3af4758e214991e4ef524d2416abb9669
9b5a84ehttps://github.com/nodejs/node/pull/28748/commits/9b5a84e3af4758e214991e4ef524d2416abb9669
https://github.com/ronag
ronaghttps://github.com/ronag
force-pushedhttps://github.com/nodejs/node/compare/db6eb4f82f297bf1059a492878f99797b891827c..9b5a84e3af4758e214991e4ef524d2416abb9669
db6eb4fhttps://github.com/nodejs/node/commit/db6eb4f82f297bf1059a492878f99797b891827c
9b5a84ehttps://github.com/nodejs/node/commit/9b5a84e3af4758e214991e4ef524d2416abb9669
Compare https://github.com/nodejs/node/compare/db6eb4f82f297bf1059a492878f99797b891827c..9b5a84e3af4758e214991e4ef524d2416abb9669
September 2, 2019 14:52https://github.com/nodejs/node/pull/28748#event-2601336174
https://github.com/ronag
ronaghttps://github.com/ronag
Sep 2, 2019https://github.com/nodejs/node/pull/28748#issuecomment-527175028
Please reload this pagehttps://github.com/nodejs/node/pull/28748
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
Sep 2, 2019https://github.com/nodejs/node/pull/28748#issuecomment-527180314
https://ci.nodejs.org/job/node-test-pull-request/25326/https://ci.nodejs.org/job/node-test-pull-request/25326/
Please reload this pagehttps://github.com/nodejs/node/pull/28748
https://github.com/mcollina
mcollinahttps://github.com/mcollina
Sep 3, 2019https://github.com/nodejs/node/pull/28748#issuecomment-527359985
Please reload this pagehttps://github.com/nodejs/node/pull/28748
https://github.com/mcollina
mcollinahttps://github.com/mcollina
Sep 3, 2019https://github.com/nodejs/node/pull/28748#event-2602699211
mcollinahttps://github.com/mcollina
Sep 3, 2019 https://github.com/nodejs/node/pull/28748#ref-commit-b03845b
https://github.com/ronag
https://github.com/mcollina
stream: make finished call the callback if the stream is closedhttps://github.com/nodejs/node/commit/b03845b9376aec590b89f753a4b7c1b47729c5f8
b03845bhttps://github.com/nodejs/node/commit/b03845b9376aec590b89f753a4b7c1b47729c5f8
#28748https://github.com/nodejs/node/pull/28748
https://github.com/BethGriggs
BethGriggshttps://github.com/BethGriggs
Sep 9, 2019 https://github.com/nodejs/node/pull/28748#ref-pullrequest-491100896
2019-10-22, Version 13.0.0 (Current) #29504 https://github.com/nodejs/node/pull/29504
https://github.com/mafintosh
mafintoshhttps://github.com/mafintosh
Sep 23, 2019https://github.com/nodejs/node/pull/28748#issuecomment-534095120
Please reload this pagehttps://github.com/nodejs/node/pull/28748
https://github.co/hiddenchars
https://github.com/nodejs/node/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F28748
https://github.com/mcollina
mcollina https://github.com/mcollina
https://github.com/nodejs/node/pull/28748/files/d456dc560b21f2ebd10671d9a1568234c0772789
https://github.com/jasnell
jasnell https://github.com/jasnell
https://github.com/nodejs/node/pull/28748/files/e0b5904b27162662d296ad528a98e49920aff11b
https://github.com/benjamingr
benjamingr https://github.com/benjamingr
https://github.com/nodejs/node/pull/28748/files/39ca23ae861e4703eb70781f739d10237aea82d3
https://github.com/trivikr
trivikr https://github.com/trivikr
https://github.com/nodejs/node/pull/28748/files/10145256842d3b2950f6aab4cef2f98313b3ca9d
https://github.com/mafintosh
mafintosh https://github.com/mafintosh
https://github.com/nodejs/node/pull/28748/files/e247465502f3841eeed63cde9dc9ffe7b5ba9479
semver-major https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Asemver-major
stream https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Astream
Please reload this pagehttps://github.com/nodejs/node/pull/28748
https://github.com/ronag
https://github.com/Trott
https://github.com/nodejs-github-bot
https://github.com/mcollina
https://github.com/mafintosh
https://github.com/jasnell
https://github.com/benjamingr
https://github.com/trivikr
https://github.com/Fishrock123
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.