René's URL Explorer Experiment


Title: stream: eos premature close by ronag · Pull Request #28720 · nodejs/node · GitHub

Open Graph Title: stream: eos premature close by ronag · Pull Request #28720 · nodejs/node

X Title: stream: eos premature close by ronag · Pull Request #28720 · nodejs/node

Description: Node.js JavaScript runtime ✨🐢🚀✨. Contribute to nodejs/node development by creating an account on GitHub.

Open Graph Description: For writable premature close is close before finish, i.e. it should look for finished instead of ended. Would be better with a finishEmitted but we don't have that. For readable we should be ch...

X Description: For writable premature close is close before finish, i.e. it should look for finished instead of ended. Would be better with a finishEmitted but we don't have that. For readable we should b...

Opengraph URL: https://github.com/nodejs/node/pull/28720

X: @github

direct link

Domain: github.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:113fe5d3-7063-1177-74a3-37cb82b4d9d4
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idE84C:C9E65:1A8DDC:2378EE:6A517423
html-safe-noncee6242f2e7be253c9b05473f9ee88ae569e18bec80daf793a94b769a7f28c43c1
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJFODRDOkM5RTY1OjFBOEREQzoyMzc4RUU6NkE1MTc0MjMiLCJ2aXNpdG9yX2lkIjoiOTQzNzMzNzc1NjE5MTU5MDc1IiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmacf14544b1a95e4b75524bf2f8926efc068912bd86a95ebeedc1b450b3f2e7ee76
hovercard-subject-tagpull_request:298107101
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/28720/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/c0281e2cf289f11eebc5e40d106192a277a24cd6ffc68436cd957a566bec6c85/nodejs/node/pull/28720
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/c0281e2cf289f11eebc5e40d106192a277a24cd6ffc68436cd957a566bec6c85/nodejs/node/pull/28720
og:image:altFor writable premature close is close before finish, i.e. it should look for finished instead of ended. Would be better with a finishEmitted but we don't have that. For readable we should be ch...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernameronag
hostnamegithub.com
expected-hostnamegithub.com
Noneb9a586c06a05a7a86fc7e3f4dbd03e42f6869085879aa184aa6369456dbd50fb
turbo-cache-controlno-cache
go-importgithub.com/nodejs/node git https://github.com/nodejs/node.git
octolytics-dimension-user_id9950313
octolytics-dimension-user_loginnodejs
octolytics-dimension-repository_id27193779
octolytics-dimension-repository_nwonodejs/node
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id27193779
octolytics-dimension-repository_network_root_nwonodejs/node
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
releaseb19955a9dd40fd99462443f7911b522d7216776a
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/nodejs/node/pull/28720#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F28720
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub Copilot appDirect agents from issue to mergehttps://github.com/features/ai/github-app
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
View all resourceshttps://github.com/resources
GitHub SponsorsFund open source developershttps://github.com/open-source/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/open-source/accelerator
GitHub Starshttps://stars.github.com
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F28720
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode
Reloadhttps://github.com/nodejs/node/pull/28720
Reloadhttps://github.com/nodejs/node/pull/28720
Reloadhttps://github.com/nodejs/node/pull/28720
Please reload this pagehttps://github.com/nodejs/node/pull/28720
nodejs https://github.com/nodejs
nodehttps://github.com/nodejs/node
Please reload this pagehttps://github.com/nodejs/node/pull/28720
Notifications https://github.com/login?return_to=%2Fnodejs%2Fnode
Fork 36.1k https://github.com/login?return_to=%2Fnodejs%2Fnode
Star 118k https://github.com/login?return_to=%2Fnodejs%2Fnode
Code https://github.com/nodejs/node
Issues 1.4k https://github.com/nodejs/node/issues
Pull requests 980 https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects https://github.com/nodejs/node/projects
Security and quality 0 https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
Code https://github.com/nodejs/node
Issues https://github.com/nodejs/node/issues
Pull requests https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects https://github.com/nodejs/node/projects
Security and quality https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
ronaghttps://github.com/ronag
nodejs:masterhttps://github.com/nodejs/node/tree/master
nxtedition:stream-pipeline-prematurehttps://github.com/nxtedition/node/tree/stream-pipeline-premature
Conversationhttps://github.com/nodejs/node/pull/28720
Commits1 (1)https://github.com/nodejs/node/pull/28720/commits
Checkshttps://github.com/nodejs/node/pull/28720/checks
Files changedhttps://github.com/nodejs/node/pull/28720/files
stream: eos premature closehttps://github.com/nodejs/node/pull/28720#top
ronaghttps://github.com/ronag
nodejs:masterhttps://github.com/nodejs/node/tree/master
nxtedition:stream-pipeline-prematurehttps://github.com/nxtedition/node/tree/stream-pipeline-premature
https://github.com/ronag
ronaghttps://github.com/ronag
Jul 16, 2019https://github.com/nodejs/node/pull/28720#issue-468735375
Please reload this pagehttps://github.com/nodejs/node/pull/28720
commit guidelineshttps://github.com/nodejs/node/blob/master/doc/guides/contributing/pull-requests.md#commit-message-guidelines
Please reload this pagehttps://github.com/nodejs/node/pull/28720
https://github.com/ronag
ronaghttps://github.com/ronag
Jul 16, 2019https://github.com/nodejs/node/pull/28720#issuecomment-511876969
Please reload this pagehttps://github.com/nodejs/node/pull/28720
https://github.com/ronag
ronaghttps://github.com/ronag
force-pushedhttps://github.com/nodejs/node/compare/554b8e038eb4bb9e4d1e9bbf16bdec3c586e3ec9..291d05c0029c2a0f77086db3a0ce9feef21c5210
554b8e0https://github.com/nodejs/node/commit/554b8e038eb4bb9e4d1e9bbf16bdec3c586e3ec9
291d05chttps://github.com/nodejs/node/commit/291d05c0029c2a0f77086db3a0ce9feef21c5210
Compare https://github.com/nodejs/node/compare/554b8e038eb4bb9e4d1e9bbf16bdec3c586e3ec9..291d05c0029c2a0f77086db3a0ce9feef21c5210
July 16, 2019 18:12https://github.com/nodejs/node/pull/28720#event-2487045558
https://github.com/ronag
ronaghttps://github.com/ronag
Jul 16, 2019https://github.com/nodejs/node/pull/28720#issuecomment-511926993
Please reload this pagehttps://github.com/nodejs/node/pull/28720
Please reload this pagehttps://github.com/nodejs/node/pull/28720
https://github.com/ronag
ronaghttps://github.com/ronag
Jul 17, 2019https://github.com/nodejs/node/pull/28720#issuecomment-512568805
@benjamingrhttps://github.com/benjamingr
Please reload this pagehttps://github.com/nodejs/node/pull/28720
https://github.com/benjamingr
benjamingrhttps://github.com/benjamingr
Jul 18, 2019https://github.com/nodejs/node/pull/28720#issuecomment-512725006
Please reload this pagehttps://github.com/nodejs/node/pull/28720
https://github.com/ronag
ronaghttps://github.com/ronag
Jul 18, 2019https://github.com/nodejs/node/pull/28720#issuecomment-512727656
Please reload this pagehttps://github.com/nodejs/node/pull/28720
@benjamincburnshttps://github.com/benjamincburns
Please reload this pagehttps://github.com/nodejs/node/pull/28720
https://github.com/benjamingr
benjamingrhttps://github.com/benjamingr
Jul 18, 2019https://github.com/nodejs/node/pull/28720#issuecomment-512766132
Please reload this pagehttps://github.com/nodejs/node/pull/28720
https://github.com/benjamingr
benjamingrhttps://github.com/benjamingr
Jul 18, 2019 https://github.com/nodejs/node/pull/28720#pullrequestreview-263574582
View reviewed changes https://github.com/nodejs/node/pull/28720/files
benjamingrhttps://github.com/benjamingr
https://github.com/nodejs/node/pull/28720#pullrequestreview-263574582
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/28720
https://github.com/benjamingr
benjamingrhttps://github.com/benjamingr
Jul 18, 2019 https://github.com/nodejs/node/pull/28720#pullrequestreview-263574677
View reviewed changes https://github.com/nodejs/node/pull/28720/files
test/parallel/test-stream-finished.jshttps://github.com/nodejs/node/pull/28720/files#diff-8d1e590f7f886b8a511a291673bc2a48fa5a189b39317e5854196947c39548b1
Please reload this pagehttps://github.com/nodejs/node/pull/28720
https://github.com/mcollina
mcollinahttps://github.com/mcollina
semver-major https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Asemver-major
Jul 18, 2019https://github.com/nodejs/node/pull/28720#event-2492367357
https://github.com/mcollina
mcollinahttps://github.com/mcollina
Jul 18, 2019https://github.com/nodejs/node/pull/28720#issuecomment-512774055
Please reload this pagehttps://github.com/nodejs/node/pull/28720
https://github.com/mcollina
mcollinahttps://github.com/mcollina
Jul 18, 2019https://github.com/nodejs/node/pull/28720#issuecomment-512774571
Please reload this pagehttps://github.com/nodejs/node/pull/28720
https://github.com/mcollina
mcollinahttps://github.com/mcollina
Jul 18, 2019 https://github.com/nodejs/node/pull/28720#pullrequestreview-263586210
View reviewed changes https://github.com/nodejs/node/pull/28720/files
test/parallel/test-stream-finished.jshttps://github.com/nodejs/node/pull/28720/files#diff-8d1e590f7f886b8a511a291673bc2a48fa5a189b39317e5854196947c39548b1
Please reload this pagehttps://github.com/nodejs/node/pull/28720
https://github.com/ronag
ronaghttps://github.com/ronag
Jul 18, 2019https://github.com/nodejs/node/pull/28720#issuecomment-512775337
Please reload this pagehttps://github.com/nodejs/node/pull/28720
@mcollinahttps://github.com/mcollina
Please reload this pagehttps://github.com/nodejs/node/pull/28720
https://github.com/ronag
ronaghttps://github.com/ronag
force-pushedhttps://github.com/nodejs/node/compare/afd02b145964895ef4abfe6efc234f07cce10189..1ee52d4882e0ccd7fb8f2b28004c53702395221f
afd02b1https://github.com/nodejs/node/commit/afd02b145964895ef4abfe6efc234f07cce10189
1ee52d4https://github.com/nodejs/node/commit/1ee52d4882e0ccd7fb8f2b28004c53702395221f
Compare https://github.com/nodejs/node/compare/afd02b145964895ef4abfe6efc234f07cce10189..1ee52d4882e0ccd7fb8f2b28004c53702395221f
July 18, 2019 11:23https://github.com/nodejs/node/pull/28720#event-2492385299
https://github.com/benjamingr
benjamingrhttps://github.com/benjamingr
Jul 18, 2019https://github.com/nodejs/node/pull/28720#issuecomment-512842646
@ronaghttps://github.com/ronag
Please reload this pagehttps://github.com/nodejs/node/pull/28720
https://github.com/ronag
ronaghttps://github.com/ronag
Jul 18, 2019https://github.com/nodejs/node/pull/28720#issuecomment-512856156
@benjamingrhttps://github.com/benjamingr
Please reload this pagehttps://github.com/nodejs/node/pull/28720
stream: cleanup #29000 https://github.com/nodejs/node/issues/29000
stream: event contract #29005 https://github.com/nodejs/node/issues/29005
https://github.com/ronag
stream: eos premature closehttps://github.com/nodejs/node/pull/28720/commits/77ff0d3045067292221af2df857fec918d5f1619
77ff0d3https://github.com/nodejs/node/pull/28720/commits/77ff0d3045067292221af2df857fec918d5f1619
https://github.com/ronag
ronaghttps://github.com/ronag
force-pushedhttps://github.com/nodejs/node/compare/1ee52d4882e0ccd7fb8f2b28004c53702395221f..77ff0d3045067292221af2df857fec918d5f1619
1ee52d4https://github.com/nodejs/node/commit/1ee52d4882e0ccd7fb8f2b28004c53702395221f
77ff0d3https://github.com/nodejs/node/commit/77ff0d3045067292221af2df857fec918d5f1619
Compare https://github.com/nodejs/node/compare/1ee52d4882e0ccd7fb8f2b28004c53702395221f..77ff0d3045067292221af2df857fec918d5f1619
August 9, 2019 16:06https://github.com/nodejs/node/pull/28720#event-2546950012
https://github.com/ronag
ronaghttps://github.com/ronag
Aug 28, 2019https://github.com/nodejs/node/pull/28720#issuecomment-525665174
Please reload this pagehttps://github.com/nodejs/node/pull/28720
https://github.com/ronag
ronaghttps://github.com/ronag
Aug 28, 2019 https://github.com/nodejs/node/pull/28720#ref-pullrequest-469711864
stream: eos on closed #28748 https://github.com/nodejs/node/pull/28748
https://github.com/ronag
ronaghttps://github.com/ronag
Sep 1, 2019https://github.com/nodejs/node/pull/28720#issuecomment-526922727
#28748https://github.com/nodejs/node/pull/28748
Please reload this pagehttps://github.com/nodejs/node/pull/28720
https://github.com/ronag
ronaghttps://github.com/ronag
Sep 1, 2019https://github.com/nodejs/node/pull/28720#event-2599390634
ronaghttps://github.com/ronag
Sep 2, 2019 https://github.com/nodejs/node/pull/28720#ref-commit-5641590
https://github.com/ronag
fixup: mergehttps://github.com/nxtedition/node/commit/56415908a642e5cf146b3ab1060bad599624c5c1
nodejs#28720https://github.com/nodejs/node/pull/28720
5641590https://github.com/nxtedition/node/commit/56415908a642e5cf146b3ab1060bad599624c5c1
https://github.co/hiddenchars
https://github.com/nodejs/node/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F28720
https://github.com/benjamingr
benjamingr https://github.com/benjamingr
https://github.com/nodejs/node/pull/28720/files/291d05c0029c2a0f77086db3a0ce9feef21c5210
https://github.com/mcollina
mcollina https://github.com/mcollina
https://github.com/nodejs/node/pull/28720/files/291d05c0029c2a0f77086db3a0ce9feef21c5210
semver-major https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Asemver-major
Please reload this pagehttps://github.com/nodejs/node/pull/28720
https://github.com/ronag
https://github.com/benjamingr
https://github.com/mcollina
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.