| route-pattern | /_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format) |
| route-controller | voltron_pull_requests_fragments |
| route-action | pull_request_layout |
| fetch-nonce | v2:03375ef5-135d-06c2-3761-1898d229d71d |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | E048:90996:2EB6036:433A228:6A4FBDC1 |
| html-safe-nonce | d6fc3472b90c1e39ca5b7b70d1eaf4623128f225857b5bba233a1afe075f8dce |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJFMDQ4OjkwOTk2OjJFQjYwMzY6NDMzQTIyODo2QTRGQkRDMSIsInZpc2l0b3JfaWQiOiIzMDE0NTAwNTcxNzQ5MDA2Nzg1IiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0= |
| visitor-hmac | 633bdf0306b9f630ab10a6975b952e5ccc26c26dfc7c2cbd5b9e5864b851c783 |
| hovercard-subject-tag | pull_request:297894699 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///voltron/pull_requests_fragments/pull_request_layout |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/28715/pull_request_layout |
| twitter:image | https://opengraph.githubassets.com/d7736eac77800a7c5f5dadf380cde4c106914550fdef294c4c8c7e3aa625cff5/nodejs/node/pull/28715 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/d7736eac77800a7c5f5dadf380cde4c106914550fdef294c4c8c7e3aa625cff5/nodejs/node/pull/28715 |
| og:image:alt | This is another take on #15404 (comment).
Depends on #28681
Refs: #15029
Checklist
make -j4 test (UNIX), or vcbuild test (Windows) passes
tests and/or benchmarks are included
documentation is c... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | ronag |
| hostname | github.com |
| expected-hostname | github.com |
| None | 7d8f8209b188a80e19a6957836ab9229715797be5db1a04163963c674ccc33f6 |
| turbo-cache-control | no-cache |
| go-import | github.com/nodejs/node git https://github.com/nodejs/node.git |
| octolytics-dimension-user_id | 9950313 |
| octolytics-dimension-user_login | nodejs |
| octolytics-dimension-repository_id | 27193779 |
| octolytics-dimension-repository_nwo | nodejs/node |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 27193779 |
| octolytics-dimension-repository_network_root_nwo | nodejs/node |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | ea848e83cf3bf3613dd7b13d52965a684fd23ec5 |
| ui-target | canary-1 |
| theme-color | #1e2327 |
| color-scheme | light dark |
| Skip to content | https://github.com/nodejs/node/pull/28715#start-of-content |
|
| https://github.com/ |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F28715 |
| GitHub CopilotWrite better code with AI | https://github.com/features/copilot |
| GitHub Copilot appDirect agents from issue to merge | https://github.com/features/ai/github-app |
| MCP RegistryNewIntegrate external tools | https://github.com/mcp |
| ActionsAutomate any workflow | https://github.com/features/actions |
| CodespacesInstant dev environments | https://github.com/features/codespaces |
| IssuesPlan and track work | https://github.com/features/issues |
| Code ReviewManage code changes | https://github.com/features/code-review |
| GitHub Advanced SecurityFind and fix vulnerabilities | https://github.com/security/advanced-security |
| Code securitySecure your code as you build | https://github.com/security/advanced-security/code-security |
| Secret protectionStop leaks before they start | https://github.com/security/advanced-security/secret-protection |
| Why GitHub | https://github.com/why-github |
| Documentation | https://docs.github.com |
| Blog | https://github.blog |
| Changelog | https://github.blog/changelog |
| Marketplace | https://github.com/marketplace |
| View all features | https://github.com/features |
| Enterprises | https://github.com/enterprise |
| Small and medium teams | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| App Modernization | https://github.com/solutions/use-case/app-modernization |
| DevSecOps | https://github.com/solutions/use-case/devsecops |
| DevOps | https://github.com/solutions/use-case/devops |
| CI/CD | https://github.com/solutions/use-case/ci-cd |
| View all use cases | https://github.com/solutions/use-case |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| View all industries | https://github.com/solutions/industry |
| View all solutions | https://github.com/solutions |
| AI | https://github.com/resources/articles?topic=ai |
| Software Development | https://github.com/resources/articles?topic=software-development |
| DevOps | https://github.com/resources/articles?topic=devops |
| Security | https://github.com/resources/articles?topic=security |
| View all topics | https://github.com/resources/articles |
| Customer stories | https://github.com/customer-stories |
| Events & webinars | https://github.com/resources/events |
| Ebooks & reports | https://github.com/resources/whitepapers |
| Business insights | https://github.com/solutions/executive-insights |
| GitHub Skills | https://skills.github.com |
| Documentation | https://docs.github.com |
| Customer support | https://support.github.com |
| Community forum | https://github.com/orgs/community/discussions |
| Trust center | https://github.com/trust-center |
| Partners | https://github.com/partners |
| View all resources | https://github.com/resources |
| GitHub SponsorsFund open source developers | https://github.com/open-source/sponsors |
| Security Lab | https://securitylab.github.com |
| Maintainer Community | https://maintainers.github.com |
| Accelerator | https://github.com/open-source/accelerator |
| GitHub Stars | https://stars.github.com |
| Archive Program | https://archiveprogram.github.com |
| Topics | https://github.com/topics |
| Trending | https://github.com/trending |
| Collections | https://github.com/collections |
| Enterprise platformAI-powered developer platform | https://github.com/enterprise |
| GitHub Advanced SecurityEnterprise-grade security features | https://github.com/security/advanced-security |
| Copilot for BusinessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/enterprise/premium-support |
| Pricing | https://github.com/pricing |
| Search syntax tips | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
| documentation | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F28715 |
|
Sign up
| https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode |
| Reload | https://github.com/nodejs/node/pull/28715 |
| Reload | https://github.com/nodejs/node/pull/28715 |
| Reload | https://github.com/nodejs/node/pull/28715 |
| Please reload this page | https://github.com/nodejs/node/pull/28715 |
|
nodejs
| https://github.com/nodejs |
| node | https://github.com/nodejs/node |
| Please reload this page | https://github.com/nodejs/node/pull/28715 |
|
Notifications
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Fork
36k
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Star
118k
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Code
| https://github.com/nodejs/node |
|
Issues
1.3k
| https://github.com/nodejs/node/issues |
|
Pull requests
973
| https://github.com/nodejs/node/pulls |
|
Actions
| https://github.com/nodejs/node/actions |
|
Projects
| https://github.com/nodejs/node/projects |
|
Security and quality
0
| https://github.com/nodejs/node/security |
|
Insights
| https://github.com/nodejs/node/pulse |
|
Code
| https://github.com/nodejs/node |
|
Issues
| https://github.com/nodejs/node/issues |
|
Pull requests
| https://github.com/nodejs/node/pulls |
|
Actions
| https://github.com/nodejs/node/actions |
|
Projects
| https://github.com/nodejs/node/projects |
|
Security and quality
| https://github.com/nodejs/node/security |
|
Insights
| https://github.com/nodejs/node/pulse |
| ronag | https://github.com/ronag |
| nodejs:master | https://github.com/nodejs/node/tree/master |
| nxtedition:writable-finished | https://github.com/nxtedition/node/tree/writable-finished |
| Conversation | https://github.com/nodejs/node/pull/28715 |
| Commits1 (1) | https://github.com/nodejs/node/pull/28715/commits |
| Checks | https://github.com/nodejs/node/pull/28715/checks |
| Files changed | https://github.com/nodejs/node/pull/28715/files |
| http: writable set to false | https://github.com/nodejs/node/pull/28715#top |
| ronag | https://github.com/ronag |
| nodejs:master | https://github.com/nodejs/node/tree/master |
| nxtedition:writable-finished | https://github.com/nxtedition/node/tree/writable-finished |
|
| https://github.com/ronag |
| ronag | https://github.com/ronag |
| Jul 16, 2019 | https://github.com/nodejs/node/pull/28715#issue-468473536 |
| Please reload this page | https://github.com/nodejs/node/pull/28715 |
| #15404 (comment) | https://github.com/nodejs/node/pull/15404#issuecomment-329502888 |
| #28681 | https://github.com/nodejs/node/pull/28681 |
| #15029 | https://github.com/nodejs/node/issues/15029 |
| commit guidelines | https://github.com/nodejs/node/blob/master/doc/guides/contributing/pull-requests.md#commit-message-guidelines |
| Please reload this page | https://github.com/nodejs/node/pull/28715 |
| https://github.com/nodejs-github-bot |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
|
http
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Ahttp |
| Jul 16, 2019 | https://github.com/nodejs/node/pull/28715#event-2485050278 |
| https://github.com/ronag |
| ronag | https://github.com/ronag |
| Jul 16, 2019 | https://github.com/nodejs/node/pull/28715#issuecomment-511686060 |
| Please reload this page | https://github.com/nodejs/node/pull/28715 |
| @mcollina | https://github.com/mcollina |
| #14024 | https://github.com/nodejs/node/pull/14024 |
| Please reload this page | https://github.com/nodejs/node/pull/28715 |
| https://github.com/mcollina |
| mcollina | https://github.com/mcollina |
|
Jul 16, 2019
| https://github.com/nodejs/node/pull/28715#pullrequestreview-262229880 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/28715/files |
| mcollina | https://github.com/mcollina |
| https://github.com/nodejs/node/pull/28715#pullrequestreview-262229880 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/28715 |
| https://github.com/mcollina |
| mcollina | https://github.com/mcollina |
| Jul 16, 2019 | https://github.com/nodejs/node/pull/28715#issuecomment-511700292 |
| @ronag | https://github.com/ronag |
| https://github.com/SimenB/node-stream-repro/blob/master/index.js | https://github.com/SimenB/node-stream-repro/blob/master/index.js |
| Please reload this page | https://github.com/nodejs/node/pull/28715 |
| https://github.com/vsemozhetbyt |
| vsemozhetbyt | https://github.com/vsemozhetbyt |
|
Jul 16, 2019
| https://github.com/nodejs/node/pull/28715#pullrequestreview-262469727 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/28715/files |
| doc/api/http.md | https://github.com/nodejs/node/pull/28715/files#diff-d692ac4524379ec6a1201165e8ff8d3267c8130e07014e8221ebf7e6f80c6641 |
| Please reload this page | https://github.com/nodejs/node/pull/28715 |
| https://github.com/ronag |
| ronag | https://github.com/ronag |
| Jul 16, 2019 | https://github.com/nodejs/node/pull/28715#issuecomment-511859643 |
| Please reload this page | https://github.com/nodejs/node/pull/28715 |
| @mcollina | https://github.com/mcollina |
| Please reload this page | https://github.com/nodejs/node/pull/28715 |
| https://github.com/ronag |
| ronag | https://github.com/ronag |
| force-pushed | https://github.com/nodejs/node/compare/5d1e99e08332ce42e65a35c439fa103e840d8e09..236a8142c202429d81feea6b18868cd5e66a9214 |
| 5d1e99e | https://github.com/nodejs/node/commit/5d1e99e08332ce42e65a35c439fa103e840d8e09 |
| 236a814 | https://github.com/nodejs/node/commit/236a8142c202429d81feea6b18868cd5e66a9214 |
|
Compare
| https://github.com/nodejs/node/compare/5d1e99e08332ce42e65a35c439fa103e840d8e09..236a8142c202429d81feea6b18868cd5e66a9214 |
| July 16, 2019 15:17 | https://github.com/nodejs/node/pull/28715#event-2486537969 |
| https://github.com/mcollina |
| mcollina | https://github.com/mcollina |
| Jul 16, 2019 | https://github.com/nodejs/node/pull/28715#issuecomment-511862289 |
| Please reload this page | https://github.com/nodejs/node/pull/28715 |
| https://github.com/ronag |
| ronag | https://github.com/ronag |
| Jul 16, 2019 | https://github.com/nodejs/node/pull/28715#issuecomment-511863845 |
| Please reload this page | https://github.com/nodejs/node/pull/28715 |
| https://github.com/ronag |
| ronag | https://github.com/ronag |
| force-pushed | https://github.com/nodejs/node/compare/26b6e883c129f67845382d49baf108a87cc36929..6125ffee0b78f3322688fb03108ce600ffa44cb6 |
| 26b6e88 | https://github.com/nodejs/node/commit/26b6e883c129f67845382d49baf108a87cc36929 |
| 6125ffe | https://github.com/nodejs/node/commit/6125ffee0b78f3322688fb03108ce600ffa44cb6 |
|
Compare
| https://github.com/nodejs/node/compare/26b6e883c129f67845382d49baf108a87cc36929..6125ffee0b78f3322688fb03108ce600ffa44cb6 |
| July 16, 2019 15:27 | https://github.com/nodejs/node/pull/28715#event-2486570904 |
|
| https://github.com/ronag |
| http: fix writable not set to false | https://github.com/nodejs/node/pull/28715/commits/72d277222de64863251328144dd019fe44ef6183 |
| 72d2772 | https://github.com/nodejs/node/pull/28715/commits/72d277222de64863251328144dd019fe44ef6183 |
| https://github.com/ronag |
| ronag | https://github.com/ronag |
| force-pushed | https://github.com/nodejs/node/compare/6125ffee0b78f3322688fb03108ce600ffa44cb6..72d277222de64863251328144dd019fe44ef6183 |
| 6125ffe | https://github.com/nodejs/node/commit/6125ffee0b78f3322688fb03108ce600ffa44cb6 |
| 72d2772 | https://github.com/nodejs/node/commit/72d277222de64863251328144dd019fe44ef6183 |
|
Compare
| https://github.com/nodejs/node/compare/6125ffee0b78f3322688fb03108ce600ffa44cb6..72d277222de64863251328144dd019fe44ef6183 |
| July 16, 2019 15:28 | https://github.com/nodejs/node/pull/28715#event-2486573699 |
| https://github.com/ronag |
| ronag | https://github.com/ronag |
| Jul 16, 2019 | https://github.com/nodejs/node/pull/28715#issuecomment-511891276 |
| Please reload this page | https://github.com/nodejs/node/pull/28715 |
| https://github.com/jasnell |
| jasnell | https://github.com/jasnell |
|
wip
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Awip |
| Jul 17, 2019 | https://github.com/nodejs/node/pull/28715#event-2489692551 |
| https://github.com/ronag |
| ronag | https://github.com/ronag |
| Aug 12, 2019 | https://github.com/nodejs/node/pull/28715#issuecomment-520332995 |
| Please reload this page | https://github.com/nodejs/node/pull/28715 |
| https://github.com/ronag |
| ronag | https://github.com/ronag |
| Aug 12, 2019 | https://github.com/nodejs/node/pull/28715#event-2549395989 |
| https://github.co/hiddenchars |
| https://github.com/nodejs/node/pull/{{ revealButtonHref }} |
| Sign up for free | https://github.com/join?source=comment-repo |
| Sign in to comment | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F28715 |
|
| https://github.com/mcollina |
|
mcollina
| https://github.com/mcollina |
|
| https://github.com/nodejs/node/pull/28715/files/b28ac784f0d529a267b46ee913749a91dd5f2c3c |
|
| https://github.com/vsemozhetbyt |
|
vsemozhetbyt
| https://github.com/vsemozhetbyt |
|
| https://github.com/nodejs/node/pull/28715/files/b28ac784f0d529a267b46ee913749a91dd5f2c3c |
|
http
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Ahttp |
|
wip
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Awip |
| Please reload this page | https://github.com/nodejs/node/pull/28715 |
|
| https://github.com/ronag |
|
| https://github.com/mcollina |
|
| https://github.com/vsemozhetbyt |
|
| https://github.com/jasnell |
|
| https://github.com/nodejs-github-bot |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |