René's URL Explorer Experiment


Title: http: avoid extra listener by ronag · Pull Request #28705 · nodejs/node · GitHub

Open Graph Title: http: avoid extra listener by ronag · Pull Request #28705 · nodejs/node

X Title: http: avoid extra listener by ronag · Pull Request #28705 · nodejs/node

Description: Node.js JavaScript runtime ✨🐢🚀✨. Contribute to nodejs/node development by creating an account on GitHub.

Open Graph Description: Minor cleanup and perf improvement. Avoid registering unnecessary listener. Checklist make -j4 test (UNIX), or vcbuild test (Windows) passes commit message follows commit guidelines

X Description: Minor cleanup and perf improvement. Avoid registering unnecessary listener. Checklist make -j4 test (UNIX), or vcbuild test (Windows) passes commit message follows commit guidelines

Opengraph URL: https://github.com/nodejs/node/pull/28705

X: @github

direct link

Domain: github.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:835bdf1f-1c99-574c-f1cc-02675a0646f7
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idA624:1A54AB:2C8E912:3E1C973:6A50DA8B
html-safe-nonceaaed2fbd8aedfb321007310ad3fdfbab128fd7933e96d5861bdbc1d323558dd0
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJBNjI0OjFBNTRBQjoyQzhFOTEyOjNFMUM5NzM6NkE1MERBOEIiLCJ2aXNpdG9yX2lkIjoiMzg0Mjc1NTAxODczMTA4NDQyNyIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmaced341cba6792061b624bfdf3859cf96a020c01ae40d6ae02324c7fddf516213e
hovercard-subject-tagpull_request:297774343
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/28705/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/e4e0aee36e947a4390674b09f8b6431d2e053865486100dda5be7a0fca79797c/nodejs/node/pull/28705
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/e4e0aee36e947a4390674b09f8b6431d2e053865486100dda5be7a0fca79797c/nodejs/node/pull/28705
og:image:altMinor cleanup and perf improvement. Avoid registering unnecessary listener. Checklist make -j4 test (UNIX), or vcbuild test (Windows) passes commit message follows commit guidelines
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernameronag
hostnamegithub.com
expected-hostnamegithub.com
None72b13e0e8d0319acdd27a145cfe73f4f06c791713d0ac4690e41fb68ad28cac0
turbo-cache-controlno-cache
go-importgithub.com/nodejs/node git https://github.com/nodejs/node.git
octolytics-dimension-user_id9950313
octolytics-dimension-user_loginnodejs
octolytics-dimension-repository_id27193779
octolytics-dimension-repository_nwonodejs/node
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id27193779
octolytics-dimension-repository_network_root_nwonodejs/node
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release73ad5c4eaffed7bb3637024653eabdbca84a855e
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/nodejs/node/pull/28705#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F28705
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub Copilot appDirect agents from issue to mergehttps://github.com/features/ai/github-app
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
View all resourceshttps://github.com/resources
GitHub SponsorsFund open source developershttps://github.com/open-source/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/open-source/accelerator
GitHub Starshttps://stars.github.com
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F28705
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode
Reloadhttps://github.com/nodejs/node/pull/28705
Reloadhttps://github.com/nodejs/node/pull/28705
Reloadhttps://github.com/nodejs/node/pull/28705
Please reload this pagehttps://github.com/nodejs/node/pull/28705
nodejs https://github.com/nodejs
nodehttps://github.com/nodejs/node
Please reload this pagehttps://github.com/nodejs/node/pull/28705
Notifications https://github.com/login?return_to=%2Fnodejs%2Fnode
Fork 36.1k https://github.com/login?return_to=%2Fnodejs%2Fnode
Star 118k https://github.com/login?return_to=%2Fnodejs%2Fnode
Code https://github.com/nodejs/node
Issues 1.3k https://github.com/nodejs/node/issues
Pull requests 979 https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects https://github.com/nodejs/node/projects
Security and quality 0 https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
Code https://github.com/nodejs/node
Issues https://github.com/nodejs/node/issues
Pull requests https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects https://github.com/nodejs/node/projects
Security and quality https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
ronaghttps://github.com/ronag
nodejs:masterhttps://github.com/nodejs/node/tree/master
nxtedition:http-refactor-clienthttps://github.com/nxtedition/node/tree/http-refactor-client
Conversationhttps://github.com/nodejs/node/pull/28705
Commits1 (1)https://github.com/nodejs/node/pull/28705/commits
Checkshttps://github.com/nodejs/node/pull/28705/checks
Files changedhttps://github.com/nodejs/node/pull/28705/files
http: avoid extra listenerhttps://github.com/nodejs/node/pull/28705#top
ronaghttps://github.com/ronag
nodejs:masterhttps://github.com/nodejs/node/tree/master
nxtedition:http-refactor-clienthttps://github.com/nxtedition/node/tree/http-refactor-client
https://github.com/ronag
ronaghttps://github.com/ronag
Jul 15, 2019https://github.com/nodejs/node/pull/28705#issue-468319311
Please reload this pagehttps://github.com/nodejs/node/pull/28705
commit guidelineshttps://github.com/nodejs/node/blob/master/doc/guides/contributing/pull-requests.md#commit-message-guidelines
Please reload this pagehttps://github.com/nodejs/node/pull/28705
https://github.com/ronag
http: avoid extra listenerhttps://github.com/nodejs/node/pull/28705/commits/9da856a12f91e7939dd76390dc1029b2511f93f5
9da856ahttps://github.com/nodejs/node/pull/28705/commits/9da856a12f91e7939dd76390dc1029b2511f93f5
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
http https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Ahttp
Jul 15, 2019https://github.com/nodejs/node/pull/28705#event-2484133778
https://github.com/jasnell
jasnellhttps://github.com/jasnell
Jul 17, 2019 https://github.com/nodejs/node/pull/28705#pullrequestreview-263108610
View reviewed changes https://github.com/nodejs/node/pull/28705/files/9da856a12f91e7939dd76390dc1029b2511f93f5
https://github.com/Trott
Trotthttps://github.com/Trott
Jul 17, 2019 https://github.com/nodejs/node/pull/28705#pullrequestreview-263327005
View reviewed changes https://github.com/nodejs/node/pull/28705/files/9da856a12f91e7939dd76390dc1029b2511f93f5
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
Jul 17, 2019https://github.com/nodejs/node/pull/28705#issuecomment-512576021
https://ci.nodejs.org/job/node-test-pull-request/24523/https://ci.nodejs.org/job/node-test-pull-request/24523/
Please reload this pagehttps://github.com/nodejs/node/pull/28705
https://github.com/Trott
Trotthttps://github.com/Trott
author ready https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22author%20ready%22
Jul 17, 2019https://github.com/nodejs/node/pull/28705#event-2490922867
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
Jul 17, 2019https://github.com/nodejs/node/pull/28705#issuecomment-512587746
https://ci.nodejs.org/job/node-test-pull-request/24528/https://ci.nodejs.org/job/node-test-pull-request/24528/
Please reload this pagehttps://github.com/nodejs/node/pull/28705
https://github.com/Trott
Trotthttps://github.com/Trott
Jul 18, 2019https://github.com/nodejs/node/pull/28705#issuecomment-513005489
Please reload this pagehttps://github.com/nodejs/node/pull/28705
https://github.com/trivikr
trivikrhttps://github.com/trivikr
Jul 18, 2019 https://github.com/nodejs/node/pull/28705#pullrequestreview-263950348
View reviewed changes https://github.com/nodejs/node/pull/28705/files/9da856a12f91e7939dd76390dc1029b2511f93f5
https://github.com/indutny
indutnyhttps://github.com/indutny
Jul 19, 2019 https://github.com/nodejs/node/pull/28705#pullrequestreview-263977794
View reviewed changes https://github.com/nodejs/node/pull/28705/files/9da856a12f91e7939dd76390dc1029b2511f93f5
indutnyhttps://github.com/indutny
https://github.com/nodejs/node/pull/28705#pullrequestreview-263977794
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/28705
https://github.com/Trott
Trotthttps://github.com/Trott
Jul 19, 2019https://github.com/nodejs/node/pull/28705#issuecomment-513081338
2fd2dd7https://github.com/nodejs/node/commit/2fd2dd75657af12a74e01a9a5e39e5f677ff3c88
Please reload this pagehttps://github.com/nodejs/node/pull/28705
https://github.com/Trott
Trotthttps://github.com/Trott
Jul 19, 2019https://github.com/nodejs/node/pull/28705#event-2494656573
Trotthttps://github.com/Trott
Jul 19, 2019 https://github.com/nodejs/node/pull/28705#ref-commit-2fd2dd7
https://github.com/ronag
https://github.com/Trott
http: avoid extra listenerhttps://github.com/Trott/io.js/commit/2fd2dd75657af12a74e01a9a5e39e5f677ff3c88
2fd2dd7https://github.com/Trott/io.js/commit/2fd2dd75657af12a74e01a9a5e39e5f677ff3c88
nodejs#28705https://github.com/nodejs/node/pull/28705
targoshttps://github.com/targos
Jul 20, 2019 https://github.com/nodejs/node/pull/28705#ref-commit-ed85043
https://github.com/ronag
https://github.com/targos
http: avoid extra listenerhttps://github.com/nodejs/node/commit/ed8504388e72152330b38af40cb2700f852e33f4
ed85043https://github.com/nodejs/node/commit/ed8504388e72152330b38af40cb2700f852e33f4
#28705https://github.com/nodejs/node/pull/28705
v12.7.0 release proposal #28816 https://github.com/nodejs/node/pull/28816
v12.7.0 release proposal #28817 https://github.com/nodejs/node/pull/28817
vikashk1https://github.com/vikashk1
Aug 13, 2019 https://github.com/nodejs/node/pull/28705#ref-commit-9af17ad
https://github.com/vikashk1
Please ignore this msg (https://github.com/vikashk1/node/commit/9af17ad05c8161db7f52de5fd3331a94857e33fc
#1https://github.com/vikashk1/node/pull/1
)https://github.com/vikashk1/node/commit/9af17ad05c8161db7f52de5fd3331a94857e33fc
9af17adhttps://github.com/vikashk1/node/commit/9af17ad05c8161db7f52de5fd3331a94857e33fc
https://github.co/hiddenchars
https://github.com/nodejs/node/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F28705
https://github.com/jasnell
jasnell https://github.com/jasnell
https://github.com/nodejs/node/pull/28705/files/9da856a12f91e7939dd76390dc1029b2511f93f5
https://github.com/Trott
Trott https://github.com/Trott
https://github.com/nodejs/node/pull/28705/files/9da856a12f91e7939dd76390dc1029b2511f93f5
https://github.com/trivikr
trivikr https://github.com/trivikr
https://github.com/nodejs/node/pull/28705/files/9da856a12f91e7939dd76390dc1029b2511f93f5
https://github.com/indutny
indutny https://github.com/indutny
https://github.com/nodejs/node/pull/28705/files/9da856a12f91e7939dd76390dc1029b2511f93f5
author ready https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22author%20ready%22
http https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Ahttp
Please reload this pagehttps://github.com/nodejs/node/pull/28705
https://github.com/ronag
https://github.com/nodejs-github-bot
https://github.com/Trott
https://github.com/indutny
https://github.com/jasnell
https://github.com/trivikr
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.