René's URL Explorer Experiment


Title: src: allow generic C++ callables in SetImmediate() by addaleax · Pull Request #28704 · nodejs/node · GitHub

Open Graph Title: src: allow generic C++ callables in SetImmediate() by addaleax · Pull Request #28704 · nodejs/node

X Title: src: allow generic C++ callables in SetImmediate() by addaleax · Pull Request #28704 · nodejs/node

Description: Node.js JavaScript runtime ✨🐢🚀✨. Contribute to nodejs/node development by creating an account on GitHub.

Open Graph Description: Modify the native SetImmediate() functions to take generic C++ callables as arguments. This makes passing arguments to the callback easier, and in particular, it allows passing std::unique_ptrs dir...

X Description: Modify the native SetImmediate() functions to take generic C++ callables as arguments. This makes passing arguments to the callback easier, and in particular, it allows passing std::unique_ptrs dir...

Opengraph URL: https://github.com/nodejs/node/pull/28704

X: @github

direct link

Domain: github.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:683eb79a-2345-c991-4789-222a88537682
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idBB7A:3463DE:3050932:43B520E:6A4F75D4
html-safe-nonceec5f2501cb2d9339978f4f3dcf7e11223d3aab575bf39af29553e8160c279879
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJCQjdBOjM0NjNERTozMDUwOTMyOjQzQjUyMEU6NkE0Rjc1RDQiLCJ2aXNpdG9yX2lkIjoiMzkzMjgxNzgyNDM0MzM1Njg4NCIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmac6c97257df93b87f1f6ba373bbdaea7241da8d22d9186ebe59650bc7c18a4c7fa
hovercard-subject-tagpull_request:297774000
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/28704/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/0423dafc128ab1db3ff852792e55d30beae6534729d34ffdcebdbd48d0b49035/nodejs/node/pull/28704
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/0423dafc128ab1db3ff852792e55d30beae6534729d34ffdcebdbd48d0b49035/nodejs/node/pull/28704
og:image:altModify the native SetImmediate() functions to take generic C++ callables as arguments. This makes passing arguments to the callback easier, and in particular, it allows passing std::unique_ptrs dir...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernameaddaleax
hostnamegithub.com
expected-hostnamegithub.com
Noneb92d11c0aa4a77d54ef4af1078b6a15fb5a70a215b30c4ecf28889d5a8e656d9
turbo-cache-controlno-cache
go-importgithub.com/nodejs/node git https://github.com/nodejs/node.git
octolytics-dimension-user_id9950313
octolytics-dimension-user_loginnodejs
octolytics-dimension-repository_id27193779
octolytics-dimension-repository_nwonodejs/node
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id27193779
octolytics-dimension-repository_network_root_nwonodejs/node
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release4b249b445842943ed31549e027f57a8ade9881ed
ui-targetcanary-2
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/nodejs/node/pull/28704#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F28704
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub Copilot appDirect agents from issue to mergehttps://github.com/features/ai/github-app
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
View all resourceshttps://github.com/resources
GitHub SponsorsFund open source developershttps://github.com/open-source/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/open-source/accelerator
GitHub Starshttps://stars.github.com
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F28704
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode
Reloadhttps://github.com/nodejs/node/pull/28704
Reloadhttps://github.com/nodejs/node/pull/28704
Reloadhttps://github.com/nodejs/node/pull/28704
Please reload this pagehttps://github.com/nodejs/node/pull/28704
nodejs https://github.com/nodejs
nodehttps://github.com/nodejs/node
Please reload this pagehttps://github.com/nodejs/node/pull/28704
Notifications https://github.com/login?return_to=%2Fnodejs%2Fnode
Fork 36k https://github.com/login?return_to=%2Fnodejs%2Fnode
Star 118k https://github.com/login?return_to=%2Fnodejs%2Fnode
Code https://github.com/nodejs/node
Issues 1.3k https://github.com/nodejs/node/issues
Pull requests 973 https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects https://github.com/nodejs/node/projects
Security and quality 0 https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
Code https://github.com/nodejs/node
Issues https://github.com/nodejs/node/issues
Pull requests https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects https://github.com/nodejs/node/projects
Security and quality https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
addaleaxhttps://github.com/addaleax
nodejs:masterhttps://github.com/nodejs/node/tree/master
addaleax:native-immediate-type-erasurehttps://github.com/addaleax/node/tree/native-immediate-type-erasure
Conversationhttps://github.com/nodejs/node/pull/28704
Commits1 (1)https://github.com/nodejs/node/pull/28704/commits
Checkshttps://github.com/nodejs/node/pull/28704/checks
Files changedhttps://github.com/nodejs/node/pull/28704/files
src: allow generic C++ callables in SetImmediate()https://github.com/nodejs/node/pull/28704#top
addaleaxhttps://github.com/addaleax
nodejs:masterhttps://github.com/nodejs/node/tree/master
addaleax:native-immediate-type-erasurehttps://github.com/addaleax/node/tree/native-immediate-type-erasure
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
Jul 15, 2019https://github.com/nodejs/node/pull/28704#issue-468318897
commit guidelineshttps://github.com/nodejs/node/blob/master/doc/guides/contributing/pull-requests.md#commit-message-guidelines
Please reload this pagehttps://github.com/nodejs/node/pull/28704
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
c++ https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Ac%2B%2B
lib / src https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22lib%20%2F%20src%22
Jul 15, 2019https://github.com/nodejs/node/pull/28704#event-2484131060
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
Jul 15, 2019https://github.com/nodejs/node/pull/28704#issuecomment-511556508
https://ci.nodejs.org/job/node-test-pull-request/24475/https://ci.nodejs.org/job/node-test-pull-request/24475/
Please reload this pagehttps://github.com/nodejs/node/pull/28704
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
wip https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Awip
Jul 15, 2019https://github.com/nodejs/node/pull/28704#event-2484229823
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
force-pushedhttps://github.com/nodejs/node/compare/ff700c202c09840c2de9c2ef5d7c8e36bcd666b2..0386696c127eeeb6e24498f6a454740b0835d24d
ff700c2https://github.com/nodejs/node/commit/ff700c202c09840c2de9c2ef5d7c8e36bcd666b2
0386696https://github.com/nodejs/node/commit/0386696c127eeeb6e24498f6a454740b0835d24d
Compare https://github.com/nodejs/node/compare/ff700c202c09840c2de9c2ef5d7c8e36bcd666b2..0386696c127eeeb6e24498f6a454740b0835d24d
July 15, 2019 22:35https://github.com/nodejs/node/pull/28704#event-2484417047
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
Jul 15, 2019https://github.com/nodejs/node/pull/28704#issuecomment-511600772
https://ci.nodejs.org/job/node-test-pull-request/24483/https://ci.nodejs.org/job/node-test-pull-request/24483/
Please reload this pagehttps://github.com/nodejs/node/pull/28704
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
force-pushedhttps://github.com/nodejs/node/compare/0386696c127eeeb6e24498f6a454740b0835d24d..3cf4e258a61e5762830694a3c3b98a1086721bed
0386696https://github.com/nodejs/node/commit/0386696c127eeeb6e24498f6a454740b0835d24d
3cf4e25https://github.com/nodejs/node/commit/3cf4e258a61e5762830694a3c3b98a1086721bed
Compare https://github.com/nodejs/node/compare/0386696c127eeeb6e24498f6a454740b0835d24d..3cf4e258a61e5762830694a3c3b98a1086721bed
July 20, 2019 15:25https://github.com/nodejs/node/pull/28704#event-2497605760
https://github.com/Fishrock123
Fishrock123https://github.com/Fishrock123
Jul 24, 2019 https://github.com/nodejs/node/pull/28704#pullrequestreview-266313752
View reviewed changes https://github.com/nodejs/node/pull/28704/files
src/node_perf.cchttps://github.com/nodejs/node/pull/28704/files#diff-6c526b90d8e9ed83f267edd4ae7e26045969736c0a74c22ffe83126cebdab42f
Fishrock123https://github.com/Fishrock123
Jul 24, 2019https://github.com/nodejs/node/pull/28704#discussion_r307043634
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/28704
addaleaxhttps://github.com/addaleax
Jul 24, 2019https://github.com/nodejs/node/pull/28704#discussion_r307048607
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/28704
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
Jul 24, 2019https://github.com/nodejs/node/pull/28704#issuecomment-514825512
nodejs/build#1875https://github.com/nodejs/build/issues/1875
Please reload this pagehttps://github.com/nodejs/node/pull/28704
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
Jul 26, 2019https://github.com/nodejs/node/pull/28704#issuecomment-515581177
https://ci.nodejs.org/job/node-test-pull-request/24721/https://ci.nodejs.org/job/node-test-pull-request/24721/
Please reload this pagehttps://github.com/nodejs/node/pull/28704
https://github.com/addaleax
src: allow generic C++ callables in SetImmediate()https://github.com/nodejs/node/pull/28704/commits/9d040477df657a9f9ec865f3c4e2ececd2894fb1
9d04047https://github.com/nodejs/node/pull/28704/commits/9d040477df657a9f9ec865f3c4e2ececd2894fb1
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
force-pushedhttps://github.com/nodejs/node/compare/6c0712f1b05a58de40b6a77fb166fcd8540d6df2..9d040477df657a9f9ec865f3c4e2ececd2894fb1
6c0712fhttps://github.com/nodejs/node/commit/6c0712f1b05a58de40b6a77fb166fcd8540d6df2
9d04047https://github.com/nodejs/node/commit/9d040477df657a9f9ec865f3c4e2ececd2894fb1
Compare https://github.com/nodejs/node/compare/6c0712f1b05a58de40b6a77fb166fcd8540d6df2..9d040477df657a9f9ec865f3c4e2ececd2894fb1
July 26, 2019 20:12https://github.com/nodejs/node/pull/28704#event-2513598581
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
Jul 26, 2019https://github.com/nodejs/node/pull/28704#issuecomment-515584390
https://ci.nodejs.org/job/node-test-pull-request/24722/https://ci.nodejs.org/job/node-test-pull-request/24722/
Please reload this pagehttps://github.com/nodejs/node/pull/28704
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
Jul 27, 2019https://github.com/nodejs/node/pull/28704#issuecomment-515696695
https://ci.nodejs.org/job/node-test-pull-request/24728/https://ci.nodejs.org/job/node-test-pull-request/24728/
Please reload this pagehttps://github.com/nodejs/node/pull/28704
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
Jul 28, 2019https://github.com/nodejs/node/pull/28704#issuecomment-515734982
https://ci.nodejs.org/job/node-test-pull-request/24732/https://ci.nodejs.org/job/node-test-pull-request/24732/
Please reload this pagehttps://github.com/nodejs/node/pull/28704
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
review wanted https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22review%20wanted%22
wip https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Awip
Jul 28, 2019https://github.com/nodejs/node/pull/28704#event-2514670654
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
Jul 28, 2019https://github.com/nodejs/node/pull/28704#issuecomment-515754458
https://ci.nodejs.org/job/node-test-pull-request/24733/https://ci.nodejs.org/job/node-test-pull-request/24733/
Please reload this pagehttps://github.com/nodejs/node/pull/28704
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
Jul 28, 2019https://github.com/nodejs/node/pull/28704#issuecomment-515791271
Please reload this pagehttps://github.com/nodejs/node/pull/28704
https://github.com/jasnell
jasnellhttps://github.com/jasnell
Jul 29, 2019 https://github.com/nodejs/node/pull/28704#pullrequestreview-267856563
View reviewed changes https://github.com/nodejs/node/pull/28704/files/9d040477df657a9f9ec865f3c4e2ececd2894fb1
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
Jul 31, 2019https://github.com/nodejs/node/pull/28704#issuecomment-517062128
5207dechttps://github.com/nodejs/node/commit/5207dec0175de92116262e8382d6ac57def3a203
Please reload this pagehttps://github.com/nodejs/node/pull/28704
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
Jul 31, 2019https://github.com/nodejs/node/pull/28704#event-2524842758
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
July 31, 2019 23:41https://github.com/nodejs/node/pull/28704#event-2524842889
addaleaxhttps://github.com/addaleax
Jul 31, 2019 https://github.com/nodejs/node/pull/28704#ref-commit-5207dec
https://github.com/addaleax
src: allow generic C++ callables in SetImmediate()https://github.com/nodejs/node/commit/5207dec0175de92116262e8382d6ac57def3a203
5207dechttps://github.com/nodejs/node/commit/5207dec0175de92116262e8382d6ac57def3a203
#28704https://github.com/nodejs/node/pull/28704
targoshttps://github.com/targos
Aug 2, 2019 https://github.com/nodejs/node/pull/28704#ref-commit-d601a0a
https://github.com/addaleax
https://github.com/targos
src: allow generic C++ callables in SetImmediate()https://github.com/nodejs/node/commit/d601a0a9c0af2bf027d649360e9d0ed00b5de9ff
d601a0ahttps://github.com/nodejs/node/commit/d601a0a9c0af2bf027d649360e9d0ed00b5de9ff
#28704https://github.com/nodejs/node/pull/28704
https://github.com/BridgeAR
BridgeARhttps://github.com/BridgeAR
Aug 6, 2019 https://github.com/nodejs/node/pull/28704#ref-pullrequest-477378713
v12.8.0 release proposal #29017 https://github.com/nodejs/node/pull/29017
https://github.co/hiddenchars
https://github.com/nodejs/node/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F28704
https://github.com/jasnell
jasnell https://github.com/jasnell
https://github.com/nodejs/node/pull/28704/files/9d040477df657a9f9ec865f3c4e2ececd2894fb1
https://github.com/Fishrock123
Fishrock123 https://github.com/Fishrock123
https://github.com/nodejs/node/pull/28704/files/3cf4e258a61e5762830694a3c3b98a1086721bed
c++ https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Ac%2B%2B
lib / src https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22lib%20%2F%20src%22
review wanted https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22review%20wanted%22
Please reload this pagehttps://github.com/nodejs/node/pull/28704
https://github.com/addaleax
https://github.com/nodejs-github-bot
https://github.com/jasnell
https://github.com/Fishrock123
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.