René's URL Explorer Experiment


Title: test: improve variable names in pty_helper.py by addaleax · Pull Request #28688 · nodejs/node · GitHub

Open Graph Title: test: improve variable names in pty_helper.py by addaleax · Pull Request #28688 · nodejs/node

X Title: test: improve variable names in pty_helper.py by addaleax · Pull Request #28688 · nodejs/node

Description: Node.js JavaScript runtime ✨🐢🚀✨. Contribute to nodejs/node development by creating an account on GitHub.

Open Graph Description: Using names like parent_fd and child_fd is more accurate here, and doesn’t come with unnecessary negative connotations, even if the previous naming is somewhat common terminology here. Checklist ...

X Description: Using names like parent_fd and child_fd is more accurate here, and doesn’t come with unnecessary negative connotations, even if the previous naming is somewhat common terminology here. Checklist ...

Opengraph URL: https://github.com/nodejs/node/pull/28688

X: @github

direct link

Domain: github.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:c4758915-a146-4d6b-cbb7-2c4af268202f
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idD540:1B445F:46E6F0F:64E7E05:6A4FD1E6
html-safe-nonce97e8538d773f8ef74677b3e41ea6173e40edd97971b7435eb88e486d5053bb52
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJENTQwOjFCNDQ1Rjo0NkU2RjBGOjY0RTdFMDU6NkE0RkQxRTYiLCJ2aXNpdG9yX2lkIjoiNzg0NDMzMDE0MzgwMzc1NzAzMCIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmacdfcdd7ed257aefb34be8c9c7690832f6c87446b80c121dbca79e242c6fae74e1
hovercard-subject-tagpull_request:297432155
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/28688/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/e124c741e37bf0479ca08ef820889bb63b039d40b738ded97277fe618f612a0d/nodejs/node/pull/28688
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/e124c741e37bf0479ca08ef820889bb63b039d40b738ded97277fe618f612a0d/nodejs/node/pull/28688
og:image:altUsing names like parent_fd and child_fd is more accurate here, and doesn’t come with unnecessary negative connotations, even if the previous naming is somewhat common terminology here. Checklist ...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernameaddaleax
hostnamegithub.com
expected-hostnamegithub.com
None19b98c3d9767bb8a56238a89ff8401d1cbdf3bc5c353799aacf49fe6c76b4b7c
turbo-cache-controlno-cache
go-importgithub.com/nodejs/node git https://github.com/nodejs/node.git
octolytics-dimension-user_id9950313
octolytics-dimension-user_loginnodejs
octolytics-dimension-repository_id27193779
octolytics-dimension-repository_nwonodejs/node
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id27193779
octolytics-dimension-repository_network_root_nwonodejs/node
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release142593e66413bbae27fd485859993597d5a3b104
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/nodejs/node/pull/28688#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F28688
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub Copilot appDirect agents from issue to mergehttps://github.com/features/ai/github-app
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
View all resourceshttps://github.com/resources
GitHub SponsorsFund open source developershttps://github.com/open-source/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/open-source/accelerator
GitHub Starshttps://stars.github.com
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F28688
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode
Reloadhttps://github.com/nodejs/node/pull/28688
Reloadhttps://github.com/nodejs/node/pull/28688
Reloadhttps://github.com/nodejs/node/pull/28688
Please reload this pagehttps://github.com/nodejs/node/pull/28688
nodejs https://github.com/nodejs
nodehttps://github.com/nodejs/node
Please reload this pagehttps://github.com/nodejs/node/pull/28688
Notifications https://github.com/login?return_to=%2Fnodejs%2Fnode
Fork 36k https://github.com/login?return_to=%2Fnodejs%2Fnode
Star 118k https://github.com/login?return_to=%2Fnodejs%2Fnode
Code https://github.com/nodejs/node
Issues 1.3k https://github.com/nodejs/node/issues
Pull requests 973 https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects https://github.com/nodejs/node/projects
Security and quality 0 https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
Code https://github.com/nodejs/node
Issues https://github.com/nodejs/node/issues
Pull requests https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects https://github.com/nodejs/node/projects
Security and quality https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
addaleaxhttps://github.com/addaleax
nodejs:masterhttps://github.com/nodejs/node/tree/master
addaleax:pty-parent-childhttps://github.com/addaleax/node/tree/pty-parent-child
Conversationhttps://github.com/nodejs/node/pull/28688
Commits1 (1)https://github.com/nodejs/node/pull/28688/commits
Checkshttps://github.com/nodejs/node/pull/28688/checks
Files changedhttps://github.com/nodejs/node/pull/28688/files
test: improve variable names in pty_helper.pyhttps://github.com/nodejs/node/pull/28688#top
addaleaxhttps://github.com/addaleax
nodejs:masterhttps://github.com/nodejs/node/tree/master
addaleax:pty-parent-childhttps://github.com/addaleax/node/tree/pty-parent-child
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
Jul 14, 2019https://github.com/nodejs/node/pull/28688#issue-467890768
commit guidelineshttps://github.com/nodejs/node/blob/master/doc/guides/contributing/pull-requests.md#commit-message-guidelines
Please reload this pagehttps://github.com/nodejs/node/pull/28688
https://github.com/addaleax
test: improve variable names in pty_helper.pyhttps://github.com/nodejs/node/pull/28688/commits/a1f3ce84c9e8226c73de18302998bd2283e4f7ec
a1f3ce8https://github.com/nodejs/node/pull/28688/commits/a1f3ce84c9e8226c73de18302998bd2283e4f7ec
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
test https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Atest
tty https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Atty
Jul 14, 2019https://github.com/nodejs/node/pull/28688#event-2481522645
https://github.com/Trott
Trotthttps://github.com/Trott
Jul 15, 2019 https://github.com/nodejs/node/pull/28688#pullrequestreview-261635400
View reviewed changes https://github.com/nodejs/node/pull/28688/files/a1f3ce84c9e8226c73de18302998bd2283e4f7ec
https://github.com/cjihrig
cjihrighttps://github.com/cjihrig
Jul 15, 2019 https://github.com/nodejs/node/pull/28688#pullrequestreview-261796949
View reviewed changes https://github.com/nodejs/node/pull/28688/files/a1f3ce84c9e8226c73de18302998bd2283e4f7ec
https://github.com/jasnell
jasnellhttps://github.com/jasnell
Jul 15, 2019 https://github.com/nodejs/node/pull/28688#pullrequestreview-261867853
View reviewed changes https://github.com/nodejs/node/pull/28688/files/a1f3ce84c9e8226c73de18302998bd2283e4f7ec
https://github.com/trivikr
trivikrhttps://github.com/trivikr
Jul 15, 2019 https://github.com/nodejs/node/pull/28688#pullrequestreview-262057452
View reviewed changes https://github.com/nodejs/node/pull/28688/files/a1f3ce84c9e8226c73de18302998bd2283e4f7ec
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
author ready https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22author%20ready%22
Jul 15, 2019https://github.com/nodejs/node/pull/28688#event-2484149013
https://github.com/nodejs-github-bot
Sign in to viewhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F28688
https://github.com/nodejs-github-bot
Sign in to viewhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F28688
https://github.com/nodejs-github-bot
Sign in to viewhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F28688
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
Jul 17, 2019https://github.com/nodejs/node/pull/28688#issuecomment-512578883
https://ci.nodejs.org/job/node-test-pull-request/24524/https://ci.nodejs.org/job/node-test-pull-request/24524/
Please reload this pagehttps://github.com/nodejs/node/pull/28688
https://github.com/Trott
Trotthttps://github.com/Trott
Jul 17, 2019https://github.com/nodejs/node/pull/28688#issuecomment-512583729
971915ehttps://github.com/nodejs/node/commit/971915e89f1106444453eba39263ade92b3ed598
Please reload this pagehttps://github.com/nodejs/node/pull/28688
https://github.com/Trott
Trotthttps://github.com/Trott
Jul 17, 2019https://github.com/nodejs/node/pull/28688#event-2490979479
Trotthttps://github.com/Trott
Jul 17, 2019 https://github.com/nodejs/node/pull/28688#ref-commit-971915e
https://github.com/addaleax
https://github.com/Trott
test: improve variable names in pty_helper.pyhttps://github.com/Trott/io.js/commit/971915e89f1106444453eba39263ade92b3ed598
971915ehttps://github.com/Trott/io.js/commit/971915e89f1106444453eba39263ade92b3ed598
nodejs#28688https://github.com/nodejs/node/pull/28688
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
July 17, 2019 22:15https://github.com/nodejs/node/pull/28688#event-2491015337
targoshttps://github.com/targos
Jul 20, 2019 https://github.com/nodejs/node/pull/28688#ref-commit-af6608c
https://github.com/addaleax
https://github.com/targos
test: improve variable names in pty_helper.pyhttps://github.com/nodejs/node/commit/af6608ca1113af4617626db9e950865e4e486403
af6608chttps://github.com/nodejs/node/commit/af6608ca1113af4617626db9e950865e4e486403
#28688https://github.com/nodejs/node/pull/28688
v12.7.0 release proposal #28816 https://github.com/nodejs/node/pull/28816
v12.7.0 release proposal #28817 https://github.com/nodejs/node/pull/28817
vikashk1https://github.com/vikashk1
Aug 13, 2019 https://github.com/nodejs/node/pull/28688#ref-commit-9af17ad
https://github.com/vikashk1
Please ignore this msg (https://github.com/vikashk1/node/commit/9af17ad05c8161db7f52de5fd3331a94857e33fc
#1https://github.com/vikashk1/node/pull/1
)https://github.com/vikashk1/node/commit/9af17ad05c8161db7f52de5fd3331a94857e33fc
9af17adhttps://github.com/vikashk1/node/commit/9af17ad05c8161db7f52de5fd3331a94857e33fc
https://github.co/hiddenchars
https://github.com/nodejs/node/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F28688
https://github.com/jasnell
jasnell https://github.com/jasnell
https://github.com/nodejs/node/pull/28688/files/a1f3ce84c9e8226c73de18302998bd2283e4f7ec
https://github.com/Trott
Trott https://github.com/Trott
https://github.com/nodejs/node/pull/28688/files/a1f3ce84c9e8226c73de18302998bd2283e4f7ec
https://github.com/cjihrig
cjihrig https://github.com/cjihrig
https://github.com/nodejs/node/pull/28688/files/a1f3ce84c9e8226c73de18302998bd2283e4f7ec
https://github.com/trivikr
trivikr https://github.com/trivikr
https://github.com/nodejs/node/pull/28688/files/a1f3ce84c9e8226c73de18302998bd2283e4f7ec
author ready https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22author%20ready%22
test https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Atest
tty https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Atty
Please reload this pagehttps://github.com/nodejs/node/pull/28688
https://github.com/addaleax
https://github.com/nodejs-github-bot
https://github.com/Trott
https://github.com/jasnell
https://github.com/cjihrig
https://github.com/trivikr
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.