| route-pattern | /_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format) |
| route-controller | voltron_pull_requests_fragments |
| route-action | pull_request_layout |
| fetch-nonce | v2:1391e189-ec96-f5e0-8e00-76f93f55ed54 |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | 9CC0:397AD8:5C4D04E:81DBF37:6A4FF3D5 |
| html-safe-nonce | 8291435e00d6c38bed883649d221b0722889d886e5a4e8a30dabf27abf445a73 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI5Q0MwOjM5N0FEODo1QzREMDRFOjgxREJGMzc6NkE0RkYzRDUiLCJ2aXNpdG9yX2lkIjoiNTkxNzgzMDY3MDk1Mzk3MzMzIiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0= |
| visitor-hmac | 0e6429e134838f252ed1ffef4323eb9dcd40666fe69c27b8883ad3933661a8ec |
| hovercard-subject-tag | pull_request:296764688 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///voltron/pull_requests_fragments/pull_request_layout |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/28643/pull_request_layout |
| twitter:image | https://opengraph.githubassets.com/6505dfd31cd4de24b6ae253e0d51608ad0c5e9c30ff90cf9a1e6c954c1fbff26/nodejs/node/pull/28643 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/6505dfd31cd4de24b6ae253e0d51608ad0c5e9c30ff90cf9a1e6c954c1fbff26/nodejs/node/pull/28643 |
| og:image:alt | The various* TSFN APIs are marked as stable, but the TSFN heading itself
is still marked as experimental.
Checklist
make -j4 test (UNIX), or vcbuild test (Windows) passes
documentation is chan... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | gabrielschulhof |
| hostname | github.com |
| expected-hostname | github.com |
| None | 19b98c3d9767bb8a56238a89ff8401d1cbdf3bc5c353799aacf49fe6c76b4b7c |
| turbo-cache-control | no-cache |
| go-import | github.com/nodejs/node git https://github.com/nodejs/node.git |
| octolytics-dimension-user_id | 9950313 |
| octolytics-dimension-user_login | nodejs |
| octolytics-dimension-repository_id | 27193779 |
| octolytics-dimension-repository_nwo | nodejs/node |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 27193779 |
| octolytics-dimension-repository_network_root_nwo | nodejs/node |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | f7e270be010aa4de2871991025fbb97f3afe2bcb |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| Skip to content | https://github.com/nodejs/node/pull/28643#start-of-content |
|
| https://github.com/ |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F28643 |
| GitHub CopilotWrite better code with AI | https://github.com/features/copilot |
| GitHub Copilot appDirect agents from issue to merge | https://github.com/features/ai/github-app |
| MCP RegistryNewIntegrate external tools | https://github.com/mcp |
| ActionsAutomate any workflow | https://github.com/features/actions |
| CodespacesInstant dev environments | https://github.com/features/codespaces |
| IssuesPlan and track work | https://github.com/features/issues |
| Code ReviewManage code changes | https://github.com/features/code-review |
| GitHub Advanced SecurityFind and fix vulnerabilities | https://github.com/security/advanced-security |
| Code securitySecure your code as you build | https://github.com/security/advanced-security/code-security |
| Secret protectionStop leaks before they start | https://github.com/security/advanced-security/secret-protection |
| Why GitHub | https://github.com/why-github |
| Documentation | https://docs.github.com |
| Blog | https://github.blog |
| Changelog | https://github.blog/changelog |
| Marketplace | https://github.com/marketplace |
| View all features | https://github.com/features |
| Enterprises | https://github.com/enterprise |
| Small and medium teams | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| App Modernization | https://github.com/solutions/use-case/app-modernization |
| DevSecOps | https://github.com/solutions/use-case/devsecops |
| DevOps | https://github.com/solutions/use-case/devops |
| CI/CD | https://github.com/solutions/use-case/ci-cd |
| View all use cases | https://github.com/solutions/use-case |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| View all industries | https://github.com/solutions/industry |
| View all solutions | https://github.com/solutions |
| AI | https://github.com/resources/articles?topic=ai |
| Software Development | https://github.com/resources/articles?topic=software-development |
| DevOps | https://github.com/resources/articles?topic=devops |
| Security | https://github.com/resources/articles?topic=security |
| View all topics | https://github.com/resources/articles |
| Customer stories | https://github.com/customer-stories |
| Events & webinars | https://github.com/resources/events |
| Ebooks & reports | https://github.com/resources/whitepapers |
| Business insights | https://github.com/solutions/executive-insights |
| GitHub Skills | https://skills.github.com |
| Documentation | https://docs.github.com |
| Customer support | https://support.github.com |
| Community forum | https://github.com/orgs/community/discussions |
| Trust center | https://github.com/trust-center |
| Partners | https://github.com/partners |
| View all resources | https://github.com/resources |
| GitHub SponsorsFund open source developers | https://github.com/open-source/sponsors |
| Security Lab | https://securitylab.github.com |
| Maintainer Community | https://maintainers.github.com |
| Accelerator | https://github.com/open-source/accelerator |
| GitHub Stars | https://stars.github.com |
| Archive Program | https://archiveprogram.github.com |
| Topics | https://github.com/topics |
| Trending | https://github.com/trending |
| Collections | https://github.com/collections |
| Enterprise platformAI-powered developer platform | https://github.com/enterprise |
| GitHub Advanced SecurityEnterprise-grade security features | https://github.com/security/advanced-security |
| Copilot for BusinessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/enterprise/premium-support |
| Pricing | https://github.com/pricing |
| Search syntax tips | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
| documentation | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F28643 |
|
Sign up
| https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode |
| Reload | https://github.com/nodejs/node/pull/28643 |
| Reload | https://github.com/nodejs/node/pull/28643 |
| Reload | https://github.com/nodejs/node/pull/28643 |
| Please reload this page | https://github.com/nodejs/node/pull/28643 |
|
nodejs
| https://github.com/nodejs |
| node | https://github.com/nodejs/node |
| Please reload this page | https://github.com/nodejs/node/pull/28643 |
|
Notifications
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Fork
36k
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Star
118k
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Code
| https://github.com/nodejs/node |
|
Issues
1.3k
| https://github.com/nodejs/node/issues |
|
Pull requests
976
| https://github.com/nodejs/node/pulls |
|
Actions
| https://github.com/nodejs/node/actions |
|
Projects
| https://github.com/nodejs/node/projects |
|
Security and quality
0
| https://github.com/nodejs/node/security |
|
Insights
| https://github.com/nodejs/node/pulse |
|
Code
| https://github.com/nodejs/node |
|
Issues
| https://github.com/nodejs/node/issues |
|
Pull requests
| https://github.com/nodejs/node/pulls |
|
Actions
| https://github.com/nodejs/node/actions |
|
Projects
| https://github.com/nodejs/node/projects |
|
Security and quality
| https://github.com/nodejs/node/security |
|
Insights
| https://github.com/nodejs/node/pulse |
| gabrielschulhof | https://github.com/gabrielschulhof |
| nodejs:master | https://github.com/nodejs/node/tree/master |
| gabrielschulhof:n-api-remove-experimental-from-heading | https://github.com/gabrielschulhof/node/tree/n-api-remove-experimental-from-heading |
| Conversation | https://github.com/nodejs/node/pull/28643 |
| Commits1 (1) | https://github.com/nodejs/node/pull/28643/commits |
| Checks | https://github.com/nodejs/node/pull/28643/checks |
| Files changed | https://github.com/nodejs/node/pull/28643/files |
| doc: mark N-API thread-safe function stable | https://github.com/nodejs/node/pull/28643#top |
| gabrielschulhof | https://github.com/gabrielschulhof |
| nodejs:master | https://github.com/nodejs/node/tree/master |
| gabrielschulhof:n-api-remove-experimental-from-heading | https://github.com/gabrielschulhof/node/tree/n-api-remove-experimental-from-heading |
|
| https://github.com/gabrielschulhof |
| gabrielschulhof | https://github.com/gabrielschulhof |
| Jul 11, 2019 | https://github.com/nodejs/node/pull/28643#issue-467032473 |
| Please reload this page | https://github.com/nodejs/node/pull/28643 |
| commit guidelines | https://github.com/nodejs/node/blob/master/doc/guides/contributing/pull-requests.md#commit-message-guidelines |
| Please reload this page | https://github.com/nodejs/node/pull/28643 |
| https://github.com/nodejs-github-bot |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
|
doc
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Adoc |
|
node-api
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Anode-api |
| Jul 11, 2019 | https://github.com/nodejs/node/pull/28643#event-2476800899 |
| https://github.com/gabrielschulhof |
| gabrielschulhof | https://github.com/gabrielschulhof |
| force-pushed | https://github.com/nodejs/node/compare/1c8f22f8a11fb47efee229f48754ad7bb501f6cb..6752625a8e4b9e0b5a445525b481f3b12c3f34cf |
| 1c8f22f | https://github.com/nodejs/node/commit/1c8f22f8a11fb47efee229f48754ad7bb501f6cb |
| 6752625 | https://github.com/nodejs/node/commit/6752625a8e4b9e0b5a445525b481f3b12c3f34cf |
|
Compare
| https://github.com/nodejs/node/compare/1c8f22f8a11fb47efee229f48754ad7bb501f6cb..6752625a8e4b9e0b5a445525b481f3b12c3f34cf |
| July 11, 2019 18:05 | https://github.com/nodejs/node/pull/28643#event-2476802054 |
| https://github.com/cjihrig |
| cjihrig | https://github.com/cjihrig |
|
Jul 11, 2019
| https://github.com/nodejs/node/pull/28643#pullrequestreview-260867695 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/28643/files |
| https://github.com/lpinca |
| lpinca | https://github.com/lpinca |
|
Jul 11, 2019
| https://github.com/nodejs/node/pull/28643#pullrequestreview-260898679 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/28643/files |
| https://github.com/BridgeAR |
| BridgeAR | https://github.com/BridgeAR |
|
Jul 11, 2019
| https://github.com/nodejs/node/pull/28643#pullrequestreview-260967723 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/28643/files |
| https://github.com/Trott |
| Trott | https://github.com/Trott |
|
Jul 12, 2019
| https://github.com/nodejs/node/pull/28643#pullrequestreview-261053729 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/28643/files |
| doc/api/n-api.md | https://github.com/nodejs/node/pull/28643/files#diff-26709ee1f9f0cb60d2d67f45106b31de8ed5eb28ad66c91903fd935a6d607d4d |
| Trott | https://github.com/Trott |
| Jul 12, 2019 | https://github.com/nodejs/node/pull/28643#discussion_r302823033 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| #28485 | https://github.com/nodejs/node/pull/28485 |
| @cjihrig | https://github.com/cjihrig |
| Please reload this page | https://github.com/nodejs/node/pull/28643 |
| Trott | https://github.com/Trott |
| Jul 12, 2019 | https://github.com/nodejs/node/pull/28643#discussion_r302823089 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| #28485 | https://github.com/nodejs/node/pull/28485 |
| @cjihrig | https://github.com/cjihrig |
| @cjihrig | https://github.com/cjihrig |
| Please reload this page | https://github.com/nodejs/node/pull/28643 |
| cjihrig | https://github.com/cjihrig |
| Jul 12, 2019 | https://github.com/nodejs/node/pull/28643#discussion_r302965978 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/28643 |
| gabrielschulhof | https://github.com/gabrielschulhof |
| Jul 12, 2019 | https://github.com/nodejs/node/pull/28643#discussion_r303047660 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| @Trott | https://github.com/Trott |
| @cjihrig | https://github.com/cjihrig |
| Please reload this page | https://github.com/nodejs/node/pull/28643 |
| gabrielschulhof | https://github.com/gabrielschulhof |
| Jul 12, 2019 | https://github.com/nodejs/node/pull/28643#discussion_r303049260 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/28643 |
| cjihrig | https://github.com/cjihrig |
| Jul 12, 2019 | https://github.com/nodejs/node/pull/28643#discussion_r303051802 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| @gabrielschulhof | https://github.com/gabrielschulhof |
| Please reload this page | https://github.com/nodejs/node/pull/28643 |
| gabrielschulhof | https://github.com/gabrielschulhof |
| Jul 12, 2019 | https://github.com/nodejs/node/pull/28643#discussion_r303054605 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| @cjihrig | https://github.com/cjihrig |
| Please reload this page | https://github.com/nodejs/node/pull/28643 |
| doc: mark N-API thread-safe function stable | https://github.com/nodejs/node/pull/28643/commits/e3359836d9620c2b1e256c066f885829894e3b4a |
| e335983 | https://github.com/nodejs/node/pull/28643/commits/e3359836d9620c2b1e256c066f885829894e3b4a |
| https://github.com/gabrielschulhof |
| gabrielschulhof | https://github.com/gabrielschulhof |
| force-pushed | https://github.com/nodejs/node/compare/6752625a8e4b9e0b5a445525b481f3b12c3f34cf..e3359836d9620c2b1e256c066f885829894e3b4a |
| 6752625 | https://github.com/nodejs/node/commit/6752625a8e4b9e0b5a445525b481f3b12c3f34cf |
| e335983 | https://github.com/nodejs/node/commit/e3359836d9620c2b1e256c066f885829894e3b4a |
|
Compare
| https://github.com/nodejs/node/compare/6752625a8e4b9e0b5a445525b481f3b12c3f34cf..e3359836d9620c2b1e256c066f885829894e3b4a |
| July 12, 2019 16:21 | https://github.com/nodejs/node/pull/28643#event-2479557251 |
| https://github.com/Trott |
| Trott | https://github.com/Trott |
|
Jul 12, 2019
| https://github.com/nodejs/node/pull/28643#pullrequestreview-261491250 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/28643/files/e3359836d9620c2b1e256c066f885829894e3b4a |
| https://github.com/nodejs-github-bot |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
| Jul 14, 2019 | https://github.com/nodejs/node/pull/28643#issuecomment-511222558 |
| https://ci.nodejs.org/job/node-test-pull-request/24428/ | https://ci.nodejs.org/job/node-test-pull-request/24428/ |
| Please reload this page | https://github.com/nodejs/node/pull/28643 |
| https://github.com/gabrielschulhof |
| gabrielschulhof | https://github.com/gabrielschulhof |
| Jul 14, 2019 | https://github.com/nodejs/node/pull/28643#issuecomment-511226450 |
| efc3946 | https://github.com/nodejs/node/commit/efc39464b0d813f15188d2d9cf14b74bcca61750 |
| Please reload this page | https://github.com/nodejs/node/pull/28643 |
| https://github.com/gabrielschulhof |
| gabrielschulhof | https://github.com/gabrielschulhof |
| Jul 14, 2019 | https://github.com/nodejs/node/pull/28643#event-2481432951 |
| gabrielschulhof | https://github.com/gabrielschulhof |
|
Jul 14, 2019
| https://github.com/nodejs/node/pull/28643#ref-commit-efc3946 |
| doc: mark N-API thread-safe function stable | https://github.com/gabrielschulhof/node/commit/efc39464b0d813f15188d2d9cf14b74bcca61750 |
| efc3946 | https://github.com/gabrielschulhof/node/commit/efc39464b0d813f15188d2d9cf14b74bcca61750 |
| nodejs#28643 | https://github.com/nodejs/node/pull/28643 |
| https://github.com/gabrielschulhof |
| gabrielschulhof | https://github.com/gabrielschulhof |
| July 14, 2019 18:52 | https://github.com/nodejs/node/pull/28643#event-2481433399 |
| targos | https://github.com/targos |
|
Jul 20, 2019
| https://github.com/nodejs/node/pull/28643#ref-commit-aee8694 |
|
| https://github.com/targos |
| doc: mark N-API thread-safe function stable | https://github.com/nodejs/node/commit/aee86940f9ca31d09389579b2b2e5fac292e192a |
| aee8694 | https://github.com/nodejs/node/commit/aee86940f9ca31d09389579b2b2e5fac292e192a |
| #28643 | https://github.com/nodejs/node/pull/28643 |
|
v12.7.0 release proposal
#28816
| https://github.com/nodejs/node/pull/28816 |
|
v12.7.0 release proposal
#28817
| https://github.com/nodejs/node/pull/28817 |
| vikashk1 | https://github.com/vikashk1 |
|
Aug 13, 2019
| https://github.com/nodejs/node/pull/28643#ref-commit-9af17ad |
|
| https://github.com/vikashk1 |
| Please ignore this msg ( | https://github.com/vikashk1/node/commit/9af17ad05c8161db7f52de5fd3331a94857e33fc |
| #1 | https://github.com/vikashk1/node/pull/1 |
| ) | https://github.com/vikashk1/node/commit/9af17ad05c8161db7f52de5fd3331a94857e33fc |
| 9af17ad | https://github.com/vikashk1/node/commit/9af17ad05c8161db7f52de5fd3331a94857e33fc |
| https://github.com/hrsakai |
| hrsakai | https://github.com/hrsakai |
|
Oct 30, 2019
| https://github.com/nodejs/node/pull/28643#ref-pullrequest-501738044 |
|
Add listener support for consumer
apache/pulsar-client-node#56
| https://github.com/apache/pulsar-client-node/pull/56 |
| https://github.co/hiddenchars |
| https://github.com/nodejs/node/pull/{{ revealButtonHref }} |
| Sign up for free | https://github.com/join?source=comment-repo |
| Sign in to comment | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F28643 |
|
| https://github.com/cjihrig |
|
cjihrig
| https://github.com/cjihrig |
|
| https://github.com/nodejs/node/pull/28643/files/6752625a8e4b9e0b5a445525b481f3b12c3f34cf |
|
| https://github.com/Trott |
|
Trott
| https://github.com/Trott |
|
| https://github.com/nodejs/node/pull/28643/files/e3359836d9620c2b1e256c066f885829894e3b4a |
|
| https://github.com/lpinca |
|
lpinca
| https://github.com/lpinca |
|
| https://github.com/nodejs/node/pull/28643/files/6752625a8e4b9e0b5a445525b481f3b12c3f34cf |
|
| https://github.com/BridgeAR |
|
BridgeAR
| https://github.com/BridgeAR |
|
| https://github.com/nodejs/node/pull/28643/files/6752625a8e4b9e0b5a445525b481f3b12c3f34cf |
|
doc
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Adoc |
|
node-api
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Anode-api |
| Please reload this page | https://github.com/nodejs/node/pull/28643 |
|
| https://github.com/gabrielschulhof |
|
| https://github.com/nodejs-github-bot |
|
| https://github.com/Trott |
|
| https://github.com/lpinca |
|
| https://github.com/cjihrig |
|
| https://github.com/BridgeAR |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |