| route-pattern | /_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format) |
| route-controller | voltron_pull_requests_fragments |
| route-action | pull_request_layout |
| fetch-nonce | v2:f56003b9-9b08-eb28-208c-61d98d5d5a68 |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | E7B2:1EDC:E59077:14A1901:6A4FAF2D |
| html-safe-nonce | ab0902db5424646516b254e2ac8b9d6e8836320e32a707cc1e16273aadb7b55d |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJFN0IyOjFFREM6RTU5MDc3OjE0QTE5MDE6NkE0RkFGMkQiLCJ2aXNpdG9yX2lkIjoiMzE3MTQ4OTY4ODA3MTQxNzY0NSIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9 |
| visitor-hmac | 123d14ba77e93ea42fd134a65e7e9bbe488b276d20a7605da2a7a5789b4e8db1 |
| hovercard-subject-tag | pull_request:296736333 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///voltron/pull_requests_fragments/pull_request_layout |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/28641/pull_request_layout |
| twitter:image | https://opengraph.githubassets.com/57859ed9821896aa339c51af4654d0758549b339bae2822dd60a0a4d2c0201df/nodejs/node/pull/28641 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/57859ed9821896aa339c51af4654d0758549b339bae2822dd60a0a4d2c0201df/nodejs/node/pull/28641 |
| og:image:alt | This commit adds an optional callback to clearScreenDown(), which is passed to the stream's write() method. It also exposes the return value of write().
If this change is accepted, I plan to up... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | cjihrig |
| hostname | github.com |
| expected-hostname | github.com |
| None | b92d11c0aa4a77d54ef4af1078b6a15fb5a70a215b30c4ecf28889d5a8e656d9 |
| turbo-cache-control | no-cache |
| go-import | github.com/nodejs/node git https://github.com/nodejs/node.git |
| octolytics-dimension-user_id | 9950313 |
| octolytics-dimension-user_login | nodejs |
| octolytics-dimension-repository_id | 27193779 |
| octolytics-dimension-repository_nwo | nodejs/node |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 27193779 |
| octolytics-dimension-repository_network_root_nwo | nodejs/node |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 4b249b445842943ed31549e027f57a8ade9881ed |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| Skip to content | https://github.com/nodejs/node/pull/28641#start-of-content |
|
| https://github.com/ |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F28641 |
| GitHub CopilotWrite better code with AI | https://github.com/features/copilot |
| GitHub Copilot appDirect agents from issue to merge | https://github.com/features/ai/github-app |
| MCP RegistryNewIntegrate external tools | https://github.com/mcp |
| ActionsAutomate any workflow | https://github.com/features/actions |
| CodespacesInstant dev environments | https://github.com/features/codespaces |
| IssuesPlan and track work | https://github.com/features/issues |
| Code ReviewManage code changes | https://github.com/features/code-review |
| GitHub Advanced SecurityFind and fix vulnerabilities | https://github.com/security/advanced-security |
| Code securitySecure your code as you build | https://github.com/security/advanced-security/code-security |
| Secret protectionStop leaks before they start | https://github.com/security/advanced-security/secret-protection |
| Why GitHub | https://github.com/why-github |
| Documentation | https://docs.github.com |
| Blog | https://github.blog |
| Changelog | https://github.blog/changelog |
| Marketplace | https://github.com/marketplace |
| View all features | https://github.com/features |
| Enterprises | https://github.com/enterprise |
| Small and medium teams | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| App Modernization | https://github.com/solutions/use-case/app-modernization |
| DevSecOps | https://github.com/solutions/use-case/devsecops |
| DevOps | https://github.com/solutions/use-case/devops |
| CI/CD | https://github.com/solutions/use-case/ci-cd |
| View all use cases | https://github.com/solutions/use-case |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| View all industries | https://github.com/solutions/industry |
| View all solutions | https://github.com/solutions |
| AI | https://github.com/resources/articles?topic=ai |
| Software Development | https://github.com/resources/articles?topic=software-development |
| DevOps | https://github.com/resources/articles?topic=devops |
| Security | https://github.com/resources/articles?topic=security |
| View all topics | https://github.com/resources/articles |
| Customer stories | https://github.com/customer-stories |
| Events & webinars | https://github.com/resources/events |
| Ebooks & reports | https://github.com/resources/whitepapers |
| Business insights | https://github.com/solutions/executive-insights |
| GitHub Skills | https://skills.github.com |
| Documentation | https://docs.github.com |
| Customer support | https://support.github.com |
| Community forum | https://github.com/orgs/community/discussions |
| Trust center | https://github.com/trust-center |
| Partners | https://github.com/partners |
| View all resources | https://github.com/resources |
| GitHub SponsorsFund open source developers | https://github.com/open-source/sponsors |
| Security Lab | https://securitylab.github.com |
| Maintainer Community | https://maintainers.github.com |
| Accelerator | https://github.com/open-source/accelerator |
| GitHub Stars | https://stars.github.com |
| Archive Program | https://archiveprogram.github.com |
| Topics | https://github.com/topics |
| Trending | https://github.com/trending |
| Collections | https://github.com/collections |
| Enterprise platformAI-powered developer platform | https://github.com/enterprise |
| GitHub Advanced SecurityEnterprise-grade security features | https://github.com/security/advanced-security |
| Copilot for BusinessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/enterprise/premium-support |
| Pricing | https://github.com/pricing |
| Search syntax tips | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
| documentation | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F28641 |
|
Sign up
| https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode |
| Reload | https://github.com/nodejs/node/pull/28641 |
| Reload | https://github.com/nodejs/node/pull/28641 |
| Reload | https://github.com/nodejs/node/pull/28641 |
| Please reload this page | https://github.com/nodejs/node/pull/28641 |
|
nodejs
| https://github.com/nodejs |
| node | https://github.com/nodejs/node |
| Please reload this page | https://github.com/nodejs/node/pull/28641 |
|
Notifications
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Fork
36k
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Star
118k
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Code
| https://github.com/nodejs/node |
|
Issues
1.3k
| https://github.com/nodejs/node/issues |
|
Pull requests
971
| https://github.com/nodejs/node/pulls |
|
Actions
| https://github.com/nodejs/node/actions |
|
Projects
| https://github.com/nodejs/node/projects |
|
Security and quality
0
| https://github.com/nodejs/node/security |
|
Insights
| https://github.com/nodejs/node/pulse |
|
Code
| https://github.com/nodejs/node |
|
Issues
| https://github.com/nodejs/node/issues |
|
Pull requests
| https://github.com/nodejs/node/pulls |
|
Actions
| https://github.com/nodejs/node/actions |
|
Projects
| https://github.com/nodejs/node/projects |
|
Security and quality
| https://github.com/nodejs/node/security |
|
Insights
| https://github.com/nodejs/node/pulse |
| cjihrig | https://github.com/cjihrig |
| nodejs:master | https://github.com/nodejs/node/tree/master |
| cjihrig:clearscreendown | https://github.com/cjihrig/node/tree/clearscreendown |
| Conversation | https://github.com/nodejs/node/pull/28641 |
| Commits1 (1) | https://github.com/nodejs/node/pull/28641/commits |
| Checks | https://github.com/nodejs/node/pull/28641/checks |
| Files changed | https://github.com/nodejs/node/pull/28641/files |
| readline: expose stream API in clearScreenDown() | https://github.com/nodejs/node/pull/28641#top |
| cjihrig | https://github.com/cjihrig |
| nodejs:master | https://github.com/nodejs/node/tree/master |
| cjihrig:clearscreendown | https://github.com/cjihrig/node/tree/clearscreendown |
|
| https://github.com/cjihrig |
| cjihrig | https://github.com/cjihrig |
| Jul 11, 2019 | https://github.com/nodejs/node/pull/28641#issue-466997820 |
| commit guidelines | https://github.com/nodejs/node/blob/master/doc/guides/contributing/pull-requests.md#commit-message-guidelines |
| Please reload this page | https://github.com/nodejs/node/pull/28641 |
| https://github.com/nodejs-github-bot |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
|
readline
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Areadline |
| Jul 11, 2019 | https://github.com/nodejs/node/pull/28641#event-2476577390 |
| https://github.com/cjihrig |
| cjihrig | https://github.com/cjihrig |
| force-pushed | https://github.com/nodejs/node/compare/28be8cdbfb596f1e2b7acf3f195644721bdeacf1..04faab5ea8ca224ea324a191817c42420a947a4b |
| 28be8cd | https://github.com/nodejs/node/commit/28be8cdbfb596f1e2b7acf3f195644721bdeacf1 |
| 04faab5 | https://github.com/nodejs/node/commit/04faab5ea8ca224ea324a191817c42420a947a4b |
|
Compare
| https://github.com/nodejs/node/compare/28be8cdbfb596f1e2b7acf3f195644721bdeacf1..04faab5ea8ca224ea324a191817c42420a947a4b |
| July 11, 2019 16:40 | https://github.com/nodejs/node/pull/28641#event-2476578791 |
| https://github.com/cjihrig |
| cjihrig | https://github.com/cjihrig |
| addaleax | https://github.com/addaleax |
| July 11, 2019 16:40 | https://github.com/nodejs/node/pull/28641#event-2476579874 |
| https://github.com/cjihrig |
| cjihrig | https://github.com/cjihrig |
|
semver-minor
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Asemver-minor |
| Jul 11, 2019 | https://github.com/nodejs/node/pull/28641#event-2476594659 |
| https://github.com/targos |
| targos | https://github.com/targos |
|
Jul 12, 2019
| https://github.com/nodejs/node/pull/28641#pullrequestreview-261100365 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/28641/files |
| https://github.com/nodejs-github-bot |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
| Jul 12, 2019 | https://github.com/nodejs/node/pull/28641#issuecomment-510886970 |
| Please reload this page | https://github.com/nodejs/node/pull/28641 |
| https://ci.nodejs.org/job/node-test-pull-request/24407/ | https://ci.nodejs.org/job/node-test-pull-request/24407/ |
| Please reload this page | https://github.com/nodejs/node/pull/28641 |
| https://github.com/cjihrig |
| cjihrig | https://github.com/cjihrig |
|
author ready
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22author%20ready%22 |
| Jul 12, 2019 | https://github.com/nodejs/node/pull/28641#event-2479152803 |
| https://github.com/Fishrock123 |
| Fishrock123 | https://github.com/Fishrock123 |
| Jul 12, 2019 | https://github.com/nodejs/node/pull/28641#issuecomment-510948099 |
| Please reload this page | https://github.com/nodejs/node/pull/28641 |
| https://github.com/cjihrig |
| cjihrig | https://github.com/cjihrig |
| Jul 12, 2019 | https://github.com/nodejs/node/pull/28641#issuecomment-510949408 |
| this discussion | https://github.com/nodejs/node/pull/28407#discussion_r298854395 |
| @addaleax | https://github.com/addaleax |
| Please reload this page | https://github.com/nodejs/node/pull/28641 |
| https://github.com/addaleax |
| addaleax | https://github.com/addaleax |
|
Jul 13, 2019
| https://github.com/nodejs/node/pull/28641#pullrequestreview-261534545 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/28641/files |
|
| https://github.com/cjihrig |
| readline: expose stream API in clearScreenDown() | https://github.com/nodejs/node/pull/28641/commits/c31f7e595af85da8ada5d278e6e96e8537b57435 |
|
| https://github.com/nodejs/node/commit/c31f7e595af85da8ada5d278e6e96e8537b57435#comments |
| c31f7e5 | https://github.com/nodejs/node/pull/28641/commits/c31f7e595af85da8ada5d278e6e96e8537b57435 |
| nodejs#28641 | https://github.com/nodejs/node/pull/28641 |
| https://github.com/cjihrig |
| cjihrig | https://github.com/cjihrig |
| force-pushed | https://github.com/nodejs/node/compare/04faab5ea8ca224ea324a191817c42420a947a4b..c31f7e595af85da8ada5d278e6e96e8537b57435 |
| 04faab5 | https://github.com/nodejs/node/commit/04faab5ea8ca224ea324a191817c42420a947a4b |
| c31f7e5 | https://github.com/nodejs/node/commit/c31f7e595af85da8ada5d278e6e96e8537b57435 |
|
Compare
| https://github.com/nodejs/node/compare/04faab5ea8ca224ea324a191817c42420a947a4b..c31f7e595af85da8ada5d278e6e96e8537b57435 |
| July 13, 2019 20:20 | https://github.com/nodejs/node/pull/28641#event-2480955825 |
| https://github.com/cjihrig |
| cjihrig | https://github.com/cjihrig |
| c31f7e5 | https://github.com/nodejs/node/commit/c31f7e595af85da8ada5d278e6e96e8537b57435 |
| Jul 13, 2019 | https://github.com/nodejs/node/pull/28641#event-2480956547 |
| https://github.com/cjihrig |
| cjihrig | https://github.com/cjihrig |
| July 13, 2019 20:22 | https://github.com/nodejs/node/pull/28641#event-2480956641 |
| https://github.com/cjihrig |
| cjihrig | https://github.com/cjihrig |
|
Jul 14, 2019
| https://github.com/nodejs/node/pull/28641#ref-pullrequest-467779164 |
|
readline: expose stream API
#28674
| https://github.com/nodejs/node/pull/28674 |
| targos | https://github.com/targos |
|
Jul 20, 2019
| https://github.com/nodejs/node/pull/28641#ref-commit-17df75f |
|
| https://github.com/cjihrig |
|
| https://github.com/targos |
| readline: expose stream API in clearScreenDown() | https://github.com/nodejs/node/commit/17df75f5c961bfbaddf8f18359ccc7d18092c5c2 |
| 17df75f | https://github.com/nodejs/node/commit/17df75f5c961bfbaddf8f18359ccc7d18092c5c2 |
| #28641 | https://github.com/nodejs/node/pull/28641 |
|
v12.7.0 release proposal
#28816
| https://github.com/nodejs/node/pull/28816 |
|
v12.7.0 release proposal
#28817
| https://github.com/nodejs/node/pull/28817 |
| vikashk1 | https://github.com/vikashk1 |
|
Aug 13, 2019
| https://github.com/nodejs/node/pull/28641#ref-commit-9af17ad |
|
| https://github.com/vikashk1 |
| Please ignore this msg ( | https://github.com/vikashk1/node/commit/9af17ad05c8161db7f52de5fd3331a94857e33fc |
| #1 | https://github.com/vikashk1/node/pull/1 |
| ) | https://github.com/vikashk1/node/commit/9af17ad05c8161db7f52de5fd3331a94857e33fc |
| 9af17ad | https://github.com/vikashk1/node/commit/9af17ad05c8161db7f52de5fd3331a94857e33fc |
| https://github.co/hiddenchars |
| https://github.com/nodejs/node/pull/{{ revealButtonHref }} |
| Sign up for free | https://github.com/join?source=comment-repo |
| Sign in to comment | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F28641 |
|
| https://github.com/addaleax |
|
addaleax
| https://github.com/addaleax |
|
| https://github.com/nodejs/node/pull/28641/files/04faab5ea8ca224ea324a191817c42420a947a4b |
|
| https://github.com/targos |
|
targos
| https://github.com/targos |
|
| https://github.com/nodejs/node/pull/28641/files/04faab5ea8ca224ea324a191817c42420a947a4b |
|
author ready
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22author%20ready%22 |
|
readline
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Areadline |
|
semver-minor
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Asemver-minor |
| Please reload this page | https://github.com/nodejs/node/pull/28641 |
|
| https://github.com/cjihrig |
|
| https://github.com/nodejs-github-bot |
|
| https://github.com/Fishrock123 |
|
| https://github.com/addaleax |
|
| https://github.com/targos |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |