René's URL Explorer Experiment


Title: readline: remove IIFE in SIGCONT handler by cjihrig · Pull Request #28639 · nodejs/node · GitHub

Open Graph Title: readline: remove IIFE in SIGCONT handler by cjihrig · Pull Request #28639 · nodejs/node

X Title: readline: remove IIFE in SIGCONT handler by cjihrig · Pull Request #28639 · nodejs/node

Description: Node.js JavaScript runtime ✨🐢🚀✨. Contribute to nodejs/node development by creating an account on GitHub.

Open Graph Description: This commit removes an IIFE in the readline 'SIGCONT' handler that was previously being used to bind this. Checklist make -j4 test (UNIX), or vcbuild test (Windows) passes commit message...

X Description: This commit removes an IIFE in the readline 'SIGCONT' handler that was previously being used to bind this. Checklist make -j4 test (UNIX), or vcbuild test (Windows) passes commit...

Opengraph URL: https://github.com/nodejs/node/pull/28639

X: @github

direct link

Domain: github.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:e3a7a600-90c0-8d5d-e68a-13aaf88cc3ea
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-id8F90:2C03D:7BF2AC0:ADC6354:6A4FF3A3
html-safe-nonce4b6e4cffe4f2b61fe246d32f2f11c0b42e1afb34eb7e201b1b13dfb6e0d0852b
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI4RjkwOjJDMDNEOjdCRjJBQzA6QURDNjM1NDo2QTRGRjNBMyIsInZpc2l0b3JfaWQiOiI2ODk3NzgyMzMzMTY1Nzk0MjExIiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmace58249bdf09471046c84642f247a42c6ffeb1d6c76d5b060b41ce656d3d283d8
hovercard-subject-tagpull_request:296663342
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/28639/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/738c9d02497fec123e32460c164551d59d4ca2e5f56bb4ba5511cc1248eeff90/nodejs/node/pull/28639
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/738c9d02497fec123e32460c164551d59d4ca2e5f56bb4ba5511cc1248eeff90/nodejs/node/pull/28639
og:image:altThis commit removes an IIFE in the readline 'SIGCONT' handler that was previously being used to bind this. Checklist make -j4 test (UNIX), or vcbuild test (Windows) passes commit message...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamecjihrig
hostnamegithub.com
expected-hostnamegithub.com
None19b98c3d9767bb8a56238a89ff8401d1cbdf3bc5c353799aacf49fe6c76b4b7c
turbo-cache-controlno-cache
go-importgithub.com/nodejs/node git https://github.com/nodejs/node.git
octolytics-dimension-user_id9950313
octolytics-dimension-user_loginnodejs
octolytics-dimension-repository_id27193779
octolytics-dimension-repository_nwonodejs/node
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id27193779
octolytics-dimension-repository_network_root_nwonodejs/node
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
releasef7e270be010aa4de2871991025fbb97f3afe2bcb
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/nodejs/node/pull/28639#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F28639
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub Copilot appDirect agents from issue to mergehttps://github.com/features/ai/github-app
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
View all resourceshttps://github.com/resources
GitHub SponsorsFund open source developershttps://github.com/open-source/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/open-source/accelerator
GitHub Starshttps://stars.github.com
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F28639
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode
Reloadhttps://github.com/nodejs/node/pull/28639
Reloadhttps://github.com/nodejs/node/pull/28639
Reloadhttps://github.com/nodejs/node/pull/28639
Please reload this pagehttps://github.com/nodejs/node/pull/28639
nodejs https://github.com/nodejs
nodehttps://github.com/nodejs/node
Please reload this pagehttps://github.com/nodejs/node/pull/28639
Notifications https://github.com/login?return_to=%2Fnodejs%2Fnode
Fork 36k https://github.com/login?return_to=%2Fnodejs%2Fnode
Star 118k https://github.com/login?return_to=%2Fnodejs%2Fnode
Code https://github.com/nodejs/node
Issues 1.3k https://github.com/nodejs/node/issues
Pull requests 976 https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects https://github.com/nodejs/node/projects
Security and quality 0 https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
Code https://github.com/nodejs/node
Issues https://github.com/nodejs/node/issues
Pull requests https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects https://github.com/nodejs/node/projects
Security and quality https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
cjihrighttps://github.com/cjihrig
nodejs:masterhttps://github.com/nodejs/node/tree/master
cjihrig:sigconthttps://github.com/cjihrig/node/tree/sigcont
Conversationhttps://github.com/nodejs/node/pull/28639
Commits1 (1)https://github.com/nodejs/node/pull/28639/commits
Checkshttps://github.com/nodejs/node/pull/28639/checks
Files changedhttps://github.com/nodejs/node/pull/28639/files
readline: remove IIFE in SIGCONT handlerhttps://github.com/nodejs/node/pull/28639#top
cjihrighttps://github.com/cjihrig
nodejs:masterhttps://github.com/nodejs/node/tree/master
cjihrig:sigconthttps://github.com/cjihrig/node/tree/sigcont
https://github.com/cjihrig
cjihrighttps://github.com/cjihrig
Jul 11, 2019https://github.com/nodejs/node/pull/28639#issue-466908427
commit guidelineshttps://github.com/nodejs/node/blob/master/doc/guides/contributing/pull-requests.md#commit-message-guidelines
Please reload this pagehttps://github.com/nodejs/node/pull/28639
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
readline https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Areadline
Jul 11, 2019https://github.com/nodejs/node/pull/28639#event-2476022281
https://github.com/BridgeAR
BridgeARhttps://github.com/BridgeAR
Jul 11, 2019 https://github.com/nodejs/node/pull/28639#pullrequestreview-260724209
View reviewed changes https://github.com/nodejs/node/pull/28639/files
https://github.com/BridgeAR
BridgeARhttps://github.com/BridgeAR
author ready https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22author%20ready%22
Jul 11, 2019https://github.com/nodejs/node/pull/28639#event-2476078714
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
Jul 11, 2019https://github.com/nodejs/node/pull/28639#issuecomment-510502326
https://ci.nodejs.org/job/node-test-pull-request/24370/https://ci.nodejs.org/job/node-test-pull-request/24370/
Please reload this pagehttps://github.com/nodejs/node/pull/28639
https://github.com/lpinca
lpincahttps://github.com/lpinca
Jul 11, 2019 https://github.com/nodejs/node/pull/28639#pullrequestreview-260900476
View reviewed changes https://github.com/nodejs/node/pull/28639/files
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
Jul 11, 2019 https://github.com/nodejs/node/pull/28639#pullrequestreview-260930322
View reviewed changes https://github.com/nodejs/node/pull/28639/files
https://github.com/targos
targoshttps://github.com/targos
Jul 12, 2019 https://github.com/nodejs/node/pull/28639#pullrequestreview-261088651
View reviewed changes https://github.com/nodejs/node/pull/28639/files
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
Jul 12, 2019https://github.com/nodejs/node/pull/28639#issuecomment-510885776
https://ci.nodejs.org/job/node-test-pull-request/24406/https://ci.nodejs.org/job/node-test-pull-request/24406/
Please reload this pagehttps://github.com/nodejs/node/pull/28639
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
Jul 12, 2019https://github.com/nodejs/node/pull/28639#issuecomment-510893838
Please reload this pagehttps://github.com/nodejs/node/pull/28639
https://ci.nodejs.org/job/node-test-pull-request/24408/https://ci.nodejs.org/job/node-test-pull-request/24408/
Please reload this pagehttps://github.com/nodejs/node/pull/28639
https://github.com/Fishrock123
Fishrock123https://github.com/Fishrock123
Jul 12, 2019 https://github.com/nodejs/node/pull/28639#pullrequestreview-261355560
View reviewed changes https://github.com/nodejs/node/pull/28639/files
https://github.com/cjihrig
readline: remove IIFE in SIGCONT handlerhttps://github.com/nodejs/node/pull/28639/commits/223ba43434ef4faad6d199d2e620ece30c278fa9
223ba43https://github.com/nodejs/node/pull/28639/commits/223ba43434ef4faad6d199d2e620ece30c278fa9
nodejs#28639https://github.com/nodejs/node/pull/28639
https://github.com/cjihrig
cjihrighttps://github.com/cjihrig
force-pushedhttps://github.com/nodejs/node/compare/e9c79659840566156465411dc76354d696c5ddf4..223ba43434ef4faad6d199d2e620ece30c278fa9
e9c7965https://github.com/nodejs/node/commit/e9c79659840566156465411dc76354d696c5ddf4
223ba43https://github.com/nodejs/node/commit/223ba43434ef4faad6d199d2e620ece30c278fa9
Compare https://github.com/nodejs/node/compare/e9c79659840566156465411dc76354d696c5ddf4..223ba43434ef4faad6d199d2e620ece30c278fa9
July 13, 2019 14:26https://github.com/nodejs/node/pull/28639#event-2480797482
https://github.com/cjihrig
cjihrighttps://github.com/cjihrig
223ba43https://github.com/nodejs/node/commit/223ba43434ef4faad6d199d2e620ece30c278fa9
Jul 13, 2019https://github.com/nodejs/node/pull/28639#event-2480798093
https://github.com/cjihrig
cjihrighttps://github.com/cjihrig
July 13, 2019 14:28https://github.com/nodejs/node/pull/28639#event-2480798192
targoshttps://github.com/targos
Jul 20, 2019 https://github.com/nodejs/node/pull/28639#ref-commit-dc73403
https://github.com/cjihrig
https://github.com/targos
readline: remove IIFE in SIGCONT handlerhttps://github.com/nodejs/node/commit/dc734030fc8c1a0e34dc0ec20a475cb8806e4492
dc73403https://github.com/nodejs/node/commit/dc734030fc8c1a0e34dc0ec20a475cb8806e4492
#28639https://github.com/nodejs/node/pull/28639
v12.7.0 release proposal #28816 https://github.com/nodejs/node/pull/28816
v12.7.0 release proposal #28817 https://github.com/nodejs/node/pull/28817
vikashk1https://github.com/vikashk1
Aug 13, 2019 https://github.com/nodejs/node/pull/28639#ref-commit-9af17ad
https://github.com/vikashk1
Please ignore this msg (https://github.com/vikashk1/node/commit/9af17ad05c8161db7f52de5fd3331a94857e33fc
#1https://github.com/vikashk1/node/pull/1
)https://github.com/vikashk1/node/commit/9af17ad05c8161db7f52de5fd3331a94857e33fc
9af17adhttps://github.com/vikashk1/node/commit/9af17ad05c8161db7f52de5fd3331a94857e33fc
https://github.co/hiddenchars
https://github.com/nodejs/node/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F28639
https://github.com/addaleax
addaleax https://github.com/addaleax
https://github.com/nodejs/node/pull/28639/files/e9c79659840566156465411dc76354d696c5ddf4
https://github.com/lpinca
lpinca https://github.com/lpinca
https://github.com/nodejs/node/pull/28639/files/e9c79659840566156465411dc76354d696c5ddf4
https://github.com/targos
targos https://github.com/targos
https://github.com/nodejs/node/pull/28639/files/e9c79659840566156465411dc76354d696c5ddf4
https://github.com/BridgeAR
BridgeAR https://github.com/BridgeAR
https://github.com/nodejs/node/pull/28639/files/e9c79659840566156465411dc76354d696c5ddf4
https://github.com/Fishrock123
Fishrock123 https://github.com/Fishrock123
https://github.com/nodejs/node/pull/28639/files/e9c79659840566156465411dc76354d696c5ddf4
author ready https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22author%20ready%22
readline https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Areadline
Please reload this pagehttps://github.com/nodejs/node/pull/28639
https://github.com/cjihrig
https://github.com/nodejs-github-bot
https://github.com/addaleax
https://github.com/Fishrock123
https://github.com/lpinca
https://github.com/targos
https://github.com/BridgeAR
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.