René's URL Explorer Experiment


Title: src: add cleanup hook for ContextifyContext by addaleax · Pull Request #28631 · nodejs/node · GitHub

Open Graph Title: src: add cleanup hook for ContextifyContext by addaleax · Pull Request #28631 · nodejs/node

X Title: src: add cleanup hook for ContextifyContext by addaleax · Pull Request #28631 · nodejs/node

Description: Node.js JavaScript runtime ✨🐢🚀✨. Contribute to nodejs/node development by creating an account on GitHub.

Open Graph Description: Otherwise there’s a memory leak left by the context when the Isolate tears down without having run the weak callback. Checklist make -j4 test (UNIX), or vcbuild test (Windows) passes commit me...

X Description: Otherwise there’s a memory leak left by the context when the Isolate tears down without having run the weak callback. Checklist make -j4 test (UNIX), or vcbuild test (Windows) passes commit me...

Opengraph URL: https://github.com/nodejs/node/pull/28631

X: @github

direct link

Domain: github.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:2944ce96-5b48-cf4b-1f93-69e831487346
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idC020:2373EB:4585E1F:625208C:6A4FC12C
html-safe-nonceb68e4bc336fa31647f9d67a40cd60048b701a3fd798dbdc8466b1bd62fc87667
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJDMDIwOjIzNzNFQjo0NTg1RTFGOjYyNTIwOEM6NkE0RkMxMkMiLCJ2aXNpdG9yX2lkIjoiMjgxNjcyNjMzMDAxOTY2MDA3NiIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmac04575c7a1f72b001c1655f9ee4c4f1b3409ad1a61123c1e62d931d35d18b3808
hovercard-subject-tagpull_request:296373603
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/28631/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/baad3a9e8986f546a5732d67bfc272836f45e351812cc0f4ae50220dfe1224c6/nodejs/node/pull/28631
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/baad3a9e8986f546a5732d67bfc272836f45e351812cc0f4ae50220dfe1224c6/nodejs/node/pull/28631
og:image:altOtherwise there’s a memory leak left by the context when the Isolate tears down without having run the weak callback. Checklist make -j4 test (UNIX), or vcbuild test (Windows) passes commit me...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernameaddaleax
hostnamegithub.com
expected-hostnamegithub.com
None7d8f8209b188a80e19a6957836ab9229715797be5db1a04163963c674ccc33f6
turbo-cache-controlno-cache
go-importgithub.com/nodejs/node git https://github.com/nodejs/node.git
octolytics-dimension-user_id9950313
octolytics-dimension-user_loginnodejs
octolytics-dimension-repository_id27193779
octolytics-dimension-repository_nwonodejs/node
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id27193779
octolytics-dimension-repository_network_root_nwonodejs/node
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
releaseea848e83cf3bf3613dd7b13d52965a684fd23ec5
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/nodejs/node/pull/28631#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F28631
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub Copilot appDirect agents from issue to mergehttps://github.com/features/ai/github-app
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
View all resourceshttps://github.com/resources
GitHub SponsorsFund open source developershttps://github.com/open-source/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/open-source/accelerator
GitHub Starshttps://stars.github.com
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F28631
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode
Reloadhttps://github.com/nodejs/node/pull/28631
Reloadhttps://github.com/nodejs/node/pull/28631
Reloadhttps://github.com/nodejs/node/pull/28631
Please reload this pagehttps://github.com/nodejs/node/pull/28631
nodejs https://github.com/nodejs
nodehttps://github.com/nodejs/node
Please reload this pagehttps://github.com/nodejs/node/pull/28631
Notifications https://github.com/login?return_to=%2Fnodejs%2Fnode
Fork 36k https://github.com/login?return_to=%2Fnodejs%2Fnode
Star 118k https://github.com/login?return_to=%2Fnodejs%2Fnode
Code https://github.com/nodejs/node
Issues 1.3k https://github.com/nodejs/node/issues
Pull requests 973 https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects https://github.com/nodejs/node/projects
Security and quality 0 https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
Code https://github.com/nodejs/node
Issues https://github.com/nodejs/node/issues
Pull requests https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects https://github.com/nodejs/node/projects
Security and quality https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
addaleaxhttps://github.com/addaleax
nodejs:masterhttps://github.com/nodejs/node/tree/master
addaleax:contextify-workershttps://github.com/addaleax/node/tree/contextify-workers
Conversationhttps://github.com/nodejs/node/pull/28631
Commits1 (1)https://github.com/nodejs/node/pull/28631/commits
Checkshttps://github.com/nodejs/node/pull/28631/checks
Files changedhttps://github.com/nodejs/node/pull/28631/files
src: add cleanup hook for ContextifyContexthttps://github.com/nodejs/node/pull/28631#top
addaleaxhttps://github.com/addaleax
nodejs:masterhttps://github.com/nodejs/node/tree/master
addaleax:contextify-workershttps://github.com/addaleax/node/tree/contextify-workers
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
Jul 10, 2019https://github.com/nodejs/node/pull/28631#issue-466553701
commit guidelineshttps://github.com/nodejs/node/blob/master/doc/guides/contributing/pull-requests.md#commit-message-guidelines
Please reload this pagehttps://github.com/nodejs/node/pull/28631
https://github.com/addaleax
src: add cleanup hook for ContextifyContexthttps://github.com/nodejs/node/pull/28631/commits/251cdfdac86a1275f2386f6b35aa1766e209f1b4
251cdfdhttps://github.com/nodejs/node/pull/28631/commits/251cdfdac86a1275f2386f6b35aa1766e209f1b4
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
c++ https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Ac%2B%2B
vm https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Avm
Jul 10, 2019https://github.com/nodejs/node/pull/28631#event-2474070072
https://github.com/cjihrig
cjihrighttps://github.com/cjihrig
Jul 11, 2019 https://github.com/nodejs/node/pull/28631#pullrequestreview-260423387
View reviewed changes https://github.com/nodejs/node/pull/28631/files/251cdfdac86a1275f2386f6b35aa1766e209f1b4
https://github.com/Fishrock123
Fishrock123https://github.com/Fishrock123
Jul 12, 2019 https://github.com/nodejs/node/pull/28631#pullrequestreview-261356165
View reviewed changes https://github.com/nodejs/node/pull/28631/files/251cdfdac86a1275f2386f6b35aa1766e209f1b4
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
author ready https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22author%20ready%22
Jul 14, 2019https://github.com/nodejs/node/pull/28631#event-2481480416
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
Jul 14, 2019https://github.com/nodejs/node/pull/28631#issuecomment-511233845
https://ci.nodejs.org/job/node-test-pull-request/24431/https://ci.nodejs.org/job/node-test-pull-request/24431/
Please reload this pagehttps://github.com/nodejs/node/pull/28631
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
Jul 14, 2019https://github.com/nodejs/node/pull/28631#issuecomment-511236496
00464b5https://github.com/nodejs/node/commit/00464b5282724a693582079244c09a1cba5d8e08
Please reload this pagehttps://github.com/nodejs/node/pull/28631
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
Jul 14, 2019https://github.com/nodejs/node/pull/28631#event-2481500473
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
July 14, 2019 21:23https://github.com/nodejs/node/pull/28631#event-2481500544
pullhttps://github.com/apps/pull
Jul 14, 2019 https://github.com/nodejs/node/pull/28631#ref-commit-00464b5
https://github.com/addaleax
src: add cleanup hook for ContextifyContexthttps://github.com/joe9111/node/commit/00464b5282724a693582079244c09a1cba5d8e08
00464b5https://github.com/joe9111/node/commit/00464b5282724a693582079244c09a1cba5d8e08
nodejs#28631https://github.com/nodejs/node/pull/28631
targoshttps://github.com/targos
Jul 20, 2019 https://github.com/nodejs/node/pull/28631#ref-commit-5c1d595
https://github.com/addaleax
https://github.com/targos
src: add cleanup hook for ContextifyContexthttps://github.com/nodejs/node/commit/5c1d5958e03941b37662bbd4704ff82af565eb46
5c1d595https://github.com/nodejs/node/commit/5c1d5958e03941b37662bbd4704ff82af565eb46
#28631https://github.com/nodejs/node/pull/28631
v12.7.0 release proposal #28816 https://github.com/nodejs/node/pull/28816
v12.7.0 release proposal #28817 https://github.com/nodejs/node/pull/28817
vikashk1https://github.com/vikashk1
Aug 13, 2019 https://github.com/nodejs/node/pull/28631#ref-commit-9af17ad
https://github.com/vikashk1
Please ignore this msg (https://github.com/vikashk1/node/commit/9af17ad05c8161db7f52de5fd3331a94857e33fc
#1https://github.com/vikashk1/node/pull/1
)https://github.com/vikashk1/node/commit/9af17ad05c8161db7f52de5fd3331a94857e33fc
9af17adhttps://github.com/vikashk1/node/commit/9af17ad05c8161db7f52de5fd3331a94857e33fc
https://github.co/hiddenchars
https://github.com/nodejs/node/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F28631
https://github.com/cjihrig
cjihrig https://github.com/cjihrig
https://github.com/nodejs/node/pull/28631/files/251cdfdac86a1275f2386f6b35aa1766e209f1b4
https://github.com/Fishrock123
Fishrock123 https://github.com/Fishrock123
https://github.com/nodejs/node/pull/28631/files/251cdfdac86a1275f2386f6b35aa1766e209f1b4
author ready https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22author%20ready%22
c++ https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Ac%2B%2B
vm https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Avm
Please reload this pagehttps://github.com/nodejs/node/pull/28631
https://github.com/addaleax
https://github.com/nodejs-github-bot
https://github.com/Fishrock123
https://github.com/cjihrig
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.