René's URL Explorer Experiment


Title: http2: compat req.complete by ronag · Pull Request #28627 · nodejs/node · GitHub

Open Graph Title: http2: compat req.complete by ronag · Pull Request #28627 · nodejs/node

X Title: http2: compat req.complete by ronag · Pull Request #28627 · nodejs/node

Description: Node.js JavaScript runtime ✨🐢🚀✨. Contribute to nodejs/node development by creating an account on GitHub.

Open Graph Description: Note sure exactly what the req.complete property is supposed to indicate. However, if it is what I assume it is then I think it's missing a check for aborted. Checklist make -j4 test (UNIX),...

X Description: Note sure exactly what the req.complete property is supposed to indicate. However, if it is what I assume it is then I think it's missing a check for aborted. Checklist make -j4 test (UN...

Opengraph URL: https://github.com/nodejs/node/pull/28627

X: @github

direct link

Domain: github.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:b1902cd8-5e0f-e32b-109e-c0579fdcd67d
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idC146:34BFFD:4A737D3:683E3F2:6A4F7C33
html-safe-nonce276b830f554d15ab936d9ed9cd7c8ecd3614c2be1fc5a156c52592f37daf84a3
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJDMTQ2OjM0QkZGRDo0QTczN0QzOjY4M0UzRjI6NkE0RjdDMzMiLCJ2aXNpdG9yX2lkIjoiNTUwMjIwNzgyMDcxODYzNjA4MyIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmacae516c78cbd9c241fbe4126d7d6707793e21b702cb65bd36fe6ba4aecb60c8b9
hovercard-subject-tagpull_request:296321598
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/28627/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/daa003d1e074a6c8819cea63932a6746785eac4130f329f480db715672fc9c9f/nodejs/node/pull/28627
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/daa003d1e074a6c8819cea63932a6746785eac4130f329f480db715672fc9c9f/nodejs/node/pull/28627
og:image:altNote sure exactly what the req.complete property is supposed to indicate. However, if it is what I assume it is then I think it's missing a check for aborted. Checklist make -j4 test (UNIX),...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernameronag
hostnamegithub.com
expected-hostnamegithub.com
Noneb92d11c0aa4a77d54ef4af1078b6a15fb5a70a215b30c4ecf28889d5a8e656d9
turbo-cache-controlno-cache
go-importgithub.com/nodejs/node git https://github.com/nodejs/node.git
octolytics-dimension-user_id9950313
octolytics-dimension-user_loginnodejs
octolytics-dimension-repository_id27193779
octolytics-dimension-repository_nwonodejs/node
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id27193779
octolytics-dimension-repository_network_root_nwonodejs/node
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release4b249b445842943ed31549e027f57a8ade9881ed
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/nodejs/node/pull/28627#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F28627
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub Copilot appDirect agents from issue to mergehttps://github.com/features/ai/github-app
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
View all resourceshttps://github.com/resources
GitHub SponsorsFund open source developershttps://github.com/open-source/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/open-source/accelerator
GitHub Starshttps://stars.github.com
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F28627
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode
Reloadhttps://github.com/nodejs/node/pull/28627
Reloadhttps://github.com/nodejs/node/pull/28627
Reloadhttps://github.com/nodejs/node/pull/28627
Please reload this pagehttps://github.com/nodejs/node/pull/28627
nodejs https://github.com/nodejs
nodehttps://github.com/nodejs/node
Please reload this pagehttps://github.com/nodejs/node/pull/28627
Notifications https://github.com/login?return_to=%2Fnodejs%2Fnode
Fork 36k https://github.com/login?return_to=%2Fnodejs%2Fnode
Star 118k https://github.com/login?return_to=%2Fnodejs%2Fnode
Code https://github.com/nodejs/node
Issues 1.3k https://github.com/nodejs/node/issues
Pull requests 973 https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects https://github.com/nodejs/node/projects
Security and quality 0 https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
Code https://github.com/nodejs/node
Issues https://github.com/nodejs/node/issues
Pull requests https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects https://github.com/nodejs/node/projects
Security and quality https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
ronaghttps://github.com/ronag
nodejs:masterhttps://github.com/nodejs/node/tree/master
nxtedition:http2-compat-completehttps://github.com/nxtedition/node/tree/http2-compat-complete
Conversationhttps://github.com/nodejs/node/pull/28627
Commits1 (1)https://github.com/nodejs/node/pull/28627/commits
Checkshttps://github.com/nodejs/node/pull/28627/checks
Files changedhttps://github.com/nodejs/node/pull/28627/files
http2: compat req.completehttps://github.com/nodejs/node/pull/28627#top
ronaghttps://github.com/ronag
nodejs:masterhttps://github.com/nodejs/node/tree/master
nxtedition:http2-compat-completehttps://github.com/nxtedition/node/tree/http2-compat-complete
https://github.com/ronag
ronaghttps://github.com/ronag
Jul 10, 2019https://github.com/nodejs/node/pull/28627#issue-466491771
Please reload this pagehttps://github.com/nodejs/node/pull/28627
commit guidelineshttps://github.com/nodejs/node/blob/master/doc/guides/contributing/pull-requests.md#commit-message-guidelines
@apapirovskihttps://github.com/apapirovski
Please reload this pagehttps://github.com/nodejs/node/pull/28627
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
http2 https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Ahttp2
Jul 10, 2019https://github.com/nodejs/node/pull/28627#event-2473719008
https://github.com/ronag
ronaghttps://github.com/ronag
Jul 10, 2019 https://github.com/nodejs/node/pull/28627#ref-pullrequest-466495161
http: add complete property #28628 https://github.com/nodejs/node/pull/28628
https://github.com/BridgeAR
BridgeARhttps://github.com/BridgeAR
Jul 11, 2019https://github.com/nodejs/node/pull/28627#issuecomment-510496101
Please reload this pagehttps://github.com/nodejs/node/pull/28627
https://github.com/mcollina
mcollinahttps://github.com/mcollina
Jul 11, 2019https://github.com/nodejs/node/pull/28627#issuecomment-510533570
Please reload this pagehttps://github.com/nodejs/node/pull/28627
https://github.com/ronag
http2: compat req.completehttps://github.com/nodejs/node/pull/28627/commits/d2f69eef964d70f4a90b2121086f3ba604d28b89
d2f69eehttps://github.com/nodejs/node/pull/28627/commits/d2f69eef964d70f4a90b2121086f3ba604d28b89
https://github.com/ronag
ronaghttps://github.com/ronag
force-pushedhttps://github.com/nodejs/node/compare/ca388de1ea311fa01e4e4ac2f12b924598b346cb..d2f69eef964d70f4a90b2121086f3ba604d28b89
ca388dehttps://github.com/nodejs/node/commit/ca388de1ea311fa01e4e4ac2f12b924598b346cb
d2f69eehttps://github.com/nodejs/node/commit/d2f69eef964d70f4a90b2121086f3ba604d28b89
Compare https://github.com/nodejs/node/compare/ca388de1ea311fa01e4e4ac2f12b924598b346cb..d2f69eef964d70f4a90b2121086f3ba604d28b89
July 12, 2019 10:35https://github.com/nodejs/node/pull/28627#event-2478635079
https://github.com/ronag
ronaghttps://github.com/ronag
Jul 12, 2019https://github.com/nodejs/node/pull/28627#issuecomment-510838919
@mcollinahttps://github.com/mcollina
Please reload this pagehttps://github.com/nodejs/node/pull/28627
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
Jul 13, 2019https://github.com/nodejs/node/pull/28627#issuecomment-511088958
https://ci.nodejs.org/job/node-test-pull-request/24418/https://ci.nodejs.org/job/node-test-pull-request/24418/
Please reload this pagehttps://github.com/nodejs/node/pull/28627
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
Jul 14, 2019https://github.com/nodejs/node/pull/28627#issuecomment-511170713
https://ci.nodejs.org/job/node-test-pull-request/24424/https://ci.nodejs.org/job/node-test-pull-request/24424/
Please reload this pagehttps://github.com/nodejs/node/pull/28627
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
Jul 14, 2019https://github.com/nodejs/node/pull/28627#issuecomment-511185113
https://ci.nodejs.org/job/node-test-pull-request/24426/https://ci.nodejs.org/job/node-test-pull-request/24426/
Please reload this pagehttps://github.com/nodejs/node/pull/28627
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
Jul 15, 2019https://github.com/nodejs/node/pull/28627#issuecomment-511273977
https://ci.nodejs.org/job/node-test-pull-request/24448/https://ci.nodejs.org/job/node-test-pull-request/24448/
Please reload this pagehttps://github.com/nodejs/node/pull/28627
https://github.com/ronag
ronaghttps://github.com/ronag
Jul 15, 2019https://github.com/nodejs/node/pull/28627#issuecomment-511504600
Please reload this pagehttps://github.com/nodejs/node/pull/28627
@mcollinahttps://github.com/mcollina
@benjamingrhttps://github.com/benjamingr
Please reload this pagehttps://github.com/nodejs/node/pull/28627
https://github.com/mcollina
mcollinahttps://github.com/mcollina
apapirovskihttps://github.com/apapirovski
July 16, 2019 08:51https://github.com/nodejs/node/pull/28627#event-2485390756
https://github.com/mcollina
mcollinahttps://github.com/mcollina
Jul 16, 2019 https://github.com/nodejs/node/pull/28627#pullrequestreview-262271723
View reviewed changes https://github.com/nodejs/node/pull/28627/files/d2f69eef964d70f4a90b2121086f3ba604d28b89
mcollinahttps://github.com/mcollina
https://github.com/nodejs/node/pull/28627#pullrequestreview-262271723
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/28627
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
Jul 17, 2019https://github.com/nodejs/node/pull/28627#issuecomment-512086037
https://ci.nodejs.org/job/node-test-pull-request/24507/https://ci.nodejs.org/job/node-test-pull-request/24507/
Please reload this pagehttps://github.com/nodejs/node/pull/28627
https://github.com/jasnell
jasnellhttps://github.com/jasnell
Jul 17, 2019 https://github.com/nodejs/node/pull/28627#pullrequestreview-263085805
View reviewed changes https://github.com/nodejs/node/pull/28627/files/d2f69eef964d70f4a90b2121086f3ba604d28b89
https://github.com/trivikr
trivikrhttps://github.com/trivikr
Jul 17, 2019 https://github.com/nodejs/node/pull/28627#pullrequestreview-263297882
View reviewed changes https://github.com/nodejs/node/pull/28627/files/d2f69eef964d70f4a90b2121086f3ba604d28b89
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
Jul 17, 2019https://github.com/nodejs/node/pull/28627#issuecomment-512586381
https://ci.nodejs.org/job/node-test-pull-request/24525/https://ci.nodejs.org/job/node-test-pull-request/24525/
Please reload this pagehttps://github.com/nodejs/node/pull/28627
https://github.com/benjamingr
benjamingrhttps://github.com/benjamingr
Jul 18, 2019 https://github.com/nodejs/node/pull/28627#pullrequestreview-263511308
View reviewed changes https://github.com/nodejs/node/pull/28627/files/d2f69eef964d70f4a90b2121086f3ba604d28b89
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
Jul 18, 2019https://github.com/nodejs/node/pull/28627#issuecomment-513007248
https://ci.nodejs.org/job/node-test-pull-request/24548/https://ci.nodejs.org/job/node-test-pull-request/24548/
Please reload this pagehttps://github.com/nodejs/node/pull/28627
https://github.com/Trott
Trotthttps://github.com/Trott
author ready https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22author%20ready%22
Jul 19, 2019https://github.com/nodejs/node/pull/28627#event-2496645820
https://github.com/Trott
Trotthttps://github.com/Trott
Jul 19, 2019 https://github.com/nodejs/node/pull/28627#pullrequestreview-264366778
View reviewed changes https://github.com/nodejs/node/pull/28627/files/d2f69eef964d70f4a90b2121086f3ba604d28b89
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
Jul 19, 2019https://github.com/nodejs/node/pull/28627#issuecomment-513330655
https://ci.nodejs.org/job/node-test-pull-request/24564/https://ci.nodejs.org/job/node-test-pull-request/24564/
Please reload this pagehttps://github.com/nodejs/node/pull/28627
https://github.com/Trott
Trotthttps://github.com/Trott
Jul 21, 2019https://github.com/nodejs/node/pull/28627#issuecomment-513523075
b30dca8https://github.com/nodejs/node/commit/b30dca8d9efcff9d7650e633c20c93ace5e52f36
Please reload this pagehttps://github.com/nodejs/node/pull/28627
https://github.com/Trott
Trotthttps://github.com/Trott
Jul 21, 2019https://github.com/nodejs/node/pull/28627#event-2497868633
Trotthttps://github.com/Trott
Jul 21, 2019 https://github.com/nodejs/node/pull/28627#ref-commit-b30dca8
https://github.com/ronag
https://github.com/Trott
http2: compat req.completehttps://github.com/Trott/io.js/commit/b30dca8d9efcff9d7650e633c20c93ace5e52f36
b30dca8https://github.com/Trott/io.js/commit/b30dca8d9efcff9d7650e633c20c93ace5e52f36
nodejs#28627https://github.com/nodejs/node/pull/28627
targoshttps://github.com/targos
Jul 22, 2019 https://github.com/nodejs/node/pull/28627#ref-commit-49e4d72
https://github.com/ronag
https://github.com/targos
http2: compat req.completehttps://github.com/nodejs/node/commit/49e4d72b5a7fcf643e1476b0f382ed08cacd6c0a
49e4d72https://github.com/nodejs/node/commit/49e4d72b5a7fcf643e1476b0f382ed08cacd6c0a
#28627https://github.com/nodejs/node/pull/28627
v12.7.0 release proposal #28816 https://github.com/nodejs/node/pull/28816
v12.7.0 release proposal #28817 https://github.com/nodejs/node/pull/28817
gntemhttps://github.com/gntem
Jul 27, 2019 https://github.com/nodejs/node/pull/28627#ref-commit-ad54edb
https://github.com/ronag
https://github.com/gntem
http2: compat req.completehttps://github.com/gntem/node/commit/ad54edbe2df3a57d6b8603f16ef225da0415400c
ad54edbhttps://github.com/gntem/node/commit/ad54edbe2df3a57d6b8603f16ef225da0415400c
nodejs#28627https://github.com/nodejs/node/pull/28627
vikashk1https://github.com/vikashk1
Aug 13, 2019 https://github.com/nodejs/node/pull/28627#ref-commit-9af17ad
https://github.com/vikashk1
Please ignore this msg (https://github.com/vikashk1/node/commit/9af17ad05c8161db7f52de5fd3331a94857e33fc
#1https://github.com/vikashk1/node/pull/1
)https://github.com/vikashk1/node/commit/9af17ad05c8161db7f52de5fd3331a94857e33fc
9af17adhttps://github.com/vikashk1/node/commit/9af17ad05c8161db7f52de5fd3331a94857e33fc
https://github.co/hiddenchars
https://github.com/nodejs/node/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F28627
https://github.com/mcollina
mcollina https://github.com/mcollina
https://github.com/nodejs/node/pull/28627/files/d2f69eef964d70f4a90b2121086f3ba604d28b89
https://github.com/jasnell
jasnell https://github.com/jasnell
https://github.com/nodejs/node/pull/28627/files/d2f69eef964d70f4a90b2121086f3ba604d28b89
https://github.com/Trott
Trott https://github.com/Trott
https://github.com/nodejs/node/pull/28627/files/d2f69eef964d70f4a90b2121086f3ba604d28b89
https://github.com/benjamingr
benjamingr https://github.com/benjamingr
https://github.com/nodejs/node/pull/28627/files/d2f69eef964d70f4a90b2121086f3ba604d28b89
https://github.com/trivikr
trivikr https://github.com/trivikr
https://github.com/nodejs/node/pull/28627/files/d2f69eef964d70f4a90b2121086f3ba604d28b89
https://github.com/apapirovski
apapirovski https://github.com/apapirovski
author ready https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22author%20ready%22
http2 https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Ahttp2
Please reload this pagehttps://github.com/nodejs/node/pull/28627
https://github.com/ronag
https://github.com/BridgeAR
https://github.com/mcollina
https://github.com/nodejs-github-bot
https://github.com/Trott
https://github.com/jasnell
https://github.com/benjamingr
https://github.com/trivikr
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.