| route-pattern | /_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format) |
| route-controller | voltron_pull_requests_fragments |
| route-action | pull_request_layout |
| fetch-nonce | v2:4d7afd40-5159-41d6-22c1-ded71ce3b43d |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | 8016:21AE3:66AD8E:8DC6AB:6A507854 |
| html-safe-nonce | 8aeb0cfa6de2a12336a2fd97ee3d8087bd2eecd464c59f58675ad4430b150814 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI4MDE2OjIxQUUzOjY2QUQ4RTo4REM2QUI6NkE1MDc4NTQiLCJ2aXNpdG9yX2lkIjoiMTY2NTcxODEwODc4OTE3NjQwNCIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9 |
| visitor-hmac | f8bb74361a8d735ae918510772f5aed72dc8fb967fdd594ce839a73847c2ce16 |
| hovercard-subject-tag | pull_request:296125460 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///voltron/pull_requests_fragments/pull_request_layout |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/28621/pull_request_layout |
| twitter:image | https://opengraph.githubassets.com/e36533cc16571498d95106bae215853186f0f324e75ac10c1cfc94eefb605e9d/nodejs/node/pull/28621 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/e36533cc16571498d95106bae215853186f0f324e75ac10c1cfc94eefb605e9d/nodejs/node/pull/28621 |
| og:image:alt | This is an alternative to finished and onFinished.isFinished to more accurately indicate when a request/response has completed.
With this PR the frequently used on-finished npm package should no lo... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | ronag |
| hostname | github.com |
| expected-hostname | github.com |
| None | d6dc8294eb500fa36bbc57472d61fe87c522f9c3c1d64f70f4926f66a66a7efb |
| turbo-cache-control | no-cache |
| go-import | github.com/nodejs/node git https://github.com/nodejs/node.git |
| octolytics-dimension-user_id | 9950313 |
| octolytics-dimension-user_login | nodejs |
| octolytics-dimension-repository_id | 27193779 |
| octolytics-dimension-repository_nwo | nodejs/node |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 27193779 |
| octolytics-dimension-repository_network_root_nwo | nodejs/node |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 7ac0ad2f2c7e4b9056617355fd9e33e22b0c8df9 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| Skip to content | https://github.com/nodejs/node/pull/28621#start-of-content |
|
| https://github.com/ |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F28621 |
| GitHub CopilotWrite better code with AI | https://github.com/features/copilot |
| GitHub Copilot appDirect agents from issue to merge | https://github.com/features/ai/github-app |
| MCP RegistryNewIntegrate external tools | https://github.com/mcp |
| ActionsAutomate any workflow | https://github.com/features/actions |
| CodespacesInstant dev environments | https://github.com/features/codespaces |
| IssuesPlan and track work | https://github.com/features/issues |
| Code ReviewManage code changes | https://github.com/features/code-review |
| GitHub Advanced SecurityFind and fix vulnerabilities | https://github.com/security/advanced-security |
| Code securitySecure your code as you build | https://github.com/security/advanced-security/code-security |
| Secret protectionStop leaks before they start | https://github.com/security/advanced-security/secret-protection |
| Why GitHub | https://github.com/why-github |
| Documentation | https://docs.github.com |
| Blog | https://github.blog |
| Changelog | https://github.blog/changelog |
| Marketplace | https://github.com/marketplace |
| View all features | https://github.com/features |
| Enterprises | https://github.com/enterprise |
| Small and medium teams | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| App Modernization | https://github.com/solutions/use-case/app-modernization |
| DevSecOps | https://github.com/solutions/use-case/devsecops |
| DevOps | https://github.com/solutions/use-case/devops |
| CI/CD | https://github.com/solutions/use-case/ci-cd |
| View all use cases | https://github.com/solutions/use-case |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| View all industries | https://github.com/solutions/industry |
| View all solutions | https://github.com/solutions |
| AI | https://github.com/resources/articles?topic=ai |
| Software Development | https://github.com/resources/articles?topic=software-development |
| DevOps | https://github.com/resources/articles?topic=devops |
| Security | https://github.com/resources/articles?topic=security |
| View all topics | https://github.com/resources/articles |
| Customer stories | https://github.com/customer-stories |
| Events & webinars | https://github.com/resources/events |
| Ebooks & reports | https://github.com/resources/whitepapers |
| Business insights | https://github.com/solutions/executive-insights |
| GitHub Skills | https://skills.github.com |
| Documentation | https://docs.github.com |
| Customer support | https://support.github.com |
| Community forum | https://github.com/orgs/community/discussions |
| Trust center | https://github.com/trust-center |
| Partners | https://github.com/partners |
| View all resources | https://github.com/resources |
| GitHub SponsorsFund open source developers | https://github.com/open-source/sponsors |
| Security Lab | https://securitylab.github.com |
| Maintainer Community | https://maintainers.github.com |
| Accelerator | https://github.com/open-source/accelerator |
| GitHub Stars | https://stars.github.com |
| Archive Program | https://archiveprogram.github.com |
| Topics | https://github.com/topics |
| Trending | https://github.com/trending |
| Collections | https://github.com/collections |
| Enterprise platformAI-powered developer platform | https://github.com/enterprise |
| GitHub Advanced SecurityEnterprise-grade security features | https://github.com/security/advanced-security |
| Copilot for BusinessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/enterprise/premium-support |
| Pricing | https://github.com/pricing |
| Search syntax tips | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
| documentation | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F28621 |
|
Sign up
| https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode |
| Reload | https://github.com/nodejs/node/pull/28621 |
| Reload | https://github.com/nodejs/node/pull/28621 |
| Reload | https://github.com/nodejs/node/pull/28621 |
| Please reload this page | https://github.com/nodejs/node/pull/28621 |
|
nodejs
| https://github.com/nodejs |
| node | https://github.com/nodejs/node |
| Please reload this page | https://github.com/nodejs/node/pull/28621 |
|
Notifications
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Fork
36k
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Star
118k
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Code
| https://github.com/nodejs/node |
|
Issues
1.3k
| https://github.com/nodejs/node/issues |
|
Pull requests
979
| https://github.com/nodejs/node/pulls |
|
Actions
| https://github.com/nodejs/node/actions |
|
Projects
| https://github.com/nodejs/node/projects |
|
Security and quality
0
| https://github.com/nodejs/node/security |
|
Insights
| https://github.com/nodejs/node/pulse |
|
Code
| https://github.com/nodejs/node |
|
Issues
| https://github.com/nodejs/node/issues |
|
Pull requests
| https://github.com/nodejs/node/pulls |
|
Actions
| https://github.com/nodejs/node/actions |
|
Projects
| https://github.com/nodejs/node/projects |
|
Security and quality
| https://github.com/nodejs/node/security |
|
Insights
| https://github.com/nodejs/node/pulse |
| ronag | https://github.com/ronag |
| nodejs:master | https://github.com/nodejs/node/tree/master |
| nxtedition:feat-http-closed | https://github.com/nxtedition/node/tree/feat-http-closed |
| Conversation | https://github.com/nodejs/node/pull/28621 |
| Commits1 (1) | https://github.com/nodejs/node/pull/28621/commits |
| Checks | https://github.com/nodejs/node/pull/28621/checks |
| Files changed | https://github.com/nodejs/node/pull/28621/files |
| [x] http: added closed property | https://github.com/nodejs/node/pull/28621#top |
| ronag | https://github.com/ronag |
| nodejs:master | https://github.com/nodejs/node/tree/master |
| nxtedition:feat-http-closed | https://github.com/nxtedition/node/tree/feat-http-closed |
|
| https://github.com/ronag |
| ronag | https://github.com/ronag |
| Jul 10, 2019 | https://github.com/nodejs/node/pull/28621#issue-466249397 |
| Please reload this page | https://github.com/nodejs/node/pull/28621 |
| #28412 | https://github.com/nodejs/node/issues/28412 |
| commit guidelines | https://github.com/nodejs/node/blob/master/doc/guides/contributing/pull-requests.md#commit-message-guidelines |
| Please reload this page | https://github.com/nodejs/node/pull/28621 |
| https://github.com/nodejs-github-bot |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
|
lib / src
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22lib%20%2F%20src%22 |
| Jul 10, 2019 | https://github.com/nodejs/node/pull/28621#event-2472208050 |
| https://github.com/ronag |
| ronag | https://github.com/ronag |
| force-pushed | https://github.com/nodejs/node/compare/847be88d5544d5fcd7c634c6a2a50e59c75d39d0..a554a24194a2c717a454cbad95d7b48377bbf37a |
| 847be88 | https://github.com/nodejs/node/commit/847be88d5544d5fcd7c634c6a2a50e59c75d39d0 |
| a554a24 | https://github.com/nodejs/node/commit/a554a24194a2c717a454cbad95d7b48377bbf37a |
|
Compare
| https://github.com/nodejs/node/compare/847be88d5544d5fcd7c634c6a2a50e59c75d39d0..a554a24194a2c717a454cbad95d7b48377bbf37a |
| July 10, 2019 11:40 | https://github.com/nodejs/node/pull/28621#event-2472268716 |
| https://github.com/vsemozhetbyt |
| vsemozhetbyt | https://github.com/vsemozhetbyt |
|
Jul 10, 2019
| https://github.com/nodejs/node/pull/28621#pullrequestreview-260069597 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/28621/files |
| doc/api/http.md | https://github.com/nodejs/node/pull/28621/files#diff-d692ac4524379ec6a1201165e8ff8d3267c8130e07014e8221ebf7e6f80c6641 |
| Please reload this page | https://github.com/nodejs/node/pull/28621 |
| doc/api/http.md | https://github.com/nodejs/node/pull/28621/files#diff-d692ac4524379ec6a1201165e8ff8d3267c8130e07014e8221ebf7e6f80c6641 |
| Please reload this page | https://github.com/nodejs/node/pull/28621 |
| doc/api/http.md | https://github.com/nodejs/node/pull/28621/files#diff-d692ac4524379ec6a1201165e8ff8d3267c8130e07014e8221ebf7e6f80c6641 |
| Please reload this page | https://github.com/nodejs/node/pull/28621 |
| doc/api/http.md | https://github.com/nodejs/node/pull/28621/files#diff-d692ac4524379ec6a1201165e8ff8d3267c8130e07014e8221ebf7e6f80c6641 |
| Please reload this page | https://github.com/nodejs/node/pull/28621 |
| https://github.com/ronag |
| ronag | https://github.com/ronag |
| force-pushed | https://github.com/nodejs/node/compare/d5bb19fa112adc149f0bd4bca7806721d51ce069..02b82d8a26f2df1522beec05af55380567cf4592 |
| d5bb19f | https://github.com/nodejs/node/commit/d5bb19fa112adc149f0bd4bca7806721d51ce069 |
| 02b82d8 | https://github.com/nodejs/node/commit/02b82d8a26f2df1522beec05af55380567cf4592 |
|
Compare
| https://github.com/nodejs/node/compare/d5bb19fa112adc149f0bd4bca7806721d51ce069..02b82d8a26f2df1522beec05af55380567cf4592 |
| July 10, 2019 14:31 | https://github.com/nodejs/node/pull/28621#event-2472784325 |
| https://github.com/ronag |
| ronag | https://github.com/ronag |
|
Jul 10, 2019
| https://github.com/nodejs/node/pull/28621#ref-pullrequest-466495161 |
|
http: add complete property
#28628
| https://github.com/nodejs/node/pull/28628 |
| https://github.com/ronag |
| ronag | https://github.com/ronag |
| force-pushed | https://github.com/nodejs/node/compare/68eaf084538398cf1b28df57db7483231fa44098..02b82d8a26f2df1522beec05af55380567cf4592 |
| 68eaf08 | https://github.com/nodejs/node/commit/68eaf084538398cf1b28df57db7483231fa44098 |
| 02b82d8 | https://github.com/nodejs/node/commit/02b82d8a26f2df1522beec05af55380567cf4592 |
|
Compare
| https://github.com/nodejs/node/compare/68eaf084538398cf1b28df57db7483231fa44098..02b82d8a26f2df1522beec05af55380567cf4592 |
| July 10, 2019 22:06 | https://github.com/nodejs/node/pull/28621#event-2474030530 |
| https://github.com/BridgeAR |
| BridgeAR | https://github.com/BridgeAR |
| Jul 11, 2019 | https://github.com/nodejs/node/pull/28621#issuecomment-510498555 |
| Please reload this page | https://github.com/nodejs/node/pull/28621 |
| https://github.com/ronag |
| ronag | https://github.com/ronag |
| force-pushed | https://github.com/nodejs/node/compare/0321930ed308fefcd6cfadf8e6f53f194b6352ba..49ab8fadbecfc05fa9270e561fa2ec748c72e3a2 |
| 0321930 | https://github.com/nodejs/node/commit/0321930ed308fefcd6cfadf8e6f53f194b6352ba |
| 49ab8fa | https://github.com/nodejs/node/commit/49ab8fadbecfc05fa9270e561fa2ec748c72e3a2 |
|
Compare
| https://github.com/nodejs/node/compare/0321930ed308fefcd6cfadf8e6f53f194b6352ba..49ab8fadbecfc05fa9270e561fa2ec748c72e3a2 |
| July 12, 2019 10:21 | https://github.com/nodejs/node/pull/28621#event-2478602911 |
| https://github.com/ronag |
| ronag | https://github.com/ronag |
| Jul 12, 2019 | https://github.com/nodejs/node/pull/28621#issuecomment-510838234 |
| Please reload this page | https://github.com/nodejs/node/pull/28621 |
| https://github.com/ronag |
| ronag | https://github.com/ronag |
|
Jul 12, 2019
| https://github.com/nodejs/node/pull/28621#ref-pullrequest-460123513 |
|
response is only finished if socket is detached
jshttp/on-finished#31
| https://github.com/jshttp/on-finished/pull/31 |
| https://github.com/Trott |
| Trott | https://github.com/Trott |
| Jul 13, 2019 | https://github.com/nodejs/node/pull/28621#issuecomment-511088543 |
| Please reload this page | https://github.com/nodejs/node/pull/28621 |
| https://github.com/sebdeckers |
| sebdeckers | https://github.com/sebdeckers |
|
Jul 13, 2019
| https://github.com/nodejs/node/pull/28621#pullrequestreview-261529485 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/28621/files |
| sebdeckers | https://github.com/sebdeckers |
| https://github.com/nodejs/node/pull/28621#pullrequestreview-261529485 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/28621 |
| https://github.com/benjamingr |
| benjamingr | https://github.com/benjamingr |
|
Jul 13, 2019
| https://github.com/nodejs/node/pull/28621#pullrequestreview-261536455 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/28621/files |
| benjamingr | https://github.com/benjamingr |
| https://github.com/nodejs/node/pull/28621#pullrequestreview-261536455 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/28621 |
| https://github.com/ronag |
| ronag | https://github.com/ronag |
| Jul 13, 2019 | https://github.com/nodejs/node/pull/28621#issuecomment-511114172 |
| Please reload this page | https://github.com/nodejs/node/pull/28621 |
| @benjamingr | https://github.com/benjamingr |
| Please reload this page | https://github.com/nodejs/node/pull/28621 |
| https://github.com/ronag |
| ronag | https://github.com/ronag |
| Jul 13, 2019 | https://github.com/nodejs/node/pull/28621#issuecomment-511114537 |
| Please reload this page | https://github.com/nodejs/node/pull/28621 |
| Please reload this page | https://github.com/nodejs/node/pull/28621 |
| https://github.com/ronag |
| ronag | https://github.com/ronag |
| Jul 13, 2019 | https://github.com/nodejs/node/pull/28621#issuecomment-511115426 |
| nxtedition@7355716 | https://github.com/nxtedition/node/commit/7355716d66456132244dc374960c78b1288b4e43 |
| Please reload this page | https://github.com/nodejs/node/pull/28621 |
| https://github.com/benjamingr |
| benjamingr | https://github.com/benjamingr |
|
Jul 13, 2019
| https://github.com/nodejs/node/pull/28621#pullrequestreview-261538561 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/28621/files |
| benjamingr | https://github.com/benjamingr |
| https://github.com/nodejs/node/pull/28621#pullrequestreview-261538561 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/28621 |
| https://github.com/ronag |
| ronag | https://github.com/ronag |
|
Jul 13, 2019
| https://github.com/nodejs/node/pull/28621#ref-pullrequest-467715235 |
|
http: don't error after http client response
#28668
| https://github.com/nodejs/node/pull/28668 |
| https://github.com/ronag |
| ronag | https://github.com/ronag |
| force-pushed | https://github.com/nodejs/node/compare/49ab8fadbecfc05fa9270e561fa2ec748c72e3a2..3f36def5e168fbdf67efc7b39747f3966aed00d7 |
| 49ab8fa | https://github.com/nodejs/node/commit/49ab8fadbecfc05fa9270e561fa2ec748c72e3a2 |
| 3f36def | https://github.com/nodejs/node/commit/3f36def5e168fbdf67efc7b39747f3966aed00d7 |
|
Compare
| https://github.com/nodejs/node/compare/49ab8fadbecfc05fa9270e561fa2ec748c72e3a2..3f36def5e168fbdf67efc7b39747f3966aed00d7 |
| July 13, 2019 12:52 | https://github.com/nodejs/node/pull/28621#event-2480755281 |
| https://github.com/ronag |
| ronag | https://github.com/ronag |
|
Jul 13, 2019
| https://github.com/nodejs/node/pull/28621#pullrequestreview-261540528 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/28621/files |
| lib/_http_server.js | https://github.com/nodejs/node/pull/28621/files#diff-2464899ab38c61dd42654fdb9658c75989cb6883b9c9d76613872a12d3fe2780 |
| Please reload this page | https://github.com/nodejs/node/pull/28621 |
| https://github.com/ronag |
| ronag | https://github.com/ronag |
| force-pushed | https://github.com/nodejs/node/compare/f8eeaee1c30c737ff07c8f0a64eb7a5756611c38..9bcc445e3ebbe0a3fb25af00c818fbbdcbeb919d |
| f8eeaee | https://github.com/nodejs/node/commit/f8eeaee1c30c737ff07c8f0a64eb7a5756611c38 |
| 9bcc445 | https://github.com/nodejs/node/commit/9bcc445e3ebbe0a3fb25af00c818fbbdcbeb919d |
|
Compare
| https://github.com/nodejs/node/compare/f8eeaee1c30c737ff07c8f0a64eb7a5756611c38..9bcc445e3ebbe0a3fb25af00c818fbbdcbeb919d |
| July 13, 2019 12:55 | https://github.com/nodejs/node/pull/28621#event-2480756791 |
| https://github.com/nodejs-github-bot |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
| Jul 14, 2019 | https://github.com/nodejs/node/pull/28621#issuecomment-511184850 |
| https://ci.nodejs.org/job/node-test-pull-request/24425/ | https://ci.nodejs.org/job/node-test-pull-request/24425/ |
| Please reload this page | https://github.com/nodejs/node/pull/28621 |
| https://github.com/mcollina |
| mcollina | https://github.com/mcollina |
|
Jul 14, 2019
| https://github.com/nodejs/node/pull/28621#pullrequestreview-261576784 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/28621/files |
| mcollina | https://github.com/mcollina |
| https://github.com/nodejs/node/pull/28621#pullrequestreview-261576784 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/28621 |
| lib/_http_client.js | https://github.com/nodejs/node/pull/28621/files#diff-cf533721360d04a028e31659e9b6cde7e4bd871200d13ce37d4a358be65bfd43 |
| Please reload this page | https://github.com/nodejs/node/pull/28621 |
| https://github.com/ronag |
| ronag | https://github.com/ronag |
| force-pushed | https://github.com/nodejs/node/compare/9bcc445e3ebbe0a3fb25af00c818fbbdcbeb919d..88e06a300632bd1b7b7507885e04987747f30eb8 |
| 9bcc445 | https://github.com/nodejs/node/commit/9bcc445e3ebbe0a3fb25af00c818fbbdcbeb919d |
| 88e06a3 | https://github.com/nodejs/node/commit/88e06a300632bd1b7b7507885e04987747f30eb8 |
|
Compare
| https://github.com/nodejs/node/compare/9bcc445e3ebbe0a3fb25af00c818fbbdcbeb919d..88e06a300632bd1b7b7507885e04987747f30eb8 |
| July 14, 2019 11:27 | https://github.com/nodejs/node/pull/28621#event-2481233605 |
| https://github.com/ronag |
| ronag | https://github.com/ronag |
| Jul 14, 2019 | https://github.com/nodejs/node/pull/28621#issuecomment-511216620 |
| Please reload this page | https://github.com/nodejs/node/pull/28621 |
| @mcollina | https://github.com/mcollina |
| Please reload this page | https://github.com/nodejs/node/pull/28621 |
| https://github.com/ronag |
| ronag | https://github.com/ronag |
| Jul 14, 2019 | https://github.com/nodejs/node/pull/28621#issuecomment-511219726 |
| @mcollina | https://github.com/mcollina |
| Please reload this page | https://github.com/nodejs/node/pull/28621 |
| https://github.com/mcollina |
| mcollina | https://github.com/mcollina |
|
Jul 16, 2019
| https://github.com/nodejs/node/pull/28621#pullrequestreview-262244015 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/28621/files |
| mcollina | https://github.com/mcollina |
| https://github.com/nodejs/node/pull/28621#pullrequestreview-262244015 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/28621 |
| lib/_http_server.js | https://github.com/nodejs/node/pull/28621/files#diff-2464899ab38c61dd42654fdb9658c75989cb6883b9c9d76613872a12d3fe2780 |
| Please reload this page | https://github.com/nodejs/node/pull/28621 |
| lib/_http_server.js | https://github.com/nodejs/node/pull/28621/files#diff-2464899ab38c61dd42654fdb9658c75989cb6883b9c9d76613872a12d3fe2780 |
| Please reload this page | https://github.com/nodejs/node/pull/28621 |
| test/parallel/test-http-connect-req-res.js | https://github.com/nodejs/node/pull/28621/files#diff-865c176975e6ebde40ee271af7290e5a85f57f3c58b6ab70f8bc34a31f5758dd |
| Please reload this page | https://github.com/nodejs/node/pull/28621 |
| test/parallel/test-http-req-res-close.js | https://github.com/nodejs/node/pull/28621/files#diff-37ba37693383248eaa42b62dbeb1702d5b29cd104540272e3ef7d40a0a51c665 |
| Please reload this page | https://github.com/nodejs/node/pull/28621 |
| https://github.com/ronag |
| ronag | https://github.com/ronag |
| force-pushed | https://github.com/nodejs/node/compare/45eead605d18f5a8bb3f4bb862a2c1dce39f39d5..2f5b68401691814df3e2b9fd95f7219252d74d7f |
| 45eead6 | https://github.com/nodejs/node/commit/45eead605d18f5a8bb3f4bb862a2c1dce39f39d5 |
| 2f5b684 | https://github.com/nodejs/node/commit/2f5b68401691814df3e2b9fd95f7219252d74d7f |
|
Compare
| https://github.com/nodejs/node/compare/45eead605d18f5a8bb3f4bb862a2c1dce39f39d5..2f5b68401691814df3e2b9fd95f7219252d74d7f |
| July 16, 2019 08:38 | https://github.com/nodejs/node/pull/28621#event-2485350518 |
| https://github.com/ronag |
| ronag | https://github.com/ronag |
| Jul 16, 2019 | https://github.com/nodejs/node/pull/28621#issuecomment-511723699 |
| @mcollina | https://github.com/mcollina |
| https://github.com/nodejs/node/blob/master/test/parallel/test-http-connect-req-res.js | https://github.com/nodejs/node/blob/master/test/parallel/test-http-connect-req-res.js |
| Please reload this page | https://github.com/nodejs/node/pull/28621 |
| https://github.com/mcollina |
| mcollina | https://github.com/mcollina |
| Jul 16, 2019 | https://github.com/nodejs/node/pull/28621#issuecomment-511725663 |
| Please reload this page | https://github.com/nodejs/node/pull/28621 |
|
| https://github.com/ronag |
| http: added closed property | https://github.com/nodejs/node/pull/28621/commits/e4ea0314782263ae2cc19bb0a7c2df62b47c7128 |
| e4ea031 | https://github.com/nodejs/node/pull/28621/commits/e4ea0314782263ae2cc19bb0a7c2df62b47c7128 |
| https://github.com/ronag |
| ronag | https://github.com/ronag |
| force-pushed | https://github.com/nodejs/node/compare/2f5b68401691814df3e2b9fd95f7219252d74d7f..e4ea0314782263ae2cc19bb0a7c2df62b47c7128 |
| 2f5b684 | https://github.com/nodejs/node/commit/2f5b68401691814df3e2b9fd95f7219252d74d7f |
| e4ea031 | https://github.com/nodejs/node/commit/e4ea0314782263ae2cc19bb0a7c2df62b47c7128 |
|
Compare
| https://github.com/nodejs/node/compare/2f5b68401691814df3e2b9fd95f7219252d74d7f..e4ea0314782263ae2cc19bb0a7c2df62b47c7128 |
| July 16, 2019 08:54 | https://github.com/nodejs/node/pull/28621#event-2485398016 |
| https://github.com/ronag |
| ronag | https://github.com/ronag |
| Jul 16, 2019 | https://github.com/nodejs/node/pull/28621#issuecomment-511728209 |
| Please reload this page | https://github.com/nodejs/node/pull/28621 |
| @mcollina | https://github.com/mcollina |
| Please reload this page | https://github.com/nodejs/node/pull/28621 |
| https://github.com/mcollina |
| mcollina | https://github.com/mcollina |
|
Jul 16, 2019
| https://github.com/nodejs/node/pull/28621#pullrequestreview-262277290 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/28621/files/e4ea0314782263ae2cc19bb0a7c2df62b47c7128 |
| lib/internal/http2/compat.js | https://github.com/nodejs/node/pull/28621/files/e4ea0314782263ae2cc19bb0a7c2df62b47c7128#diff-e241fc9fee7eaeaf021850ee74d273cc350099b52c548d7fdb85c8440eef1c8f |
| mcollina | https://github.com/mcollina |
| Jul 16, 2019 | https://github.com/nodejs/node/pull/28621#discussion_r303799324 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/28621 |
| https://github.com/ronag |
| ronag | https://github.com/ronag |
|
Jul 23, 2019
| https://github.com/nodejs/node/pull/28621#ref-pullrequest-469711864 |
|
stream: eos on closed
#28748
| https://github.com/nodejs/node/pull/28748 |
| https://github.com/ronag |
| ronag | https://github.com/ronag |
| Aug 26, 2019 | https://github.com/nodejs/node/pull/28621#issuecomment-524857582 |
| Please reload this page | https://github.com/nodejs/node/pull/28621 |
| https://github.com/ronag |
| ronag | https://github.com/ronag |
| Aug 26, 2019 | https://github.com/nodejs/node/pull/28621#event-2583659626 |
| https://github.com/ronag |
| ronag | https://github.com/ronag |
| Aug 26, 2019 | https://github.com/nodejs/node/pull/28621#event-2583660047 |
| https://github.co/hiddenchars |
| https://github.com/nodejs/node/pull/{{ revealButtonHref }} |
| Sign up for free | https://github.com/join?source=comment-repo |
| Sign in to comment | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F28621 |
|
| https://github.com/mcollina |
|
mcollina
| https://github.com/mcollina |
|
| https://github.com/nodejs/node/pull/28621/files/e4ea0314782263ae2cc19bb0a7c2df62b47c7128 |
|
| https://github.com/benjamingr |
|
benjamingr
| https://github.com/benjamingr |
|
| https://github.com/nodejs/node/pull/28621/files/49ab8fadbecfc05fa9270e561fa2ec748c72e3a2 |
|
| https://github.com/sebdeckers |
|
sebdeckers
| https://github.com/sebdeckers |
|
| https://github.com/nodejs/node/pull/28621/files/49ab8fadbecfc05fa9270e561fa2ec748c72e3a2 |
|
| https://github.com/vsemozhetbyt |
|
vsemozhetbyt
| https://github.com/vsemozhetbyt |
|
| https://github.com/nodejs/node/pull/28621/files/a554a24194a2c717a454cbad95d7b48377bbf37a |
|
lib / src
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22lib%20%2F%20src%22 |
| Please reload this page | https://github.com/nodejs/node/pull/28621 |
|
| https://github.com/ronag |
|
| https://github.com/BridgeAR |
|
| https://github.com/Trott |
|
| https://github.com/nodejs-github-bot |
|
| https://github.com/mcollina |
|
| https://github.com/sebdeckers |
|
| https://github.com/benjamingr |
|
| https://github.com/vsemozhetbyt |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |